[dev] Re: [tools-dev] Line-endings in source files

2009-08-31 Thread Jens-Heiner Rechtien
Hi,

Christian Lohmaier wrote:
 Hi *,
 
 it seems to me that lately a huge amount of lineend-changes did occur.
 Maybe it is just a bad impression because many of the cws I had a look
 at lately did cause so many unrelated changes, but still:
 
 *Please* take care of lineendings before you commit.
 
 especially: please don't create files with mixed lineendings.

I can only emphasize how important this is.

Heiner


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.org
For additional commands, e-mail: dev-h...@openoffice.org



[dev] Re: [tools-dev] Line-endings in source files

2009-08-31 Thread Jan Holesovsky
Hi Heiner,

On Monday 31 of August 2009, Jens-Heiner Rechtien wrote:

  it seems to me that lately a huge amount of lineend-changes did occur.
  Maybe it is just a bad impression because many of the cws I had a look
  at lately did cause so many unrelated changes, but still:
 
  *Please* take care of lineendings before you commit.
 
  especially: please don't create files with mixed lineendings.

 I can only emphasize how important this is.

Bjoern kindly offered to do a Python version of a pre-commit hook once; it was 
more complex, but can we at least try the CRLF check?  Bjoern, would you be 
willing to provide that, if Heiner agrees to use it?

[IIRC, the main concern was the use of the overriding mechanism, but I still 
think it would be better than nothing, more so if the hook provides an exact 
info what to do to fix the situation.]

Thank you,
Kendy

-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.org
For additional commands, e-mail: dev-h...@openoffice.org



[dev] Re: [tools-dev] Line-endings in source files

2009-08-31 Thread Bjoern Michaelsen
Jan Holesovsky kendy at suse.cz writes:
  I can only emphasize how important this is.
 
 Bjoern kindly offered to do a Python version of a pre-commit hook once; it 
 was 
 more complex, but can we at least try the CRLF check?  Bjoern, would you be 
 willing to provide that, if Heiner agrees to use it?

I am currently on vacation and will likely be offline (and off infrastructure)
for some time. I know that it is sneaky and cowardly to try to use that as an
excuse, but I will take a look when I return (if its still relevant then).

IIRC Heiner has implemented a commit hook for commits on tags - so it is likely
that it is much easier to just extend that hook than writing an additional one.

However, since our months left with SVN as our main SCM are hopefully
single-digit numbers I wonder if it is still worth the effort.

Have Fun,

Bjoern






-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.org
For additional commands, e-mail: dev-h...@openoffice.org



[dev] Line-endings in source files

2009-08-30 Thread Christian Lohmaier
Hi *,

it seems to me that lately a huge amount of lineend-changes did occur.
Maybe it is just a bad impression because many of the cws I had a look
at lately did cause so many unrelated changes, but still:

*Please* take care of lineendings before you commit.

especially: please don't create files with mixed lineendings.

Thanks a lot

ciao
Christian

-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.org
For additional commands, e-mail: dev-h...@openoffice.org