Re: [OSM-dev] Deleting TIGER node tags
This is all redundant information. Be bold, delete it. 80n On Fri, Jun 26, 2009 at 5:59 PM, Andy Allan gravityst...@gmail.com wrote: Hello Devs, source = tiger_import_dch_v0.6_20070813 tiger:county = St. Louis, MO tiger:tlid = 100111260:100111261:10055:10059 tiger:upload_uuid = bulk_upload.pl-6143e1a9-589d-43a0-9248-e95658773ef4 Stuff like this appears on every node in the US, which is a pain. I reckon it's all pointless, since all that info is on the ways in the first place, and it's worth deleting them. Here's some numbers from Matt to consider: Tiger node tags make up 85.43% of all node tags and take up: * 12.97% of the bzipped planet size (805Mb). * 34.68% of the uncompressed planet size. * 42.20% of the lines in the planet. * 31.51% of the parsing time of the planet (based on xmllint --stream). So, can anyone think of a good reason to keep them? Should we just delete tags like these? I'd love to hear if anyone think we should keep them (bearing in mind all the info, including ids, would remain on the ways in any case). http://wiki.openstreetmap.org/wiki/TIGER_fixup/node_tags Cheers, Andy ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] OAuth
2009/6/27 Frederik Ramm frede...@remote.org: Hi, I just wanted to say (though it isn't normally my style) that I think this OAuth stuff is really great and a leap forward for the OSM developer community. Thank you for implementing that! Until now, developers were forced to either deal with Rails and somehow write extensions to the Rails port and get them accepted (not for the faint at heart, nor for those who are really bad at human communications which unfortunately geeks tend to be), or they set up their own stuff which then did ugly things like churn out .osm files that you would have to open in JOSM and upload or things like that. With a working OAuth implementation, all these people can now integrate their applications properly with OSM, which will greatly enhance the palette of tools available to users on any level. I haven't looked at your implementation - which SVN revision should I check out to do so? http://svn.openstreetmap.org/sites/rails_port_branches/oauth/ Does the implementation * allow third party applications to identify an OSM user so that they can, for example, store local preferences under that username? Yeo * allow users to grant third party applications the right to make edits in their name? Yep * allow the first item above WITHOUT at the same time allowing the second item above (so that I can authenticate with a third party application but I may not trust that application enough to actually make edits in my name)? I'm guessing so * allow users to grant third party applications the right to retrieve their non-public GPS tracks, and again, give the user a choice whether a given third-party application should have this right (or only know the username, or only make edits)? Yep All the above options are listed as permissions a client application may use at the application key registration page: http://oauth.dev.openstreetmap.org/oauth_clients/new I'll happily try my hand at implementing those features of the above that aren't in there yet. I'm very eager to create application prototypes in various programming languages and unleash them onto our developer community - I am sure the uptake will be great. Bye Frederik I think the one thing we've not yet seen is any client using OAuth, that would make it even better. An OAuth test server is online at http://oauth.dev.openstreetmap.org/ and following the svn branch. -- Regards, Thomas Wood (Edgemaster) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] OAuth
Frederik Ramm wrote: I haven't looked at your implementation - which SVN revision should I check out to do so? It's on a branch for now - rails_port_branches/oauth is what you want. Does the implementation * allow third party applications to identify an OSM user so that they can, for example, store local preferences under that username? I'm not sure what you mean by identify in this context, but one of the permissions an application can ask for is the ability to read and/or write to a users preferences (read and write are separate permissions). * allow users to grant third party applications the right to make edits in their name? Yes. * allow the first item above WITHOUT at the same time allowing the second item above (so that I can authenticate with a third party application but I may not trust that application enough to actually make edits in my name)? OAuth is not about providing third party authentication - that is the job of an OpenID provider. OAuth is about allowing third parties to do things on our web site in the name of a given user without exposing authentication details to them. But yes, you can grant preference access without granting edit access. * allow users to grant third party applications the right to retrieve their non-public GPS tracks, and again, give the user a choice whether a given third-party application should have this right (or only know the username, or only make edits)? Once again, yes. The permissions currently implemented are: - Read preferences - Write preferences - Create diary entries and comments and add new friends - Make edits using the API - Read the users GPX traces, including private ones - Add new GPX traces One thing I'm interested in peoples thoughts on is the third of those which covers several different things - would those be better split up? Tom -- Tom Hughes (t...@compton.nu) http://www.compton.nu/ ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Deleting TIGER node tags
2009/6/27 Minh Nguyen m...@zoomtown.com: Ngày 6/26/09 12:59 PM, Andy Allan viết: Hello Devs, source = tiger_import_dch_v0.6_20070813 tiger:county = St. Louis, MO tiger:tlid = 100111260:100111261:10055:10059 tiger:upload_uuid = bulk_upload.pl-6143e1a9-589d-43a0-9248-e95658773ef4 Stuff like this appears on every node in the US, which is a pain. I reckon it's all pointless, since all that info is on the ways in the first place, and it's worth deleting them. Here's some numbers from Matt to consider: Tiger node tags make up 85.43% of all node tags and take up: * 12.97% of the bzipped planet size (805Mb). * 34.68% of the uncompressed planet size. * 42.20% of the lines in the planet. * 31.51% of the parsing time of the planet (based on xmllint --stream). So, can anyone think of a good reason to keep them? Should we just delete tags like these? I'd love to hear if anyone think we should keep them (bearing in mind all the info, including ids, would remain on the ways in any case). http://wiki.openstreetmap.org/wiki/TIGER_fixup/node_tags Cheers, Andy The tiger:county data is actually kinda useful. I've been using it to know where the county lines are according to TIGER, to make the county boundaries more precise in my area. It's also nice to see tiger:county values on nearby streets when mapping power lines in Potlatch, so I know just how carried away I got without having to leave the editor and zoom way out. But that's probably a fringe usage. :) Andy's only talking about the node tags at the moment -- this data will still be on the ways for now so you'll still be able to do these things. Dave ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Deleting TIGER node tags
On Sat, 2009-06-27 at 09:26 +0100, 80n wrote: This is all redundant information. Be bold, delete it. Indeed. Leave it in the ways, remove it from the nodes. ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] [OSM-talk] Map legends: Another option
On Fri, Jun 26, 2009 at 11:17 PM, Lars Ahlzenl...@ahlzen.com wrote: Hi All, I know that there's been some talk about generating map legends/keys lately, and I don't know if there's a need for another option. It generated some interest when I mentioned it in my diary recently, however... I created a python script that generates an HTML legend (with images) based on a description of features to be included and one or more Mapnik XML configuration files. Thus, I can automatically generate legends for each zoom level of my map. If I modify the map style, I can just run the script again. Example at: http://toposm.com/ma/ (click on Show/Hide Legend at the bottom right). It's dynamic, so it will reload when you zoom in and out. It was created for the TopOSM project, but it may be useful to other projects that use Mapnik for rendering. The script itself, and more info, is available at: http://wiki.openstreetmap.org/wiki/TopOSM#Map_legend It would be neat if someone modified this to make it generate a legend for the main web interface. It's not that hard, here's an example of an entry for osmarender being added: http://trac.openstreetmap.org/changeset/16132 The motorway key is then used to look up a translation, e.g.: http://trac.openstreetmap.org/browser/sites/rails_port/config/locales/en.yml#L581 Of course if you were going to modify it to have sections as in that example you'd have to add section heading generation to the code, but that shouldn't be that hard. The main thing that needs to be done is to make something that can read the main mapnik stylesheet and spit out something machine readable that indicates what zoom level that feature is visible on, a path to an associated PNG file, and optionally what section (e.g. Roads) it's under. Looks like this is mostly done at TopOSM, it's just a matter of someone doing the needed integration legwork. ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Deleting TIGER node tags
Indeed. Leave it in the ways, remove it from the nodes. Is this a low (database) level delete? Or will we gain a new history entry for every node showing the node as it was before the delete and as it was after? If the latter then won't the database end up bigger rather than smaller? Ed ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Deleting TIGER node tags
2009/6/27 Ed Loach e...@loach.me.uk: Indeed. Leave it in the ways, remove it from the nodes. Is this a low (database) level delete? Or will we gain a new history entry for every node showing the node as it was before the delete and as it was after? If the latter then won't the database end up bigger rather than smaller? Ed The database is a matter for the sysadmins, this will however impact greatly on the planetfile size, which more people often struggle with. -- Regards, Thomas Wood (Edgemaster) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] OAuth
Hi, Tom Hughes wrote: That isn't really how OAuth works. OAuth allows an application to say to a web site I would like to do X and the site then interacts with the user to get their permission (by asking them to log in if necessary and then to confirm they want to grant permission to the application) and then gives the application an opaque token it can use to access the site. Thanks. Is the application required to keep track of which operations are allowed with the token and which aren't? I mean, if I am the application and I send my user over to OSM to get permission for reading his preferences, and later I want to make an edit in the user's name and try to use that same token - will this then simply fail, and would I then send the user to OSM again to upgrade the token, or would I get a new token then? Or would I always check with OSM first wether what I'm about to do is allowed with the token? Well I don't think there is an OAuth permission to read the user details currently so an application wouldn't be able to get an OAuth token that allowed it to retrieve the username. Such a permission could be added of course. I could imagine that it would be very useful - if only for the 3rd party application to be able to have something on screen that says I am currently using a token that does OSM API operations for the user fred (some users may have more than one account and could get confused). Has there been any discussion, or even consensus, on the lifetime of tokens? Will this be left to the user? Will they be valid until revoked? Bye Frederik ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Deleting TIGER node tags
Greg Stark wrote: Also, are ways actually entirely in one county or another? It seems to me they would often span borders. That is how they are reported to the census bureau. Every county reports on the parts of roads that lie within its borders. They rarely match up exactly enough at the boundary for the import to be able to join them up. In some extreme cases, like roads along a ridge that is also the county border, every left turn is reported as a piece from county A, and every right turn as a piece from county B :) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] OAuth
On Sat, Jun 27, 2009 at 3:17 PM, Tom Hughest...@compton.nu wrote: Frederik Ramm wrote: Is the application required to keep track of which operations are allowed with the token and which aren't? I mean, if I am the application and I send my user over to OSM to get permission for reading his preferences, and later I want to make an edit in the user's name and try to use that same token - will this then simply fail, and would I then send the user to OSM again to upgrade the token, or would I get a new token then? Or would I always check with OSM first wether what I'm about to do is allowed with the token? Matt knows more about how it all works than me but you will certainly need to do something to either upgrade or replace the token. at the moment there isn't an API to interrogate a token to find out which capabilities it has, but if that's wanted it can be added. the workflow is like this: 1. application developer registers with OSM, and sets up those permissions which their app wants/needs, 2. user uses the app, which uses its credentials to form an OAuth request, 3. user is redirected to OSM where they log in and agree to none, some or all of the permissions the app requested, 4. OSM redirects the user back to the app's callback URL, although the app doesn't actually need to close the loop - this can be a static page saying thanks. you can close this window and return to the app, 5. any call to the API using that token is forbidden if the app didn't request that capability or the user didn't approve it and OK otherwise. 6. the user can revoke that token at any time, including while the app is using it. if you need to upgrade a token then you can ask for a new one with different permissions. *or* a better way might be to have multiple tokens for the app (e.g: one token for the API capability, another for GPX). that way the user can approve and revoke them at different times. Has there been any discussion, or even consensus, on the lifetime of tokens? Will this be left to the user? Will they be valid until revoked? They last forever unless explicitly revoked I believe. yep, although it would be pretty simple to have them expire after some time (maybe set by the app) if anyone would find that useful? Frederik Ramm wrote: Tom Hughes wrote: * allow third party applications to identify an OSM user so that they can, for example, store local preferences under that username? I'm not sure what you mean by identify in this context, but one of the permissions an application can ask for is the ability to read and/or write to a users preferences (read and write are separate permissions). I would want a third-party application to know that whoever they are talking to is the OSM user so-and-so, that's all - so that the application can e.g. save application-local preferences for that user without having to use an extra login/password to that site. yep - you want the read user preferences capability. it allows you to read the user preferences and the user details. the OSM display name is part of that and i'm thinking of adding the user ID too, since display name can change. if you want to store the preferences on the OSM server instead (e.g: to allow site independence) then you'll also want the write user preferences capability. cheers, matt ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Deleting TIGER node tags
On Jun 27, 2009, at 10:16 AM, Stellan Lagerstrom wrote: Greg Stark wrote: Also, are ways actually entirely in one county or another? It seems to me they would often span borders. That is how they are reported to the census bureau. Every county reports on the parts of roads that lie within its borders. They rarely match up exactly enough at the boundary for the import to be able to join them up. Where the TIGER data is in good shape, they do line up exactly. I can point you to some examples. Can you point me to some examples where they don't line up? -- Russ Nelson - http://community.cloudmade.com/blog - http://wiki.openstreetmap.org/wiki/User:RussNelson r...@cloudmade.com - Twitter: Russ_OSM - http://openstreetmap.org/user/RussNelson ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
[josm-dev] unit testing
Unit testing seems slightly disregarded and I wonder why nobody has opened a jira ticket to fix? I would do the work if we would find an agreement which unit test library or framework to use. What are your thoughts? -Dieter ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] unit testing
I would focus on unit tests. Primarily all tests should run successfully after checkout from repository. Could you add missing libraries to svn repo? I've only found newer versions of the same. -Dieter On 27 Jun 2009, at 13:21, Karl Guggisberg wrote: Hi, I've only recently started to commit unit test cases, in a non- systematic way, thought. I strongly agree that there should be more test cases. I've been using the following framework(s) in test cases: - JUnit 4 - FEST (for reflection) I've started to write functional test cases too, mainly for automated GUI tests using FEST. My env is structured as follows test/unit - unit test cases test/unit/build.xml - ANT file for unit tests test/functional - functional test cases (including GUI tests and tests which require a running API server) test/functional/build.xml - ANT file for functional test test/data - test data for specific test cases (i.e. a set of merge test cases) test/lib/junit- JUnit libraries test/lib/fest - FEST libraries test/report - output directory for test cases I've committed a subset of this so far. If it was useful for you, I could commit the rest too. It's not very clean yet and it could be improved. So, I encourage you to work on this. Regards Karl -Ursprüngliche Nachricht- Von: josm-dev-boun...@openstreetmap.org [mailto:josm-dev-boun...@openstreetmap.org] Im Auftrag von Dieter Muecke Gesendet: Samstag, 27. Juni 2009 13:01 An: josm-dev@openstreetmap.org Betreff: [josm-dev] unit testing Unit testing seems slightly disregarded and I wonder why nobody has opened a jira ticket to fix? I would do the work if we would find an agreement which unit test library or framework to use. What are your thoughts? -Dieter ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] unit testing
OK, it's in the repository. Let me know if you need something else. -- Karl -Ursprüngliche Nachricht- Von: Dieter Muecke [mailto:d_mu...@me.com] Gesendet: Samstag, 27. Juni 2009 13:39 An: karl.guggisb...@guggis.ch Cc: josm-dev@openstreetmap.org Betreff: Re: AW: [josm-dev] unit testing I would focus on unit tests. Primarily all tests should run successfully after checkout from repository. Could you add missing libraries to svn repo? I've only found newer versions of the same. -Dieter On 27 Jun 2009, at 13:21, Karl Guggisberg wrote: Hi, I've only recently started to commit unit test cases, in a non- systematic way, thought. I strongly agree that there should be more test cases. I've been using the following framework(s) in test cases: - JUnit 4 - FEST (for reflection) I've started to write functional test cases too, mainly for automated GUI tests using FEST. My env is structured as follows test/unit - unit test cases test/unit/build.xml - ANT file for unit tests test/functional - functional test cases (including GUI tests and tests which require a running API server) test/functional/build.xml - ANT file for functional test test/data - test data for specific test cases (i.e. a set of merge test cases) test/lib/junit- JUnit libraries test/lib/fest - FEST libraries test/report - output directory for test cases I've committed a subset of this so far. If it was useful for you, I could commit the rest too. It's not very clean yet and it could be improved. So, I encourage you to work on this. Regards Karl -Ursprüngliche Nachricht- Von: josm-dev-boun...@openstreetmap.org [mailto:josm-dev-boun...@openstreetmap.org] Im Auftrag von Dieter Muecke Gesendet: Samstag, 27. Juni 2009 13:01 An: josm-dev@openstreetmap.org Betreff: [josm-dev] unit testing Unit testing seems slightly disregarded and I wonder why nobody has opened a jira ticket to fix? I would do the work if we would find an agreement which unit test library or framework to use. What are your thoughts? -Dieter ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
