[Potlatch-dev] [OpenStreetMap] #4496: Potlatch 2 can leave isolated nodes

2012-07-28 Thread OpenStreetMap
#4496: Potlatch 2 can leave isolated nodes
--+-
 Reporter:  Madryn|   Owner:  potlatch-dev@…

 Type:  defect|  Status:  new   

 Priority:  minor |   Milestone:

Component:  potlatch2 | Version:

 Keywords:  odbl=clean isolated node  |  
--+-
 My understanding is that, when a way is deleted, all of its nodes are
 deleted unless they are part of other ways or are tagged with further
 information. That rule appears to be followed even if the only tag on a
 node is 'odbl=clean'. I deleted a way (a short footpath) that contained
 several nodes marked odbl=clean. After deleting the way, several isolated
 nodes remained, each tagged with 'odbl=clean' and no other tags. It would
 be easy to fail to notice these nodes and to leave them in place, thus
 increasing the size of the database without adding anything to the map.
 I was using the default editor (Potlatch 2 in-browser) running on Firefox
 under Windows XP.

-- 
Ticket URL: https://trac.openstreetmap.org/ticket/4496
OpenStreetMap http://www.openstreetmap.org/
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [OSM-dev] [GSoC] Improvements to Vespucci

2012-07-28 Thread Jan Schejbal
Hi,
I have rewritten the GPS tracking part to use a Service, allowing tracks
to be reliably recorded even when the application is not active. Tracks
are now only recorded by user request. The GPS location can be shown or
hidden independently from track recording. Recorded tracks are
automatically and continuously saved (an 8k buffer from a BufferedWriter
and OS buffers apply). GPS location updates are only requested when
needed. This means that exitting the app with the home button will
disable location updates (if no track is being recorded) to avoid
draining the battery.

Please note that track uploading support was never implemented, so
currently, you cannot get the tracks out of Vespucci.

Some additional minor enhancements are included.

The code is in the repo. A new APK has been provided at the usual URL.

My future priorities are:
- implementing Undo
- honor optional/non-fixed tags from presets
- show icons from presets on map

If time allows, saving tracks and changes to XML (and/or uploading
tracks) could also be included.

Kind regards,
Jan

___
dev mailing list
dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/dev


Re: [OSM-dev] [GSoC] Improvements to Vespucci

2012-07-28 Thread Toby Murray
Not sure if this has anything to do with your changes or not but I can
no longer use Bing imagery. If I select Bing as the background,
Vespucci crashes when I go back to the map. Then I can't even start it
up until I nuke all data to reset the background option back to mapnik
tiles. If it isn't related to your changes, I'm wondering if it might
have to do with problems people were seeing with Bing in JOSM and P2 a
couple of days ago.

Toby

___
dev mailing list
dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/dev


Re: [OSM-dev] [GSoC] Improvements to Vespucci

2012-07-28 Thread winfi...@gmail.com
I have the same issue. I didn't realise it was to Bing though.

Sent from my HTC FLYER

- Reply message -
From: Toby Murray toby.mur...@gmail.com
To: dev@openstreetmap.org
Cc: osmeditor4andr...@googlegroups.com
Subject: [OSM-dev] [GSoC] Improvements to Vespucci
Date: Sat, Jul 28, 2012 10:08


Not sure if this has anything to do with your changes or not but I can
no longer use Bing imagery. If I select Bing as the background,
Vespucci crashes when I go back to the map. Then I can't even start it
up until I nuke all data to reset the background option back to mapnik
tiles. If it isn't related to your changes, I'm wondering if it might
have to do with problems people were seeing with Bing in JOSM and P2 a
couple of days ago.

Toby

___
dev mailing list
dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/dev
___
dev mailing list
dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/dev


Re: [OSM-dev] [GSoC] Improvements to Vespucci

2012-07-28 Thread Jan Schejbal
Am 2012-07-28 10:08, schrieb Toby Murray:
 Not sure if this has anything to do with your changes or not but I can
 no longer use Bing imagery. If I select Bing as the background,
 Vespucci crashes when I go back to the map.

I can confirm that it does happen in my version, and that it does not
happen with Vespucci-0.7.0.apk from the download section.

The problem is that the constructor of OpenStreetMapTileServer (which is
called on the main thread via Main.onStart() - Map.setPrefs() -
OpenStreetMapTileServer.get()) attempts to do blocking network I/O
(which android does not allow on the main thread).

However, it looks like none of the relevant code was changed since the
0.7.0 release. The documentation for the NetworkOnMainThreadException
reveals that This is only thrown for applications targeting the
Honeycomb SDK or higher. - i.e. there is a programming issue (network
access on the main thread) which did go unnoticed until I bumped the
Target SDK Version, enabling strict mode.

An ugly hack (disabling strict mode) will be provided with the next APK
to fix (read: ignore) this issue temporarily, until someone who is
more knowledgable about the tile provider code fixes it properly by
moving the network I/O off the main thread.

Kind regards,
Jan

___
dev mailing list
dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/dev


Re: [OSM-dev] [GSoC] Improvements to Vespucci

2012-07-28 Thread Jan Schejbal
Am 2012-07-28 10:13, schrieb winfi...@gmail.com:
 I have the same issue. I didn't realise it was to Bing though.

A new APK has now been uploaded to the usual location.

Please note that this does not really fix the underlying issue, just
disable the crash Android triggers to alert developers about it. Instead
of crashing, a red border around the screen is now shown while the main
thread is hanging due to network I/O.

The issue might cause application not responding issues in slow
networks, and causes the app to take long to start up. Therefor, it
probably should be fixed sooner or later by someone knowledgable in the
Map tile code.

Kind regards,
Jan

___
dev mailing list
dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/dev