Re: [OSM-dev] [GSoC] Improvements to Vespucci
I don't see much use for an action bar in the tag editor. We should just leave it as it is. We've made some great progress thanks to Jan to be talking about trivial things like this. :) On Sun, Aug 19, 2012 at 4:35 AM, andrewg_oz andrew.greg...@gmail.comwrote: Everything is looking pretty good now. I'm going to take Vespucci out for a survey later today to see how things go. I've also noticed a small annoyance with the tag editor. The main map activity is using the new action bar, but the tag editor activity is still using the classic Android title bar. With the background transparent it looks a little messy seeing half the action bar of the main activity behind the title bar of the tag editor. Is that something easy to fix? (eg make the tag editor use an action bar too?) Regards, Andrew ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] [GSoC] Improvements to Vespucci
On Sunday, August 19, 2012 2:16:18 PM UTC+8, Marcus Wolschon wrote: I don't see much use for an action bar in the tag editor. On the contrary, we're starting to have quite a little collection of buttons in the main form that would be much better if moved to an action bar. We should just leave it as it is. See above. We've made some great progress thanks to Jan to be talking about trivial things like this. :) Jan has indeed made excellent progress, and Vespucci is very much better for it. Nevertheless, he seems to be familiar with action bars and if it was something that could be done quickly with little effort, then now would seem the time to do it. Too often things aren't done because they're trivial. And more things. And more things. Eventually the software ends up feeling shoddy because there are so many trivial things that need fixing. Don't worry, I'll raise an issue and I'll do it, but I think I'll wait until Jan's branch is merged into the trunk. ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] [GSoC] Improvements to Vespucci
On Sun, Aug 19, 2012 at 12:18 PM, andrewg_oz andrew.greg...@gmail.comwrote: On Sunday, August 19, 2012 2:16:18 PM UTC+8, Marcus Wolschon wrote: I don't see much use for an action bar in the tag editor. On the contrary, we're starting to have quite a little collection of buttons in the main form that would be much better if moved to an action bar. We should just leave it as it is. See above. We've made some great progress thanks to Jan to be talking about trivial things like this. :) Jan has indeed made excellent progress, and Vespucci is very much better for it. Nevertheless, he seems to be familiar with action bars and if it was something that could be done quickly with little effort, then now would seem the time to do it. Too often things aren't done because they're trivial. And more things. And more things. Eventually the software ends up feeling shoddy because there are so many trivial things that need fixing. Don't worry, I'll raise an issue and I'll do it, but I think I'll wait until Jan's branch is merged into the trunk. In that case, let's talk about it in detail in 2 weeks, okay? GSoC deadline in tomorrow (So now is the time for last documentation and comments) and I'll be on a short vacation. Marcu ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] [GSoC] Improvements to Vespucci
On Sunday, August 19, 2012 10:35:50 AM UTC+8, andrewg_oz wrote: Everything is looking pretty good now. I'm going to take Vespucci out for a survey later today to see how things go. Now that I'm back from my survey, here are the things I noticed. First the good stuff: 1. GPS works fine. Turned it off and on again no problem. 2. Undo works too! I even used it once! :-) *Very* handy. 3. The new presets are working nicely. Unfortunately, it's not all good: 1. After a while the action bar items started disappearing. First the undo and GPS buttons disappeared. The main action drop-down (Move, EasyEdit, New, etc) was still visible and worked properly. Pressing Menu just revealed Preferences and Help. Transfer was not visible anywhere. Going into the Preferences and backing out without changing anything resulted in the main action drop-down going blank (the little triangle was still visible), and pressing it would do nothing. The action bar was blank except for the little triangle related to the main action drop-down. At this point I couldn't transfer to save my data. I had to exit Vespucci and restart it. 2. In the tag editor, the tag key/value auto complete doesn't seem to be working properly. The key auto-complete seems to be working, but the value auto-complete seems to be missing entirely. On the whole, it's all working very well. ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] [GSoC] Improvements to Vespucci
On Sun, Aug 19, 2012 at 12:32 PM, andrewg_oz andrew.greg...@gmail.comwrote: On Sunday, August 19, 2012 10:35:50 AM UTC+8, andrewg_oz wrote: Everything is looking pretty good now. I'm going to take Vespucci out for a survey later today to see how things go. Now that I'm back from my survey, here are the things I noticed. First the good stuff: 1. GPS works fine. Turned it off and on again no problem. 2. Undo works too! I even used it once! :-) *Very* handy. 3. The new presets are working nicely. Unfortunately, it's not all good: 1. After a while the action bar items started disappearing. First the undo and GPS buttons disappeared. The main action drop-down (Move, EasyEdit, New, etc) was still visible and worked properly. Pressing Menu just revealed Preferences and Help. Transfer was not visible anywhere. Going into the Preferences and backing out without changing anything resulted in the main action drop-down going blank (the little triangle was still visible), and pressing it would do nothing. The action bar was blank except for the little triangle related to the main action drop-down. At this point I couldn't transfer to save my data. I had to exit Vespucci and restart it. 2. In the tag editor, the tag key/value auto complete doesn't seem to be working properly. The key auto-complete seems to be working, but the value auto-complete seems to be missing entirely. On the whole, it's all working very well. Value auto-complete worked fine here. What keys did you try? What Android Version are you using? 4.x with native Action bar, 3.x with the first Action Bar or an earlier one with the Compat-Library/ActionBarSherlock ? ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] [GSoC] Improvements to Vespucci
On Sunday, August 19, 2012 6:49:30 PM UTC+8, Marcus Wolschon wrote: On Sun, Aug 19, 2012 at 12:32 PM, andrewg_oz andrew@gmail.comjavascript: wrote: 2. In the tag editor, the tag key/value auto complete doesn't seem to be working properly. The key auto-complete seems to be working, but the value auto-complete seems to be missing entirely. Value auto-complete worked fine here. What keys did you try? I first noticed the problem with street name completion. Previously it would auto-complete based on nearby street names. So that's the name key for one. Now I've also tried highway. i.e. typing r in the value should get road and residential at least, but nothing. oneway should get yes or no, but nothing. Same for the designated and segregated keys on footways. No value auto-completes at all. What Android Version are you using? 4.x with native Action bar, 3.x with the first Action Bar or an earlier one with the Compat-Library/ActionBarSherlock ? Sorry, I should always mention version. :-( I'm using Jan's latest apk, on an HTC Desire Z that is running Gingerbread (2.3). So I guess that means the compatibility action bar library. Except that as previously discussed there is no action bar in the tag editor and I've had the value auto-completion working before... Andrew ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] [GSoC] Improvements to Vespucci
Am 2012-08-19 04:35, schrieb andrewg_oz: I've also noticed a small annoyance with the tag editor. The main map activity is using the new action bar, but the tag editor activity is still using the classic Android title bar. With the background transparent it looks a little messy seeing half the action bar of the main activity behind the title bar of the tag editor. Is that something easy to fix? (eg make the tag editor use an action bar too?) Reasonably easy, yes, but given that the absolute deadline is in 22 hours (give or take timezone differences), it is not going to happen as part of GSoC. Gruß Jan ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] [GSoC] Improvements to Vespucci
Am 2012-08-19 12:32, schrieb andrewg_oz: 1. After a while the action bar items started disappearing. First the undo and GPS buttons disappeared. If it happened during data uploading, I think the workaround was missing there, so maybe just inserting it fixed everything. I noticed that at least in some cases where the menu gets messed up an exception is thrown due to a call from the wrong thread. I have now removed an overly broad try..catch to ensure this results in a crash and gets immediately noticed, including a nice stack trace to find where the wrong call was made so it can be fixed. If icons continue to disappear despite this, we'll have to remove menu invalidation (and thus dynamic menus) altogether. I have also built the newest version with the current ActionBarSherlock and support library. Please test it thoroughly. 2. In the tag editor, the tag key/value auto complete doesn't seem to be working properly. The key auto-complete seems to be working, but the value auto-complete seems to be missing entirely. (Should also be fixed now, mail went only to the osmeditor list) Kind regards, Jan ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Duplicate IDs
On Mon, Aug 20, 2012 at 3:38 AM, Jochen Topf joc...@remote.org wrote: On Sun, Aug 19, 2012 at 09:25:45PM +0200, Lukas Kabrt wrote: I have created a small library for parsing OSM data and one of the users reported a weird error. The root cause of this error is the fact that there are elements with duplicate IDs in the database. I have found at least this pair - http://www.openstreetmap.org/browse/way/49755010 and http://www.openstreetmap.org/browse/node/49755010 Before I start fixing this error, it would be nice to know whether this is an exceptional case or whether these kind of integrity violations happens more often. Has anyone seen other elements with duplicate IDs? What is the best way to fix it in the database? OSM has three types of objects: nodes, ways, and relations. And they all have their own number space. While this seems common knowledge to longtime OSM people, is this documented in the wiki? I looked at the following pages and nothing indicates that nodes, ways, relations, and changesets all have their own ID number space: http://wiki.openstreetmap.org/wiki/Elements http://wiki.openstreetmap.org/wiki/API_v0.6 Is there another page stating this? It's possible that someone relatively new to OSM might commit the same mistake of assuming that all elements of any type have unique IDs. ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Duplicate IDs
On Sun, Aug 19, 2012 at 3:25 PM, Lukas Kabrt lu...@kabrt.cz wrote: Before I start fixing this error, it would be nice to know whether this is an exceptional case or whether these kind of integrity violations happens more often. Has anyone seen other elements with duplicate IDs? What is the best way to fix it in the database? I'm going to assume from your name and your domain that English isn't your first language, but I think it needs mentioning that stating that this is an integrity violation is a bit offputting. As others have mentioned (as well as the OSM documentation), IDs are not guaranteed to be unique across element types, and so if your code does, then this is simply a bad assumption on your part. You may not have intended your mail to sound like you were blaming OSM developers for being in error, but that's how it came off. - Serge ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] [GSoC] Improvements to Vespucci
On Sunday, August 19, 2012 11:07:18 PM UTC+8, Jan Schejbal wrote: Am 2012-08-19 12:32, schrieb andrewg_oz: 1. After a while the action bar items started disappearing. First the undo and GPS buttons disappeared. If it happened during data uploading, I think the workaround was missing there, so maybe just inserting it fixed everything. That's possible. I was uploading at the time I noticed the items go missing, but I had also been uploading on at least six other occasions without any problems. I noticed that at least in some cases where the menu gets messed up an exception is thrown due to a call from the wrong thread. I have now removed an overly broad try..catch to ensure this results in a crash and gets immediately noticed, including a nice stack trace to find where the wrong call was made so it can be fixed. I regret not making more effort to merge in my ACRA support changes. I think I'll have to make that one of the first things to do after your own changes are merged in. If icons continue to disappear despite this, we'll have to remove menu invalidation (and thus dynamic menus) altogether. I have also built the newest version with the current ActionBarSherlock and support library. Please test it thoroughly. I've just downloaded your latest. I didn't notice the items go missing until about an hour into the survey and after several uploads. It's probably going to take another actual survey to test properly and I won't be able to do that until next weekend. 2. In the tag editor, the tag key/value auto complete doesn't seem to be working properly. The key auto-complete seems to be working, but the value auto-complete seems to be missing entirely. (Should also be fixed now, mail went only to the osmeditor list) Confirmed. Thanks for that. Regards, Andrew ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
