Re: Develop for JOSM core or plugin?
Sounds like a feature small enough and useful to all to be considered a core enhancement. Le sam. 27 avr. 2019 à 11:22, Jiri Vlasak a écrit : > On Fri, Apr 26, 2019 at 02:53:49PM -0700, Tom H. wrote: > > Hi All, > > > > I'm using JOSM constantly in my day to day job, and I'm having a few > ideas > > for using hotkeys to toggle some of the layer settings that can now only > be > > activated by point and click. I'm new to contributing in JOSM but am > > currently looking through the dev docs, and I was just wondering if it's > > better to realize my hotkey ideas via a plugin, or trying to > incorporating > > them into the JOSM core? > > tl;dr (generic) ? upstream : plugin ; > > There was already discussion when I started developing the plugin. Feel > free to > see the "JOSM enhancements vs. separate plugin" thread [1]. > > Have a nice day, > jiri > > [1]: > https://lists.openstreetmap.org/pipermail/josm-dev/2018-May/thread.html > >
Re: [OSM-dev] oauth token lifetime
On 27/04/2019 14:37, Jiri Vlasak wrote: On Fri, Apr 26, 2019 at 07:28:39PM +0100, Tom Hughes wrote: On 26/04/2019 19:06, Jiri Vlasak wrote: This approach is similar to one used by HOT Tasking Manager [1]. In my "oauth settings" section I have many many "Tasking Manager 3 - Prod" tokens. And I feel this approach is not right. That's usually because the client is broken and is not storing the token but is instead requesting a new one every time you use it. That's my guess too. So, I would like to write it better. My problem is that I am quite confused by OAuth. If I understand it correctly, OAuth is here for authorization. But, in my case (and in the case of HOT Tasking Manager), the use case is authentication. Yes it is really abuse of OAuth in general but is common. Note that OAuth 2 (in the form of OpenID Connect) has basically merged the two use cases anyway. So maybe I should ask - is it possible to authenticate to osm.org? Well yes, that is what OAuth does. What is happening here is using your osm.org account to authenticate to a third party site. That works if the third party is prepared to accept you allowing it to access osm.org as valid authentication. Tom -- Tom Hughes (t...@compton.nu) http://compton.nu/ ___ dev mailing list dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] oauth token lifetime
On Fri, Apr 26, 2019 at 07:28:39PM +0100, Tom Hughes wrote: > On 26/04/2019 19:06, Jiri Vlasak wrote: > > This approach is similar to one used by HOT Tasking Manager [1]. In my > > "oauth > > settings" section I have many many "Tasking Manager 3 - Prod" tokens. And I > > feel this approach is not right. > > That's usually because the client is broken and is not storing the > token but is instead requesting a new one every time you use it. That's my guess too. So, I would like to write it better. My problem is that I am quite confused by OAuth. If I understand it correctly, OAuth is here for authorization. But, in my case (and in the case of HOT Tasking Manager), the use case is authentication. So maybe I should ask - is it possible to authenticate to osm.org? Thanks a lot, jiri ___ dev mailing list dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/dev
Re: Develop for JOSM core or plugin?
On Fri, Apr 26, 2019 at 02:53:49PM -0700, Tom H. wrote: > Hi All, > > I'm using JOSM constantly in my day to day job, and I'm having a few ideas > for using hotkeys to toggle some of the layer settings that can now only be > activated by point and click. I'm new to contributing in JOSM but am > currently looking through the dev docs, and I was just wondering if it's > better to realize my hotkey ideas via a plugin, or trying to incorporating > them into the JOSM core? tl;dr (generic) ? upstream : plugin ; There was already discussion when I started developing the plugin. Feel free to see the "JOSM enhancements vs. separate plugin" thread [1]. Have a nice day, jiri [1]: https://lists.openstreetmap.org/pipermail/josm-dev/2018-May/thread.html
