Re: [josm-dev] Common presets for OSM editors?

2015-06-19 Thread Bryce Nesbitt
A while back I wrote scripts to build a *grid* of preset support (base on
parsing the source code of each editor).  I use that on occasion to
identify and argue in favour of adding certain presets.

I think the bigger constraint on OSM growth though is not presets, but
rendering support.  There are good communities of mappers and features
which have presets, but are rendered nowhere.
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Possible patch to MessageNotifier : Offer mappers visibility into tag discussions

2015-04-03 Thread Bryce Nesbitt
On Fri, Mar 27, 2015 at 12:05 AM, Jochen Topf joc...@remote.org wrote:

 Have you considered that those thousands of mappers are not interested in
 endless discussions about tags?


Yes, exactly, I did consider it.  The tagging list is a huge and ugly pit
that many wisely choose not to wade in.
But a enthusiast for electric power mapping may be intently interested in a
new proposal to alter electric power tags.

How can we, intrusively, tip off the right community of mappers that their
tags are getting discussed,
without burdening them with subscribe to the tagging list?

Could Taginfo identify in big data form the mappers most affected by a
tagging proposal?
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Possible patch to MessageNotifier : Offer mappers visibility into tag discussions

2015-04-03 Thread Bryce Nesbitt
On Fri, Apr 3, 2015 at 2:19 PM, Bryce Nesbitt bry...@obviously.com wrote:

 How can we, intrusively, tip off the right community of mappers that their
 tags are getting discussed


s/intrusively/unobtrusively/
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Possible patch to MessageNotifier : Offer mappers visibility into tag discussions

2015-04-03 Thread Bryce Nesbitt
On Fri, Mar 27, 2015 at 12:05 AM, Jochen Topf joc...@remote.org wrote:

 For me seeing any news or discussions when starting JOSM ist
 the worst possible moment, because I started it with a specific goal in
 mind,
 ie editing something in OSM. I don't want to be distracted by news then.


Perhaps at commit time is more opportune, be it a plugin or core feature:


Your changeset ID is 123123133.  Thank you for helping to improve the map!

400 other changesets were made in the last hour.
You have 2 messages from other mappers.
5 people edited the same area you just did, including 0 first time mappers.
7 tagging conventions are up for discussion: paving_stone_aggregate_size,
taginfo_alt_data, 'renaming status approved to published'.
Upcoming conferences include: STOM USA April 1st, OpenGeoGeo.

Nothing here forces anyone to care about the community, but it could
connect them to community.
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Possible patch to MessageNotifier : Offer mappers visibility into tag discussions

2015-03-26 Thread Bryce Nesbitt
On Wed, Mar 25, 2015 at 1:14 AM, Dirk Stöcker openstreet...@dstoecker.de
wrote:

 On Tue, 24 Mar 2015, Bryce Nesbitt wrote:

  Not every tag proposal of is interest to a given mapper.  But perhaps this
 will help connect
 the right mapper to the right tag design debate.

 Your thoughts?


 Fine if you make a plugin of it. Nothing for the core.
 Ciao


How about instead something on the news page, automatically built, and
translated in JOSM's languages?


---
A plugin is straightforward enough to create, but the only people enabling
such a plugin would be the exact people already engaged in discussions of
tagging improvements.

It should be observed that JOSM does quite a bit to influence and control
tag behavior:
* Auto-complete tag names
* Validation rules
* Presets

But there's a step before a preset is accepted by the JOSM core developers,
and it's that process that could use some
visibility among the tens of thousands of mappers who don't follow the
mailing lists.

Thoughts?
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Possible patch to MessageNotifier : Offer mappers visibility into tag discussions

2015-03-26 Thread Bryce Nesbitt
Put another way:  thousands of mappers will use editors like JOSM, mapping
happily.  My goal here is to find ways to
give those mappers a view into the discussions behind the data.  A link to
OSM weekly news for example, would fit in just as well.

This is not meant to be anything big or intrusive.  Just the message that
the wider community is currently talking about X, Y, Z.
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


[josm-dev] Possible patch to MessageNotifier : Offer mappers visibility into tag discussions

2015-03-25 Thread Bryce Nesbitt
This is a partially baked JOSM patch:
https://www.dropbox.com/s/m1txareeowlnvc3/MessageNotifier.java?dl=0
The code is hacky and quickly done, but here's why I created it:

The discussion around design of new tags has created a lot of complaints,
but it also has a lot of value.  One of the problems is that the tagging
mailing list attracts a small set of tag enthusiasts.  By notifying JOSM
mappers of tag designs under consideration, my hope is to broaden the
viewpoints given.  JOSM mappers are often experienced, and can help make a
tagging proposal great.

Thus a notification window, checked at the same interval as messages:


​
One big problem is that it's coded to notify mappers of votes.  But the
vote stage is too late.  It would be better to get new voices involved
earlier.

Not every tag proposal of is interest to a given mapper.  But perhaps this
will help connect
the right mapper to the right tag design debate.

Your thoughts?
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Checking tags

2015-03-16 Thread Bryce Nesbitt
On Mon, Mar 16, 2015 at 2:11 AM, Martin Koppenhoefer dieterdre...@gmail.com
 wrote:


 2015-03-16 10:01 GMT+01:00 Bryce Nesbitt bry...@obviously.com:

 You can use any Unicode characters (utf-8) as you like.


 Is now,
need not be forever.
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Checking tags

2015-03-16 Thread Bryce Nesbitt
On Mon, Mar 16, 2015 at 7:02 AM, colliar colliar4e...@aol.com wrote:

 There is already the info level warning about keys or values not in
 presets. Maybe a new category for these warnings could help as right now
 they are well hidden.


The INFO level is essentially unusable, because too many valid keys do not
appear in JOSM's presets.

However, adding to the mistake checkfile could help a little:
   hight
   denonation
   naem
   nota
Along with warnings about colons greater than two, and keys length less
than four, etc.
--

Putting warnings inline with the tag editor could help a little.
I'd also like to see that area used for warning about tags that JOSM will
silently delete on upload.

--
Ultimately think the problem is not really at the editor level.  A buddy
system where changsets are looked
at by a second mapper would do far more.  Mangled keys often go hand in
hand with data that's also mangled.
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Checking tags

2015-03-16 Thread Bryce Nesbitt
I don't like the 1000 uses approach.
Some really terrible tags are used more than 1000 times,
and some really great ones less.

---
I think it far more useful to have editors offer guidance to new mappers.
JOSM can know how many changesets a person has uploaded, and turn on
extra guidance, especially for large changesets.  Connect new mappers to
experienced mappers via the editor!
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Checking tags

2015-03-16 Thread Bryce Nesbitt
At some level I feel it's the API's job to reject changesets with invalid
key/value lengths or characters.
JOSM should perhaps have a matching validator rule.
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Fwd: GSoC: OpenGL view for JOSM

2015-03-10 Thread Bryce Nesbitt
On Mon, Mar 9, 2015 at 10:19 AM, Michael Zangl
openstreet...@michael.fam-zangl.net wrote:

 This is a thing that annoyed me for a long time: JOSM is slow when
 zooming out. I would like to improve this and have enough spare time
 this summer to work on this as GSoC project.

One reason is fairly simple to fix:  JOSM loads background image tiles
in a non-optimal order.
If it first loaded the tiles under the currently selected object and
the mouse cursor, it would feel
much faster.

As it stands often the map tiles that are half off screen come in first.

___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] OSC format for offering proposed changes

2015-02-25 Thread Bryce Nesbitt
I use JOSM XML for this all the time.

I'm able build a file representing add/update/delete operations.
It works well with the TODO plugin.
It's all pretty smooth.

Downsides:
* The delete operation is a bit invisible: deleted notes only show up at
upload time.
* Changeset tags in the file are ignored, so I can't pre-set the tags used
for any eventual upload.
* If the file has ways, the TODO plugin is hard to use.  It ends up
stepping you through each node of the way, which gets tedious.  The
workaround is to search for any tag, then step through only things that
have tags.



On Wed, Feb 25, 2015 at 1:48 PM, Martijn van Exel m...@rtijn.org wrote:

 Hey JOSM-dev,

 I am curious what JOSMs capabilities are with regard to reading OSC files.
 I tried a few OSC files and they seem to read in correctly, but I am not
 sure how useful they are for a use case where you would want to offer a
 small file with proposed changes to OSM. Say I have a set of changes that
 consist of a mix of new tags to existing objects, changed ways / nodes,
 added ways / nodes, removed ways / nodes. I want to give this file to
 someone to load in JOSM and review + upload if they think the data is good.
 Would JOSM XML be a better choice for this?

 Thanks for your help,
 --
 Martijn van Exel
 skype: mvexel
 ___
 josm-dev mailing list
 josm-dev@openstreetmap.org
 https://lists.openstreetmap.org/listinfo/josm-dev

___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] OSC format for offering proposed changes

2015-02-25 Thread Bryce Nesbitt
n Wed, Feb 25, 2015 at 5:50 PM, Martijn van Exel m...@rtijn.org wrote:

 The first two downsides you mention, invisible deletes and ignored
 changeset tags, are not specific to the TODO plugin, or are they? I mean,
 making deletes visible (through a toggle switch perhaps) and supporting
 changeset tags in the JOSM XML format is something that could be added to
 JOSM core? I think this may be useful.



Because a deleted node is deleted, it can't be selected, so can't be added
to the TODO plugin list.
--
The changeset tag is already supported in the OSM XML format... it's just
not processed by the JOSM core.


--
Don't discount the third downside.  If you have a mixture of nodes ways and
areas, the third issue really bites.  You select all
and the TODO plugin walks you through every darn node.  It gets a little
better if you review only objects with a tag, but
that's hard to explain.

The dream TODO plugin for me would walk through in proximity order:
a) New objects
b) Modified objects
c) Deleted objects
d) Unmodified objects
With the plugin jumping to the next nearest object at each step ( a
proximity search ).
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


[josm-dev] JOSM Validator and FIXME

2015-02-18 Thread Bryce Nesbitt
Is the JOSM validator, as of 7995, still meant to process fixme or
FIXME tags?
I see it in the code:

UntaggedNode.java
if (contains(tag, fixme) || contains(tag, FIXME)) {

I see it in the wiki at http://wiki.openstreetmap.org/wiki/JOSM/Validator



But a sample FIXME node does not seem to trigger validation
https://www.openstreetmap.org/node/3358314882
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


[josm-dev] Middle click on area?

2015-02-16 Thread Bryce Nesbitt
I'm writing to see if there's been past discussion about extending middle
click to areas.

Right now if I used middle click on the interior of a closed way, nothing
shows up.
To select the closed way requires finding one of the edges.
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Middle click on area?

2015-02-16 Thread Bryce Nesbitt
On Mon, Feb 16, 2015 at 3:10 PM, Michael Kugelmann michaelk_...@gmx.de
wrote:

 On 17.02.2015 at 00:02 Bryce Nesbitt wrote:

 I'm writing to see if there's been past discussion about extending middle
 click to areas.

 Which tool/app/program (under which OS and on which Platform) or Map (on
 which Wiki page in which Browser) etc. do you talk about?
 Just my 2 cents,
 Michael.


I'm talking about The Open Street Map editor JOSM, running on all
platforms, under the Java programming environment.

With JOSM, middle click is used to select among objects that share the same
location.  For example when two areas
abut each other exactly, such as at the boundary between a
landuse=residential and landuse=commercial.
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Similarly named ways

2015-01-05 Thread Bryce Nesbitt
On Sat, Jan 3, 2015 at 12:17 PM, Paul Hartmann phaau...@gmail.com wrote:

 Improvement of the validator code is welcome, but I think we should just
 ignore the remaining false positives and don't add any validator-related
 tags to the OSM data.
 Paul


It would take only one tag.
Right now the validator will nag everyone editing in a particular area in
perpetuity.

How about:

*josm:validator:override=3*

Where the 3 represents the version of the given node/way/relation that
should not
trigger a validator message.  The warning could reappear later if the given
node/way
is actually edited.
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Similarly named ways

2015-01-05 Thread Bryce Nesbitt
On Mon, Jan 5, 2015 at 9:54 PM, Nelson A. de Oliveira nao...@gmail.com wrote:
 On Tue, Jan 6, 2015 at 2:43 AM, Bryce Nesbitt bry...@obviously.com wrote:
 It would take only one tag.

 Overrides should not be included in OSM itself.
 Otherwise we will have a database with an ignore tag for JOSM, another
 for editor X, other for Y and so on.

While it's true that could result in one tag per editor, there are a
finite number of editors.

The only other alternative is a database maintained on the JOSM
servers, with the same data.
That is perhaps cleaner from an OSM data point of view, but quite
likely more fragile.

The dogmatic answer is don't pollute the OSM data space.  The
pragmatic answer might not take that too strictly.

___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] JOSM 7777 released, with the new logo + help needed for an OSM blog post

2014-12-12 Thread Bryce Nesbitt
I did a little bit of work on the Mac setup instructions on the wiki.

Since even OS X Yosemite (the latest version from Apple) includes Java 6,
the setup for JOSM is quite involved for Mac users.  Some more work on
this issue
is definitely needed, especially if the hope is to draft in more new
users to JOSM.

___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Empty values are only warnings in validator?

2013-10-17 Thread Bryce Nesbitt
On Tue, Oct 15, 2013 at 6:56 AM, Martin Koppenhoefer dieterdre...@gmail.com
 wrote:

 I wonder if empty values shouldn't be considered errors in validator?
 Currently they are displayed as warnings on upload.


Agreed.  I think validator sometimes is too picky, but empty values are a
good validator catch.
Leading and trailing whitespace (including newlines) is another candidate
for a warning.
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] The Golden Rules

2013-08-25 Thread Bryce Nesbitt
On Sun, Aug 25, 2013 at 3:00 AM, Martin Koppenhoefer dieterdre...@gmail.com
 wrote:

 2013/8/24 Bryce Nesbitt bry...@obviously.com

 We're encouraged by project consensus to map areas based on Bing
 maps alone, for example.


 are we? Can you point me to a place in the wiki where this is the case? I
 always thought of aerial imagery as an additional source for mapping, not
 necessarily the only one, (I admit I also have mapped sometimes based on
 aerial imagery alone, but I didn't feel like I was doing a perfect mapping
 in these cases).


For sure in HOT land, where alerts asking for pure photo mapping come in
rather regularly.
http://maproulette.org/ is entirely photo mapping (using humans to count
highway lanes in air photos).
And in general, tiger tweaking, often promoted, is largely done as photo
mapping.

The wiki, of course, is only one version of consensus.

There's a judgement call here: when do you have enough knowledge to map? On
occasion after visiting an area, I'll feel I don't have enough, and punt on
something I even have a geotagged photo of.
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] The Golden Rules

2013-08-24 Thread Bryce Nesbitt
On Sat, Aug 24, 2013 at 1:58 AM, SomeoneElse li...@mail.atownsend.org.ukwrote:

 On Sat, Aug 24, 2013 at 1:58 AM, SomeoneElse li...@mail.atownsend.org.uk
  wrote:

What 
http://wiki.openstreetmap.org/**wiki/Mechanical_Edit_Policyhttp://wiki.openstreetmap.org/wiki/Mechanical_Edit_Policy
actually
 says is Generally, this policy covers all edits where an individual change
 to an object is not performed by a human being. This includes ...
 search-and-replace operations using an editor... unless your changes are
 backed up by knowledge or survey rather than just reckoning.


This quickly becomes a fuzzy question of what constitutes knowledge.

We're encouraged by project consensus to map areas based on Bing maps
alone, for example.  Is that knowledge?
Are map notes left by visitors to OpenStreetMap knowledge?
How about incorrect or misspelled attributes left by other mappers: is that
sort of like looking at Bing?
Is combining all the clues above (including clues left presumably by local
mappers), plus Google searches,  Knowledge?


If I edit a powerline that spans four counties:
Have I harmed or helped the map?
Have I harmed or helped the community of mappers?
Have I harmed or helped the* community of people who map power lines*?


So the question really becomes what *community or communities* apply to a
particular edit?
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] The Golden Rules

2013-08-24 Thread Bryce Nesbitt
On Sat, Aug 24, 2013 at 3:33 AM, Dirk Stöcker openstreet...@dstoecker.dewrote:

 On one side JOSM is the accepted expert tool. It allows to use it in a
 very broad range of situations. I don't intent to limit that as e.g. Bryce
 suggests. OSM developed very well and very likely the high freedom is a
 major part in that development.


The suggestion actually involves no restriction of freedom.
The proposal was to display to the mapper the extent of unexamined mapping,
e.g.:

   You edited attributes on *536* nodes, and individually examined *3* of
them.


Perhaps that's just a note.  Or perhaps that comes with:

   You edited attributes on *536* nodes, and individually examined *3* of
them.
   [x] yes I feel this is compatible with the *mechanical edit policy*
   [CONTINUE]


It is pretty easy with JOSM to accidentally edit bulk edit attributes: in
fact it's a strength of JOSM to be able to make such sweeping changes.
Having a little meter that tells you what you've done is useful even to the
most expert mapper.  When I bulk correct tagging mistakes it is
my intent to examine every changed node visually.  While the TODO plugin
helps, this could develop into something even more useful.

(For the beginner editor equivalent see
https://github.com/systemed/iD/issues/1735 ).
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] The Golden Rules

2013-08-24 Thread Bryce Nesbitt
On Sat, Aug 24, 2013 at 12:43 PM, Nicolás Alvarez nicolas.alva...@gmail.com
 wrote:

 2013/8/24 Bryce Nesbitt bry...@obviously.com:
  Is combining all the clues above (including clues left presumably by
 local
  mappers), plus Google searches,  Knowledge?

 I've been told that plus Google searches gets you in licensing
 trouble. Not because of Google, of course, but because of the sites
 you find.


Copying from Google Map, or any other map: that's trouble.
Looking up a company or venue website prior to mapping it?  Fair game.
Copyrights don't cover facts, they cover expression.


There is a problem spot, but it's more subtle. Say I visit a fruit stand
and map it.  I return home and
look up the fruit stand website to get the list of produce they offer.  On
the fruit stand website is google map, which I just glanced at.  Have I
contaminated the edit?
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] The Golden Rules

2013-08-24 Thread Bryce Nesbitt
On Sat, Aug 24, 2013 at 12:43 PM, Nicolás Alvarez nicolas.alva...@gmail.com
 wrote:

 2013/8/24 Bryce Nesbitt bry...@obviously.com:
  Is combining all the clues above (including clues left presumably by
 local
  mappers), plus Google searches,  Knowledge?

 I've been told that plus Google searches gets you in licensing
 trouble. Not because of Google, of course, but because of the sites
 you find.


Copying from Google Map, or any other map: that's trouble.
Looking up a company or venue website prior to mapping it?  Fair game.
Copyrights don't cover facts of any sort, they cover expression.  Patents
don't apply.



There is a problem spot, but it's more subtle. Say I visit a fruit stand
and map it.  I return home and
look up their website to get the list of produce they offer.  On their
website is google map, which I just glanced at.  Have I contaminated the
edit?
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] The Golden Rules

2013-08-24 Thread Bryce Nesbitt
On Fri, Aug 23, 2013 at 4:49 PM, Frederik Ramm frede...@remote.org wrote:

   at the bottom of our MotD it says:
 Remember the golden rules of OpenStreetMap:
 * Don't copy from other maps
 * Have fun!...
 Thoughts?


Right now that MotD element is below the fold, and only the dedicated
will scroll to it.  Put it at the top?
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Thank You Note?

2013-06-15 Thread Bryce Nesbitt
On Sat, Jun 15, 2013 at 3:37 AM, Frederik Ramm frede...@remote.org wrote:


 Sure, even nicer to get encouraging emails from others in the project but
 how likely is that?


Peer review is a bigger topic.
But peer review is also mapper-to-mapper contact.

Editing OSM can be a very isolated experience.  You find the map.  You find
a feature that's wrong.  You learn the tool.  You change it.
And that's it.  No followup, no thanks, no feedback.

Connecting a new (first 20 edits) user to a nearby mapper, that could
really draw people into the community of OSM.

I'd definitely review the edits of new nearby mappers.


[image: Inline image 1]
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Thank You Note?

2013-06-14 Thread Bryce Nesbitt
On Fri, Jun 14, 2013 at 3:53 AM, Frederik Ramm frede...@remote.org wrote:

 Hi,

at the FOSSGIS conference, someone said in a presentation that the user
 experience in OSM could be improved if the editor were to give a simple
 thank you message after you have uploaded something. Thank yo for
 contributing to OpenStreetMap or so.


I think it far more powerful if nothing special happens
...but a day or two later someone drops by, reviews the edit, and sends a
note of encouragement.

(but why is this on the JOSM list... JOSM is not an entry level editor?)
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] In josm load/save format how to specify changeset information?

2011-08-28 Thread Bryce Nesbitt

Patch at:
http://josm.openstreetmap.de/ticket/6742

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] In josm load/save format how to specify changeset information?

2011-08-27 Thread Bryce Nesbitt

On 08/26/2011 06:40 AM, André Riedel wrote:

2011/8/26 Bryce Nesbittbry...@obviously.com:

If not what syntax would make sense?

I would prefer something like this: [1] (Changeset syntax)

?xml version='1.0' encoding='UTF-8'?
osm version='0.6' generator='JOSM'
   changeset
 tag k=created_by v=JOSM 1.61/
 tag k=comment v=osmchange script to import dog poop sighting 
database/
 tag k=source v=Par-tay/
 tag k=source:website v=http://dataimport.org/dataset.kml/
   /changeset
   node id='-3' action='modify' visible='true'
lat='1.3698003002266779' lon='-1.235183515664342'
 tag k='access' v='foo' /
   /node
...
/osm


Ok, I was able to partially implement that, adding to the DataSet and 
parsing it.


Would a josm intermediate to advanced developer be willing to help 
finish the patch?
It is murky how to populate the stored changeset tags in the 
TagSettingsPanel,

and what to do if two layers specify different changeset tags.


===
--- src/org/openstreetmap/josm/io/OsmImporter.java(revision 4348)
+++ src/org/openstreetmap/josm/io/OsmImporter.java(working copy)
@@ -41,6 +41,11 @@
 protected void importData(InputStream in, File associatedFile) 
throws IllegalDataException {
 DataSet dataSet = OsmReader.parseDataSet(in, 
NullProgressMonitor.INSTANCE);
 final OsmDataLayer layer = new OsmDataLayer(dataSet, 
associatedFile.getName(), associatedFile);

+System.out.println(Bryce start);
+//System.out.println(dataSet.toString());
+System.out.println(dataSet.getChangeSet());
+System.out.println(Bryce end);
+
 // FIXME: remove UI stuff from IO subsystem
 //
 Runnable uiStuff = new Runnable() {

Index: src/org/openstreetmap/josm/data/osm/DataSet.java
===
--- src/org/openstreetmap/josm/data/osm/DataSet.java(revision 4348)
+++ src/org/openstreetmap/josm/data/osm/DataSet.java(working copy)
@@ -206,6 +206,17 @@
 this.version = version;
 }

+/*
+ * Holding bin for changeset tag information, to be applied when or 
if this is ever uploaded.

+ */
+private HashMap changeSetTags = new HashMap();
+public HashMap getChangeSet() {
+return changeSetTags;
+}
+public void addChangeSetTag(String k, String v) {
+this.changeSetTags.put(k,v);
+}
+
 /**
  * All nodes goes here, even when included in other data (ways 
etc). This enables the instant
  * conversion of the whole DataSet by iterating over this data 
structure.



___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev