Re: [ovs-dev] [PATCH] bridge: Fix use-after-free in bridge_aa_refresh_queue().

2015-04-17 Thread Dennis Flynn 
Acked-by: Dennis Flynn drfl...@avaya.com

On Thu, Apr 16, 2015 at 5:49 PM, Ben Pfaff b...@nicira.com wrote:

 Found by LLVM scan-build.

 Reported-by: Kevin Lo ke...@freebsd.org
 Signed-off-by: Ben Pfaff b...@nicira.com
 ---
  vswitchd/bridge.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

 diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
 index ea7d788..ee96f38 100644
 --- a/vswitchd/bridge.c
 +++ b/vswitchd/bridge.c
 @@ -3920,12 +3920,12 @@ static void
  bridge_aa_refresh_queued(struct bridge *br)
  {
  struct ovs_list *list = xmalloc(sizeof *list);
 -struct bridge_aa_vlan *node;
 +struct bridge_aa_vlan *node, *next;

  list_init(list);
  ofproto_aa_vlan_get_queued(br-ofproto, list);

 -LIST_FOR_EACH(node, list_node, list) {
 +LIST_FOR_EACH_SAFE (node, next, list_node, list) {
  struct port *port;

  VLOG_INFO(ifname=%s, vlan=%u, oper=%u, node-port_name,
 node-vlan,
 --
 2.1.3

 ___
 dev mailing list
 dev@openvswitch.org
 http://openvswitch.org/mailman/listinfo/dev

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] bridge: Fix use-after-free in bridge_aa_refresh_queue().

2015-04-17 Thread Ben Pfaff 
Applied, thanks!

On Fri, Apr 17, 2015 at 12:01:15PM -0400, Dennis Flynn wrote:
 Acked-by: Dennis Flynn drfl...@avaya.com
 
 On Thu, Apr 16, 2015 at 5:49 PM, Ben Pfaff b...@nicira.com wrote:
 
  Found by LLVM scan-build.
 
  Reported-by: Kevin Lo ke...@freebsd.org
  Signed-off-by: Ben Pfaff b...@nicira.com
  ---
   vswitchd/bridge.c | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)
 
  diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
  index ea7d788..ee96f38 100644
  --- a/vswitchd/bridge.c
  +++ b/vswitchd/bridge.c
  @@ -3920,12 +3920,12 @@ static void
   bridge_aa_refresh_queued(struct bridge *br)
   {
   struct ovs_list *list = xmalloc(sizeof *list);
  -struct bridge_aa_vlan *node;
  +struct bridge_aa_vlan *node, *next;
 
   list_init(list);
   ofproto_aa_vlan_get_queued(br-ofproto, list);
 
  -LIST_FOR_EACH(node, list_node, list) {
  +LIST_FOR_EACH_SAFE (node, next, list_node, list) {
   struct port *port;
 
   VLOG_INFO(ifname=%s, vlan=%u, oper=%u, node-port_name,
  node-vlan,
  --
  2.1.3
 
  ___
  dev mailing list
  dev@openvswitch.org
  http://openvswitch.org/mailman/listinfo/dev
 
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] bridge: Fix use-after-free in bridge_aa_refresh_queue().

2015-04-16 Thread Ben Pfaff 
Found by LLVM scan-build.

Reported-by: Kevin Lo ke...@freebsd.org
Signed-off-by: Ben Pfaff b...@nicira.com
---
 vswitchd/bridge.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index ea7d788..ee96f38 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -3920,12 +3920,12 @@ static void
 bridge_aa_refresh_queued(struct bridge *br)
 {
 struct ovs_list *list = xmalloc(sizeof *list);
-struct bridge_aa_vlan *node;
+struct bridge_aa_vlan *node, *next;
 
 list_init(list);
 ofproto_aa_vlan_get_queued(br-ofproto, list);
 
-LIST_FOR_EACH(node, list_node, list) {
+LIST_FOR_EACH_SAFE (node, next, list_node, list) {
 struct port *port;
 
 VLOG_INFO(ifname=%s, vlan=%u, oper=%u, node-port_name, node-vlan,
-- 
2.1.3

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev