Re: [ovs-dev] [PATCH] ovn-northd: Drop redundant matching constraints in build_stateful().

[Ben Pfaff]

On Thu, Oct 06, 2016 at 04:19:59PM -0700, Justin Pettit wrote:
> 
> > On Oct 5, 2016, at 6:27 PM, Ben Pfaff  wrote:
> > 
> > ip4.dst implies ip, udp.dst implies udp, and tcp.dst implies tcp.
> > 
> > Signed-off-by: Ben Pfaff 
> 
> Acked-by: Justin Pettit 

Thanks, applied to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn-northd: Drop redundant matching constraints in build_stateful().

[Justin Pettit]

> On Oct 5, 2016, at 6:27 PM, Ben Pfaff  wrote:
> 
> ip4.dst implies ip, udp.dst implies udp, and tcp.dst implies tcp.
> 
> Signed-off-by: Ben Pfaff 

Acked-by: Justin Pettit 

--Justin




___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ovn-northd: Drop redundant matching constraints in build_stateful().

[Ben Pfaff]

ip4.dst implies ip, udp.dst implies udp, and tcp.dst implies tcp.

Signed-off-by: Ben Pfaff 
---
 ovn/northd/ovn-northd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
index 4668d9e..9bb49e8 100644
--- a/ovn/northd/ovn-northd.c
+++ b/ovn/northd/ovn-northd.c
@@ -2708,12 +2708,12 @@ build_stateful(struct ovn_datapath *od, struct hmap 
*lflows)
 /* New connections in Ingress table. */
 char *action = xasprintf("ct_lb(%s);", node->value);
 struct ds match = DS_EMPTY_INITIALIZER;
-ds_put_format(, "ct.new && ip && ip4.dst == %s", ip_address);
+ds_put_format(, "ct.new && ip4.dst == %s", ip_address);
 if (port) {
 if (lb->protocol && !strcmp(lb->protocol, "udp")) {
-ds_put_format(, " && udp && udp.dst == %d", port);
+ds_put_format(, " && udp.dst == %d", port);
 } else {
-ds_put_format(, " && tcp && tcp.dst == %d", port);
+ds_put_format(, " && tcp.dst == %d", port);
 }
 ovn_lflow_add(lflows, od, S_SWITCH_IN_STATEFUL,
   120, ds_cstr(), action);
-- 
2.1.3

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev