Re: [ovs-dev] [PATCH 3/3] ovn-controller.at: Stop hardcoding a list of iface types

2016-10-18 Thread Takashi YAMAMOTO 
On Wed, Oct 19, 2016 at 1:48 AM, Ben Pfaff  wrote:

> On Tue, Oct 18, 2016 at 09:25:26PM +0900, YAMAMOTO Takashi wrote:
> > The list of supported iface types hardcoded in the test
> > is wrong on NetBSD. (or any userland-only ports I guess)
> > Instead of adding another case for NetBSD following WIN32,
> > just get the list from ovsdb.
> >
> > Signed-off-by: YAMAMOTO Takashi 
>
> Good idea.
>
> Acked-by: Ben Pfaff 
>

thank you. pushed to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/3] ovn-controller.at: Stop hardcoding a list of iface types

2016-10-18 Thread Ben Pfaff 
On Tue, Oct 18, 2016 at 09:25:26PM +0900, YAMAMOTO Takashi wrote:
> The list of supported iface types hardcoded in the test
> is wrong on NetBSD. (or any userland-only ports I guess)
> Instead of adding another case for NetBSD following WIN32,
> just get the list from ovsdb.
> 
> Signed-off-by: YAMAMOTO Takashi 

Good idea.

Acked-by: Ben Pfaff 
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 3/3] ovn-controller.at: Stop hardcoding a list of iface types

2016-10-18 Thread YAMAMOTO Takashi 
The list of supported iface types hardcoded in the test
is wrong on NetBSD. (or any userland-only ports I guess)
Instead of adding another case for NetBSD following WIN32,
just get the list from ovsdb.

Signed-off-by: YAMAMOTO Takashi 
---
 tests/ovn-controller.at | 8 +---
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/tests/ovn-controller.at b/tests/ovn-controller.at
index b1211a5..60a6760 100644
--- a/tests/ovn-controller.at
+++ b/tests/ovn-controller.at
@@ -193,13 +193,7 @@ OVS_WAIT_UNTIL([check_datapath_type bar])
 ovs-vsctl set Bridge br-int datapath-type=\"\"
 OVS_WAIT_UNTIL([check_datapath_type ""])
 
-# The following will need to be updated as OVS starts to support more
-# interface types.
-if test "$IS_WIN32" = "yes"; then
-
expected_iface_types="dummy,dummy-internal,dummy-pmd,geneve,gre,internal,lisp,patch,stt,system,vxlan"
-else
-
expected_iface_types="dummy,dummy-internal,dummy-pmd,geneve,gre,internal,lisp,patch,stt,system,tap,vxlan"
-fi
+expected_iface_types=$(ovs-vsctl get Open_vSwitch . iface_types|sed 's/[[]][[ 
]]//g')
 chassis_iface_types=$(ovn-sbctl get Chassis ${sysid} external_ids:iface-types 
| sed -e 's/\"//g')
 echo "chassis_iface_types = ${chassis_iface_types}"
 AT_CHECK([test "${expected_iface_types}" = "${chassis_iface_types}"])
-- 
2.5.4 (Apple Git-61)

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev