Re: [ovs-dev] [PATCH 4/4] ovn-nbctl: Improve ovn-nbctl manpage

[Ben Pfaff]

On Wed, Oct 05, 2016 at 04:20:45AM -0700, nickcooper-zhangtonghao wrote:
> Signed-off-by: nickcooper-zhangtonghao 
> 

Thanks for pointing out the omission.  I ended up doing significant
further work here.  I applied the following final patch.

--8<--cut here-->8--

From: nickcooper-zhangtonghao 
Date: Wed, 5 Oct 2016 04:20:45 -0700
Subject: [PATCH] ovn-nbctl: Improve ovn-nbctl manpage

Signed-off-by: nickcooper-zhangtonghao 
[b...@ovn.org added further improvements]
Signed-off-by: Ben Pfaff 
---
 ovn/utilities/ovn-nbctl.8.xml | 40 
 1 file changed, 32 insertions(+), 8 deletions(-)

diff --git a/ovn/utilities/ovn-nbctl.8.xml b/ovn/utilities/ovn-nbctl.8.xml
index 7cd515f..2cbd6e0 100644
--- a/ovn/utilities/ovn-nbctl.8.xml
+++ b/ovn/utilities/ovn-nbctl.8.xml
@@ -169,14 +169,38 @@
 
   lsp-set-addresses port 
[address]...
   
-Sets the addresses associated with port to
-address.  Each address should be either an
-Ethernet address or an Ethernet address followed by IP addresses
-(separated by space and quoted to form a single command-line
-argument).  The special form unknown is also valid.
-Multiple Ethernet addresses or Ethernet+IPs combinations may be set.
-If no address argument is given, port will have
-no addresses associated with it.
+
+  Sets the addresses associated with port to
+  address.  Each address should be one of the
+  following:
+
+
+
+  an Ethernet address, optionally followed by a space and one or 
more IP addresses
+  
+OVN delivers packets for the Ethernet address to this port.
+  
+
+  unknown
+  
+OVN delivers unicast Ethernet packets whose destination MAC address
+is not in any logical port's addresses column to ports with address
+unknown.
+  
+
+  dynamic
+  
+Use this keyword to make ovn-northd generate a
+globally unique MAC address and choose an unused IPv4 address with
+the logical port's subnet and store them in the port's
+dynamic_addresses column.
+  
+
+
+
+  Multiple addresses may be set.  If no address argument is
+  given, port will have no addresses associated with it.
+
   
 
   lsp-get-addresses port
-- 
2.1.3

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 4/4] ovn-nbctl: Improve ovn-nbctl manpage

[nickcooper-zhangtonghao]

Signed-off-by: nickcooper-zhangtonghao 
---
 ovn/utilities/ovn-nbctl.8.xml | 13 ++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/ovn/utilities/ovn-nbctl.8.xml b/ovn/utilities/ovn-nbctl.8.xml
index 7cd515f..70798dc 100644
--- a/ovn/utilities/ovn-nbctl.8.xml
+++ b/ovn/utilities/ovn-nbctl.8.xml
@@ -173,10 +173,17 @@
 address.  Each address should be either an
 Ethernet address or an Ethernet address followed by IP addresses
 (separated by space and quoted to form a single command-line
-argument).  The special form unknown is also valid.
+argument).  The special form unknown is valid.
+When an OVN logical switch processes a unicast Ethernet frame
+whose destination MAC address is not in any logical port's addresses
+column, it delivers it to the port (or ports) whose addresses columns
+include unknown.  The special form dynamic is also valid.
+Use this keyword to make ovn-northd generate a globally unique MAC
+address and choose an unused IPv4 address with the logical port's
+subnet and store them in the port's dynamic_addresses column.
 Multiple Ethernet addresses or Ethernet+IPs combinations may be set.
-If no address argument is given, port will have
-no addresses associated with it.
+If no address argument is given, port will
+have no addresses associated with it.
   
 
   lsp-get-addresses port
-- 
1.8.3.1



___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev