Re: [ovs-dev] [PATCH] bridge: Fix high cpu utilization.
Awesome, thanks for the fix. On 1 October 2014 10:01, Alex Wang al...@nicira.com wrote: +dnl -- +AT_SETUP([ovs-vswitchd -- start additional ovs-vswitchd process]) +OVS_VSWITCHD_START + +# start another ovs-vswitchd process. +ovs-vswitchd --log-file=fakelog +pid=`echo $!` + +# sleep for a while +sleep 5 5 seems high, is this just to make sure that vswitchd gets a chance to fully initialize and go through the wait block once? Acked-by: Joe Stringer joestrin...@nicira.com ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH] bridge: Fix high cpu utilization.
Thx for the review~ 5 seems high, is this just to make sure that vswitchd gets a chance to fully initialize and go through the wait block once? Yeah, also to maybe cumulate more logs, if there is something. How about changing it to 2 s? Acked-by: Joe Stringer joestrin...@nicira.com ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH] bridge: Fix high cpu utilization.
I had a play around and could only reproduce the bug with mininum 3 seconds. On 1 October 2014 12:11, Alex Wang al...@nicira.com wrote: Thx for the review~ 5 seems high, is this just to make sure that vswitchd gets a chance to fully initialize and go through the wait block once? Yeah, also to maybe cumulate more logs, if there is something. How about changing it to 2 s? Acked-by: Joe Stringer joestrin...@nicira.com ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH] bridge: Fix high cpu utilization.
Yeah, so should we use 5 seconds? or use ovs_wait() to wait on the number of lines which could wait up to 10 seconds...? On Tue, Sep 30, 2014 at 4:14 PM, Joe Stringer joestrin...@nicira.com wrote: I had a play around and could only reproduce the bug with mininum 3 seconds. On 1 October 2014 12:11, Alex Wang al...@nicira.com wrote: Thx for the review~ 5 seems high, is this just to make sure that vswitchd gets a chance to fully initialize and go through the wait block once? Yeah, also to maybe cumulate more logs, if there is something. How about changing it to 2 s? Acked-by: Joe Stringer joestrin...@nicira.com ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH] bridge: Fix high cpu utilization.
Maybe just stick with 5. On 1 October 2014 13:10, Alex Wang al...@nicira.com wrote: Yeah, so should we use 5 seconds? or use ovs_wait() to wait on the number of lines which could wait up to 10 seconds...? On Tue, Sep 30, 2014 at 4:14 PM, Joe Stringer joestrin...@nicira.com wrote: I had a play around and could only reproduce the bug with mininum 3 seconds. On 1 October 2014 12:11, Alex Wang al...@nicira.com wrote: Thx for the review~ 5 seems high, is this just to make sure that vswitchd gets a chance to fully initialize and go through the wait block once? Yeah, also to maybe cumulate more logs, if there is something. How about changing it to 2 s? Acked-by: Joe Stringer joestrin...@nicira.com ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH] bridge: Fix high cpu utilization.
On Tue, Sep 30, 2014 at 5:13 PM, Joe Stringer joestrin...@nicira.com wrote: Maybe just stick with 5. 5 it is, also fold in the following check, applied to master~ diff --git a/tests/ovs-vswitchd.at b/tests/ovs-vswitchd.at index 9be3078..2c72a7f 100644 --- a/tests/ovs-vswitchd.at +++ b/tests/ovs-vswitchd.at @@ -82,7 +82,16 @@ sleep 5 kill $pid # check the fakelog, should only see one ERR for reporting -# the existing ovs-vswitchd process. +# the existing ovs-vswitchd process and one WARN for killing +# the process. +AT_CHECK([grep ERR fakelog | wc -l], [0], [dnl +1 +]) + +AT_CHECK([grep WARN fakelog | wc -l], [0], [dnl +1 +]) + ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
