Re: [ovs-dev] [PATCH] netdev-bsd: Fix use of uninitialized data in netdev_bsd_rxq_recv().
Thanks to everyone who reviewed this, I applied it to master and backported it as far as branch-2.0. On Thu, Apr 16, 2015 at 02:19:37PM -0700, Ben Pfaff wrote: When netdev_bsd_get_mtu() failed, it didn't report the error to the caller, so the caller couldn't work around not knowing the MTU. Found by LLVM scan-build. Reported-by: Kevin Lo ke...@freebsd.org Signed-off-by: Ben Pfaff b...@nicira.com --- lib/netdev-bsd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c index 541e5ec..cc01470 100644 --- a/lib/netdev-bsd.c +++ b/lib/netdev-bsd.c @@ -843,7 +843,7 @@ netdev_bsd_get_mtu(const struct netdev *netdev_, int *mtup) } ovs_mutex_unlock(netdev-mutex); -return 0; +return error; } static int -- 2.1.3 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH] netdev-bsd: Fix use of uninitialized data in netdev_bsd_rxq_recv().
Subject should be corrected, otherwise: Acked-by: Jarno Rajahalme jrajaha...@nicira.com On Apr 16, 2015, at 2:19 PM, Ben Pfaff b...@nicira.com wrote: When netdev_bsd_get_mtu() failed, it didn't report the error to the caller, so the caller couldn't work around not knowing the MTU. Found by LLVM scan-build. Reported-by: Kevin Lo ke...@freebsd.org Signed-off-by: Ben Pfaff b...@nicira.com --- lib/netdev-bsd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c index 541e5ec..cc01470 100644 --- a/lib/netdev-bsd.c +++ b/lib/netdev-bsd.c @@ -843,7 +843,7 @@ netdev_bsd_get_mtu(const struct netdev *netdev_, int *mtup) } ovs_mutex_unlock(netdev-mutex); -return 0; +return error; } static int -- 2.1.3 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH] netdev-bsd: Fix use of uninitialized data in netdev_bsd_rxq_recv().
This one I should take care of it. :-) Acked-by: Kevin Lo ke...@freebsd.org On Thu, Apr 16, 2015 at 03:08:17PM -0700, Jarno Rajahalme wrote: Subject should be corrected, otherwise: Acked-by: Jarno Rajahalme jrajaha...@nicira.com On Apr 16, 2015, at 2:19 PM, Ben Pfaff b...@nicira.com wrote: When netdev_bsd_get_mtu() failed, it didn't report the error to the caller, so the caller couldn't work around not knowing the MTU. Found by LLVM scan-build. Reported-by: Kevin Lo ke...@freebsd.org Signed-off-by: Ben Pfaff b...@nicira.com --- lib/netdev-bsd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c index 541e5ec..cc01470 100644 --- a/lib/netdev-bsd.c +++ b/lib/netdev-bsd.c @@ -843,7 +843,7 @@ netdev_bsd_get_mtu(const struct netdev *netdev_, int *mtup) } ovs_mutex_unlock(netdev-mutex); -return 0; +return error; } static int -- 2.1.3 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH] netdev-bsd: Fix use of uninitialized data in netdev_bsd_rxq_recv().
Acked-by: YAMAMOTO Takashi yamam...@valinux.co.jp This one I should take care of it. :-) Acked-by: Kevin Lo ke...@freebsd.org On Thu, Apr 16, 2015 at 03:08:17PM -0700, Jarno Rajahalme wrote: Subject should be corrected, otherwise: Acked-by: Jarno Rajahalme jrajaha...@nicira.com On Apr 16, 2015, at 2:19 PM, Ben Pfaff b...@nicira.com wrote: When netdev_bsd_get_mtu() failed, it didn't report the error to the caller, so the caller couldn't work around not knowing the MTU. Found by LLVM scan-build. Reported-by: Kevin Lo ke...@freebsd.org Signed-off-by: Ben Pfaff b...@nicira.com --- lib/netdev-bsd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c index 541e5ec..cc01470 100644 --- a/lib/netdev-bsd.c +++ b/lib/netdev-bsd.c @@ -843,7 +843,7 @@ netdev_bsd_get_mtu(const struct netdev *netdev_, int *mtup) } ovs_mutex_unlock(netdev-mutex); -return 0; +return error; } static int -- 2.1.3 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
