Re: [ovs-dev] [PATCH] perf-counter: Remove unused vlog module.
Do you want to remove the #include openvswitch/vlog.h line since there are no users now? Regardless: Acked-by: Justin Pettit jpet...@nicira.com --Justin On Apr 17, 2015, at 9:30 AM, Ben Pfaff b...@nicira.com wrote: Otherwise Clang warns about an unused variable. Signed-off-by: Ben Pfaff b...@nicira.com --- lib/perf-counter.c |2 -- 1 file changed, 2 deletions(-) diff --git a/lib/perf-counter.c b/lib/perf-counter.c index 0e8..a1162ae 100644 --- a/lib/perf-counter.c +++ b/lib/perf-counter.c @@ -32,8 +32,6 @@ #include shash.h #include util.h -VLOG_DEFINE_THIS_MODULE(perf_counter); - static struct shash perf_counters; static int fd__ = 0; -- 1.7.10.4 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH] perf-counter: Remove unused vlog module.
Good point, done, thanks. I'll apply this in a minute. On Fri, Apr 17, 2015 at 10:03:07AM -0700, Justin Pettit wrote: Do you want to remove the #include openvswitch/vlog.h line since there are no users now? Regardless: Acked-by: Justin Pettit jpet...@nicira.com --Justin On Apr 17, 2015, at 9:30 AM, Ben Pfaff b...@nicira.com wrote: Otherwise Clang warns about an unused variable. Signed-off-by: Ben Pfaff b...@nicira.com --- lib/perf-counter.c |2 -- 1 file changed, 2 deletions(-) diff --git a/lib/perf-counter.c b/lib/perf-counter.c index 0e8..a1162ae 100644 --- a/lib/perf-counter.c +++ b/lib/perf-counter.c @@ -32,8 +32,6 @@ #include shash.h #include util.h -VLOG_DEFINE_THIS_MODULE(perf_counter); - static struct shash perf_counters; static int fd__ = 0; -- 1.7.10.4 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
