Re: [ovs-dev] [PATCH v1] Python-IDL: getattr after mutate fix

[Russell Bryant]

On Wed, Oct 12, 2016 at 5:36 PM, Amitabha Biswas  wrote:

> This commit returns the updated column value when getattr is done
> after a mutate operation is performed (but before the commit).
>
> Signed-off-by: Amitabha Biswas 
>
> Reported-by: Richard Theis 
>
> Reported-at: http://openvswitch.org/pipermail/dev/2016-September/
> 080120.html
>
> Fixes: a59912a0ee8e ("python: Add support for partial map and set
> updates")
>

Thanks!  I applied this to master and branch-2.6.

-- 
Russell Bryant
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v1] Python-IDL: getattr after mutate fix

[Amitabha Biswas]

Thanks! I reposted the patch with the update to the commit message.

Amitabha

> On Oct 12, 2016, at 1:16 PM, Russell Bryant  wrote:
> 
> 
> 
> On Wed, Oct 12, 2016 at 10:32 AM, Amitabha Biswas  > wrote:
> This commit returns the updated column value when getattr is done
> after a mutate operation is performed (but before the commit). It
> addresses the bug reported in
> http://openvswitch.org/pipermail/dev/2016-September/080120.html 
> 
> 
> You can also record this with a "Reported-at" header:
> 
> Reported-at: http://openvswitch.org/pipermail/dev/2016-September/080120.html 
> 
> 
> It would also be good to record the related commit that this fixes.
> 
> Fixes: a59912a0ee8e ("python: Add support for partial map and partial set 
> updates")
> 
> Signed-off-by: Amitabha Biswas  >
> 
> Your Signed-off-by doesn't match the commit author (your gmail address).  Can 
> you re-submit with the two matching?
>  
> Reported-by: Richard Theis >
> 
> Other than the Signed-off-by issue, I think this is ready to apply.
> 
> Thanks!
> 
> -- 
> Russell Bryant 

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v1] Python-IDL: getattr after mutate fix

[Russell Bryant]

On Wed, Oct 12, 2016 at 10:32 AM, Amitabha Biswas 
wrote:

> This commit returns the updated column value when getattr is done
> after a mutate operation is performed (but before the commit). It
> addresses the bug reported in
> http://openvswitch.org/pipermail/dev/2016-September/080120.html


You can also record this with a "Reported-at" header:

Reported-at: http://openvswitch.org/pipermail/dev/2016-September/080120.html

It would also be good to record the related commit that this fixes.

Fixes: a59912a0ee8e ("python: Add support for partial map and partial set
updates")

Signed-off-by: Amitabha Biswas 
>

Your Signed-off-by doesn't match the commit author (your gmail address).
Can you re-submit with the two matching?


> Reported-by: Richard Theis 


Other than the Signed-off-by issue, I think this is ready to apply.

Thanks!

-- 
Russell Bryant
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev