[jira] [Updated] (OWB-935) wrong result of javax.enterprise.inject.Instance in combination with alternatives
[
https://issues.apache.org/jira/browse/OWB-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Struberg updated OWB-935:
--
Fix Version/s: 1.6.3
wrong result of javax.enterprise.inject.Instance in combination with
alternatives
-
Key: OWB-935
URL: https://issues.apache.org/jira/browse/OWB-935
Project: OpenWebBeans
Issue Type: Bug
Components: Injection and Lookup
Affects Versions: 1.2.2
Reporter: Gerhard Petracek
Assignee: Mark Struberg
Fix For: 1.6.3
Attachments: OWB-935.zip
if the result of InjectionResolver#findByAlternatives is 1 (for
InstanceImpl#iterator) and there is one alternative-bean in the result, beans
without alternative implementations aren't part of the result, because
alternativeSet only contains alternative beans - see:
{code}
if (containsAlternative)
{
return alternativeSet;
}
return enableSet;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[VOTE] Release OpenWebBeans-1.6.2
Hi!
I'd like to call a VOTE for a maintenance release of Apache OpenWebBeans-1.6.2.
We fixed 2 bugs which are needed by TomEE-7.x
Here is the staging repo:
https://repository.apache.org/content/repositories/orgapacheopenwebbeans-1015/
And here is the source release:
https://repository.apache.org/content/repositories/orgapacheopenwebbeans-1015/org/apache/openwebbeans/openwebbeans/1.6.2/openwebbeans-1.6.2-source-release.zip
[+1] let's ship it
[+0] meh don't care
[-1] nope, because ${reason}
The VOTE is open for 72h.
txs and LieGrue,
strub
[jira] [Reopened] (OWB-705) Tomcat 7 module uses old OWBInjector API
[ https://issues.apache.org/jira/browse/OWB-705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg reopened OWB-705: --- Assignee: Romain Manni-Bucau looks like this didn't get applied yet. Please check usages of OWBInjector. Tomcat 7 module uses old OWBInjector API Key: OWB-705 URL: https://issues.apache.org/jira/browse/OWB-705 Project: OpenWebBeans Issue Type: Bug Affects Versions: 1.1.5 Reporter: Romain Manni-Bucau Assignee: Romain Manni-Bucau Fix For: 1.6.3 Attachments: OWB-t7.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OWB-706) Interceptor bindings on methods that come from an interface with a generic type may not work
[
https://issues.apache.org/jira/browse/OWB-706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Struberg closed OWB-706.
-
Interceptor bindings on methods that come from an interface with a generic
type may not work
Key: OWB-706
URL: https://issues.apache.org/jira/browse/OWB-706
Project: OpenWebBeans
Issue Type: Bug
Components: Interceptor and Decorators
Affects Versions: 1.1.5
Reporter: Joe Bergmark
Assignee: Joe Bergmark
Priority: Minor
Fix For: 1.2.0
If you apply an interceptor binding to a method that implements an interface
that has a generic type, the interceptor might not be executed.
I'll write some unit tests, but I think the scenario is something like the
following:
public interface FooT{
public void doSomethingT
}
public class Bar implements FooString{
@MyInterceptorBinding
public void doSomethingString
}
When a contextual reference of Bar is cast to Foo, or even to FooString,
calls to doSomething are no longer intercepted.
What seems to be happening is that due to type erasure, Bar really has to
implement FooObject, so the JDK adds a bridge method doSomething(Object) to
Bar that under the covers just calls doSomething(String). The handler
doesn't recognize that doSomething(Object) will call doSomething(String) and
therefore doesn't run the interceptor.
While the problem is complex, I believe the solution is pretty easy (at least
for the Javassist case). We can just add a check for bridge methods to the
new MethodFilter (probably rename it to something less specific than
FinalizeMethodFilter) so that doSomethign(String) will get called on the
proxy and we will properly run the interceptor then rather than passing the
call to doSomething(Object) down to the proxied instance.
This problem goes back to version 1.0, and its a very edge case, so I don't
think it has to go into 1.1.6.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OWB-706) Interceptor bindings on methods that come from an interface with a generic type may not work
[
https://issues.apache.org/jira/browse/OWB-706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Struberg updated OWB-706:
--
Fix Version/s: 1.2.0
Interceptor bindings on methods that come from an interface with a generic
type may not work
Key: OWB-706
URL: https://issues.apache.org/jira/browse/OWB-706
Project: OpenWebBeans
Issue Type: Bug
Components: Interceptor and Decorators
Affects Versions: 1.1.5
Reporter: Joe Bergmark
Assignee: Joe Bergmark
Priority: Minor
Fix For: 1.2.0
If you apply an interceptor binding to a method that implements an interface
that has a generic type, the interceptor might not be executed.
I'll write some unit tests, but I think the scenario is something like the
following:
public interface FooT{
public void doSomethingT
}
public class Bar implements FooString{
@MyInterceptorBinding
public void doSomethingString
}
When a contextual reference of Bar is cast to Foo, or even to FooString,
calls to doSomething are no longer intercepted.
What seems to be happening is that due to type erasure, Bar really has to
implement FooObject, so the JDK adds a bridge method doSomething(Object) to
Bar that under the covers just calls doSomething(String). The handler
doesn't recognize that doSomething(Object) will call doSomething(String) and
therefore doesn't run the interceptor.
While the problem is complex, I believe the solution is pretty easy (at least
for the Javassist case). We can just add a check for bridge methods to the
new MethodFilter (probably rename it to something less specific than
FinalizeMethodFilter) so that doSomethign(String) will get called on the
proxy and we will properly run the interceptor then rather than passing the
call to doSomething(Object) down to the proxied instance.
This problem goes back to version 1.0, and its a very edge case, so I don't
think it has to go into 1.1.6.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OWB-1017) Adding an annotated type as interceptor binding does not take the annotated type metadata into account
[
https://issues.apache.org/jira/browse/OWB-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Struberg updated OWB-1017:
---
Fix Version/s: 1.5.0
Adding an annotated type as interceptor binding does not take the annotated
type metadata into account
--
Key: OWB-1017
URL: https://issues.apache.org/jira/browse/OWB-1017
Project: OpenWebBeans
Issue Type: Bug
Components: Lifecycle
Reporter: Antonin Stefanutti
Assignee: Romain Manni-Bucau
Fix For: 1.5.0
Attachments: OwbBean.java, OwbClassBinding.java, OwbExtension.java,
OwbMethodBinding.java, OwbMethodInterceptor.java, OwbTest.java
When calling the {{BeforeBeanDiscovery.addInterceptorBinding(AnnotatedType?
extends Annotation)}} method, the metadata of the provided {{AnnotatedType}}
argument are not taken into account. A typical use case is when some of the
members of the provided annotated type have been decorated with the
{{@NonBinding}} annotation.
Indeed, the implementation in the
{{org.apache.webbeans.portable.events.discovery.BeforeBeanDiscoveryImpl}}
class delegate to the class-based version of the
{{BeforeBeanDiscovery.addInterceptorBinding}} method by losing all the
metadata information in the process.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OWB-1017) Adding an annotated type as interceptor binding does not take the annotated type metadata into account
[
https://issues.apache.org/jira/browse/OWB-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Struberg closed OWB-1017.
--
Assignee: Mark Struberg (was: Romain Manni-Bucau)
setting the fix-version back to 1.5.0 as this was the version we shipped the
changes with. Txs again for the report, Antonin!
Adding an annotated type as interceptor binding does not take the annotated
type metadata into account
--
Key: OWB-1017
URL: https://issues.apache.org/jira/browse/OWB-1017
Project: OpenWebBeans
Issue Type: Bug
Components: Lifecycle
Reporter: Antonin Stefanutti
Assignee: Mark Struberg
Fix For: 1.5.0
Attachments: OwbBean.java, OwbClassBinding.java, OwbExtension.java,
OwbMethodBinding.java, OwbMethodInterceptor.java, OwbTest.java
When calling the {{BeforeBeanDiscovery.addInterceptorBinding(AnnotatedType?
extends Annotation)}} method, the metadata of the provided {{AnnotatedType}}
argument are not taken into account. A typical use case is when some of the
members of the provided annotated type have been decorated with the
{{@NonBinding}} annotation.
Indeed, the implementation in the
{{org.apache.webbeans.portable.events.discovery.BeforeBeanDiscoveryImpl}}
class delegate to the class-based version of the
{{BeforeBeanDiscovery.addInterceptorBinding}} method by losing all the
metadata information in the process.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OWB-949) Implement @TransientReference
[ https://issues.apache.org/jira/browse/OWB-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662285#comment-14662285 ] Arne Limburg commented on OWB-949: -- Sehr geehrte Damen und Herren, in der Zeit vom 30.07.2015 - 14.08.2015 bin ich nicht im Büro zu erreichen. In dringenden Fällen wenden Sie sich bitte an unser Office Management (office.managem...@openknowledge.de) unter der Nummer +49 441 4082 0. Mit freundlichen Grüßen Arne Limburg - Dear Sir or Madam, I'm out of office from 07/30/2015 to 08/15/2015. For anything urgent please contact our office management (office.managem...@openknowledge.de) on +49 441 4082 0. Sincerely, Arne Limburg -- Arne Limburg – Enterprise Architekt open knowledge GmbH Poststraße 1, 26122 Oldenburg Mobil: +49 (0) 151 108 22 942 Tel: +49 441 - 4082-0 Fax: +49 441 - 4082-111 arne.limb...@openknowledge.de http://www.openknowledge.de Registergericht: Amtsgericht Oldenburg, HRB 4670 Geschäftsführer: Lars Röwekamp, Jens Schumann Nächste Konferenz(en): MobileTech Conference 2015 | Berlin | 31. Aug. bis 3. Sept. 2015 http://www.openknowledge.de/ok/mtc_2015_berlin Herbstcampus 2015 | Nürnberg | 31. Aug. bis 3. Sept. 2015 http://www.openknowledge.de/ok/herbstcampus_nuernberg_2015 Implement @TransientReference - Key: OWB-949 URL: https://issues.apache.org/jira/browse/OWB-949 Project: OpenWebBeans Issue Type: Task Reporter: Arne Limburg Fix For: 1.2.0 @TransientReference is a new feature of CDI 1.1 and needs to be implemented in OWB -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OWB-981) Validation of InjectionPoints
[ https://issues.apache.org/jira/browse/OWB-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg closed OWB-981. - Validation of InjectionPoints - Key: OWB-981 URL: https://issues.apache.org/jira/browse/OWB-981 Project: OpenWebBeans Issue Type: Bug Reporter: Arne Limburg Assignee: Arne Limburg Fix For: 1.5.0 The injection points of observer methods are currently not validated and in general the validation of injection points misses validation for duplicate @Delegate injection points -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OWB-949) Implement @TransientReference
[ https://issues.apache.org/jira/browse/OWB-949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg updated OWB-949: -- Fix Version/s: 1.2.0 Implement @TransientReference - Key: OWB-949 URL: https://issues.apache.org/jira/browse/OWB-949 Project: OpenWebBeans Issue Type: Task Reporter: Arne Limburg Fix For: 1.2.0 @TransientReference is a new feature of CDI 1.1 and needs to be implemented in OWB -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OWB-981) Validation of InjectionPoints
[ https://issues.apache.org/jira/browse/OWB-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg updated OWB-981: -- Fix Version/s: 1.5.0 Validation of InjectionPoints - Key: OWB-981 URL: https://issues.apache.org/jira/browse/OWB-981 Project: OpenWebBeans Issue Type: Bug Reporter: Arne Limburg Assignee: Arne Limburg Fix For: 1.5.0 The injection points of observer methods are currently not validated and in general the validation of injection points misses validation for duplicate @Delegate injection points -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OWB-949) Implement @TransientReference
[ https://issues.apache.org/jira/browse/OWB-949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg closed OWB-949. - Implement @TransientReference - Key: OWB-949 URL: https://issues.apache.org/jira/browse/OWB-949 Project: OpenWebBeans Issue Type: Task Reporter: Arne Limburg Fix For: 1.2.0 @TransientReference is a new feature of CDI 1.1 and needs to be implemented in OWB -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [VOTE] Release OpenWebBeans-1.6.2
+1
On Fri, Aug 7, 2015 at 5:03 PM, Mark Struberg strub...@yahoo.de wrote:
Hi!
I'd like to call a VOTE for a maintenance release of Apache
OpenWebBeans-1.6.2.
We fixed 2 bugs which are needed by TomEE-7.x
Here is the staging repo:
https://repository.apache.org/content/repositories/orgapacheopenwebbeans-1015/
And here is the source release:
https://repository.apache.org/content/repositories/orgapacheopenwebbeans-1015/org/apache/openwebbeans/openwebbeans/1.6.2/openwebbeans-1.6.2-source-release.zip
[+1] let's ship it
[+0] meh don't care
[-1] nope, because ${reason}
The VOTE is open for 72h.
txs and LieGrue,
strub
--
Best regard,
Daniel Cunha (soro)
