[GitHub] [openwebbeans] rmannibucau commented on pull request #53: Remove non-determinism in BeanCacheKey.java to fix flaky test BeanCacheKeyUnitTest.testEquals2Annotations
rmannibucau commented on PR #53: URL: https://github.com/apache/openwebbeans/pull/53#issuecomment-1611029535 this is the standard JVM behavior, `Class` cached the loaded bytecode which has no deterministic order but once loaded it is sorted. Not sure it is well documented but all JVM behave like that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openwebbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [openwebbeans] rmannibucau commented on pull request #53: Remove non-determinism in BeanCacheKey.java to fix flaky test BeanCacheKeyUnitTest.testEquals2Annotations
rmannibucau commented on PR #53: URL: https://github.com/apache/openwebbeans/pull/53#issuecomment-1608949065 Ok, found the bug you speak about, it is in your code in https://github.com/TestingResearchIllinois/NonDex/blob/master/nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/ClassVisitorShufflingAdder.java#L39 so will close the PR since it does not fix any actual flakiness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openwebbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [openwebbeans] rmannibucau commented on pull request #53: Remove non-determinism in BeanCacheKey.java to fix flaky test BeanCacheKeyUnitTest.testEquals2Annotations
rmannibucau commented on PR #53: URL: https://github.com/apache/openwebbeans/pull/53#issuecomment-1608837296 Hi, AFAIK this is not needed nor flaky because it is stable per classloader so stable in the OWB context so it sounds faster to not sort+toString the methods rather than doing it to not gain any determinism. Didnt check the failure details but do you have them cause by jvm contract it shouldnt be possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openwebbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
