Re: ContainerPool buffering changes
Hi Tyson. I’ll have a look. -r > On Nov 12, 2019, at 2:00 PM, Tyson Norris wrote: > > Seeking someone to review this PR – I’ve been load testing it this week with > good success. > https://github.com/apache/openwhisk/pull/4593 > > We can discuss at the call tomorrow if nobody reviews it before then. > > Anyone? > Thanks > Tyson > > From: Tyson Norris > Date: Thursday, November 7, 2019 at 6:34 AM > To: "dev@openwhisk.apache.org" > Subject: ContainerPool buffering changes > > Hi – > I have a long outstanding PR to change buffer processing at ContainerPool > https://github.com/apache/openwhisk/pull/4593 > The background is that in cases where container scheduling fails, we should > not immediately retry scheduling, but rather wait for a resource-affecting > event to occur, and then retry. With the previous impl, we saw cases where > scheduling would get into a tight loop and crash the invoker. > > Please let me know if you have any concerns? > > Thanks > Tyson
Re: ContainerPool buffering changes
Seeking someone to review this PR – I’ve been load testing it this week with good success. https://github.com/apache/openwhisk/pull/4593 We can discuss at the call tomorrow if nobody reviews it before then. Anyone? Thanks Tyson From: Tyson Norris Date: Thursday, November 7, 2019 at 6:34 AM To: "dev@openwhisk.apache.org" Subject: ContainerPool buffering changes Hi – I have a long outstanding PR to change buffer processing at ContainerPool https://github.com/apache/openwhisk/pull/4593 The background is that in cases where container scheduling fails, we should not immediately retry scheduling, but rather wait for a resource-affecting event to occur, and then retry. With the previous impl, we saw cases where scheduling would get into a tight loop and crash the invoker. Please let me know if you have any concerns? Thanks Tyson
ContainerPool buffering changes
Hi – I have a long outstanding PR to change buffer processing at ContainerPool https://github.com/apache/openwhisk/pull/4593 The background is that in cases where container scheduling fails, we should not immediately retry scheduling, but rather wait for a resource-affecting event to occur, and then retry. With the previous impl, we saw cases where scheduling would get into a tight loop and crash the invoker. Please let me know if you have any concerns? Thanks Tyson
