[GitHub] orc pull request #157: ORC-223 FileDump utility should print user metadata
GitHub user ekoifman opened a pull request: https://github.com/apache/orc/pull/157 ORC-223 FileDump utility should print user metadata @sershe could you review please You can merge this pull request into a Git repository by running: $ git pull https://github.com/ekoifman/orc ORC-223 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/orc/pull/157.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #157 commit 4525fdf49eda4bc13d29f12adae546b8eef370c2 Author: Eugene Koifman Date: 2017-08-14T22:51:25Z ORC-223 FileDump utility should print user metadata --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] orc pull request #156: ORC-195 - FileFormatException should include file nam...
GitHub user ekoifman opened a pull request: https://github.com/apache/orc/pull/156 ORC-195 - FileFormatException should include file name in the message @omalley could you review please You can merge this pull request into a Git repository by running: $ git pull https://github.com/ekoifman/orc ORC-195 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/orc/pull/156.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #156 commit a04c78ddaf25935e362bd827c780af98b931696b Author: Eugene Koifman Date: 2017-08-14T19:49:37Z ORC-195 - FileFormatException should include file name in the message --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] orc issue #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS configura...
Github user ekoifman commented on the issue: https://github.com/apache/orc/pull/154 added validation, fixed comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] orc issue #134: Orc 17
Github user omalley commented on the issue: https://github.com/apache/orc/pull/134 Unfortunately, this doesn't build on MacOS. :( I'll take some time this week to figure out what needs to be fixed. I've gone ahead and rebased it to the current master and squashed the commits in https://github.com/omalley/orc/tree/pr/134 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] orc pull request #151: ORC-226 Support getWriterId in c++ reader interface
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/151#discussion_r133008869
--- Diff: c++/include/orc/Reader.hh ---
@@ -288,6 +288,17 @@ namespace orc {
virtual uint64_t getCompressionSize() const = 0;
/**
+ * Get ID of writer that generated the file.
+ * Current availiable Orc writers:
+ * 0 = ORC Java
+ * 1 = ORC C++
+ * 2 = Presto
+ * @param id out parameter for writer id
+ * @return true if writer id is availiable, false if otherwise
+ */
+virtual bool getWriterId(uint32_t & id) const = 0;
--- End diff --
Ok, I see. But I am still not sure about returning ORC_FUTURE. The caller
may want to obtain the exact writer ID for debugging purpose. It can choose to
ignore if it wants. We just give them one more option. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #155: ORC-227: Fix ExternalProject_Add
Github user asfgit closed the pull request at: https://github.com/apache/orc/pull/155 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] orc pull request #153: ORC-229. Add an UNSTABLE-PRE-2.0 file format version.
Github user asfgit closed the pull request at: https://github.com/apache/orc/pull/153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] orc pull request #155: ORC-227: Fix ExternalProject_Add
GitHub user majetideepak opened a pull request: https://github.com/apache/orc/pull/155 ORC-227: Fix ExternalProject_Add @omalley This commit got left out from the previous PR You can merge this pull request into a Git repository by running: $ git pull https://github.com/majetideepak/orc ORC-227 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/orc/pull/155.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #155 commit bceaecd8d0195e9ef27adbdf41515f1900730652 Author: Deepak Majeti Date: 2017-08-10T14:37:32Z Fix ExternalProject_Add --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
