[GitHub] orc pull request #151: ORC-226 Support getWriterId in c++ reader interface
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/151#discussion_r10343
--- Diff: c++/include/orc/Reader.hh ---
@@ -288,6 +288,17 @@ namespace orc {
virtual uint64_t getCompressionSize() const = 0;
/**
+ * Get ID of writer that generated the file.
+ * Current availiable Orc writers:
+ * 0 = ORC Java
+ * 1 = ORC C++
+ * 2 = Presto
+ * @param id out parameter for writer id
+ * @return true if writer id is availiable, false if otherwise
+ */
+virtual bool getWriterId(uint32_t & id) const = 0;
--- End diff --
Then we need a logger in Orc library which we don't have now. What's the
problem of returning actual value instead of ORC_FUTURE?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #151: ORC-226 Support getWriterId in c++ reader interface
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/151#discussion_r10120
--- Diff: c++/include/orc/Reader.hh ---
@@ -288,6 +288,17 @@ namespace orc {
virtual uint64_t getCompressionSize() const = 0;
/**
+ * Get ID of writer that generated the file.
+ * Current availiable Orc writers:
+ * 0 = ORC Java
+ * 1 = ORC C++
+ * 2 = Presto
+ * @param id out parameter for writer id
+ * @return true if writer id is availiable, false if otherwise
+ */
+virtual bool getWriterId(uint32_t & id) const = 0;
--- End diff --
Maybe we should print an error message with the actual id number if it
isn't recognized. That would let you debug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS co...
Github user asfgit closed the pull request at: https://github.com/apache/orc/pull/154 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] orc pull request #157: ORC-223 FileDump utility should print user metadata
Github user asfgit closed the pull request at: https://github.com/apache/orc/pull/157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] orc pull request #158: ORC-230: Add OSX os to travis testing
Github user asfgit closed the pull request at: https://github.com/apache/orc/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] orc issue #149: ORC-224: Implement column writers of primitive types
Github user wgtmac commented on the issue: https://github.com/apache/orc/pull/149 @majetideepak No worries. Thanks for looking into this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] orc issue #134: Orc 17
Github user majetideepak commented on the issue: https://github.com/apache/orc/pull/134 I am adding a Travis test for OSX os. It should ease catching OSX issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] orc issue #134: Orc 17
Github user jamesclampffer commented on the issue: https://github.com/apache/orc/pull/134 Those errors should go away after HDFS-10787 is finished (or applied to the PR temporarily) since it exposes an API to get at the configuration without using std::tr2::optional. We had to suppress a bunch of errors coming from optional when it was added to libhdfs++; eventually I'd like to get rid of the remaining uses of it in the implementation as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] orc issue #149: ORC-224: Implement column writers of primitive types
Github user majetideepak commented on the issue: https://github.com/apache/orc/pull/149 @wgtmac Sorry for taking longer. I will definitely try to complete this as soon as possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] orc issue #134: Orc 17
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/134
It looks like it is a "long" vs "long long" problem.
/Users/owen/work/code/orc/build/libhdfspp_ep-prefix/src/libhdfspp_ep/lib/common/configuration.cc:85:12:
error: no viable conversion from returned value of type 'optional' to
function return type 'optional'
return result;
^~
/Users/owen/work/code/orc/build/libhdfspp_ep-prefix/src/libhdfspp_ep/third_party/tr2/optional.hpp:427:13:
note: candidate constructor not viable: no known conversion from
'std::experimental::optional' to 'std::experimental::nullopt_t' for 1st
argument
constexpr optional(nullopt_t) noexcept : OptionalBase() {};
^
/Users/owen/work/code/orc/build/libhdfspp_ep-prefix/src/libhdfspp_ep/third_party/tr2/optional.hpp:429:3:
note: candidate constructor not viable: no known conversion from
'std::experimental::optional' to 'const std::experimental::optional &' for 1st argument
optional(const optional& rhs)
^
/Users/owen/work/code/orc/build/libhdfspp_ep-prefix/src/libhdfspp_ep/third_party/tr2/optional.hpp:438:3:
note: candidate constructor not viable: no known conversion from
'std::experimental::optional' to 'std::experimental::optional
&&' for 1st argument
optional(optional&& rhs) noexcept(is_nothrow_move_constructible::value)
^
/Users/owen/work/code/orc/build/libhdfspp_ep-prefix/src/libhdfspp_ep/third_party/tr2/optional.hpp:447:13:
note: candidate constructor not viable: no known conversion from
'std::experimental::optional' to 'const long long &' for 1st argument
constexpr optional(const T& v) : OptionalBase(v) {}
^
/Users/owen/work/code/orc/build/libhdfspp_ep-prefix/src/libhdfspp_ep/third_party/tr2/optional.hpp:449:13:
note: candidate constructor not viable: no known conversion from
'std::experimental::optional' to 'long long &&' for 1st argument
constexpr optional(T&& v) : OptionalBase(constexpr_move(v)) {}
^
1 error generated.
make[5]: *** [lib/common/CMakeFiles/common_obj.dir/configuration.cc.o]
Error 1
make[4]: *** [lib/common/CMakeFiles/common_obj.dir/all] Error 2
make[3]: *** [all] Error 2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc issue #134: Orc 17
Github user AnatoliShein commented on the issue: https://github.com/apache/orc/pull/134 Hi @omalley , What error messages do you get when trying to build on MacOS? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
