[GitHub] orc issue #186: ORC-187: BitFieldReader has an unnecessary loop

2017-11-06 Thread t3rmin4t0r 
Github user t3rmin4t0r commented on the issue:

https://github.com/apache/orc/pull/186
  
LGTM - +1


---

[GitHub] orc issue #170: ORC-207: [C++] Enable users the ability to provide their own...

2017-11-06 Thread majetideepak 
Github user majetideepak commented on the issue:

https://github.com/apache/orc/pull/170
  
@jcrist  Yes, this should be good to merge with rebasing. I will try to 
merge this in by today.


---

[GitHub] orc issue #149: ORC-224: Implement column writers of primitive types

2017-11-06 Thread majetideepak 
Github user majetideepak commented on the issue:

https://github.com/apache/orc/pull/149
  
@wgtmac Sorry for the delay. I was tied up last week. I will definitely 
work on this today/tomorrow.


---

[GitHub] orc issue #170: ORC-207: [C++] Enable users the ability to provide their own...

2017-11-06 Thread jcrist 
Github user jcrist commented on the issue:

https://github.com/apache/orc/pull/170
  
I find myself in need of this PR. Looks like this has a few merge 
conflicts, but other than that is this ready to merge?


---

[GitHub] orc issue #149: ORC-224: Implement column writers of primitive types

2017-11-06 Thread wgtmac 
Github user wgtmac commented on the issue:

https://github.com/apache/orc/pull/149
  
@majetideepak Just a reminder that this one needs your help. Thanks!


---