[GitHub] orc issue #225: ORC-313,ORC-317: Check types in footer

[stiga-huang]

Github user stiga-huang commented on the issue:

https://github.com/apache/orc/pull/225
  
@majetideepak To be clean, I open #231 for ORC-317. I'd like to close this 
PR. Thanks for your review!


---

[GitHub] orc pull request #231: ORC-317: [C++] check that indices in the protobuf typ...

[stiga-huang]

GitHub user stiga-huang opened a pull request:

https://github.com/apache/orc/pull/231

ORC-317: [C++] check that indices in the protobuf type tree are valid

A corrupt file may contain loops in the protobuf type tree. We should check 
this before invoking `convertType`. The file attached to the Jira can reproduce 
this bug. Tests are added for coverage. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stiga-huang/orc check-type-id

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/orc/pull/231.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #231


commit edece2ba16da09433fa7ca5f5cfeb966df09d58a
Author: stiga-huang 
Date:   2018-03-15T23:37:55Z

ORC-317: check that indices in the protobuf type tree are valid




---

[GitHub] orc issue #225: ORC-313,ORC-317: Check types in footer

[majetideepak]

Github user majetideepak commented on the issue:

https://github.com/apache/orc/pull/225
  
@stiga-huang  I will look into these this week. Can you fix the title of 
this PR? Thanks!


---

[GitHub] orc pull request #228: ORC-319: [C++] should not throw a pointer of exceptio...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/orc/pull/228


---