GitHub user majetideepak opened a pull request:

    https://github.com/apache/orc/pull/135

    Update and use CMake External Project to build compression libraries

    Including the whole source of external libraries adds bloat.
    It also is not useful if clients prefer to use their own third-party 
libraries.
    In this PR
    1) The libraries are updated to the most recent ones.
    2) CMake `ExternalProject_Add`  is used to build the libraries
    
    Files to review
    ```
    cmake_modules/ThirdpartyToolchain.cmake
    c++/libs/CMakeLists.txt
    CMakeLists.txt
    ```
    Rest of the changes are just deletes of the libraries
    I will file a JIRA to enable users the ability to provide their own 
libraries.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/majetideepak/orc ORC-204

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #135
    
----
commit 0bc85be0a7ba60dc53ab402a5a278503cf98f97d
Author: Deepak Majeti <deepak.maj...@hpe.com>
Date:   2017-07-10T16:43:47Z

    Update and use CMake External Project to build compression libraries

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to