[GitHub] orc pull request #191: ORC-265: [C++] Add documentation for C++ build suppor...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/orc/pull/191


---

[GitHub] orc pull request #191: ORC-265: [C++] Add documentation for C++ build suppor...

[majetideepak]

Github user majetideepak commented on a diff in the pull request:

https://github.com/apache/orc/pull/191#discussion_r153647593
  
--- Diff: site/_docs/building.md ---
@@ -70,3 +70,25 @@ To build:
 % mvn package
 ~~~
 
+## Building just C++
+
+~~~ shell
+% mkdir build
+% cd build
+% cmake .. -DBUILD_JAVA=OFF
+% make package test-out
+~~~
+
+## Specify third-party libraries for C++ build
+
+~~~ shell
+% mkdir build
+% cd build
+% GTEST_HOME= \
+  SNAPPY_HOME= \
+  ZLIB_HOME= \
+  LZ4_HOME= \
+  PROTOBUF_HOME= \
+  cmake  .. -DBUILD_JAVA=OFF
+% make package test-out
--- End diff --

That is correct. The recent changes made did put the dependency on CMake 
variables. Fixed the comments.


---

[GitHub] orc pull request #191: ORC-265: [C++] Add documentation for C++ build suppor...

[owen-hortonworks]

Github user owen-hortonworks commented on a diff in the pull request:

https://github.com/apache/orc/pull/191#discussion_r153621386
  
--- Diff: site/_docs/building.md ---
@@ -70,3 +70,25 @@ To build:
 % mvn package
 ~~~
 
+## Building just C++
+
+~~~ shell
+% mkdir build
+% cd build
+% cmake .. -DBUILD_JAVA=OFF
+% make package test-out
+~~~
+
+## Specify third-party libraries for C++ build
+
+~~~ shell
+% mkdir build
+% cd build
+% GTEST_HOME= \
+  SNAPPY_HOME= \
+  ZLIB_HOME= \
+  LZ4_HOME= \
+  PROTOBUF_HOME= \
+  cmake  .. -DBUILD_JAVA=OFF
+% make package test-out
--- End diff --

Actually, looking at the ThirdpartyToolchain.cmake, it goes the other way. 
It is looking at the environment variable and setting the cmake variable. 
Setting the cmake variable directly works fine. 


---

[GitHub] orc pull request #191: ORC-265: [C++] Add documentation for C++ build suppor...

[majetideepak]

Github user majetideepak commented on a diff in the pull request:

https://github.com/apache/orc/pull/191#discussion_r153607648
  
--- Diff: site/_docs/building.md ---
@@ -70,3 +70,25 @@ To build:
 % mvn package
 ~~~
 
+## Building just C++
+
+~~~ shell
+% mkdir build
+% cd build
+% cmake .. -DBUILD_JAVA=OFF
+% make package test-out
+~~~
+
+## Specify third-party libraries for C++ build
+
+~~~ shell
+% mkdir build
+% cd build
+% GTEST_HOME= \
+  SNAPPY_HOME= \
+  ZLIB_HOME= \
+  LZ4_HOME= \
+  PROTOBUF_HOME= \
+  cmake  .. -DBUILD_JAVA=OFF
+% make package test-out
--- End diff --

@wgtmac  That is correct. We manually set it in travis-ci testing as well.
 ``cmake -DOPENSSL_ROOT_DIR=`brew --prefix openssl` ..``
I will check with Anatoli Shein if we can fix this / or add documentation 
here. Thanks!


---

[GitHub] orc pull request #191: ORC-265: [C++] Add documentation for C++ build suppor...

[majetideepak]

GitHub user majetideepak opened a pull request:

https://github.com/apache/orc/pull/191

ORC-265: [C++] Add documentation for C++ build support



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/majetideepak/orc ORC-265

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/orc/pull/191.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #191


commit f13da19acdbf27a9310578b97ec133d11f0acc28
Author: Deepak Majeti 
Date:   2017-11-15T22:56:56Z

ORC-265: [C++] Add documentation for C++ build support




---