[GitHub] [incubator-pagespeed-ngx] JialuZhang commented on issue #1679: pagespeed with load balancer (nginx) and front-end (apache)
JialuZhang commented on issue #1679:
URL:
https://github.com/apache/incubator-pagespeed-ngx/issues/1679#issuecomment-785382925
@salvoaranzulla
In your posted configuration,
```
RewriteEngine Off
SetHandler pagespeed_global_admin
AuthType Basic
AuthName "Restricted Area"
AuthUserFile "path/auth/.digest_pw"
Require valid-user
```
the line "RewriteEngine Off“ is a silent misconfiguration. This means
adding it to your system will not change any system behavior.
"RewriteEngine Off" is introduced by Apache to explicitly disable all
"RewriteRule" and "RewriteCond".
That is to say, if you include multiple "RewriteRule" and "RewriteCond"
parameters in your configuration, then instead of commenting them all, you can
explicitly set “RewriteEngine Off” to disable all "RewriteRule".
More importantly, the default value of “RewriteEngine" is already an "off",
so adding “RewriteEngine off" is quite unnecessary and it may cause confusion
to users.
Since herein there is no "RewriteRule", deleting “RewriteEngine Off” would
be ideal.
Related Apache source code snippet:
```
run_rewritemap_programs(server_rec *s , apr_pool_t *p){
if (conf->state == ENGINE_DISABLED) { // usage of "RewriteEngine"
return APR_SUCCESS; // early return
rewritemap_program(...); // usage of "RewriteRule"
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-pagespeed-mod] JialuZhang commented on issue #676: Summary of mod_rewrite and mod_pagespeed interactions
JialuZhang commented on issue #676:
URL:
https://github.com/apache/incubator-pagespeed-mod/issues/676#issuecomment-785271610
@GoogleCodeExporter
Thanks for the work around. However, in your posted configuration, the line:
"RewriteEngine Off" is a misconfiguration, and adding it to your system will
not change any system behavior.
Why "RewriteEngine Off" is allowed by Apache is that, if you include
multiple "RewriteRule" parameters in your configuration, then instead of
commenting them all, you can explicitly using “RewriteEngine Off” to disable
all "RewriteRule".
More importantly, the default value of “RewriteEngine" is already an "off",
so adding “RewriteEngine Off" is quite unnecessary and it may cause confusion
to users.
Since herein there is no "RewriteRule", deleting “RewriteEngine Off” would
be ideal.
Related Apache source code snippet:
```
run_rewritemap_programs(server_rec *s , apr_pool_t *p){
if (conf->state == ENGINE_DISABLED) { // usage of "RewriteEngine"
return APR_SUCCESS; // early return
rewritemap_program(...); // usage of "RewriteRule"
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-pagespeed-mod] JialuZhang commented on issue #1981: Images Not Showed
JialuZhang commented on issue #1981:
URL:
https://github.com/apache/incubator-pagespeed-mod/issues/1981#issuecomment-785262821
@LuigiMdg
In your posted configuration, the line: "RewriteEngine Off" is a
misconfiguration, and adding it to your system will not change any system
behavior.
Why "RewriteEngine Off" is allowed by Apache is that, if you include
multiple "RewriteRule" parameters in your configuration, then instead of
commenting them all, you can explicitly using “RewriteEngine Off” to disable
all "RewriteRule".
More importantly, the default value of “RewriteEngine" is already an "off",
so adding “RewriteEngine Off" is quite unnecessary and it may cause confusion
to users.
Since herein there is no "RewriteRule", deleting “RewriteEngine Off” would
be ideal.
Related Apache source code snippet:
```
run_rewritemap_programs(server_rec *s , apr_pool_t *p){
if (conf->state == ENGINE_DISABLED) { // usage of "RewriteEngine"
return APR_SUCCESS; // early return
rewritemap_program(...); // usage of "RewriteRule"
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-pagespeed-mod] JialuZhang edited a comment on issue #1745: How to access admin console?
JialuZhang edited a comment on issue #1745:
URL:
https://github.com/apache/incubator-pagespeed-mod/issues/1745#issuecomment-785259932
@timeassistant
In your posted configuration, the line: "RewriteEngine Off" is a
misconfiguration, and adding it to your system will not change any system
behavior.
Why "RewriteEngine Off" is allowed by Apache is that, if you include
multiple "RewriteRule" parameters in your configuration, then instead of
commenting them all, you can explicitly using “RewriteEngine Off” to disable
all "RewriteRule".
More importantly, the default value of “RewriteEngine" is already an "off",
so adding “RewriteEngine Off" is quite unnecessary and it may cause confusion
to users.
Since herein there is no "RewriteRule", deleting “RewriteEngine Off” would
be ideal.
Related Apache source code snippet:
```
run_rewritemap_programs(server_rec *s , apr_pool_t *p){
if (conf->state == ENGINE_DISABLED) { // usage of "RewriteEngine"
return APR_SUCCESS; // early return
rewritemap_program(...); // usage of "RewriteRule"
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-pagespeed-mod] JialuZhang commented on issue #1745: How to access admin console?
JialuZhang commented on issue #1745:
URL:
https://github.com/apache/incubator-pagespeed-mod/issues/1745#issuecomment-785259932
@timeassistant
In your posted configuration, the line: "RewriteEngine Off" is a
misconfiguration (all three of "RewriteEngine Off" are misconfiguration), and
adding it to your system will not change any system behavior.
Why "RewriteEngine Off" is allowed by Apache is that, if you include
multiple "RewriteRule" parameters in your configuration, then instead of
commenting them all, you can explicitly using “RewriteEngine Off” to disable
all "RewriteRule".
More importantly, the default value of “RewriteEngine" is already an "off",
so adding “RewriteEngine Off" is quite unnecessary and it may cause confusion
to users.
Since herein there is no "RewriteRule", deleting “RewriteEngine Off” would
be ideal.
Related Apache source code snippet:
```
run_rewritemap_programs(server_rec *s , apr_pool_t *p){
if (conf->state == ENGINE_DISABLED) { // usage of "RewriteEngine"
return APR_SUCCESS; // early return
rewritemap_program(...); // usage of "RewriteRule"
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-pagespeed-mod] JialuZhang commented on issue #1291: Apache2: /mod_pagespeed_beacon returns 404
JialuZhang commented on issue #1291:
URL:
https://github.com/apache/incubator-pagespeed-mod/issues/1291#issuecomment-785151687
@GuillaumeRossolini
In your posted configuration, the line: "RewriteEngine Off" is a
misconfiguration (all three of "RewriteEngine Off" are misconfiguration), and
adding it to your system will not change any system behavior.
Why "RewriteEngine Off" is allowed by Apache is that, if you include
multiple "RewriteRule" parameters in your configuration, then instead of
commenting them all, you can explicitly using “RewriteEngine Off” to disable
all "RewriteRule".
More importantly, the default value of “RewriteEngine" is already an "off",
so adding “RewriteEngine Off" is quite unnecessary and it may cause confusion
to users.
Since herein there is no "RewriteRule", deleting “RewriteEngine Off” would
be ideal.
Related Apache source code snippet:
```
run_rewritemap_programs(server_rec *s , apr_pool_t *p){
if (conf->state == ENGINE_DISABLED) { // usage of "RewriteEngine"
return APR_SUCCESS; // early return
rewritemap_program(...); // usage of "RewriteRule"
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-pagespeed-mod] jmarantz closed issue #2038: Safari 14 will support webp
jmarantz closed issue #2038: URL: https://github.com/apache/incubator-pagespeed-mod/issues/2038 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-pagespeed-mod] jmarantz commented on issue #2038: Safari 14 will support webp
jmarantz commented on issue #2038: URL: https://github.com/apache/incubator-pagespeed-mod/issues/2038#issuecomment-785067841 I'm trying to understand this thread. I think, as Lofessa said, that if Safari can read webp, and sends Accept:image/webp in its request header, then PageSpeed will send webp to Safari. No customization on the PageSpeed side need to be done. I did not understand @Poseidonas response "Safari cannot read webp", which contradicts the premise of this issue. But in any case I don't think there's any bug here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-pagespeed-mod] Lofesa commented on issue #2038: Safari 14 will support webp
Lofesa commented on issue #2038: URL: https://github.com/apache/incubator-pagespeed-mod/issues/2038#issuecomment-784993379 Well... you can configure pagespeed to serve webp to all clients or not. `pagespeed ServeRewrittenWebpUrlsToAnyAgent off;` that is the default. When this parameter is off, pagespeed only serve webp images to those browser that send a navigational header image/webp. If the browser don´t send ths header, no webp is served. I don´t know how Safari does this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-pagespeed-mod] Poseidonas commented on issue #2038: Safari 14 will support webp
Poseidonas commented on issue #2038: URL: https://github.com/apache/incubator-pagespeed-mod/issues/2038#issuecomment-784977780 > Hello, > > It seems like Safari 14 will support webp. > > The Safari 14 Beta release note : > > https://developer.apple.com/documentation/safari-release-notes/safari-14-beta-release-notes > > ``` > Media > New Features > Added WebP image support. > ``` > > Thanks, > > Eric Great news! @Lofesa The pagespeed can server webp to any client but the problem is that the Safari cannot read webp. In other words you have to enable the UserAgent Append to ensure that your users can see your webp content successfully --as jpeg ofc and NOT as webp. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
