[GitHub] [incubator-pagespeed-ngx] imartinez-tws edited a comment on issue #1714: IPRO PNG to webP lossy
imartinez-tws edited a comment on issue #1714: URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1714#issuecomment-705389356 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] imartinez-tws edited a comment on issue #1714: IPRO PNG to webP lossy
imartinez-tws edited a comment on issue #1714: URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1714#issuecomment-705551695 I have tried with this configuration ` # Pagespeed configuration pagespeed on; pagespeed EnableFilters convert_jpeg_to_webp; pagespeed EnableFilters convert_png_to_jpeg; pagespeed EnableFilters recompress_webp; pagespeed WebpRecompressionQuality 40; ` An this configuration ` # Pagespeed configuration pagespeed on; pagespeed EnableFilters convert_jpeg_to_webp; pagespeed EnableFilters convert_png_to_jpeg; pagespeed WebpRecompressionQuality 40; ` First request returns PNG with s-maxage=10 as expected, after some time, the content is still the PNG original image. As it is a direct request is/should be using IPRO. I have used this image as a test https://www.gstatic.com/webp/gallery3/1.png This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] imartinez-tws edited a comment on issue #1714: IPRO PNG to webP lossy
imartinez-tws edited a comment on issue #1714: URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1714#issuecomment-705506772 The links you are mentioning are not filters but options for filtering. The only filter that converts PNG to webP is this one https://www.modpagespeed.com/doc/reference-image-optimize#convert_to_webp_lossless And based on my tests, the options for webP quality only apply for this filter which clearly says the input is a webP image but not a PNG one: https://www.modpagespeed.com/doc/reference-image-optimize#recompress_webp I wonder if there is a way to have a filter (or combination of them) which takes the PNG with transparency and converts to webP based on WebpRecompressionQuality option, something like convert_to_webp_lossy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-pagespeed-ngx] imartinez-tws edited a comment on issue #1714: IPRO PNG to webP lossy
imartinez-tws edited a comment on issue #1714: URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1714#issuecomment-705389356 Thanks for the responses. Yes I am aware of how IPRO works based on the accept header, the content type and the vary header and I am quite happy with the default behaviour. According to documentation, convert_png_to_jpeg is only applicable "if they have no transparent pixels and if PageSpeed determines that they are not sensitive to compression noise". That drastically reduces the number of images that can be converted and AFAIK, it's possible to convert images with transparency to webP lossy. I wonder if there is a way to bypass this restriction and give control to the user about the quality adjustment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
