[jira] [Updated] (PARQUET-2254) Build a BloomFilter with a more precise size

2023-03-06 Thread Mars (Jira)


 [ 
https://issues.apache.org/jira/browse/PARQUET-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mars updated PARQUET-2254:
--
Description: 
Now the usage is to specify the size, and then build BloomFilter. In general 
scenarios, it is actually not sure how much the distinct value is. 
If BloomFilter can be automatically generated according to the data, the file 
size can be reduced and the reading efficiency can also be improved.

I have an idea that the user can specify a maximum BloomFilter filter size, 
then we build multiple BloomFilter at the same time, we can use the largest 
BloomFilter as a counting tool( If there is no hit when inserting a value, the 
counter will be +1, of course this may be imprecise but enough)
Then at the end of the write, choose a BloomFilter of a more appropriate size 
when the file is finally written.

I want to implement this feature and hope to get your opinions, thank you

  was:
Now the usage is to specify the size, and then build BloomFilter. In general 
scenarios, it is actually not sure how much the distinct value is. 
If BloomFilter can be automatically generated according to the data, the file 
size can be reduced and the reading efficiency can also be improved.

I have an idea that the user can specify a maximum BloomFilter filter size, 
then we build several BloomFilter at the same time, we can use the largest 
BloomFilter as a counting tool( If there is no hit when inserting a value, the 
counter will be +1, of course this may be imprecise but enough)
Then at the end of the write, choose a BloomFilter of a more appropriate size 
when the file is finally written.

I want to implement this feature and hope to get your opinions, thank you


> Build a BloomFilter with a more precise size
> 
>
> Key: PARQUET-2254
> URL: https://issues.apache.org/jira/browse/PARQUET-2254
> Project: Parquet
>  Issue Type: Improvement
>Reporter: Mars
>Priority: Major
>
> Now the usage is to specify the size, and then build BloomFilter. In general 
> scenarios, it is actually not sure how much the distinct value is. 
> If BloomFilter can be automatically generated according to the data, the file 
> size can be reduced and the reading efficiency can also be improved.
> I have an idea that the user can specify a maximum BloomFilter filter size, 
> then we build multiple BloomFilter at the same time, we can use the largest 
> BloomFilter as a counting tool( If there is no hit when inserting a value, 
> the counter will be +1, of course this may be imprecise but enough)
> Then at the end of the write, choose a BloomFilter of a more appropriate size 
> when the file is finally written.
> I want to implement this feature and hope to get your opinions, thank you



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (PARQUET-2237) Improve performance when filters in RowGroupFilter can match exactly

2023-03-06 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/PARQUET-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697256#comment-17697256
 ] 

ASF GitHub Bot commented on PARQUET-2237:
-

yabola commented on PR #1023:
URL: https://github.com/apache/parquet-mr/pull/1023#issuecomment-1457669848

   @wgtmac @gszadovszky 
   I have a proposal to  automatically build BloomFilter with a more precise 
size. I create a jira https://issues.apache.org/jira/browse/PARQUET-2254 and  I 
hope to get your opinions, thank you.
   
   > Now the usage is to specify the size, and then build BloomFilter. In 
general scenarios, it is actually not sure how much the distinct value is.
   If BloomFilter can be automatically generated according to the data, the 
file size can be reduced and the reading efficiency can also be improved.
   
   I have an idea that the user can specify a maximum BloomFilter filter size, 
then we build several BloomFilter at the same time, we can use the largest 
BloomFilter as a counting tool( If there is no hit when inserting a value, the 
counter will be +1, of course this may be imprecise but enough)
   Then at the end of the write, choose a BloomFilter of a more appropriate 
size when the file is finally written.
   
   I want to implement this feature and




> Improve performance when filters in RowGroupFilter can match exactly
> 
>
> Key: PARQUET-2237
> URL: https://issues.apache.org/jira/browse/PARQUET-2237
> Project: Parquet
>  Issue Type: Improvement
>Reporter: Mars
>Priority: Major
>
> If we can accurately judge by the minMax status, we don’t need to load the 
> dictionary from filesystem and compare one by one anymore.
> Similarly , Bloomfilter needs to load from filesystem, it may costs time and 
> memory. If we can exactly determine the existence/nonexistence of the value 
> from minMax or dictionary filters , then we can avoid using Bloomfilter to 
> Improve performance.
> For example,
>  # read data greater than {{x1}} in the block, if minMax in status is all 
> greater than {{{}x1{}}}, then we don't need to read dictionary and compare 
> one by one.
>  # If we already have page dictionaries and have compared one by one, we 
> don't need to read BloomFilter and compare.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [parquet-mr] yabola commented on pull request #1023: PARQUET-2237 Improve performance when filters in RowGroupFilter can match exactly

2023-03-06 Thread via GitHub


yabola commented on PR #1023:
URL: https://github.com/apache/parquet-mr/pull/1023#issuecomment-1457669848

   @wgtmac @gszadovszky 
   I have a proposal to  automatically build BloomFilter with a more precise 
size. I create a jira https://issues.apache.org/jira/browse/PARQUET-2254 and  I 
hope to get your opinions, thank you.
   
   > Now the usage is to specify the size, and then build BloomFilter. In 
general scenarios, it is actually not sure how much the distinct value is.
   If BloomFilter can be automatically generated according to the data, the 
file size can be reduced and the reading efficiency can also be improved.
   
   I have an idea that the user can specify a maximum BloomFilter filter size, 
then we build several BloomFilter at the same time, we can use the largest 
BloomFilter as a counting tool( If there is no hit when inserting a value, the 
counter will be +1, of course this may be imprecise but enough)
   Then at the end of the write, choose a BloomFilter of a more appropriate 
size when the file is finally written.
   
   I want to implement this feature and


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (PARQUET-2254) Build a BloomFilter with a more precise size

2023-03-06 Thread Mars (Jira)


 [ 
https://issues.apache.org/jira/browse/PARQUET-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mars updated PARQUET-2254:
--
Description: 
Now the usage is to specify the size, and then build BloomFilter. In general 
scenarios, it is actually not sure how much the distinct value is. 
If BloomFilter can be automatically generated according to the data, the file 
size can be reduced and the reading efficiency can also be improved.

I have an idea that the user can specify a maximum BloomFilter filter size, 
then we build several BloomFilter at the same time, we can use the largest 
BloomFilter as a counting tool( If there is no hit when inserting a value, the 
counter will be +1, of course this may be imprecise but enough)
Then at the end of the write, choose a BloomFilter of a more appropriate size 
when the file is finally written.

I want to implement this feature and hope to get your opinions, thank you

  was:
Now the usage is to specify the size, and then build BloomFilter. In general 
scenarios, it is actually not sure how much the distinct value is. 
If BloomFilter can be automatically generated according to the data, the file 
size can be reduced and the reading efficiency can also be improved.

I have an idea that the user can specify a maximum BloomFilter filter size, 
then we build several BloomFilter at the same time, we can use the largest 
BloomFilter as a counting tool( If there is no hit when inserting a value, the 
counter will be +1, of course this may be imprecise but enough)
Then at the end of the write, choose a BloomFilter of a more appropriate size 
when the file is finally written.


> Build a BloomFilter with a more precise size
> 
>
> Key: PARQUET-2254
> URL: https://issues.apache.org/jira/browse/PARQUET-2254
> Project: Parquet
>  Issue Type: Improvement
>Reporter: Mars
>Priority: Major
>
> Now the usage is to specify the size, and then build BloomFilter. In general 
> scenarios, it is actually not sure how much the distinct value is. 
> If BloomFilter can be automatically generated according to the data, the file 
> size can be reduced and the reading efficiency can also be improved.
> I have an idea that the user can specify a maximum BloomFilter filter size, 
> then we build several BloomFilter at the same time, we can use the largest 
> BloomFilter as a counting tool( If there is no hit when inserting a value, 
> the counter will be +1, of course this may be imprecise but enough)
> Then at the end of the write, choose a BloomFilter of a more appropriate size 
> when the file is finally written.
> I want to implement this feature and hope to get your opinions, thank you



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (PARQUET-2254) Build a BloomFilter with a more precise size

2023-03-06 Thread Mars (Jira)
Mars created PARQUET-2254:
-

 Summary: Build a BloomFilter with a more precise size
 Key: PARQUET-2254
 URL: https://issues.apache.org/jira/browse/PARQUET-2254
 Project: Parquet
  Issue Type: Improvement
Reporter: Mars


Now the usage is to specify the size, and then build BloomFilter. In general 
scenarios, it is actually not sure how much the distinct value is. 
If BloomFilter can be automatically generated according to the data, the file 
size can be reduced and the reading efficiency can also be improved.

I have an idea that the user can specify a maximum BloomFilter filter size, 
then we build several BloomFilter at the same time, we can use the largest 
BloomFilter as a counting tool( If there is no hit when inserting a value, the 
counter will be +1, of course this may be imprecise but enough)
Then at the end of the write, choose a BloomFilter of a more appropriate size 
when the file is finally written.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (PARQUET-2252) Make some methods public to allow external projects to implement page skipping

2023-03-06 Thread Yujiang Zhong (Jira)


 [ 
https://issues.apache.org/jira/browse/PARQUET-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yujiang Zhong resolved PARQUET-2252.

Resolution: Fixed

Resolved by https://github.com/apache/parquet-mr/pull/1038

> Make some methods public to allow external projects to implement page skipping
> --
>
> Key: PARQUET-2252
> URL: https://issues.apache.org/jira/browse/PARQUET-2252
> Project: Parquet
>  Issue Type: New Feature
>Reporter: Yujiang Zhong
>Assignee: Yujiang Zhong
>Priority: Major
>
> Iceberg hopes to implement the column index filter based on Iceberg's own 
> expressions, we would like to be able to use some of the methods in Parquet 
> repo, for example: methods in `RowRanges` and `IndexIterator`, however these 
> are currently not public. Currently we can only rely on reflection to use 
> them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (PARQUET-2252) Make some methods public to allow external projects to implement page skipping

2023-03-06 Thread Yujiang Zhong (Jira)


 [ 
https://issues.apache.org/jira/browse/PARQUET-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yujiang Zhong reassigned PARQUET-2252:
--

Assignee: Yujiang Zhong

> Make some methods public to allow external projects to implement page skipping
> --
>
> Key: PARQUET-2252
> URL: https://issues.apache.org/jira/browse/PARQUET-2252
> Project: Parquet
>  Issue Type: New Feature
>Reporter: Yujiang Zhong
>Assignee: Yujiang Zhong
>Priority: Major
>
> Iceberg hopes to implement the column index filter based on Iceberg's own 
> expressions, we would like to be able to use some of the methods in Parquet 
> repo, for example: methods in `RowRanges` and `IndexIterator`, however these 
> are currently not public. Currently we can only rely on reflection to use 
> them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (PARQUET-2252) Make some methods public to allow external projects to implement page skipping

2023-03-06 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/PARQUET-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697187#comment-17697187
 ] 

ASF GitHub Bot commented on PARQUET-2252:
-

rdblue commented on PR #1038:
URL: https://github.com/apache/parquet-mr/pull/1038#issuecomment-1457264814

   Thanks, @zhongyujiang!




> Make some methods public to allow external projects to implement page skipping
> --
>
> Key: PARQUET-2252
> URL: https://issues.apache.org/jira/browse/PARQUET-2252
> Project: Parquet
>  Issue Type: New Feature
>Reporter: Yujiang Zhong
>Priority: Major
>
> Iceberg hopes to implement the column index filter based on Iceberg's own 
> expressions, we would like to be able to use some of the methods in Parquet 
> repo, for example: methods in `RowRanges` and `IndexIterator`, however these 
> are currently not public. Currently we can only rely on reflection to use 
> them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (PARQUET-2252) Make some methods public to allow external projects to implement page skipping

2023-03-06 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/PARQUET-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697186#comment-17697186
 ] 

ASF GitHub Bot commented on PARQUET-2252:
-

rdblue merged PR #1038:
URL: https://github.com/apache/parquet-mr/pull/1038




> Make some methods public to allow external projects to implement page skipping
> --
>
> Key: PARQUET-2252
> URL: https://issues.apache.org/jira/browse/PARQUET-2252
> Project: Parquet
>  Issue Type: New Feature
>Reporter: Yujiang Zhong
>Priority: Major
>
> Iceberg hopes to implement the column index filter based on Iceberg's own 
> expressions, we would like to be able to use some of the methods in Parquet 
> repo, for example: methods in `RowRanges` and `IndexIterator`, however these 
> are currently not public. Currently we can only rely on reflection to use 
> them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [parquet-mr] rdblue commented on pull request #1038: PARQUET-2252: Make some methods public to allow external projects to …

2023-03-06 Thread via GitHub


rdblue commented on PR #1038:
URL: https://github.com/apache/parquet-mr/pull/1038#issuecomment-1457264814

   Thanks, @zhongyujiang!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [parquet-mr] rdblue merged pull request #1038: PARQUET-2252: Make some methods public to allow external projects to …

2023-03-06 Thread via GitHub


rdblue merged PR #1038:
URL: https://github.com/apache/parquet-mr/pull/1038


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org