[jira] [Commented] (PARQUET-2385) Don't initialize CodecFactory in ParquetWriter
[
https://issues.apache.org/jira/browse/PARQUET-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789508#comment-17789508
]
ASF GitHub Bot commented on PARQUET-2385:
-
amousavigourabi opened a new pull request, #1203:
URL: https://github.com/apache/parquet-mr/pull/1203
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
> Don't initialize CodecFactory in ParquetWriter
> --
>
> Key: PARQUET-2385
> URL: https://issues.apache.org/jira/browse/PARQUET-2385
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-mr
>Reporter: Atour Mousavi Gourabi
>Priority: Major
>
> In ParquetWriter we initialize a CodecFactory, instead we should allow users
> to set their own via the builder as to provide a little more flexibility
> (analogous to PARQUET-2282).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] PARQUET-2385: Allow user to specify CodecFactory for ParquetWriter [parquet-mr]
amousavigourabi opened a new pull request, #1203:
URL: https://github.com/apache/parquet-mr/pull/1203
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (PARQUET-2385) Don't initialize CodecFactory in ParquetWriter
Atour Mousavi Gourabi created PARQUET-2385: -- Summary: Don't initialize CodecFactory in ParquetWriter Key: PARQUET-2385 URL: https://issues.apache.org/jira/browse/PARQUET-2385 Project: Parquet Issue Type: Improvement Components: parquet-mr Reporter: Atour Mousavi Gourabi In ParquetWriter we initialize a CodecFactory, instead we should allow users to set their own via the builder as to provide a little more flexibility (analogous to PARQUET-2282). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PARQUET-2384) Mark toOriginalType as deprecated
[
https://issues.apache.org/jira/browse/PARQUET-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789369#comment-17789369
]
ASF GitHub Bot commented on PARQUET-2384:
-
Fokko opened a new pull request, #1202:
URL: https://github.com/apache/parquet-mr/pull/1202
The OriginalType itself has been marked as deprecated for a long time, would
be good to mark these as deprecated as well.
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
> Mark toOriginalType as deprecated
> -
>
> Key: PARQUET-2384
> URL: https://issues.apache.org/jira/browse/PARQUET-2384
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-mr
>Affects Versions: 1.13.1
>Reporter: Fokko Driesprong
>Assignee: Fokko Driesprong
>Priority: Major
> Fix For: 1.14.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] PARQUET-2384: Mark `toOriginalType` as deprecated [parquet-mr]
Fokko opened a new pull request, #1202:
URL: https://github.com/apache/parquet-mr/pull/1202
The OriginalType itself has been marked as deprecated for a long time, would
be good to mark these as deprecated as well.
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (PARQUET-2384) Mark toOriginalType as deprecated
Fokko Driesprong created PARQUET-2384: - Summary: Mark toOriginalType as deprecated Key: PARQUET-2384 URL: https://issues.apache.org/jira/browse/PARQUET-2384 Project: Parquet Issue Type: Improvement Components: parquet-mr Affects Versions: 1.13.1 Reporter: Fokko Driesprong Assignee: Fokko Driesprong Fix For: 1.14.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PARQUET-2382) Remove the deprecated OriginalType
[ https://issues.apache.org/jira/browse/PARQUET-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789365#comment-17789365 ] ASF GitHub Bot commented on PARQUET-2382: - Fokko commented on PR #1194: URL: https://github.com/apache/parquet-mr/pull/1194#issuecomment-1825293064 Makes sense. I think it would be good to remove `OriginalType` at some point. Let's target this PR for 2.0 and leave it for now. I'll create another PR to mark the `getOriginalType()` deprecated (this one was marked as private by Yetus before, but I think it would be best to mark them as deprecated for 1.14.0). > Remove the deprecated OriginalType > -- > > Key: PARQUET-2382 > URL: https://issues.apache.org/jira/browse/PARQUET-2382 > Project: Parquet > Issue Type: Improvement >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.14.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] PARQUET-2382: Remove the deprecated `OriginalType` [parquet-mr]
Fokko commented on PR #1194: URL: https://github.com/apache/parquet-mr/pull/1194#issuecomment-1825293064 Makes sense. I think it would be good to remove `OriginalType` at some point. Let's target this PR for 2.0 and leave it for now. I'll create another PR to mark the `getOriginalType()` deprecated (this one was marked as private by Yetus before, but I think it would be best to mark them as deprecated for 1.14.0). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
