[GitHub] [parquet-format] emkornfield commented on a diff in pull request #184: PARQUET-758: Add Float16/Half-float logical type

2022-12-07 Thread GitBox 


emkornfield commented on code in PR #184:
URL: https://github.com/apache/parquet-format/pull/184#discussion_r1042516177


##
src/main/thrift/parquet.thrift:
##
@@ -232,6 +232,7 @@ struct MapType {} // see LogicalTypes.md
 struct ListType {}// see LogicalTypes.md
 struct EnumType {}// allowed for BINARY, must be encoded with UTF-8
 struct DateType {}// allowed for INT32
+struct Float16Type {} // allowed for FIXED[2], must encoded raw FLOAT16 bytes

Review Comment:
   yes. BYTE_STREAM_SPLIT



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [parquet-format] emkornfield commented on a diff in pull request #184: PARQUET-758: Add Float16/Half-float logical type

2022-08-30 Thread GitBox 


emkornfield commented on code in PR #184:
URL: https://github.com/apache/parquet-format/pull/184#discussion_r958042831


##
src/main/thrift/parquet.thrift:
##
@@ -232,6 +232,7 @@ struct MapType {} // see LogicalTypes.md
 struct ListType {}// see LogicalTypes.md
 struct EnumType {}// allowed for BINARY, must be encoded with UTF-8
 struct DateType {}// allowed for INT32
+struct Float16Type {} // allowed for FIXED[2], must encoded raw FLOAT16 bytes

Review Comment:
   why not allow bit splitting?  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org