[GitHub] [parquet-mr] gszadovszky commented on pull request #925: PARQUET-2078: Failed to read parquet file after writing with the same …
gszadovszky commented on pull request #925: URL: https://github.com/apache/parquet-mr/pull/925#issuecomment-910067975 @shangxinli, @ggershinsky, please note that I'll be on vacation from today till the end of next week so won't have time for this PR. While this seems to be quite urgent so do not hesitate to push it in and initiate a release for 1.12.1. I think this fix would worth a separate release as quick as possible. Also, do not forget to approve the unit tests execution for every new commits since @loudongfeng is not a member (or whatever GitHub actions require to be executed automatically). -- Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #925: PARQUET-2078: Failed to read parquet file after writing with the same …
gszadovszky commented on pull request #925: URL: https://github.com/apache/parquet-mr/pull/925#issuecomment-910067975 @shangxinli, @ggershinsky, please note that I'll be on vacation from today till the end of next week so won't have time for this PR. While this seems to be quite urgent so do not hesitate to push it in and initiate a release for 1.12.1. I think this fix would worth a separate release as quick as possible. Also, do not forget to approve the unit tests execution for every new commits since @loudongfeng is not a member (or whatever GitHub actions require to be executed automatically). -- Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #925: PARQUET-2078: Failed to read parquet file after writing with the same …
gszadovszky commented on pull request #925: URL: https://github.com/apache/parquet-mr/pull/925#issuecomment-908452452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #925: PARQUET-2078: Failed to read parquet file after writing with the same …
gszadovszky commented on pull request #925: URL: https://github.com/apache/parquet-mr/pull/925#issuecomment-908986790 @ggershinsky, sorry, I've completely missed the fact that `RowGroup.file_offset` is introduced for the encryption feature and it actually required for it. Somehow we shall check if the `file_offset` points to the previous row group. At the worst case we shall check at least if the parquet file is written by 1.12.0. But in this case we only know that the `file_offset` might be wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #925: PARQUET-2078: Failed to read parquet file after writing with the same …
gszadovszky commented on pull request #925: URL: https://github.com/apache/parquet-mr/pull/925#issuecomment-908452452 @ggershinsky, even though this PR fixes the write path as well we have already released 1.12.0 so we have to prepare for the case of `RowGroup.file_offset` is incorrect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
