[GitHub] [parquet-mr] shangxinli commented on pull request #947: PARQUET-2121: Remove descriptions for the removed modules
shangxinli commented on pull request #947: URL: https://github.com/apache/parquet-mr/pull/947#issuecomment-1059353244 > Thank you for the elaboration, @shangxinli! Let me confirm, I think the parquet-cascading* and parquet-scrooge directories were removed on the master branch in #888. In addition, they had been renamed to "*-deprecated" before the removal, so the line in .gitignore in question has no effect. So I'm not sure what "the code is still there" you mentioned means... Is my understanding correct? Thanks @sekikn for checking! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #947: PARQUET-2121: Remove descriptions for the removed modules
shangxinli commented on pull request #947: URL: https://github.com/apache/parquet-mr/pull/947#issuecomment-1054543248 The only comment left is in the .gitignore file. Question is should we remove 'parquet-scrooge/.cache'? If the code for parquet-scrooge is still there, there may be needed to keep it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #947: PARQUET-2121: Remove descriptions for the removed modules
shangxinli commented on pull request #947: URL: https://github.com/apache/parquet-mr/pull/947#issuecomment-1050466476 Thanks for addressing the comments! There is one left over. After that, I think we can merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #947: PARQUET-2121: Remove descriptions for the removed modules
shangxinli commented on pull request #947: URL: https://github.com/apache/parquet-mr/pull/947#issuecomment-1039353753 @sekikn Thanks for working on it! Just leave some minor comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #947: PARQUET-2121: Remove descriptions for the removed modules
shangxinli commented on pull request #947: URL: https://github.com/apache/parquet-mr/pull/947#issuecomment-1039353753 @sekikn Thanks for working on it! Just leave some minor comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
