[jira] [Commented] (PARQUET-1470) Inputstream leakage in ParquetFileWriter.appendFile
[
https://issues.apache.org/jira/browse/PARQUET-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761589#comment-16761589
]
ASF GitHub Bot commented on PARQUET-1470:
-
gszadovszky commented on pull request #611: PARQUET-1470: Inputstream leakage
in ParquetFileWriter.appendFile
URL: https://github.com/apache/parquet-mr/pull/611
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inputstream leakage in ParquetFileWriter.appendFile
> ---
>
> Key: PARQUET-1470
> URL: https://issues.apache.org/jira/browse/PARQUET-1470
> Project: Parquet
> Issue Type: Bug
> Components: parquet-mr
>Affects Versions: 1.10.0
>Reporter: Arnaud Linz
>Assignee: Fokko Driesprong
>Priority: Major
> Labels: pull-request-available
>
> Current implementation of ParquetFileWriter.appendFile is:
>
> {{public void appendFile(InputFile file) throws IOException {}}
> {{ ParquetFileReader.open(file).appendTo(this);}}
> {{ }}}
> this method never closes the inputstream created when the file is opened in
> the ParquetFileReader constructor.
> This leads for instance to TooManyFilesOpened exceptions when large merge are
> made with the parquet tools.
> something like
> {{ try (ParquetFileReader reader = ParquetFileReader.open(file)) {}}
> {{ reader.appendTo(this);}}
> {{ }}}
> would be cleaner.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PARQUET-1470) Inputstream leakage in ParquetFileWriter.appendFile
[
https://issues.apache.org/jira/browse/PARQUET-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760198#comment-16760198
]
ASF GitHub Bot commented on PARQUET-1470:
-
Fokko commented on pull request #611: [PARQUET-1470] Inputstream leakage in
ParquetFileWriter.appendFile
URL: https://github.com/apache/parquet-mr/pull/611
Add a try-with-resource: https://jira.apache.org/jira/browse/PARQUET-1470
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inputstream leakage in ParquetFileWriter.appendFile
> ---
>
> Key: PARQUET-1470
> URL: https://issues.apache.org/jira/browse/PARQUET-1470
> Project: Parquet
> Issue Type: Bug
> Components: parquet-mr
>Affects Versions: 1.10.0
>Reporter: Arnaud Linz
>Assignee: Fokko Driesprong
>Priority: Major
> Labels: pull-request-available
>
> Current implementation of ParquetFileWriter.appendFile is:
>
> {{public void appendFile(InputFile file) throws IOException {}}
> {{ ParquetFileReader.open(file).appendTo(this);}}
> {{ }}}
> this method never closes the inputstream created when the file is opened in
> the ParquetFileReader constructor.
> This leads for instance to TooManyFilesOpened exceptions when large merge are
> made with the parquet tools.
> something like
> {{ try (ParquetFileReader reader = ParquetFileReader.open(file)) {}}
> {{ reader.appendTo(this);}}
> {{ }}}
> would be cleaner.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PARQUET-1470) Inputstream leakage in ParquetFileWriter.appendFile
[
https://issues.apache.org/jira/browse/PARQUET-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717363#comment-16717363
]
Wes McKinney commented on PARQUET-1470:
---
[~ArnaudL] we all propose changes to the Parquet repositories using pull
requests, not by pushing directly to the repo. Another committer will merge
your patch if it is accepted
> Inputstream leakage in ParquetFileWriter.appendFile
> ---
>
> Key: PARQUET-1470
> URL: https://issues.apache.org/jira/browse/PARQUET-1470
> Project: Parquet
> Issue Type: Bug
> Components: parquet-mr
>Affects Versions: 1.10.0
>Reporter: Arnaud Linz
>Priority: Major
>
> Current implementation of ParquetFileWriter.appendFile is:
>
> {{public void appendFile(InputFile file) throws IOException {}}
> {{ ParquetFileReader.open(file).appendTo(this);}}
> {{ }}}
> this method never closes the inputstream created when the file is opened in
> the ParquetFileReader constructor.
> This leads for instance to TooManyFilesOpened exceptions when large merge are
> made with the parquet tools.
> something like
> {{ try (ParquetFileReader reader = ParquetFileReader.open(file)) {}}
> {{ reader.appendTo(this);}}
> {{ }}}
> would be cleaner.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PARQUET-1470) Inputstream leakage in ParquetFileWriter.appendFile
[
https://issues.apache.org/jira/browse/PARQUET-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717272#comment-16717272
]
Arnaud Linz commented on PARQUET-1470:
--
I tried, but I'm not a regular commiter and don't have push access to the repo.
It would be quicker if someone else takes care of it.
> Inputstream leakage in ParquetFileWriter.appendFile
> ---
>
> Key: PARQUET-1470
> URL: https://issues.apache.org/jira/browse/PARQUET-1470
> Project: Parquet
> Issue Type: Bug
> Components: parquet-mr
>Affects Versions: 1.10.0
>Reporter: Arnaud Linz
>Priority: Major
>
> Current implementation of ParquetFileWriter.appendFile is:
>
> {{public void appendFile(InputFile file) throws IOException {}}
> {{ ParquetFileReader.open(file).appendTo(this);}}
> {{ }}}
> this method never closes the inputstream created when the file is opened in
> the ParquetFileReader constructor.
> This leads for instance to TooManyFilesOpened exceptions when large merge are
> made with the parquet tools.
> something like
> {{ try (ParquetFileReader reader = ParquetFileReader.open(file)) {}}
> {{ reader.appendTo(this);}}
> {{ }}}
> would be cleaner.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PARQUET-1470) Inputstream leakage in ParquetFileWriter.appendFile
[
https://issues.apache.org/jira/browse/PARQUET-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708702#comment-16708702
]
Nandor Kollar commented on PARQUET-1470:
Sounds like a reasonable improvement. Would you mind opening a PR?
> Inputstream leakage in ParquetFileWriter.appendFile
> ---
>
> Key: PARQUET-1470
> URL: https://issues.apache.org/jira/browse/PARQUET-1470
> Project: Parquet
> Issue Type: Bug
> Components: parquet-mr
>Affects Versions: 1.10.0
>Reporter: Arnaud Linz
>Priority: Major
>
> Current implementation of ParquetFileWriter.appendFile is:
>
> {{public void appendFile(InputFile file) throws IOException {}}
> {{ ParquetFileReader.open(file).appendTo(this);}}
> {{ }}}
> this method never closes the inputstream created when the file is opened in
> the ParquetFileReader constructor.
> This leads for instance to TooManyFilesOpened exceptions when large merge are
> made with the parquet tools.
> something like
> {{ try (ParquetFileReader reader = ParquetFileReader.open(file)) {}}
> {{ reader.appendTo(this);}}
> {{ }}}
> would be cleaner.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
