[jira] [Commented] (PARQUET-1862) A mistake of Parquet Format Thrift definition file's comment
[
https://issues.apache.org/jira/browse/PARQUET-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107115#comment-17107115
]
ASF GitHub Bot commented on PARQUET-1862:
-
gszadovszky merged pull request #159:
URL: https://github.com/apache/parquet-format/pull/159
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> A mistake of Parquet Format Thrift definition file's comment
>
>
> Key: PARQUET-1862
> URL: https://issues.apache.org/jira/browse/PARQUET-1862
> Project: Parquet
> Issue Type: Bug
> Components: parquet-format
>Reporter: Liam Su
>Assignee: Liam Su
>Priority: Minor
>
> A comment of *DataPageHeaderV2* in the src/main/thrift/parquet.thrift is
> wrong.
>
> {code:java}
> /** optional statistics for this column chunk */
> 8: optional Statistics statistics;
> {code}
>
> should be
> {code:java}
> /** optional statistics for the data in this page */
> 8: optional Statistics statistics;
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PARQUET-1862) A mistake of Parquet Format Thrift definition file's comment
[
https://issues.apache.org/jira/browse/PARQUET-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107042#comment-17107042
]
Liam Su commented on PARQUET-1862:
--
PR
[https://github.com/apache/parquet-format/pull/159]
> A mistake of Parquet Format Thrift definition file's comment
>
>
> Key: PARQUET-1862
> URL: https://issues.apache.org/jira/browse/PARQUET-1862
> Project: Parquet
> Issue Type: Bug
> Components: parquet-format
>Reporter: Liam Su
>Priority: Minor
>
> A comment of *DataPageHeaderV2* in the src/main/thrift/parquet.thrift is
> wrong.
>
> {code:java}
> /** optional statistics for this column chunk */
> 8: optional Statistics statistics;
> {code}
>
> should be
> {code:java}
> /** optional statistics for the data in this page */
> 8: optional Statistics statistics;
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PARQUET-1862) A mistake of Parquet Format Thrift definition file's comment
[
https://issues.apache.org/jira/browse/PARQUET-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107036#comment-17107036
]
ASF GitHub Bot commented on PARQUET-1862:
-
Liam8 opened a new pull request #159:
URL: https://github.com/apache/parquet-format/pull/159
Statistics in DataPageHeaderV2 should be about the page, not column chunk.
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Commits
- [x] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> A mistake of Parquet Format Thrift definition file's comment
>
>
> Key: PARQUET-1862
> URL: https://issues.apache.org/jira/browse/PARQUET-1862
> Project: Parquet
> Issue Type: Bug
> Components: parquet-format
>Reporter: Liam Su
>Priority: Minor
>
> A comment of *DataPageHeaderV2* in the src/main/thrift/parquet.thrift is
> wrong.
>
> {code:java}
> /** optional statistics for this column chunk */
> 8: optional Statistics statistics;
> {code}
>
> should be
> {code:java}
> /** optional statistics for the data in this page */
> 8: optional Statistics statistics;
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
