Re: Unable to compile thrift

2017-02-08 Thread Pradeep Gollakota 
After modifying the failing line to appropriately use reflection, the
following command successfully built parquet-mr with thrift 0.9.3

LC_ALL=C mvn install -DskipTests -Dthrift.version=0.9.3
-Dsun.zip.disableMemoryMapping=true

Not sure if I actually need the sun.zip.disableMemoryMapping property set
to true or not. The first build failed with a SIGSEGV and looking into it,
found this JDK bug https://bugs.openjdk.java.net/browse/JDK-8168632. For
the second build I set the property and it succeded.

That should unblock me, thanks for you help guys!
​

On Wed, Feb 8, 2017 at 12:23 PM, Lars Volker  wrote:

> I remember trying to compile with the latest version of thrift shipped in
> Ubuntu 14.04 a few weeks back and got the same error. Using 0.7 worked
> though. Sadly I don't know why it fails on a Mac.
>
> On Feb 8, 2017 21:18, "Pradeep Gollakota"  wrote:
>
> > I tried building with -Dthrift.version=0.9.3 and the build still failed
> > with the following error:
> >
> > [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-compiler-plugin:3.1:compile
> > (default-compile) on project parquet-thrift: Compilation failure
> > [ERROR] /Users/pgollakota/workspace/apache/parquet-mr/parquet-
> > thrift/src/main/java/org/apache/parquet/hadoop/thrift/
> > ThriftBytesWriteSupport.java:[144,34]
> > cannot find symbol
> > [ERROR] symbol:   method setReadLength(int)
> > [ERROR] location: class org.apache.thrift.protocol.TBinaryProtocol
> > [ERROR] -> [Help 1]
> > [ERROR]
> >
> > So it looks like the source is not compatible?
> > ​
> >
> > On Wed, Feb 8, 2017 at 12:14 PM, Wes McKinney 
> wrote:
> >
> > > hi Pradeep -- you can use Thrift 0.7 or higher (the instructions say
> > > "0.7+", perhaps we should call this out more explicitly). I recommend
> > > building Thrift 0.9.3 or 0.10 -- let us know if you have issues with
> > > these
> > >
> > > Thanks
> > > Wes
> > >
> > > On Wed, Feb 8, 2017 at 2:19 PM, Pradeep Gollakota <
> pradeep...@gmail.com>
> > > wrote:
> > > > Hi folks,
> > > >
> > > > I'm trying to build parquet from source. However, the instructions
> call
> > > for
> > > > the installation of thrift-0.7.0. I'm developing on a mac and that
> > > version
> > > > of thrift does not compile. I get the following error when I run
> make:
> > > >
> > > > ```
> > > > make
> > > > /Library/Developer/CommandLineTools/usr/bin/make  all-recursive
> > > > Making all in compiler/cpp
> > > > /Library/Developer/CommandLineTools/usr/bin/make  all-am
> > > > make[3]: Nothing to be done for `all-am'.
> > > > Making all in lib
> > > > Making all in cpp
> > > > Making all in .
> > > > if /bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H
> > -I.
> > > > -I. -I../..  -I/usr/local/include -I./src  -Wall -g -O2 -MT
> > > > ThreadManager.lo -MD -MP -MF ".deps/ThreadManager.Tpo" -c -o
> > > > ThreadManager.lo `test -f 'src/concurrency/ThreadManager.cpp' ||
> echo
> > > > './'`src/concurrency/ThreadManager.cpp; \
> > > > then mv -f ".deps/ThreadManager.Tpo" ".deps/ThreadManager.Plo"; else
> rm
> > > -f
> > > > ".deps/ThreadManager.Tpo"; exit 1; fi
> > > >  g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I/usr/local/include -I./src
> -Wall
> > > -g
> > > > -O2 -MT ThreadManager.lo -MD -MP -MF .deps/ThreadManager.Tpo -c
> > > > src/concurrency/ThreadManager.cpp  -fno-common -DPIC -o
> > > > .libs/ThreadManager.o
> > > > In file included from src/concurrency/ThreadManager.cpp:20:
> > > > src/concurrency/ThreadManager.h:24:10: fatal error: 'tr1/functional'
> > > file
> > > > not found
> > > > #include 
> > > >  ^
> > > > 1 error generated.
> > > > make[4]: *** [ThreadManager.lo] Error 1
> > > > make[3]: *** [all-recursive] Error 1
> > > > make[2]: *** [all-recursive] Error 1
> > > > make[1]: *** [all-recursive] Error 1
> > > > make: *** [all] Error 2
> > > > ```
> > > >
> > > > I'm going through thrift jira's to see if I can find any workarounds,
> > > but I
> > > > was wondering if any of you have faced this issue and have gotten
> > around
> > > it.
> > > >
> > > > Thanks,
> > > > Pradeep
> > >
> >
>

Re: Unable to compile thrift

2017-02-08 Thread Lars Volker 
I remember trying to compile with the latest version of thrift shipped in
Ubuntu 14.04 a few weeks back and got the same error. Using 0.7 worked
though. Sadly I don't know why it fails on a Mac.

On Feb 8, 2017 21:18, "Pradeep Gollakota"  wrote:

> I tried building with -Dthrift.version=0.9.3 and the build still failed
> with the following error:
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.1:compile
> (default-compile) on project parquet-thrift: Compilation failure
> [ERROR] /Users/pgollakota/workspace/apache/parquet-mr/parquet-
> thrift/src/main/java/org/apache/parquet/hadoop/thrift/
> ThriftBytesWriteSupport.java:[144,34]
> cannot find symbol
> [ERROR] symbol:   method setReadLength(int)
> [ERROR] location: class org.apache.thrift.protocol.TBinaryProtocol
> [ERROR] -> [Help 1]
> [ERROR]
>
> So it looks like the source is not compatible?
> ​
>
> On Wed, Feb 8, 2017 at 12:14 PM, Wes McKinney  wrote:
>
> > hi Pradeep -- you can use Thrift 0.7 or higher (the instructions say
> > "0.7+", perhaps we should call this out more explicitly). I recommend
> > building Thrift 0.9.3 or 0.10 -- let us know if you have issues with
> > these
> >
> > Thanks
> > Wes
> >
> > On Wed, Feb 8, 2017 at 2:19 PM, Pradeep Gollakota 
> > wrote:
> > > Hi folks,
> > >
> > > I'm trying to build parquet from source. However, the instructions call
> > for
> > > the installation of thrift-0.7.0. I'm developing on a mac and that
> > version
> > > of thrift does not compile. I get the following error when I run make:
> > >
> > > ```
> > > make
> > > /Library/Developer/CommandLineTools/usr/bin/make  all-recursive
> > > Making all in compiler/cpp
> > > /Library/Developer/CommandLineTools/usr/bin/make  all-am
> > > make[3]: Nothing to be done for `all-am'.
> > > Making all in lib
> > > Making all in cpp
> > > Making all in .
> > > if /bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H
> -I.
> > > -I. -I../..  -I/usr/local/include -I./src  -Wall -g -O2 -MT
> > > ThreadManager.lo -MD -MP -MF ".deps/ThreadManager.Tpo" -c -o
> > > ThreadManager.lo `test -f 'src/concurrency/ThreadManager.cpp' || echo
> > > './'`src/concurrency/ThreadManager.cpp; \
> > > then mv -f ".deps/ThreadManager.Tpo" ".deps/ThreadManager.Plo"; else rm
> > -f
> > > ".deps/ThreadManager.Tpo"; exit 1; fi
> > >  g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I/usr/local/include -I./src -Wall
> > -g
> > > -O2 -MT ThreadManager.lo -MD -MP -MF .deps/ThreadManager.Tpo -c
> > > src/concurrency/ThreadManager.cpp  -fno-common -DPIC -o
> > > .libs/ThreadManager.o
> > > In file included from src/concurrency/ThreadManager.cpp:20:
> > > src/concurrency/ThreadManager.h:24:10: fatal error: 'tr1/functional'
> > file
> > > not found
> > > #include 
> > >  ^
> > > 1 error generated.
> > > make[4]: *** [ThreadManager.lo] Error 1
> > > make[3]: *** [all-recursive] Error 1
> > > make[2]: *** [all-recursive] Error 1
> > > make[1]: *** [all-recursive] Error 1
> > > make: *** [all] Error 2
> > > ```
> > >
> > > I'm going through thrift jira's to see if I can find any workarounds,
> > but I
> > > was wondering if any of you have faced this issue and have gotten
> around
> > it.
> > >
> > > Thanks,
> > > Pradeep
> >
>

Re: Unable to compile thrift

2017-02-08 Thread Pradeep Gollakota 
I tried building with -Dthrift.version=0.9.3 and the build still failed
with the following error:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile
(default-compile) on project parquet-thrift: Compilation failure
[ERROR] 
/Users/pgollakota/workspace/apache/parquet-mr/parquet-thrift/src/main/java/org/apache/parquet/hadoop/thrift/ThriftBytesWriteSupport.java:[144,34]
cannot find symbol
[ERROR] symbol:   method setReadLength(int)
[ERROR] location: class org.apache.thrift.protocol.TBinaryProtocol
[ERROR] -> [Help 1]
[ERROR]

So it looks like the source is not compatible?
​

On Wed, Feb 8, 2017 at 12:14 PM, Wes McKinney  wrote:

> hi Pradeep -- you can use Thrift 0.7 or higher (the instructions say
> "0.7+", perhaps we should call this out more explicitly). I recommend
> building Thrift 0.9.3 or 0.10 -- let us know if you have issues with
> these
>
> Thanks
> Wes
>
> On Wed, Feb 8, 2017 at 2:19 PM, Pradeep Gollakota 
> wrote:
> > Hi folks,
> >
> > I'm trying to build parquet from source. However, the instructions call
> for
> > the installation of thrift-0.7.0. I'm developing on a mac and that
> version
> > of thrift does not compile. I get the following error when I run make:
> >
> > ```
> > make
> > /Library/Developer/CommandLineTools/usr/bin/make  all-recursive
> > Making all in compiler/cpp
> > /Library/Developer/CommandLineTools/usr/bin/make  all-am
> > make[3]: Nothing to be done for `all-am'.
> > Making all in lib
> > Making all in cpp
> > Making all in .
> > if /bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I.
> > -I. -I../..  -I/usr/local/include -I./src  -Wall -g -O2 -MT
> > ThreadManager.lo -MD -MP -MF ".deps/ThreadManager.Tpo" -c -o
> > ThreadManager.lo `test -f 'src/concurrency/ThreadManager.cpp' || echo
> > './'`src/concurrency/ThreadManager.cpp; \
> > then mv -f ".deps/ThreadManager.Tpo" ".deps/ThreadManager.Plo"; else rm
> -f
> > ".deps/ThreadManager.Tpo"; exit 1; fi
> >  g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I/usr/local/include -I./src -Wall
> -g
> > -O2 -MT ThreadManager.lo -MD -MP -MF .deps/ThreadManager.Tpo -c
> > src/concurrency/ThreadManager.cpp  -fno-common -DPIC -o
> > .libs/ThreadManager.o
> > In file included from src/concurrency/ThreadManager.cpp:20:
> > src/concurrency/ThreadManager.h:24:10: fatal error: 'tr1/functional'
> file
> > not found
> > #include 
> >  ^
> > 1 error generated.
> > make[4]: *** [ThreadManager.lo] Error 1
> > make[3]: *** [all-recursive] Error 1
> > make[2]: *** [all-recursive] Error 1
> > make[1]: *** [all-recursive] Error 1
> > make: *** [all] Error 2
> > ```
> >
> > I'm going through thrift jira's to see if I can find any workarounds,
> but I
> > was wondering if any of you have faced this issue and have gotten around
> it.
> >
> > Thanks,
> > Pradeep
>

Re: Unable to compile thrift

2017-02-08 Thread Wes McKinney 
hi Pradeep -- you can use Thrift 0.7 or higher (the instructions say
"0.7+", perhaps we should call this out more explicitly). I recommend
building Thrift 0.9.3 or 0.10 -- let us know if you have issues with
these

Thanks
Wes

On Wed, Feb 8, 2017 at 2:19 PM, Pradeep Gollakota  wrote:
> Hi folks,
>
> I'm trying to build parquet from source. However, the instructions call for
> the installation of thrift-0.7.0. I'm developing on a mac and that version
> of thrift does not compile. I get the following error when I run make:
>
> ```
> make
> /Library/Developer/CommandLineTools/usr/bin/make  all-recursive
> Making all in compiler/cpp
> /Library/Developer/CommandLineTools/usr/bin/make  all-am
> make[3]: Nothing to be done for `all-am'.
> Making all in lib
> Making all in cpp
> Making all in .
> if /bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I.
> -I. -I../..  -I/usr/local/include -I./src  -Wall -g -O2 -MT
> ThreadManager.lo -MD -MP -MF ".deps/ThreadManager.Tpo" -c -o
> ThreadManager.lo `test -f 'src/concurrency/ThreadManager.cpp' || echo
> './'`src/concurrency/ThreadManager.cpp; \
> then mv -f ".deps/ThreadManager.Tpo" ".deps/ThreadManager.Plo"; else rm -f
> ".deps/ThreadManager.Tpo"; exit 1; fi
>  g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I/usr/local/include -I./src -Wall -g
> -O2 -MT ThreadManager.lo -MD -MP -MF .deps/ThreadManager.Tpo -c
> src/concurrency/ThreadManager.cpp  -fno-common -DPIC -o
> .libs/ThreadManager.o
> In file included from src/concurrency/ThreadManager.cpp:20:
> src/concurrency/ThreadManager.h:24:10: fatal error: 'tr1/functional' file
> not found
> #include 
>  ^
> 1 error generated.
> make[4]: *** [ThreadManager.lo] Error 1
> make[3]: *** [all-recursive] Error 1
> make[2]: *** [all-recursive] Error 1
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2
> ```
>
> I'm going through thrift jira's to see if I can find any workarounds, but I
> was wondering if any of you have faced this issue and have gotten around it.
>
> Thanks,
> Pradeep