[jira] [Commented] (PDFBOX-3934) Page missing
[ https://issues.apache.org/jira/browse/PDFBOX-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182983#comment-16182983 ] Tilman Hausherr commented on PDFBOX-3934: - File genko_oc_shiryo1.pdf (in PDFBOX-3788) fails with "Missing root object specification in trailer". > Page missing > > > Key: PDFBOX-3934 > URL: https://issues.apache.org/jira/browse/PDFBOX-3934 > Project: PDFBox > Issue Type: Bug > Components: Parsing >Affects Versions: 2.0.5, 2.0.6, 2.0.7 >Reporter: Tilman Hausherr >Assignee: Andreas Lehmkühler > Labels: regression > Attachments: BCZSFNQAB62TUBURWG6B3ZOZCG5IH46P.pdf, > PDFBOX-3934-KTUUMJNQ7NYGJJMEDGSY5OEU76G6JX2V.pdf > > > The first page (with "iéseg") was in 2.0.4 but is no longer there since 2.0.5. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3934) Page missing
[ https://issues.apache.org/jira/browse/PDFBOX-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182968#comment-16182968 ] Andreas Lehmkühler commented on PDFBOX-3934: I've fixed the regression. The brute force search now includes compressed objects when rebuilding the trailer information. [~tilman], [~talli...@mitre.org] Please run your tests to see if it works. > Page missing > > > Key: PDFBOX-3934 > URL: https://issues.apache.org/jira/browse/PDFBOX-3934 > Project: PDFBox > Issue Type: Bug > Components: Parsing >Affects Versions: 2.0.5, 2.0.6, 2.0.7 >Reporter: Tilman Hausherr >Assignee: Andreas Lehmkühler > Labels: regression > Attachments: BCZSFNQAB62TUBURWG6B3ZOZCG5IH46P.pdf, > PDFBOX-3934-KTUUMJNQ7NYGJJMEDGSY5OEU76G6JX2V.pdf > > > The first page (with "iéseg") was in 2.0.4 but is no longer there since 2.0.5. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3934) Page missing
[ https://issues.apache.org/jira/browse/PDFBOX-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182963#comment-16182963 ] ASF subversion and git services commented on PDFBOX-3934: - Commit 1809890 from [~lehmi] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1809890 ] PDFBOX-3934: include compressed objects in brute force search when rebuilding the trailer > Page missing > > > Key: PDFBOX-3934 > URL: https://issues.apache.org/jira/browse/PDFBOX-3934 > Project: PDFBox > Issue Type: Bug > Components: Parsing >Affects Versions: 2.0.5, 2.0.6, 2.0.7 >Reporter: Tilman Hausherr >Assignee: Andreas Lehmkühler > Labels: regression > Attachments: BCZSFNQAB62TUBURWG6B3ZOZCG5IH46P.pdf, > PDFBOX-3934-KTUUMJNQ7NYGJJMEDGSY5OEU76G6JX2V.pdf > > > The first page (with "iéseg") was in 2.0.4 but is no longer there since 2.0.5. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3934) Page missing
[ https://issues.apache.org/jira/browse/PDFBOX-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182964#comment-16182964 ] ASF subversion and git services commented on PDFBOX-3934: - Commit 1809891 from [~lehmi] in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1809891 ] PDFBOX-3934: include compressed objects in brute force search when rebuilding the trailer > Page missing > > > Key: PDFBOX-3934 > URL: https://issues.apache.org/jira/browse/PDFBOX-3934 > Project: PDFBox > Issue Type: Bug > Components: Parsing >Affects Versions: 2.0.5, 2.0.6, 2.0.7 >Reporter: Tilman Hausherr >Assignee: Andreas Lehmkühler > Labels: regression > Attachments: BCZSFNQAB62TUBURWG6B3ZOZCG5IH46P.pdf, > PDFBOX-3934-KTUUMJNQ7NYGJJMEDGSY5OEU76G6JX2V.pdf > > > The first page (with "iéseg") was in 2.0.4 but is no longer there since 2.0.5. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-2852) Improve code quality (2)
[ https://issues.apache.org/jira/browse/PDFBOX-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182753#comment-16182753 ] ASF subversion and git services commented on PDFBOX-2852: - Commit 1809865 from [~tilman] in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1809865 ] PDFBOX-2852: remove tabs > Improve code quality (2) > > > Key: PDFBOX-2852 > URL: https://issues.apache.org/jira/browse/PDFBOX-2852 > Project: PDFBox > Issue Type: Task >Affects Versions: 2.0.0 >Reporter: Tilman Hausherr > Attachments: explicit_array_creation.patch, fix_javadoc.patch, > foreach2.patch, foreach.patch, generic_type_arguments.patch, noarray.patch, > PDNameTreeNode.java.patch, semicolon.patch, StringBuffer.patch, > stringbuilder.patch, unnecessary_type_casting.patch, unused_imports.patch, > usestatic.patch, winansiencoding2.patch, winansiencoding.patch, > XMPSchema.java.patch > > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2576, which was getting too long. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-2852) Improve code quality (2)
[ https://issues.apache.org/jira/browse/PDFBOX-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182752#comment-16182752 ] ASF subversion and git services commented on PDFBOX-2852: - Commit 1809864 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1809864 ] PDFBOX-2852: remove tabs > Improve code quality (2) > > > Key: PDFBOX-2852 > URL: https://issues.apache.org/jira/browse/PDFBOX-2852 > Project: PDFBox > Issue Type: Task >Affects Versions: 2.0.0 >Reporter: Tilman Hausherr > Attachments: explicit_array_creation.patch, fix_javadoc.patch, > foreach2.patch, foreach.patch, generic_type_arguments.patch, noarray.patch, > PDNameTreeNode.java.patch, semicolon.patch, StringBuffer.patch, > stringbuilder.patch, unnecessary_type_casting.patch, unused_imports.patch, > usestatic.patch, winansiencoding2.patch, winansiencoding.patch, > XMPSchema.java.patch > > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2576, which was getting too long. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Resolved] (PDFBOX-3943) /Helv entry in /DR not created if /DR exists
[ https://issues.apache.org/jira/browse/PDFBOX-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tilman Hausherr resolved PDFBOX-3943. - Resolution: Fixed > /Helv entry in /DR not created if /DR exists > > > Key: PDFBOX-3943 > URL: https://issues.apache.org/jira/browse/PDFBOX-3943 > Project: PDFBox > Issue Type: Bug > Components: AcroForm >Affects Versions: 2.0.7 >Reporter: Tilman Hausherr >Assignee: Tilman Hausherr >Priority: Minor > Fix For: 2.0.8, 3.0.0 > > > The code in the attached issue shows that > {{PDAcroForm.verifyOrCreateDefaults()}} doesn't create the /Helv entry if the > /DR entry exists but /Helv is missing. I'll do that and the same for /ZaDb. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3943) /Helv entry in /DR not created if /DR exists
[ https://issues.apache.org/jira/browse/PDFBOX-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182745#comment-16182745 ] ASF subversion and git services commented on PDFBOX-3943: - Commit 1809863 from [~tilman] in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1809863 ] PDFBOX-3943: create /Helv and /ZaDb entries if they don't exist, regardless if /DR existed or not > /Helv entry in /DR not created if /DR exists > > > Key: PDFBOX-3943 > URL: https://issues.apache.org/jira/browse/PDFBOX-3943 > Project: PDFBox > Issue Type: Bug > Components: AcroForm >Affects Versions: 2.0.7 >Reporter: Tilman Hausherr >Assignee: Tilman Hausherr >Priority: Minor > Fix For: 2.0.8, 3.0.0 > > > The code in the attached issue shows that > {{PDAcroForm.verifyOrCreateDefaults()}} doesn't create the /Helv entry if the > /DR entry exists but /Helv is missing. I'll do that and the same for /ZaDb. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3943) /Helv entry in /DR not created if /DR exists
[ https://issues.apache.org/jira/browse/PDFBOX-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182744#comment-16182744 ] ASF subversion and git services commented on PDFBOX-3943: - Commit 1809862 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1809862 ] PDFBOX-3943: create /Helv and /ZaDb entries if they don't exist, regardless if /DR existed or not > /Helv entry in /DR not created if /DR exists > > > Key: PDFBOX-3943 > URL: https://issues.apache.org/jira/browse/PDFBOX-3943 > Project: PDFBox > Issue Type: Bug > Components: AcroForm >Affects Versions: 2.0.7 >Reporter: Tilman Hausherr >Assignee: Tilman Hausherr >Priority: Minor > Fix For: 2.0.8, 3.0.0 > > > The code in the attached issue shows that > {{PDAcroForm.verifyOrCreateDefaults()}} doesn't create the /Helv entry if the > /DR entry exists but /Helv is missing. I'll do that and the same for /ZaDb. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3942) ClassCastException in getOptionalContentGroups
[ https://issues.apache.org/jira/browse/PDFBOX-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182738#comment-16182738 ] Tilman Hausherr commented on PDFBOX-3942: - To test your application, you can get a snapshot here: https://repository.apache.org/content/groups/snapshots/org/apache/pdfbox/pdfbox-app/2.0.8-SNAPSHOT/ To see the current source, use svn or see here: https://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentProperties.java?view=markup > ClassCastException in getOptionalContentGroups > -- > > Key: PDFBOX-3942 > URL: https://issues.apache.org/jira/browse/PDFBOX-3942 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 2.0.6 >Reporter: Vlad-Tudor Marchis >Assignee: Tilman Hausherr >Priority: Minor > Labels: support > Fix For: 2.0.8, 3.0.0 > > Attachments: PDOptionalContentProperties.java > > > I noticed this issue when trying to remove a set of layers I previously added > on a multi-page PDF. I noticed it in version 2.0.6, but might be present in > others. > Here is a stacktrace snippet: > Caused by: java.lang.ClassCastException: org.apache.pdfbox.cos.COSDictionary > cannot be cast to org.apache.pdfbox.cos.COSObject > at > org.apache.pdfbox.pdmodel.graphics.optionalcontent.PDOptionalContentProperties.getOptionalContentGroups(PDOptionalContentProperties.java:180). > I looked at the source and saw the toDictionary method that seemed to be used > in every other place so I just put in in place and it seems to have solved > the issue. > I've uploaded the updated file, the one that I'm using, which you can review > and include in your project if it's a valid fix. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3809) PDAcroForm.flatten(PDField list, refreshAppearances boolean) flattens all form fields instead of specified ones.
[ https://issues.apache.org/jira/browse/PDFBOX-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182736#comment-16182736 ] Tilman Hausherr commented on PDFBOX-3809: - We could get a list of all widgets from the field list, and check for equality at the COS level for each PDAnnotationWidget. The "only" problem that remains is removing a field. There's currently no way to remove a single field from the tree. But I think this can be done recursively by going through the tree: - on the array level, check the terminal fields if there's a match at the COS level - if yes, then delete field from COSArray and report success - if no, then for each non terminal field, get the kids array and do as described. This won't be done for the next release (it could, but this would be risky), but I think it can be done. Alternative: we do nothing and make the method private > PDAcroForm.flatten(PDField list, refreshAppearances boolean) flattens all > form fields instead of specified ones. > > > Key: PDFBOX-3809 > URL: https://issues.apache.org/jira/browse/PDFBOX-3809 > Project: PDFBox > Issue Type: Improvement > Components: AcroForm >Affects Versions: 2.0.5, 2.0.6, 2.0.7 >Reporter: Cristin Donaher >Priority: Minor > > Thanks for the excellent PDF library. For my use case I need to flatten a > subset of the AcroForm fields. I was attempting to use the > PDAcroForm.flatten call, passing in my field list. However, after the method > is called, all the fields are gone. > The method itself appears to remove all PDFAnnotationWidgets from each page > and at the end clears the acroform's field set. > Is the javadoc description (This will flatten the specified form fields.) > just misleading? Could a flatten call for a subset of fields be added? > Thanks -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Created] (PDFBOX-3943) /Helv entry in /DR not created if /DR exists
Tilman Hausherr created PDFBOX-3943: --- Summary: /Helv entry in /DR not created if /DR exists Key: PDFBOX-3943 URL: https://issues.apache.org/jira/browse/PDFBOX-3943 Project: PDFBox Issue Type: Bug Components: AcroForm Affects Versions: 2.0.7 Reporter: Tilman Hausherr Assignee: Tilman Hausherr Priority: Minor Fix For: 2.0.8, 3.0.0 The code in the attached issue shows that {{PDAcroForm.verifyOrCreateDefaults()}} doesn't create the /Helv entry if the /DR entry exists but /Helv is missing. I'll do that and the same for /ZaDb. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3940) Lost metadata in 2.0.8-SNAPSHOT
[ https://issues.apache.org/jira/browse/PDFBOX-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182730#comment-16182730 ] ASF subversion and git services commented on PDFBOX-3940: - Commit 1809861 from [~tilman] in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1809861 ] PDFBOX-3940: add test > Lost metadata in 2.0.8-SNAPSHOT > --- > > Key: PDFBOX-3940 > URL: https://issues.apache.org/jira/browse/PDFBOX-3940 > Project: PDFBox > Issue Type: Bug > Components: Parsing >Affects Versions: 2.0.8 >Reporter: Tim Allison >Assignee: Tilman Hausherr > Labels: regression > Fix For: 2.0.8, 3.0.0 > > Attachments: 079977.pdf, 2_0_7_079977.pdf.json, > 2_0_8-SNAPSHOT_079977.pdf.json > > > We noticed some missing metadata values in the recent large scale regression > testing. I finally had a chance to look. It looks like a genuine regression. > The diff btwn 2.0.7 and 2.0.8-SNAPSHOT in metadata values is often -2. > However, in some files, the problem is more pronounced. > In the attached file, when we call {{PDDocument.getDocumentInformation()}}, > the returned {{PDDocumentInformation info}} is empty in 2.0.8-SNAPSHOT but > not in 2.0.7. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3940) Lost metadata in 2.0.8-SNAPSHOT
[ https://issues.apache.org/jira/browse/PDFBOX-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182729#comment-16182729 ] ASF subversion and git services commented on PDFBOX-3940: - Commit 1809860 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1809860 ] PDFBOX-3940: add test > Lost metadata in 2.0.8-SNAPSHOT > --- > > Key: PDFBOX-3940 > URL: https://issues.apache.org/jira/browse/PDFBOX-3940 > Project: PDFBox > Issue Type: Bug > Components: Parsing >Affects Versions: 2.0.8 >Reporter: Tim Allison >Assignee: Tilman Hausherr > Labels: regression > Fix For: 2.0.8, 3.0.0 > > Attachments: 079977.pdf, 2_0_7_079977.pdf.json, > 2_0_8-SNAPSHOT_079977.pdf.json > > > We noticed some missing metadata values in the recent large scale regression > testing. I finally had a chance to look. It looks like a genuine regression. > The diff btwn 2.0.7 and 2.0.8-SNAPSHOT in metadata values is often -2. > However, in some files, the problem is more pronounced. > In the attached file, when we call {{PDDocument.getDocumentInformation()}}, > the returned {{PDDocumentInformation info}} is empty in 2.0.8-SNAPSHOT but > not in 2.0.7. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3942) ClassCastException in getOptionalContentGroups
[ https://issues.apache.org/jira/browse/PDFBOX-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182185#comment-16182185 ] Vlad-Tudor Marchis commented on PDFBOX-3942: I think I grabbed the source from an older version by accident. I will try the new versions, thank you! > ClassCastException in getOptionalContentGroups > -- > > Key: PDFBOX-3942 > URL: https://issues.apache.org/jira/browse/PDFBOX-3942 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 2.0.6 >Reporter: Vlad-Tudor Marchis >Assignee: Tilman Hausherr >Priority: Minor > Labels: support > Fix For: 2.0.8, 3.0.0 > > Attachments: PDOptionalContentProperties.java > > > I noticed this issue when trying to remove a set of layers I previously added > on a multi-page PDF. I noticed it in version 2.0.6, but might be present in > others. > Here is a stacktrace snippet: > Caused by: java.lang.ClassCastException: org.apache.pdfbox.cos.COSDictionary > cannot be cast to org.apache.pdfbox.cos.COSObject > at > org.apache.pdfbox.pdmodel.graphics.optionalcontent.PDOptionalContentProperties.getOptionalContentGroups(PDOptionalContentProperties.java:180). > I looked at the source and saw the toDictionary method that seemed to be used > in every other place so I just put in in place and it seems to have solved > the issue. > I've uploaded the updated file, the one that I'm using, which you can review > and include in your project if it's a valid fix. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org