[jira] [Resolved] (PDFBOX-5773) Add leading "0" for octal values in MacOSRomanEncoding

2024-02-21 Thread Jira 


 [ 
https://issues.apache.org/jira/browse/PDFBOX-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Lehmkühler resolved PDFBOX-5773.

Resolution: Fixed

[~dvholten] thanks for the contribution

> Add leading "0" for octal values in MacOSRomanEncoding
> --
>
> Key: PDFBOX-5773
> URL: https://issues.apache.org/jira/browse/PDFBOX-5773
> Project: PDFBox
>  Issue Type: Bug
>  Components: FontBox
>Affects Versions: 2.0.30, 3.0.1 PDFBox, 4.0.0
>Reporter: Andreas Lehmkühler
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 2.0.31, 3.0.2 PDFBox, 4.0.0
>
>
> In {{org.apache.pdfbox.pdmodel.font.encoding.MacOSRomanEncoding}} the leading 
> "0" for all octal values is missing, see 
> https://github.com/apache/pdfbox/pull/186



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: [PR] suppress warnings for octals, omit trailing blanks [pdfbox]

2024-02-21 Thread via GitHub 


lehmi commented on code in PR #186:
URL: https://github.com/apache/pdfbox/pull/186#discussion_r1498752894


##
pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacRomanEncoding.java:
##
@@ -29,6 +29,7 @@ public class MacRomanEncoding extends Encoding
 /**
  * Table of octal character codes and their corresponding names.
  */
+@SuppressWarnings("OctalInteger")

Review Comment:
   We are using sonar and I guess it was added to address that one



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-02-21 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819502#comment-17819502
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1915941 from le...@apache.org in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1915941 ]

PDFBOX-5660: simplify as proposed by DvonHolten, closes #186

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: [PR] suppress warnings for octals, omit trailing blanks [pdfbox]

2024-02-21 Thread via GitHub 


DvonHolten commented on code in PR #186:
URL: https://github.com/apache/pdfbox/pull/186#discussion_r1498751356


##
pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacRomanEncoding.java:
##
@@ -29,6 +29,7 @@ public class MacRomanEncoding extends Encoding
 /**
  * Table of octal character codes and their corresponding names.
  */
+@SuppressWarnings("OctalInteger")

Review Comment:
   there are other SuppressWarnings (like "squid:S106" or 
"SpellCheckingInspection"). There are just a few warnings defined in Java, so 
that annotation mostly adresses 'other tools'. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: [PR] suppress warnings for octals, omit trailing blanks [pdfbox]

2024-02-21 Thread via GitHub 


lehmi commented on code in PR #186:
URL: https://github.com/apache/pdfbox/pull/186#discussion_r1498750997


##
pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/Encoding.java:
##
@@ -159,23 +159,18 @@ public boolean contains(int code)
 
 /**
  * This will take a character code and get the name from the code.
- * 
+ *
  * @param code character code
- * @return PostScript glyph name
+ * @return PostScript glyph name, or ".notdef" when not found.
  */
 public String getName(int code)
 {
-   String name = codeToName.get(code);
-   if (name != null)
-   {
-  return name;
-   }
-   return ".notdef";
+   return codeToName.getOrDefault(code, ".notdef");

Review Comment:
   I've added the proposed change as well, see PDFBOX-5660



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: [PR] suppress warnings for octals, omit trailing blanks [pdfbox]

2024-02-21 Thread via GitHub 


lehmi commented on code in PR #186:
URL: https://github.com/apache/pdfbox/pull/186#discussion_r1498750601


##
pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacExpertEncoding.java:
##
@@ -27,6 +27,7 @@ public class MacExpertEncoding extends Encoding
 /**
  * Table of octal character codes and their corresponding names.
  */
+@SuppressWarnings("OctalInteger")

Review Comment:
   I won't add that as it is IntelliJ specific



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: [PR] suppress warnings for octals, omit trailing blanks [pdfbox]

2024-02-21 Thread via GitHub 


lehmi commented on code in PR #186:
URL: https://github.com/apache/pdfbox/pull/186#discussion_r1498749957


##
pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacOSRomanEncoding.java:
##
@@ -27,7 +27,9 @@ public class MacOSRomanEncoding extends MacRomanEncoding
 /**
  * Table of octal character codes and their corresponding names
  * on top of {@link MacRomanEncoding}.
+ * ToDo are these really octals?? leading 0 seems to be missing

Review Comment:
   Thanks, I've added the leading "0", see PDFBOX-5773



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-02-21 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819500#comment-17819500
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1915940 from le...@apache.org in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1915940 ]

PDFBOX-5660: simplify as proposed by DvonHolten

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: [PR] suppress warnings for octals, omit trailing blanks [pdfbox]

2024-02-21 Thread via GitHub 


DvonHolten commented on code in PR #186:
URL: https://github.com/apache/pdfbox/pull/186#discussion_r1498745030


##
pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/Encoding.java:
##
@@ -159,23 +159,18 @@ public boolean contains(int code)
 
 /**
  * This will take a character code and get the name from the code.
- * 
+ *
  * @param code character code
- * @return PostScript glyph name
+ * @return PostScript glyph name, or ".notdef" when not found.
  */
 public String getName(int code)
 {
-   String name = codeToName.get(code);
-   if (name != null)
-   {
-  return name;
-   }
-   return ".notdef";
+   return codeToName.getOrDefault(code, ".notdef");

Review Comment:
   getOrDefault() is used in 2 other locations as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5773) Add leading "0" for octal values in MacOSRomanEncoding

2024-02-21 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/PDFBOX-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819498#comment-17819498
 ] 

ASF subversion and git services commented on PDFBOX-5773:
-

Commit 1915939 from le...@apache.org in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1915939 ]

PDFBOX-5773: add missing leading "0" of octal values as pointed out by 
DvonHolten

> Add leading "0" for octal values in MacOSRomanEncoding
> --
>
> Key: PDFBOX-5773
> URL: https://issues.apache.org/jira/browse/PDFBOX-5773
> Project: PDFBox
>  Issue Type: Bug
>  Components: FontBox
>Affects Versions: 2.0.30, 3.0.1 PDFBox, 4.0.0
>Reporter: Andreas Lehmkühler
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 2.0.31, 3.0.2 PDFBox, 4.0.0
>
>
> In {{org.apache.pdfbox.pdmodel.font.encoding.MacOSRomanEncoding}} the leading 
> "0" for all octal values is missing, see 
> https://github.com/apache/pdfbox/pull/186



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5773) Add leading "0" for octal values in MacOSRomanEncoding

2024-02-21 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/PDFBOX-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819496#comment-17819496
 ] 

ASF subversion and git services commented on PDFBOX-5773:
-

Commit 1915937 from le...@apache.org in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1915937 ]

PDFBOX-5773: add missing leading "0" of octal values as pointed out by 
DvonHolten

> Add leading "0" for octal values in MacOSRomanEncoding
> --
>
> Key: PDFBOX-5773
> URL: https://issues.apache.org/jira/browse/PDFBOX-5773
> Project: PDFBox
>  Issue Type: Bug
>  Components: FontBox
>Affects Versions: 2.0.30, 3.0.1 PDFBox, 4.0.0
>Reporter: Andreas Lehmkühler
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 2.0.31, 3.0.2 PDFBox, 4.0.0
>
>
> In {{org.apache.pdfbox.pdmodel.font.encoding.MacOSRomanEncoding}} the leading 
> "0" for all octal values is missing, see 
> https://github.com/apache/pdfbox/pull/186



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5773) Add leading "0" for octal values in MacOSRomanEncoding

2024-02-21 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/PDFBOX-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819497#comment-17819497
 ] 

ASF subversion and git services commented on PDFBOX-5773:
-

Commit 1915938 from le...@apache.org in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1915938 ]

PDFBOX-5773: add missing leading "0" of octal values as pointed out by 
DvonHolten

> Add leading "0" for octal values in MacOSRomanEncoding
> --
>
> Key: PDFBOX-5773
> URL: https://issues.apache.org/jira/browse/PDFBOX-5773
> Project: PDFBox
>  Issue Type: Bug
>  Components: FontBox
>Affects Versions: 2.0.30, 3.0.1 PDFBox, 4.0.0
>Reporter: Andreas Lehmkühler
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 2.0.31, 3.0.2 PDFBox, 4.0.0
>
>
> In {{org.apache.pdfbox.pdmodel.font.encoding.MacOSRomanEncoding}} the leading 
> "0" for all octal values is missing, see 
> https://github.com/apache/pdfbox/pull/186



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Created] (PDFBOX-5773) Add leading "0" for octal values in MacOSRomanEncoding

2024-02-21 Thread Jira 
Andreas Lehmkühler created PDFBOX-5773:
--

 Summary: Add leading "0" for octal values in MacOSRomanEncoding
 Key: PDFBOX-5773
 URL: https://issues.apache.org/jira/browse/PDFBOX-5773
 Project: PDFBox
  Issue Type: Bug
  Components: FontBox
Affects Versions: 3.0.1 PDFBox, 2.0.30, 4.0.0
Reporter: Andreas Lehmkühler
Assignee: Andreas Lehmkühler
 Fix For: 2.0.31, 3.0.2 PDFBox, 4.0.0


In {{org.apache.pdfbox.pdmodel.font.encoding.MacOSRomanEncoding}} the leading 
"0" for all octal values is missing, see 
https://github.com/apache/pdfbox/pull/186



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: [PR] Guard PDRange constructors against invalid ranges [pdfbox]

2024-02-21 Thread via GitHub 


pingpingy1 closed pull request #176: Guard PDRange constructors against invalid 
ranges
URL: https://github.com/apache/pdfbox/pull/176


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is back to normal : PDFBox » PDFBox-trunk » Apache PDFBox parent #2027

2024-02-21 Thread Apache Jenkins Server 
See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is back to normal : PDFBox » PDFBox-trunk #2027

2024-02-21 Thread Apache Jenkins Server 
See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: [PR] suppress warnings for octals, omit trailing blanks [pdfbox]

2024-02-21 Thread via GitHub 


xzel23 commented on code in PR #186:
URL: https://github.com/apache/pdfbox/pull/186#discussion_r1498274646


##
pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacExpertEncoding.java:
##
@@ -27,6 +27,7 @@ public class MacExpertEncoding extends Encoding
 /**
  * Table of octal character codes and their corresponding names.
  */
+@SuppressWarnings("OctalInteger")

Review Comment:
   I think that's IntelliJ specific and might in turn produce a warning in 
other IDEs.



##
pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacOSRomanEncoding.java:
##
@@ -27,7 +27,9 @@ public class MacOSRomanEncoding extends MacRomanEncoding
 /**
  * Table of octal character codes and their corresponding names
  * on top of {@link MacRomanEncoding}.
+ * ToDo are these really octals?? leading 0 seems to be missing

Review Comment:
   Good catch!



##
pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/Encoding.java:
##
@@ -159,23 +159,18 @@ public boolean contains(int code)
 
 /**
  * This will take a character code and get the name from the code.
- * 
+ *
  * @param code character code
- * @return PostScript glyph name
+ * @return PostScript glyph name, or ".notdef" when not found.
  */
 public String getName(int code)
 {
-   String name = codeToName.get(code);
-   if (name != null)
-   {
-  return name;
-   }
-   return ".notdef";
+   return codeToName.getOrDefault(code, ".notdef");

Review Comment:
   getOrDefault() is available from Java 8 on, ok for PDFBox  3+.



##
pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacRomanEncoding.java:
##
@@ -29,6 +29,7 @@ public class MacRomanEncoding extends Encoding
 /**
  * Table of octal character codes and their corresponding names.
  */
+@SuppressWarnings("OctalInteger")

Review Comment:
   same as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[PR] suppress warnings for octals, omit trailing blanks [pdfbox]

2024-02-21 Thread via GitHub 


DvonHolten opened a new pull request, #186:
URL: https://github.com/apache/pdfbox/pull/186

   - suppress warnings on octal constants in Encoding-tables
   - ToDo potential error: missing leading 0 in MacOSRomanEncoding.java
   - drop trailing blanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Build failed in Jenkins: PDFBox » PDFBox-trunk » Apache PDFBox parent #2026

2024-02-21 Thread Apache Jenkins Server 
See 


Changes:


--
[...truncated 35.96 KB...]
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/com/fasterxml/jackson/datatype/jackson-datatype-jsr310/2.16.0/jackson-datatype-jsr310-2.16.0.jar
 (128 kB at 815 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/com/fasterxml/jackson/module/jackson-module-afterburner/2.16.0/jackson-module-afterburner-2.16.0.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/jsoup/jsoup/1.16.2/jsoup-1.16.2.jar 
(452 kB at 2.7 MB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/com/fasterxml/jackson/module/jackson-module-blackbird/2.16.0/jackson-module-blackbird-2.16.0.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/com/fasterxml/jackson/module/jackson-module-afterburner/2.16.0/jackson-module-afterburner-2.16.0.jar
 (218 kB at 1.2 MB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/com/fasterxml/jackson/dataformat/jackson-dataformat-yaml/2.16.0/jackson-dataformat-yaml-2.16.0.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/com/fasterxml/jackson/core/jackson-core/2.16.0/jackson-core-2.16.0.jar
 (579 kB at 3.3 MB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/yaml/snakeyaml/2.2/snakeyaml-2.2.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/com/fasterxml/jackson/core/jackson-databind/2.16.0/jackson-databind-2.16.0.jar
 (1.6 MB at 8.8 MB/s)
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/com/fasterxml/jackson/module/jackson-module-blackbird/2.16.0/jackson-module-blackbird-2.16.0.jar
 (65 kB at 350 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/com/esotericsoftware/minlog/1.3.1/minlog-1.3.1.jar
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/com/h3xstream/retirejs/retirejs-core/3.0.4/retirejs-core-3.0.4.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/com/esotericsoftware/minlog/1.3.1/minlog-1.3.1.jar
 (5.9 kB at 32 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/com/github/spullara/mustache/java/compiler/0.9.6/compiler-0.9.6.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/com/github/spullara/mustache/java/compiler/0.9.6/compiler-0.9.6.jar
 (101 kB at 517 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/sonatype/ossindex/ossindex-service-client/1.8.2/ossindex-service-client-1.8.2.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/com/fasterxml/jackson/dataformat/jackson-dataformat-yaml/2.16.0/jackson-dataformat-yaml-2.16.0.jar
 (55 kB at 295 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/sonatype/ossindex/ossindex-service-api/1.8.2/ossindex-service-api-1.8.2.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/yaml/snakeyaml/2.2/snakeyaml-2.2.jar 
(334 kB at 1.7 MB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/com/google/code/gson/gson/2.9.0/gson-2.9.0.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/sonatype/ossindex/ossindex-service-api/1.8.2/ossindex-service-api-1.8.2.jar
 (31 kB at 153 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/com/google/guava/guava/32.1.3-jre/guava-32.1.3-jre.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/sonatype/ossindex/ossindex-service-client/1.8.2/ossindex-service-client-1.8.2.jar
 (53 kB at 260 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/checkerframework/checker-qual/3.37.0/checker-qual-3.37.0.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/com/h3xstream/retirejs/retirejs-core/3.0.4/retirejs-core-3.0.4.jar
 (34 kB at 161 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/com/google/errorprone/error_prone_annotations/2.21.1/error_prone_annotations-2.21.1.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/com/google/errorprone/error_prone_annotations/2.21.1/error_prone_annotations-2.21.1.jar
 (17 kB at 77 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/com/moandjiezana/toml/toml4j/0.7.2/toml4j-0.7.2.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/com/google/code/gson/gson/2.9.0/gson-2.9.0.jar
 (249 kB at 1.1 MB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/com/hankcs/aho-corasick-double-array-trie/1.2.3/aho-corasick-double-array-trie-1.2.3.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/checkerframework/checker-qual/3.37.0/checker-qual-3.37.0.jar
 (224 kB at 947 kB/s)
[INFO]

Build failed in Jenkins: PDFBox » PDFBox-trunk #2026

2024-02-21 Thread Apache Jenkins Server 
See 


Changes:

[Tilman Hausherr] PDFBOX-5772, DSS-3269: ignore page option when signature 
field already exists, as suggested by Michael Klink

[Tilman Hausherr] PDFBOX-5768: fix escapes, by Saurav Rawat


--
[...truncated 44.95 KB...]
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-api-meta/4.0.0-alpha-7/maven-api-meta-4.0.0-alpha-7.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-api-xml/4.0.0-alpha-7/maven-api-xml-4.0.0-alpha-7.jar
 (8.4 kB at 28 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/jetbrains/annotations/24.1.0/annotations-24.1.0.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/lucene/lucene-core/8.11.2/lucene-core-8.11.2.jar
 (3.6 MB at 11 MB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/com/github/spotbugs/spotbugs-annotations/4.8.0/spotbugs-annotations-4.8.0.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/jetbrains/annotations/24.1.0/annotations-24.1.0.jar
 (31 kB at 97 kB/s)
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/com/github/spotbugs/spotbugs-annotations/4.8.0/spotbugs-annotations-4.8.0.jar
 (15 kB at 48 kB/s)
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-api-meta/4.0.0-alpha-7/maven-api-meta-4.0.0-alpha-7.jar
 (12 kB at 34 kB/s)
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/bouncycastle/bcprov-jdk18on/1.71/bcprov-jdk18on-1.71.jar
 (6.1 MB at 15 MB/s)
[INFO] Checking for updates
[WARNING] An NVD API Key was not provided - it is highly recommended to use an 
NVD API key as the update can take a VERY long time without an API Key
[INFO] NVD API has 239,107 records in this update
[INFO] Downloaded 10,000/239,107 (4%)
[INFO] Downloaded 20,000/239,107 (8%)
[INFO] Downloaded 30,000/239,107 (13%)
[INFO] Downloaded 40,000/239,107 (17%)
[INFO] Downloaded 50,000/239,107 (21%)
[INFO] Downloaded 60,000/239,107 (25%)
[INFO] Downloaded 70,000/239,107 (29%)
[INFO] Downloaded 80,000/239,107 (33%)
[INFO] Downloaded 90,000/239,107 (38%)
[INFO] Downloaded 100,000/239,107 (42%)
[INFO] Downloaded 110,000/239,107 (46%)
[INFO] Downloaded 120,000/239,107 (50%)
[INFO] Downloaded 130,000/239,107 (54%)
[INFO] Downloaded 140,000/239,107 (59%)
[INFO] Downloaded 150,000/239,118 (63%)
[INFO] Downloaded 160,000/239,118 (67%)
[INFO] Downloaded 170,000/239,118 (71%)
[INFO] Downloaded 180,000/239,118 (75%)
[INFO] Downloaded 190,000/239,118 (79%)
[INFO] Downloaded 200,000/239,118 (84%)
[INFO] Downloaded 210,000/239,118 (88%)
[INFO] Downloaded 220,000/239,118 (92%)
[INFO] Downloaded 230,000/239,118 (96%)
[INFO] Downloaded 240,000/239,118 (100%)
[INFO] Downloaded 239,118/239,118 (100%)
[INFO] Completed processing batch 1/120 (1%) in 2,728ms
[INFO] Completed processing batch 2/120 (2%) in 1,985ms
[INFO] Completed processing batch 3/120 (3%) in 2,066ms
[INFO] Completed processing batch 4/120 (3%) in 1,797ms
[INFO] Completed processing batch 5/120 (4%) in 2,051ms
[INFO] Completed processing batch 6/120 (5%) in 2,061ms
[INFO] Completed processing batch 7/120 (6%) in 1,650ms
[INFO] Completed processing batch 8/120 (7%) in 1,441ms
[INFO] Completed processing batch 9/120 (8%) in 1,607ms
[INFO] Completed processing batch 10/120 (8%) in 2,015ms
[INFO] Completed processing batch 11/120 (9%) in 1,495ms
[INFO] Completed processing batch 12/120 (10%) in 1,509ms
[INFO] Completed processing batch 13/120 (11%) in 1,222ms
[INFO] Completed processing batch 14/120 (12%) in 1,809ms
[INFO] Completed processing batch 15/120 (13%) in 1,387ms
[INFO] Completed processing batch 16/120 (13%) in 1,714ms
[INFO] Completed processing batch 17/120 (14%) in 1,784ms
[INFO] Completed processing batch 18/120 (15%) in 1,793ms
[INFO] Completed processing batch 19/120 (16%) in 2,368ms
[INFO] Completed processing batch 20/120 (17%) in 2,458ms
[INFO] Completed processing batch 21/120 (18%) in 2,581ms
[INFO] Completed processing batch 22/120 (18%) in 2,345ms
[INFO] Completed processing batch 23/120 (19%) in 3,083ms
[INFO] Completed processing batch 24/120 (20%) in 4,216ms
[INFO] Completed processing batch 25/120 (21%) in 2,335ms
[INFO] Completed processing batch 26/120 (22%) in 2,788ms
[INFO] Completed processing batch 27/120 (23%) in 3,455ms
[INFO] Completed processing batch 28/120 (23%) in 2,335ms
[INFO] Completed processing batch 29/120 (24%) in 2,469ms
[INFO] Completed processing batch 30/120 (25%) in 2,145ms
[INFO] Completed processing batch 31/120 (26%) in 2,234ms
[INFO] Completed processing batch 32/120 (27%) in 2,152ms
[INFO] Completed processing batch 33/120 (28%) in 1,353ms
[INFO] Completed processing batch 34/120 (28%) in 1,268ms
[INFO] Completed processing batch 35/120 (29%) in 1,500ms
[INFO] Completed

Re: [PR] Enable Native Markdown Extraction in Apache PDFBox [pdfbox]

2024-02-21 Thread via GitHub 


rawatsaurav01 commented on PR #180:
URL: https://github.com/apache/pdfbox/pull/180#issuecomment-1957377183

   Thank you @THausherr for your acknowledgement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: [PR] some ToDo s to make things better [pdfbox]

2024-02-21 Thread via GitHub 


DvonHolten closed pull request #184: some ToDo s to make things better
URL: https://github.com/apache/pdfbox/pull/184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5772) Inconsistent signature page handling when signing in existing signature fields

2024-02-21 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/PDFBOX-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819286#comment-17819286
 ] 

ASF subversion and git services commented on PDFBOX-5772:
-

Commit 1915922 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1915922 ]

PDFBOX-5772, DSS-3269: ignore page option when signature field already exists, 
as suggested by Michael Klink

> Inconsistent signature page handling when signing in existing signature fields
> --
>
> Key: PDFBOX-5772
> URL: https://issues.apache.org/jira/browse/PDFBOX-5772
> Project: PDFBox
>  Issue Type: Bug
>  Components: Signing
>Affects Versions: 2.0.30, 3.0.1 PDFBox
>Reporter: Michael Klink
>Priority: Major
> Fix For: 2.0.31, 3.0.2 PDFBox, 4.0.0
>
>
> In eSig DSS issue DSS-3269 - 
> [https://ec.europa.eu/digital-building-blocks/tracker/browse/DSS-3269] - it 
> became apparent that {{PDDocument.addSignature(PDSignature, 
> SignatureInterface, SignatureOptions)}} does not consistently handle the 
> signature page while signing in existing signature fields:
> On one hand that method does look for an existing signature field of the 
> given name and - if found - explicitly does not overwrite the link to the 
> page of the widget. This implies that existing signature fields are supported 
> as they are and are not to be re-located.
> On the other hand that method unconditionally adds the signature widget to 
> the page indicated by the signature option page number.
> In the linked DSS issue this causes signing an existing signature field on 
> different page than in the options to appear both on the original page and 
> the option page which is not desired.
> Expected behavior would be that in case of an existing signature field and 
> widget 
> * either the signature option page is ignored and only the current page of 
> the signature field is used
> * or the field widget consequentially is used to the signature option page, 
> removing it from its original page.
> The natural option would be the former one.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5772) Inconsistent signature page handling when signing in existing signature fields

2024-02-21 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/PDFBOX-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819288#comment-17819288
 ] 

ASF subversion and git services commented on PDFBOX-5772:
-

Commit 1915924 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1915924 ]

PDFBOX-5772, DSS-3269: ignore page option when signature field already exists, 
as suggested by Michael Klink

> Inconsistent signature page handling when signing in existing signature fields
> --
>
> Key: PDFBOX-5772
> URL: https://issues.apache.org/jira/browse/PDFBOX-5772
> Project: PDFBox
>  Issue Type: Bug
>  Components: Signing
>Affects Versions: 2.0.30, 3.0.1 PDFBox
>Reporter: Michael Klink
>Priority: Major
> Fix For: 2.0.31, 3.0.2 PDFBox, 4.0.0
>
>
> In eSig DSS issue DSS-3269 - 
> [https://ec.europa.eu/digital-building-blocks/tracker/browse/DSS-3269] - it 
> became apparent that {{PDDocument.addSignature(PDSignature, 
> SignatureInterface, SignatureOptions)}} does not consistently handle the 
> signature page while signing in existing signature fields:
> On one hand that method does look for an existing signature field of the 
> given name and - if found - explicitly does not overwrite the link to the 
> page of the widget. This implies that existing signature fields are supported 
> as they are and are not to be re-located.
> On the other hand that method unconditionally adds the signature widget to 
> the page indicated by the signature option page number.
> In the linked DSS issue this causes signing an existing signature field on 
> different page than in the options to appear both on the original page and 
> the option page which is not desired.
> Expected behavior would be that in case of an existing signature field and 
> widget 
> * either the signature option page is ignored and only the current page of 
> the signature field is used
> * or the field widget consequentially is used to the signature option page, 
> removing it from its original page.
> The natural option would be the former one.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5772) Inconsistent signature page handling when signing in existing signature fields

2024-02-21 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/PDFBOX-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819287#comment-17819287
 ] 

ASF subversion and git services commented on PDFBOX-5772:
-

Commit 1915923 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1915923 ]

PDFBOX-5772, DSS-3269: ignore page option when signature field already exists, 
as suggested by Michael Klink

> Inconsistent signature page handling when signing in existing signature fields
> --
>
> Key: PDFBOX-5772
> URL: https://issues.apache.org/jira/browse/PDFBOX-5772
> Project: PDFBox
>  Issue Type: Bug
>  Components: Signing
>Affects Versions: 2.0.30, 3.0.1 PDFBox
>Reporter: Michael Klink
>Priority: Major
> Fix For: 2.0.31, 3.0.2 PDFBox, 4.0.0
>
>
> In eSig DSS issue DSS-3269 - 
> [https://ec.europa.eu/digital-building-blocks/tracker/browse/DSS-3269] - it 
> became apparent that {{PDDocument.addSignature(PDSignature, 
> SignatureInterface, SignatureOptions)}} does not consistently handle the 
> signature page while signing in existing signature fields:
> On one hand that method does look for an existing signature field of the 
> given name and - if found - explicitly does not overwrite the link to the 
> page of the widget. This implies that existing signature fields are supported 
> as they are and are not to be re-located.
> On the other hand that method unconditionally adds the signature widget to 
> the page indicated by the signature option page number.
> In the linked DSS issue this causes signing an existing signature field on 
> different page than in the options to appear both on the original page and 
> the option page which is not desired.
> Expected behavior would be that in case of an existing signature field and 
> widget 
> * either the signature option page is ignored and only the current page of 
> the signature field is used
> * or the field widget consequentially is used to the signature option page, 
> removing it from its original page.
> The natural option would be the former one.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: [PR] Enable Native Markdown Extraction in Apache PDFBox [pdfbox]

2024-02-21 Thread via GitHub 


THausherr commented on PR #180:
URL: https://github.com/apache/pdfbox/pull/180#issuecomment-1956613451

   Thank you, I've simplified this and committed it. If there isn't any further 
input then I'll commit to versions 2 and 3 in a few days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5768) Enable Native Markdown Extraction in Apache PDFBox

2024-02-21 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/PDFBOX-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819234#comment-17819234
 ] 

ASF subversion and git services commented on PDFBOX-5768:
-

Commit 1915921 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1915921 ]

PDFBOX-5768: fix escapes, by Saurav Rawat

> Enable Native Markdown Extraction in Apache PDFBox
> --
>
> Key: PDFBOX-5768
> URL: https://issues.apache.org/jira/browse/PDFBOX-5768
> Project: PDFBox
>  Issue Type: New Feature
>  Components: Utilities
>Affects Versions: 2.0.30, 3.0.1 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Minor
>  Labels: markdown
> Fix For: 2.0.31, 3.0.2 PDFBox, 4.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is back to normal : PDFBox » PDFBox-trunk #2025

2024-02-21 Thread Apache Jenkins Server 
See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is back to normal : PDFBox » PDFBox-trunk » Apache PDFBox parent #2025

2024-02-21 Thread Apache Jenkins Server 
See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Build failed in Jenkins: PDFBox » PDFBox-trunk » Apache PDFBox parent #2024

2024-02-21 Thread Apache Jenkins Server 
See 


Changes:


--
[...truncated 260.81 KB...]
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/io/github/jeremylong/jcs3-slf4j/1.0.5/jcs3-slf4j-1.0.5.jar
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-xml/4.0.2/plexus-xml-4.0.2.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-xml/4.0.2/plexus-xml-4.0.2.jar
 (89 kB at 329 kB/s)
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/io/github/jeremylong/jcs3-slf4j/1.0.5/jcs3-slf4j-1.0.5.jar
 (5.7 kB at 21 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-xml-impl/4.0.0-alpha-7/maven-xml-impl-4.0.0-alpha-7.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/commons/commons-jcs3-core/3.2/commons-jcs3-core-3.2.jar
 (543 kB at 2.0 MB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-api-xml/4.0.0-alpha-7/maven-api-xml-4.0.0-alpha-7.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-xml-impl/4.0.0-alpha-7/maven-xml-impl-4.0.0-alpha-7.jar
 (19 kB at 71 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-api-meta/4.0.0-alpha-7/maven-api-meta-4.0.0-alpha-7.jar
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/sonatype/plexus/plexus-sec-dispatcher/1.4/plexus-sec-dispatcher-1.4.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-api-meta/4.0.0-alpha-7/maven-api-meta-4.0.0-alpha-7.jar
 (12 kB at 40 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/shared/maven-dependency-tree/3.2.1/maven-dependency-tree-3.2.1.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/sonatype/plexus/plexus-sec-dispatcher/1.4/plexus-sec-dispatcher-1.4.jar
 (28 kB at 97 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/shared/maven-artifact-transfer/0.13.1/maven-artifact-transfer-0.13.1.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-api-xml/4.0.0-alpha-7/maven-api-xml-4.0.0-alpha-7.jar
 (8.4 kB at 29 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-core/3.1.0/maven-core-3.1.0.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/shared/maven-dependency-tree/3.2.1/maven-dependency-tree-3.2.1.jar
 (43 kB at 148 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-settings/3.1.0/maven-settings-3.1.0.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-settings/3.1.0/maven-settings-3.1.0.jar
 (47 kB at 160 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-settings-builder/3.1.0/maven-settings-builder-3.1.0.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-settings-builder/3.1.0/maven-settings-builder-3.1.0.jar
 (41 kB at 139 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-repository-metadata/3.1.0/maven-repository-metadata-3.1.0.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/shared/maven-artifact-transfer/0.13.1/maven-artifact-transfer-0.13.1.jar
 (159 kB at 527 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-plugin-api/3.1.0/maven-plugin-api-3.1.0.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-repository-metadata/3.1.0/maven-repository-metadata-3.1.0.jar
 (30 kB at 98 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-model-builder/3.1.0/maven-model-builder-3.1.0.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-plugin-api/3.1.0/maven-plugin-api-3.1.0.jar
 (50 kB at 160 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-aether-provider/3.1.0/maven-aether-provider-3.1.0.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-model-builder/3.1.0/maven-model-builder-3.1.0.jar
 (159 kB at 508 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/eclipse/sisu/org.eclipse.sisu.plexus/0.0.0.M2a/org.eclipse.sisu.plexus-0.0.0.M2a.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/eclipse/sisu/org.eclipse.sisu.plexus/0.0.0.M2a/org.eclipse.sisu.plexus-0.0.0.M2a.jar

Build failed in Jenkins: PDFBox » PDFBox-trunk #2024

2024-02-21 Thread Apache Jenkins Server 
See 


Changes:

[Tilman Hausherr] PDFBOX-5660: update shade plugin


--
[...truncated 270.03 KB...]
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/jetbrains/annotations/24.1.0/annotations-24.1.0.jar
 (31 kB at 85 kB/s)
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar
 (20 kB at 54 kB/s)
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/com/github/spotbugs/spotbugs-annotations/4.8.0/spotbugs-annotations-4.8.0.jar
 (15 kB at 41 kB/s)
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/com/google/guava/guava/32.1.3-jre/guava-32.1.3-jre.jar
 (3.0 MB at 8.1 MB/s)
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/sonatype/sisu/sisu-guice/2.1.7/sisu-guice-2.1.7-noaop.jar
 (472 kB at 1.2 MB/s)
[INFO] Downloaded from central: 
https://repo.maven.apache.org/maven2/org/bouncycastle/bcprov-jdk18on/1.71/bcprov-jdk18on-1.71.jar
 (6.1 MB at 13 MB/s)
[INFO] Checking for updates
[WARNING] An NVD API Key was not provided - it is highly recommended to use an 
NVD API key as the update can take a VERY long time without an API Key
[INFO] NVD API has 239,086 records in this update
[INFO] Downloaded 10,000/239,086 (4%)
[INFO] Downloaded 20,000/239,086 (8%)
[INFO] Downloaded 30,000/239,086 (13%)
[INFO] Downloaded 40,000/239,086 (17%)
[INFO] Downloaded 50,000/239,086 (21%)
[INFO] Downloaded 60,000/239,086 (25%)
[INFO] Downloaded 70,000/239,086 (29%)
[INFO] Downloaded 80,000/239,086 (33%)
[INFO] Downloaded 90,000/239,086 (38%)
[INFO] Downloaded 100,000/239,086 (42%)
[INFO] Downloaded 110,000/239,086 (46%)
[INFO] Downloaded 120,000/239,086 (50%)
[INFO] Downloaded 130,000/239,086 (54%)
[INFO] Downloaded 140,000/239,086 (59%)
[INFO] Downloaded 150,000/239,086 (63%)
[INFO] Downloaded 160,000/239,086 (67%)
[INFO] Downloaded 170,000/239,086 (71%)
[INFO] Downloaded 180,000/239,086 (75%)
[INFO] Downloaded 190,000/239,086 (79%)
[INFO] Downloaded 200,000/239,086 (84%)
[INFO] Downloaded 210,000/239,086 (88%)
[INFO] Downloaded 220,000/239,086 (92%)
[INFO] Downloaded 230,000/239,086 (96%)
[INFO] Downloaded 240,000/239,086 (100%)
[INFO] Downloaded 239,086/239,086 (100%)
[INFO] Completed processing batch 1/120 (1%) in 2,315ms
[INFO] Completed processing batch 2/120 (2%) in 2,010ms
[INFO] Completed processing batch 3/120 (3%) in 1,874ms
[INFO] Completed processing batch 4/120 (3%) in 1,850ms
[INFO] Completed processing batch 5/120 (4%) in 2,016ms
[INFO] Completed processing batch 6/120 (5%) in 1,755ms
[INFO] Completed processing batch 7/120 (6%) in 1,637ms
[INFO] Completed processing batch 8/120 (7%) in 1,677ms
[INFO] Completed processing batch 9/120 (8%) in 1,330ms
[INFO] Completed processing batch 10/120 (8%) in 1,639ms
[INFO] Completed processing batch 11/120 (9%) in 1,267ms
[INFO] Completed processing batch 12/120 (10%) in 1,374ms
[INFO] Completed processing batch 13/120 (11%) in 1,277ms
[INFO] Completed processing batch 14/120 (12%) in 1,414ms
[INFO] Completed processing batch 15/120 (13%) in 1,366ms
[INFO] Completed processing batch 16/120 (13%) in 1,470ms
[INFO] Completed processing batch 17/120 (14%) in 1,887ms
[INFO] Completed processing batch 18/120 (15%) in 1,672ms
[INFO] Completed processing batch 19/120 (16%) in 2,130ms
[INFO] Completed processing batch 20/120 (17%) in 2,097ms
[INFO] Completed processing batch 21/120 (18%) in 2,530ms
[INFO] Completed processing batch 22/120 (18%) in 2,375ms
[INFO] Completed processing batch 23/120 (19%) in 3,507ms
[INFO] Completed processing batch 24/120 (20%) in 2,912ms
[INFO] Completed processing batch 25/120 (21%) in 2,497ms
[INFO] Completed processing batch 26/120 (22%) in 2,951ms
[INFO] Completed processing batch 27/120 (23%) in 2,821ms
[INFO] Completed processing batch 28/120 (23%) in 3,440ms
[INFO] Completed processing batch 29/120 (24%) in 2,301ms
[INFO] Completed processing batch 30/120 (25%) in 2,096ms
[INFO] Completed processing batch 31/120 (26%) in 2,102ms
[INFO] Completed processing batch 32/120 (27%) in 1,771ms
[INFO] Completed processing batch 33/120 (28%) in 1,678ms
[INFO] Completed processing batch 34/120 (28%) in 1,425ms
[INFO] Completed processing batch 35/120 (29%) in 1,514ms
[INFO] Completed processing batch 36/120 (30%) in 1,513ms
[INFO] Completed processing batch 37/120 (31%) in 1,030ms
[INFO] Completed processing batch 38/120 (32%) in 1,479ms
[INFO] Completed processing batch 39/120 (33%) in 1,266ms
[INFO] Completed processing batch 40/120 (33%) in 1,031ms
[INFO] Completed processing batch 41/120 (34%) in 1,375ms
[INFO] Completed processing batch 42/120 (35%) in 894ms
[INFO] Completed processing batch 43/120 (36%) in 1,507ms
[INFO] Completed processing batch

[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-02-21 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819126#comment-17819126
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1915915 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1915915 ]

PDFBOX-5660: update shade plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-02-21 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819124#comment-17819124
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1915914 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1915914 ]

PDFBOX-5660: update shade plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org