[jira] [Comment Edited] (PDFBOX-4095) Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)

2018-05-22 Thread Tilman Hausherr (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484352#comment-16484352
 ] 

Tilman Hausherr edited comment on PDFBOX-4095 at 5/22/18 8:34 PM:
--

Thanks... Differences:

A-Designers-Guide-to-Transparency-2007.pdf, p7: better
A-Designers-Guide-to-Transparency-2007.pdf, p12: better
gs-bugzilla690477.pdf: now perfect
blendmodes.pdf: now perfect
blendmodes-rgb.pdf: now perfect
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p4: better
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p7: hard to 
tell, probably better (the C's)
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to 
tell, very slight difference
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to tell
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p2: 16.0 now perfect, 16.1 and 16.2 
different 
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p5: 16.4 better, 16.1 different 
gs-bugzilla689095.pdf: better
gs-bugzilla697433-1.pdf: better
PDFJS-6924.pdf: probably perfect now
pop-bugzilla93476.pdf: better
Transparency_DesignGuide-2004.pdf, p11: better
Transparency_DesignGuide-2004.pdf, p17: better
Transparency_DesignGuide-2004.pdf, p20: better

So it's good :-)  I'll have a look at the code tomorrow and commit.


was (Author: tilman):
Thanks... I'll have a look at the differences and post them here. This will 
take some time

A-Designers-Guide-to-Transparency-2007.pdf, p7: better
A-Designers-Guide-to-Transparency-2007.pdf, p12: better
gs-bugzilla690477.pdf: now perfect
blendmodes.pdf: now perfect
blendmodes-rgb.pdf: now perfect
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p4: better
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p7: hard to 
tell, probably better (the C's)
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to 
tell, very slight difference
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to tell
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p2: 16.0 now perfect, 16.1 and 16.2 
different 
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p5: 16.4 better, 16.1 different 
gs-bugzilla689095.pdf: better
gs-bugzilla697433-1.pdf: better
PDFJS-6924.pdf: probably perfect now
pop-bugzilla93476.pdf: better

...

> Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)
> 
>
> Key: PDFBOX-4095
> URL: https://issues.apache.org/jira/browse/PDFBOX-4095
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Rendering
>Affects Versions: 2.0.8
>Reporter: savan patel
>Priority: Major
> Attachments: A-Designers-Guide-to-Transparency-2007.pdf, 
> BlendComposite-2.patch, BlendComposite.java.patch, BlendMode-2.patch, 
> BlendMode.java.patch, COSName.java.patch, Transparency_DesignGuide-2004.pdf, 
> blendmodes.pdf, gs-bugzilla689095.pdf, gs-bugzilla690477.pdf, 
> gs-bugzilla695975.pdf, gs-bugzilla697433-1.pdf, hue-not-committed.patch
>
>
> I have a patch for implementation of non separable blend modes...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Comment Edited] (PDFBOX-4095) Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)

2018-05-22 Thread Tilman Hausherr (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484352#comment-16484352
 ] 

Tilman Hausherr edited comment on PDFBOX-4095 at 5/22/18 7:48 PM:
--

Thanks... I'll have a look at the differences and post them here. This will 
take some time

A-Designers-Guide-to-Transparency-2007.pdf, p7: better
A-Designers-Guide-to-Transparency-2007.pdf, p12: better
gs-bugzilla690477.pdf: now perfect
blendmodes.pdf: now perfect
blendmodes-rgb.pdf: now perfect
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p4: better
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p7: hard to 
tell, probably better (the C's)
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to 
tell, very slight difference
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to tell
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p2: 16.0 now perfect, 16.1 and 16.2 
different 
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p5: 16.4 better, 16.1 different 
gs-bugzilla689095.pdf: better
gs-bugzilla697433-1.pdf: better
PDFJS-6924.pdf: probably perfect now
pop-bugzilla93476.pdf: better

...


was (Author: tilman):
Thanks... I'll have a look at the differences and post them here. This will 
take some time

A-Designers-Guide-to-Transparency-2007.pdf, p7: better
A-Designers-Guide-to-Transparency-2007.pdf, p12: better
gs-bugzilla690477.pdf: now perfect
blendmodes.pdf: now perfect
blendmodes-rgb.pdf: now perfect
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p4: better
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p7: hard to 
tell, probably better (the C's)
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to 
tell, very slight difference
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to tell
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p2: 16.0 now perfect, 16.1 and 16.2 
different 
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p5: 16.4 better, 16.1 different 
gs-bugzilla689095.pdf: better
gs-bugzilla697433-1.pdf: better
PDFJS-6924.pdf: probably perfect now

...

> Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)
> 
>
> Key: PDFBOX-4095
> URL: https://issues.apache.org/jira/browse/PDFBOX-4095
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Rendering
>Affects Versions: 2.0.8
>Reporter: savan patel
>Priority: Major
> Attachments: A-Designers-Guide-to-Transparency-2007.pdf, 
> BlendComposite-2.patch, BlendComposite.java.patch, BlendMode-2.patch, 
> BlendMode.java.patch, COSName.java.patch, Transparency_DesignGuide-2004.pdf, 
> blendmodes.pdf, gs-bugzilla689095.pdf, gs-bugzilla690477.pdf, 
> gs-bugzilla695975.pdf, gs-bugzilla697433-1.pdf, hue-not-committed.patch
>
>
> I have a patch for implementation of non separable blend modes...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Comment Edited] (PDFBOX-4095) Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)

2018-05-22 Thread Tilman Hausherr (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484352#comment-16484352
 ] 

Tilman Hausherr edited comment on PDFBOX-4095 at 5/22/18 7:46 PM:
--

Thanks... I'll have a look at the differences and post them here. This will 
take some time

A-Designers-Guide-to-Transparency-2007.pdf, p7: better
A-Designers-Guide-to-Transparency-2007.pdf, p12: better
gs-bugzilla690477.pdf: now perfect
blendmodes.pdf: now perfect
blendmodes-rgb.pdf: now perfect
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p4: better
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p7: hard to 
tell, probably better (the C's)
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to 
tell, very slight difference
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to tell
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p2: 16.0 now perfect, 16.1 and 16.2 
different 
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p5: 16.4 better, 16.1 different 
gs-bugzilla689095.pdf: better
gs-bugzilla697433-1.pdf: better
PDFJS-6924.pdf: probably perfect now

...


was (Author: tilman):
Thanks... I'll have a look at the differences and post them here. This will 
take some time

A-Designers-Guide-to-Transparency-2007.pdf, p7: better
A-Designers-Guide-to-Transparency-2007.pdf, p12: better
gs-bugzilla690477.pdf: now perfect
blendmodes.pdf: now perfect
blendmodes-rgb.pdf: now perfect
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p4: better
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p7: hard to 
tell, probably better (the C's)
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to 
tell, very slight difference
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to tell
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p2: 16.0 now perfect, 16.1 and 16.2 
different 
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p5: 16.4 better, 16.1 different 
gs-bugzilla689095.pdf: better
gs-bugzilla697433-1.pdf: better

...

> Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)
> 
>
> Key: PDFBOX-4095
> URL: https://issues.apache.org/jira/browse/PDFBOX-4095
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Rendering
>Affects Versions: 2.0.8
>Reporter: savan patel
>Priority: Major
> Attachments: A-Designers-Guide-to-Transparency-2007.pdf, 
> BlendComposite-2.patch, BlendComposite.java.patch, BlendMode-2.patch, 
> BlendMode.java.patch, COSName.java.patch, Transparency_DesignGuide-2004.pdf, 
> blendmodes.pdf, gs-bugzilla689095.pdf, gs-bugzilla690477.pdf, 
> gs-bugzilla695975.pdf, gs-bugzilla697433-1.pdf, hue-not-committed.patch
>
>
> I have a patch for implementation of non separable blend modes...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Comment Edited] (PDFBOX-4095) Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)

2018-05-22 Thread Tilman Hausherr (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484352#comment-16484352
 ] 

Tilman Hausherr edited comment on PDFBOX-4095 at 5/22/18 7:41 PM:
--

Thanks... I'll have a look at the differences and post them here. This will 
take some time

A-Designers-Guide-to-Transparency-2007.pdf, p7: better
A-Designers-Guide-to-Transparency-2007.pdf, p12: better
gs-bugzilla690477.pdf: now perfect
blendmodes.pdf: now perfect
blendmodes-rgb.pdf: now perfect
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p4: better
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p7: hard to 
tell, probably better (the C's)
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to 
tell, very slight difference
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to tell
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p2: 16.0 now perfect, 16.1 and 16.2 
different 
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p5: 16.4 better, 16.1 different 
gs-bugzilla689095.pdf: better
gs-bugzilla697433-1.pdf: better

...


was (Author: tilman):
Thanks... I'll have a look at the differences and post them here. This will 
take some time

A-Designers-Guide-to-Transparency-2007.pdf, p7: better
A-Designers-Guide-to-Transparency-2007.pdf, p12: better
gs-bugzilla690477.pdf: now perfect
blendmodes.pdf: now perfect
blendmodes-rgb.pdf: now perfect
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p4: better
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p7: hard to 
tell, probably better (the C's)
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to 
tell, very slight difference
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to tell
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p2: 16.0 now perfect, 16.1 and 16.2 
different 
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p5: 16.4 better, 16.1 different 

...

> Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)
> 
>
> Key: PDFBOX-4095
> URL: https://issues.apache.org/jira/browse/PDFBOX-4095
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Rendering
>Affects Versions: 2.0.8
>Reporter: savan patel
>Priority: Major
> Attachments: A-Designers-Guide-to-Transparency-2007.pdf, 
> BlendComposite-2.patch, BlendComposite.java.patch, BlendMode-2.patch, 
> BlendMode.java.patch, COSName.java.patch, Transparency_DesignGuide-2004.pdf, 
> blendmodes.pdf, gs-bugzilla689095.pdf, gs-bugzilla690477.pdf, 
> gs-bugzilla695975.pdf, gs-bugzilla697433-1.pdf, hue-not-committed.patch
>
>
> I have a patch for implementation of non separable blend modes...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Comment Edited] (PDFBOX-4095) Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)

2018-05-22 Thread Tilman Hausherr (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484352#comment-16484352
 ] 

Tilman Hausherr edited comment on PDFBOX-4095 at 5/22/18 7:05 PM:
--

Thanks... I'll have a look at the differences and post them here. This will 
take some time

A-Designers-Guide-to-Transparency-2007.pdf, p7: better
A-Designers-Guide-to-Transparency-2007.pdf, p12: better
gs-bugzilla690477.pdf: now perfect
blendmodes.pdf: now perfect
blendmodes-rgb.pdf: now perfect
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p4: better
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p7: hard to 
tell, probably better (the C's)
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to 
tell, very slight difference
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to tell
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p2: 16.0 now perfect, 16.1 and 16.2 
different 
Ghent_PDF-Output-Test-V50_ALL_X4.pdf, p5: 16.4 better, 16.1 different 

...


was (Author: tilman):
Thanks... I'll have a look at the differences and post them here. This will 
take some time

A-Designers-Guide-to-Transparency-2007.pdf, p7: better
A-Designers-Guide-to-Transparency-2007.pdf, p12: better
gs-bugzilla690477.pdf: now perfect
blendmodes.pdf: now perfect
blendmodes-rgb.pdf: now perfect
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p4: better
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p7: hard to 
tell, probably better (the C's)
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to 
tell, very slight difference

...

> Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)
> 
>
> Key: PDFBOX-4095
> URL: https://issues.apache.org/jira/browse/PDFBOX-4095
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Rendering
>Affects Versions: 2.0.8
>Reporter: savan patel
>Priority: Major
> Attachments: A-Designers-Guide-to-Transparency-2007.pdf, 
> BlendComposite-2.patch, BlendComposite.java.patch, BlendMode-2.patch, 
> BlendMode.java.patch, COSName.java.patch, Transparency_DesignGuide-2004.pdf, 
> blendmodes.pdf, gs-bugzilla689095.pdf, gs-bugzilla690477.pdf, 
> gs-bugzilla695975.pdf, gs-bugzilla697433-1.pdf, hue-not-committed.patch
>
>
> I have a patch for implementation of non separable blend modes...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Comment Edited] (PDFBOX-4095) Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)

2018-05-22 Thread Tilman Hausherr (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484352#comment-16484352
 ] 

Tilman Hausherr edited comment on PDFBOX-4095 at 5/22/18 6:28 PM:
--

Thanks... I'll have a look at the differences and post them here. This will 
take some time

A-Designers-Guide-to-Transparency-2007.pdf, p7: better
A-Designers-Guide-to-Transparency-2007.pdf, p12: better
gs-bugzilla690477.pdf: now perfect
blendmodes.pdf: now perfect
blendmodes-rgb.pdf: now perfect
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p4: better
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p7: hard to 
tell, probably better (the C's)
eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf, p14: hard to 
tell, very slight difference

...


was (Author: tilman):
Thanks... I'll have a look at the differences and post them here. This will 
take some time

A-Designers-Guide-to-Transparency-2007.pdf, p7: better
A-Designers-Guide-to-Transparency-2007.pdf, p12: better
gs-bugzilla690477.pdf: now perfect
...

> Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)
> 
>
> Key: PDFBOX-4095
> URL: https://issues.apache.org/jira/browse/PDFBOX-4095
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Rendering
>Affects Versions: 2.0.8
>Reporter: savan patel
>Priority: Major
> Attachments: A-Designers-Guide-to-Transparency-2007.pdf, 
> BlendComposite-2.patch, BlendComposite.java.patch, BlendMode-2.patch, 
> BlendMode.java.patch, COSName.java.patch, Transparency_DesignGuide-2004.pdf, 
> blendmodes.pdf, gs-bugzilla689095.pdf, gs-bugzilla690477.pdf, 
> gs-bugzilla695975.pdf, gs-bugzilla697433-1.pdf, hue-not-committed.patch
>
>
> I have a patch for implementation of non separable blend modes...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Comment Edited] (PDFBOX-4095) Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)

2018-05-22 Thread Jani Pehkonen (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484055#comment-16484055
 ] 

Jani Pehkonen edited comment on PDFBOX-4095 at 5/22/18 5:54 PM:


I have improved [~savan]'s patch.
 [^BlendComposite-2.patch] [^BlendMode-2.patch]


was (Author: janipe):
I have improved the patch.
[^BlendComposite-2.patch]  [^BlendMode-2.patch]

> Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)
> 
>
> Key: PDFBOX-4095
> URL: https://issues.apache.org/jira/browse/PDFBOX-4095
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Rendering
>Affects Versions: 2.0.8
>Reporter: savan patel
>Priority: Major
> Attachments: A-Designers-Guide-to-Transparency-2007.pdf, 
> BlendComposite-2.patch, BlendComposite.java.patch, BlendMode-2.patch, 
> BlendMode.java.patch, COSName.java.patch, Transparency_DesignGuide-2004.pdf, 
> blendmodes.pdf, gs-bugzilla689095.pdf, gs-bugzilla690477.pdf, 
> gs-bugzilla695975.pdf, gs-bugzilla697433-1.pdf, hue-not-committed.patch
>
>
> I have a patch for implementation of non separable blend modes...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Comment Edited] (PDFBOX-4095) Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)

2018-03-22 Thread Tilman Hausherr (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350678#comment-16350678
 ] 

Tilman Hausherr edited comment on PDFBOX-4095 at 3/22/18 6:34 PM:
--

Thanks... I tested with many PDFs, there are a lot of differences, some are 
rendered incorrectly (e.g. [^gs-bugzilla690477.pdf])... maybe start with 
 
[http://www.eci.org/_media/downloads/altona_test_suite/eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf]
 there is an exception (IOOB) on page 17. Of course I can't say for sure if it 
is a bug in your change, or if your change uncovered bugs that have been there 
already.

It might also be possible that I messed up something while inserting your code. 
If possible, try attaching real diff / patch files, this avoids any human error.


was (Author: tilman):
Thanks... I tested with many PDFs, there are a lot of differences, some are 
rendered incorrectly (e.g. [^gs-bugzilla690477.pdf])... maybe start with 
 
[http://www.eci.org/_media/downloads/altona_test_suite/eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf]
 there is an exception (IOOB) on one of the last pages. Of course I can't say 
for sure if it is a bug in your change, or if your change uncovered bugs that 
have been there already.

It might also be possible that I messed up something while inserting your code. 
If possible, try attaching real diff / patch files, this avoids any human error.

> Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)
> 
>
> Key: PDFBOX-4095
> URL: https://issues.apache.org/jira/browse/PDFBOX-4095
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Rendering
>Affects Versions: 2.0.8
>Reporter: savan patel
>Priority: Major
> Attachments: BlendComposite.java.patch, BlendMode.java.patch, 
> COSName.java.patch, blendmodes.pdf, gs-bugzilla690477.pdf, 
> gs-bugzilla697433-1.pdf
>
>
> I have a patch for implementation of non separable blend modes...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Comment Edited] (PDFBOX-4095) Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)

2018-02-05 Thread savan patel (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352151#comment-16352151
 ] 

savan patel edited comment on PDFBOX-4095 at 2/5/18 2:12 PM:
-

this isn't any human error i guess,,, i also got error for 
([http://www.eci.org/_media/downloads/altona_test_suite/eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf])
 this pdf,,, and other pdfs are also not rendering properly,,,

so my solution is not working properly...

 

i think issue is opacity... i guess...

 


was (Author: savan):
this isn't any human error i guess,,, i also got error for 
([http://www.eci.org/_media/downloads/altona_test_suite/eci_altona-test-suite-v2_technical2_one-patch-per-page_x4.pdf])
 this pdf,,, and other pdfs are also not rendering properly,,,

so my solution is not working properly...

> Non Separable Blend Modes implementation(HUE, SATURATION, COLOR, LUMINOSITY)
> 
>
> Key: PDFBOX-4095
> URL: https://issues.apache.org/jira/browse/PDFBOX-4095
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Rendering
>Affects Versions: 2.0.8
>Reporter: savan patel
>Priority: Major
> Attachments: BlendComposite.java.patch, BlendMode.java.patch, 
> COSName.java.patch, blendmodes.pdf, gs-bugzilla690477.pdf, 
> gs-bugzilla697433-1.pdf
>
>
> I have a patch for implementation of non separable blend modes...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org