[jira] [Commented] (PDFBOX-3492) Remove classic signing and keep external signing only
[ https://issues.apache.org/jira/browse/PDFBOX-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265103#comment-17265103 ] Maruan Sahyoun commented on PDFBOX-3492: [~tilman] why not resolve it as won't do? > Remove classic signing and keep external signing only > - > > Key: PDFBOX-3492 > URL: https://issues.apache.org/jira/browse/PDFBOX-3492 > Project: PDFBox > Issue Type: Sub-task > Components: Signing >Affects Versions: 3.0.0 PDFBox >Reporter: Tilman Hausherr >Priority: Major > Fix For: 3.0.0 PDFBox > > > to be done later, lets first wait for feedback on the external signing. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3492) Remove classic signing and keep external signing only
[ https://issues.apache.org/jira/browse/PDFBOX-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265095#comment-17265095 ] Tilman Hausherr commented on PDFBOX-3492: - It's now 2021 and I have the same feeling - "did I create this ticket? Why?" > Remove classic signing and keep external signing only > - > > Key: PDFBOX-3492 > URL: https://issues.apache.org/jira/browse/PDFBOX-3492 > Project: PDFBox > Issue Type: Sub-task > Components: Signing >Affects Versions: 3.0.0 PDFBox >Reporter: Tilman Hausherr >Priority: Major > Fix For: 3.0.0 PDFBox > > > to be done later, lets first wait for feedback on the external signing. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3492) Remove classic signing and keep external signing only
[ https://issues.apache.org/jira/browse/PDFBOX-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946152#comment-16946152 ] Tilman Hausherr commented on PDFBOX-3492: - LOL, I created this ticket and today I don't consider it THAT important, nor do I remember it. Maybe there was a discussion about it. External signing means that the signing can be done by an outside application. However the external-signing-code, as it is now, can also be used without having an outside application. See the CreateSignature examples. I suspect that my thought was to have the code only once, because it is two different paths to do the same thing, so we could dump the "old style". In the sample code you'll see that the signing method is always the same. > Remove classic signing and keep external signing only > - > > Key: PDFBOX-3492 > URL: https://issues.apache.org/jira/browse/PDFBOX-3492 > Project: PDFBox > Issue Type: Sub-task > Components: Signing >Affects Versions: 3.0.0 PDFBox >Reporter: Tilman Hausherr >Priority: Major > Fix For: 3.0.0 PDFBox > > > to be done later, lets first wait for feedback on the external signing. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3492) Remove classic signing and keep external signing only
[ https://issues.apache.org/jira/browse/PDFBOX-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946122#comment-16946122 ] Jason Pyeron commented on PDFBOX-3492: -- Can someone expand on or explain this ticket more? > Remove classic signing and keep external signing only > - > > Key: PDFBOX-3492 > URL: https://issues.apache.org/jira/browse/PDFBOX-3492 > Project: PDFBox > Issue Type: Sub-task > Components: Signing >Affects Versions: 3.0.0 PDFBox >Reporter: Tilman Hausherr >Priority: Major > Fix For: 3.0.0 PDFBox > > > to be done later, lets first wait for feedback on the external signing. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3492) Remove classic signing and keep external signing only
[ https://issues.apache.org/jira/browse/PDFBOX-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484649#comment-15484649 ] Andreas Lehmkühler commented on PDFBOX-3492: We are already following the principles of sematic versioning, at least more or less. We are not that strict when it comes to bugfix releases, ours are not limited to fixes only but always contain some improvements aswell. But we are strict about api changes. Sayin that, we need a major release to do such changes. > Remove classic signing and keep external signing only > - > > Key: PDFBOX-3492 > URL: https://issues.apache.org/jira/browse/PDFBOX-3492 > Project: PDFBox > Issue Type: Sub-task > Components: Signing >Affects Versions: 2.1.0 >Reporter: Tilman Hausherr > Fix For: 2.1.0 > > > to be done later, lets first wait for feedback on the external signing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3492) Remove classic signing and keep external signing only
[ https://issues.apache.org/jira/browse/PDFBOX-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483005#comment-15483005 ] John Hewson commented on PDFBOX-3492: - The trend nowadays is to follow [semver](http://semver.org), though perhaps not strictly. > Remove classic signing and keep external signing only > - > > Key: PDFBOX-3492 > URL: https://issues.apache.org/jira/browse/PDFBOX-3492 > Project: PDFBox > Issue Type: Sub-task > Components: Signing >Affects Versions: 2.1.0 >Reporter: Tilman Hausherr > Fix For: 2.1.0 > > > to be done later, lets first wait for feedback on the external signing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3492) Remove classic signing and keep external signing only
[ https://issues.apache.org/jira/browse/PDFBOX-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15482447#comment-15482447 ] Maruan Sahyoun commented on PDFBOX-3492: AFAIK breaking changes can only be made in major releases which means we'd have to wait for 3.x to remove the old stuff. > Remove classic signing and keep external signing only > - > > Key: PDFBOX-3492 > URL: https://issues.apache.org/jira/browse/PDFBOX-3492 > Project: PDFBox > Issue Type: Sub-task > Components: Signing >Affects Versions: 2.1.0 >Reporter: Tilman Hausherr > Fix For: 2.1.0 > > > to be done later, lets first wait for feedback on the external signing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3492) Remove classic signing and keep external signing only
[ https://issues.apache.org/jira/browse/PDFBOX-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480147#comment-15480147 ] John Hewson commented on PDFBOX-3492: - We can't make breaking changes in 2.1 though? Or am I missing something? > Remove classic signing and keep external signing only > - > > Key: PDFBOX-3492 > URL: https://issues.apache.org/jira/browse/PDFBOX-3492 > Project: PDFBox > Issue Type: Sub-task > Components: Signing >Affects Versions: 2.1.0 >Reporter: Tilman Hausherr > Fix For: 2.1.0 > > > to be done later, lets first wait for feedback on the external signing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org