[jira] [Commented] (PDFBOX-4114) ICCBased color spaces wrong color output
[ https://issues.apache.org/jira/browse/PDFBOX-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369384#comment-16369384 ] Tilman Hausherr commented on PDFBOX-4114: - Any solution by Harald Kuhr is good for us. Thanks for finding it. I committed your patch in a slightly modified form. > ICCBased color spaces wrong color output > > > Key: PDFBOX-4114 > URL: https://issues.apache.org/jira/browse/PDFBOX-4114 > Project: PDFBox > Issue Type: Bug > Components: PDModel, Rendering >Affects Versions: 2.0.8 >Reporter: Michael Vakulich >Priority: Major > Fix For: 2.0.9, 3.0.0 PDFBox > > Attachments: ICCBased_updated.patch, compare.jpg, highResPdf-1.jpg, > highResPdf.pdf > > > When rendering page with embedded ICC_profile (DeviceCMYK) it has a wrong > colors, like semitransparent white plane covering the page > See the render output > Tried patches suggested here > [https://forums.adobe.com/thread/1914790] > https://github.com/haraldk/TwelveMonkeys/blob/master/imageio/imageio-jpeg/src/main/java/com/twelvemonkeys/imageio/plugins/jpeg/JPEGImageReader.java > and trying one by one found that problem is connected to profileClass > Here is the one of proposed patches I've found and which worked for me > Please review proposed patch -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4114) ICCBased color spaces wrong color output
[ https://issues.apache.org/jira/browse/PDFBOX-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369374#comment-16369374 ] ASF subversion and git services commented on PDFBOX-4114: - Commit 1824795 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1824795 ] PDFBOX-2917, PDFBOX-4114: fix icc profile that has the wrong display class as done in twelvemonkeys and suggested by Michael Vakulich > ICCBased color spaces wrong color output > > > Key: PDFBOX-4114 > URL: https://issues.apache.org/jira/browse/PDFBOX-4114 > Project: PDFBox > Issue Type: Bug > Components: PDModel, Rendering >Affects Versions: 2.0.8 >Reporter: Michael Vakulich >Priority: Major > Fix For: 2.0.9, 3.0.0 PDFBox > > Attachments: ICCBased_updated.patch, compare.jpg, highResPdf-1.jpg, > highResPdf.pdf > > > When rendering page with embedded ICC_profile (DeviceCMYK) it has a wrong > colors, like semitransparent white plane covering the page > See the render output > Tried patches suggested here > [https://forums.adobe.com/thread/1914790] > https://github.com/haraldk/TwelveMonkeys/blob/master/imageio/imageio-jpeg/src/main/java/com/twelvemonkeys/imageio/plugins/jpeg/JPEGImageReader.java > and trying one by one found that problem is connected to profileClass > Here is the one of proposed patches I've found and which worked for me > Please review proposed patch -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4114) ICCBased color spaces wrong color output
[ https://issues.apache.org/jira/browse/PDFBOX-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369372#comment-16369372 ] ASF subversion and git services commented on PDFBOX-4114: - Commit 1824794 from [~tilman] in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1824794 ] PDFBOX-2917, PDFBOX-4114: fix icc profile that has the wrong display class as done in twelvemonkeys and suggested by Michael Vakulich > ICCBased color spaces wrong color output > > > Key: PDFBOX-4114 > URL: https://issues.apache.org/jira/browse/PDFBOX-4114 > Project: PDFBox > Issue Type: Bug > Components: PDModel, Rendering >Affects Versions: 2.0.8 >Reporter: Michael Vakulich >Priority: Major > Fix For: 2.0.9, 3.0.0 PDFBox > > Attachments: ICCBased_updated.patch, compare.jpg, highResPdf-1.jpg, > highResPdf.pdf > > > When rendering page with embedded ICC_profile (DeviceCMYK) it has a wrong > colors, like semitransparent white plane covering the page > See the render output > Tried patches suggested here > [https://forums.adobe.com/thread/1914790] > https://github.com/haraldk/TwelveMonkeys/blob/master/imageio/imageio-jpeg/src/main/java/com/twelvemonkeys/imageio/plugins/jpeg/JPEGImageReader.java > and trying one by one found that problem is connected to profileClass > Here is the one of proposed patches I've found and which worked for me > Please review proposed patch -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4114) ICCBased color spaces wrong color output
[ https://issues.apache.org/jira/browse/PDFBOX-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368596#comment-16368596 ] Michael Vakulich commented on PDFBOX-4114: -- I don't think that this fix will break things even if jdk will be fixed as soon as fix itself is changing profile class to display, That looks like a pdf issue that it apply profiles to image even if they has wrong display class so we force the profile to be used by jdk. Will correct my description and patch according comments. > ICCBased color spaces wrong color output > > > Key: PDFBOX-4114 > URL: https://issues.apache.org/jira/browse/PDFBOX-4114 > Project: PDFBox > Issue Type: Bug > Components: PDModel, Rendering >Affects Versions: 2.0.8 >Reporter: Michael Vakulich >Priority: Major > Fix For: 2.0.9, 3.0.0 PDFBox > > Attachments: ICCBased.patch, compare.jpg, highResPdf-1.jpg, > highResPdf.pdf > > > When rendering page with embedded ICC_profile (DeviceCMYK) it has a wrong > colors, like semitransparent white plane covering the page > See the render output > Looking across internet I've found that this issue is caused because JSK has > an issue with using profiles which Class is not Display. > Here is the one of proposed patches I've found and which worked for me > Please review proposed patch -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4114) ICCBased color spaces wrong color output
[
https://issues.apache.org/jira/browse/PDFBOX-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368380#comment-16368380
]
Tilman Hausherr commented on PDFBOX-4114:
-
I need some time to review the effects with different jdks and different
configurations (KCMS / LCMS). I ran a rendering diff test and the rendering of
8 files of 1000 are different. One of them was known to have bad rendering
(PDFBOX-2917) and that looks good now, so this is getting interesting :)
Shouldn't {{fixProfile}} be called *after* {{is_sRGB}}?
And what if java has fixed this bug in some later version - wouldn't your fix
"undo" it?
Your parameter is named "cmykProfile" but ICC profiles don't have to be CMYK.
There can be with 3 colors or gray.
Please edit your question to add what you've found "across internet", i.e. put
a link or two there.
> ICCBased color spaces wrong color output
>
>
> Key: PDFBOX-4114
> URL: https://issues.apache.org/jira/browse/PDFBOX-4114
> Project: PDFBox
> Issue Type: Bug
> Components: PDModel, Rendering
>Affects Versions: 2.0.8
>Reporter: Michael Vakulich
>Priority: Major
> Fix For: 2.0.9, 3.0.0 PDFBox
>
> Attachments: ICCBased.patch, compare.jpg, highResPdf-1.jpg,
> highResPdf.pdf
>
>
> When rendering page with embedded ICC_profile (DeviceCMYK) it has a wrong
> colors, like semitransparent white plane covering the page
> See the render output
> Looking across internet I've found that this issue is caused because JSK has
> an issue with using profiles which Class is not Display.
> Here is the one of proposed patches I've found and which worked for me
> Please review proposed patch
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
