[jira] [Commented] (PDFBOX-4125) FDFField.writeXML KO with String

2018-03-04 Thread Loic (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385419#comment-16385419
 ] 

Loic commented on PDFBOX-4125:
--

Yes. It definitively resolve the issue. Thanks for your reactivity. 

 

> FDFField.writeXML KO with String
> 
>
> Key: PDFBOX-4125
> URL: https://issues.apache.org/jira/browse/PDFBOX-4125
> Project: PDFBox
>  Issue Type: Bug
>  Components: AcroForm
>Affects Versions: 2.0.8
>Reporter: Loic
>Assignee: Maruan Sahyoun
>Priority: Major
>  Labels: FDF
> Fix For: 2.0.9, 3.0.0 PDFBox
>
>
> When saving an XFDF into file, all the `` are skiped in the output.
> This is due to an incoherence between `writeXML()` which use `value 
> instanceof COSString`
> {code:java}
>  public void writeXML(Writer output) throws IOException
> {
> output.write("\n");
> Object value = getValue();
> if (value != null)
> {
> if (value instanceof COSString)
> {
> output.write("" + escapeXML(((COSString) 
> value).getString()) + "\n");
> }
> else if (value instanceof COSStream)
> {
> output.write("" + escapeXML(((COSStream) 
> value).toTextString()) + "\n");
> }
> }
> {code}
> and `getValue()` which transform COSString into String :
> {code:java}
>  public Object getValue() throws IOException
> {
> COSBase value = field.getDictionaryObject(COSName.V);
> if (value instanceof COSName)
> {
> return ((COSName) value).getName();
> }
> else if (value instanceof COSArray)
> {
> return COSArrayList.convertCOSStringCOSArrayToList((COSArray) 
> value);
> }
> else if (value instanceof COSString)
> {
> return ((COSString) value).getString();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-4125) FDFField.writeXML KO with String

2018-03-04 Thread Maruan Sahyoun (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385358#comment-16385358
 ] 

Maruan Sahyoun commented on PDFBOX-4125:


[~loic oudot] we are planning to release 2.0.9 - could you provide an update if 
the issue is resolved by the fixes applied?

> FDFField.writeXML KO with String
> 
>
> Key: PDFBOX-4125
> URL: https://issues.apache.org/jira/browse/PDFBOX-4125
> Project: PDFBox
>  Issue Type: Bug
>  Components: AcroForm
>Affects Versions: 2.0.8
>Reporter: Loic
>Assignee: Maruan Sahyoun
>Priority: Major
>  Labels: FDF
> Fix For: 2.0.9, 3.0.0 PDFBox
>
>
> When saving an XFDF into file, all the `` are skiped in the output.
> This is due to an incoherence between `writeXML()` which use `value 
> instanceof COSString`
> {code:java}
>  public void writeXML(Writer output) throws IOException
> {
> output.write("\n");
> Object value = getValue();
> if (value != null)
> {
> if (value instanceof COSString)
> {
> output.write("" + escapeXML(((COSString) 
> value).getString()) + "\n");
> }
> else if (value instanceof COSStream)
> {
> output.write("" + escapeXML(((COSStream) 
> value).toTextString()) + "\n");
> }
> }
> {code}
> and `getValue()` which transform COSString into String :
> {code:java}
>  public Object getValue() throws IOException
> {
> COSBase value = field.getDictionaryObject(COSName.V);
> if (value instanceof COSName)
> {
> return ((COSName) value).getName();
> }
> else if (value instanceof COSArray)
> {
> return COSArrayList.convertCOSStringCOSArrayToList((COSArray) 
> value);
> }
> else if (value instanceof COSString)
> {
> return ((COSString) value).getString();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-4125) FDFField.writeXML KO with String

2018-02-24 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375548#comment-16375548
 ] 

ASF subversion and git services commented on PDFBOX-4125:
-

Commit 1825237 from [~msahyoun] in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1825237 ]

PDFBOX-4125: output  for List values

> FDFField.writeXML KO with String
> 
>
> Key: PDFBOX-4125
> URL: https://issues.apache.org/jira/browse/PDFBOX-4125
> Project: PDFBox
>  Issue Type: Bug
>  Components: AcroForm
>Affects Versions: 2.0.8
>Reporter: Loic
>Assignee: Maruan Sahyoun
>Priority: Major
>
> When saving an XFDF into file, all the `` are skiped in the output.
> This is due to an incoherence between `writeXML()` which use `value 
> instanceof COSString`
> {code:java}
>  public void writeXML(Writer output) throws IOException
> {
> output.write("\n");
> Object value = getValue();
> if (value != null)
> {
> if (value instanceof COSString)
> {
> output.write("" + escapeXML(((COSString) 
> value).getString()) + "\n");
> }
> else if (value instanceof COSStream)
> {
> output.write("" + escapeXML(((COSStream) 
> value).toTextString()) + "\n");
> }
> }
> {code}
> and `getValue()` which transform COSString into String :
> {code:java}
>  public Object getValue() throws IOException
> {
> COSBase value = field.getDictionaryObject(COSName.V);
> if (value instanceof COSName)
> {
> return ((COSName) value).getName();
> }
> else if (value instanceof COSArray)
> {
> return COSArrayList.convertCOSStringCOSArrayToList((COSArray) 
> value);
> }
> else if (value instanceof COSString)
> {
> return ((COSString) value).getString();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-4125) FDFField.writeXML KO with String

2018-02-24 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375545#comment-16375545
 ] 

ASF subversion and git services commented on PDFBOX-4125:
-

Commit 1825236 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1825236 ]

PDFBOX-4125: output  for List values

> FDFField.writeXML KO with String
> 
>
> Key: PDFBOX-4125
> URL: https://issues.apache.org/jira/browse/PDFBOX-4125
> Project: PDFBox
>  Issue Type: Bug
>  Components: AcroForm
>Affects Versions: 2.0.8
>Reporter: Loic
>Assignee: Maruan Sahyoun
>Priority: Major
>
> When saving an XFDF into file, all the `` are skiped in the output.
> This is due to an incoherence between `writeXML()` which use `value 
> instanceof COSString`
> {code:java}
>  public void writeXML(Writer output) throws IOException
> {
> output.write("\n");
> Object value = getValue();
> if (value != null)
> {
> if (value instanceof COSString)
> {
> output.write("" + escapeXML(((COSString) 
> value).getString()) + "\n");
> }
> else if (value instanceof COSStream)
> {
> output.write("" + escapeXML(((COSStream) 
> value).toTextString()) + "\n");
> }
> }
> {code}
> and `getValue()` which transform COSString into String :
> {code:java}
>  public Object getValue() throws IOException
> {
> COSBase value = field.getDictionaryObject(COSName.V);
> if (value instanceof COSName)
> {
> return ((COSName) value).getName();
> }
> else if (value instanceof COSArray)
> {
> return COSArrayList.convertCOSStringCOSArrayToList((COSArray) 
> value);
> }
> else if (value instanceof COSString)
> {
> return ((COSString) value).getString();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-4125) FDFField.writeXML KO with String

2018-02-24 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375541#comment-16375541
 ] 

ASF subversion and git services commented on PDFBOX-4125:
-

Commit 1825232 from [~msahyoun] in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1825232 ]

PDFBOX-4125: getValue() either returns String or Array - adjust writeXML to 
deal with that

> FDFField.writeXML KO with String
> 
>
> Key: PDFBOX-4125
> URL: https://issues.apache.org/jira/browse/PDFBOX-4125
> Project: PDFBox
>  Issue Type: Bug
>  Components: AcroForm
>Affects Versions: 2.0.8
>Reporter: Loic
>Assignee: Maruan Sahyoun
>Priority: Major
>
> When saving an XFDF into file, all the `` are skiped in the output.
> This is due to an incoherence between `writeXML()` which use `value 
> instanceof COSString`
> {code:java}
>  public void writeXML(Writer output) throws IOException
> {
> output.write("\n");
> Object value = getValue();
> if (value != null)
> {
> if (value instanceof COSString)
> {
> output.write("" + escapeXML(((COSString) 
> value).getString()) + "\n");
> }
> else if (value instanceof COSStream)
> {
> output.write("" + escapeXML(((COSStream) 
> value).toTextString()) + "\n");
> }
> }
> {code}
> and `getValue()` which transform COSString into String :
> {code:java}
>  public Object getValue() throws IOException
> {
> COSBase value = field.getDictionaryObject(COSName.V);
> if (value instanceof COSName)
> {
> return ((COSName) value).getName();
> }
> else if (value instanceof COSArray)
> {
> return COSArrayList.convertCOSStringCOSArrayToList((COSArray) 
> value);
> }
> else if (value instanceof COSString)
> {
> return ((COSString) value).getString();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-4125) FDFField.writeXML KO with String

2018-02-24 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375540#comment-16375540
 ] 

ASF subversion and git services commented on PDFBOX-4125:
-

Commit 1825231 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1825231 ]

PDFBOX-4125: getValue() either returns String or Array - adjust writeXML to 
deal with that

> FDFField.writeXML KO with String
> 
>
> Key: PDFBOX-4125
> URL: https://issues.apache.org/jira/browse/PDFBOX-4125
> Project: PDFBox
>  Issue Type: Bug
>  Components: AcroForm
>Affects Versions: 2.0.8
>Reporter: Loic
>Assignee: Maruan Sahyoun
>Priority: Major
>
> When saving an XFDF into file, all the `` are skiped in the output.
> This is due to an incoherence between `writeXML()` which use `value 
> instanceof COSString`
> {code:java}
>  public void writeXML(Writer output) throws IOException
> {
> output.write("\n");
> Object value = getValue();
> if (value != null)
> {
> if (value instanceof COSString)
> {
> output.write("" + escapeXML(((COSString) 
> value).getString()) + "\n");
> }
> else if (value instanceof COSStream)
> {
> output.write("" + escapeXML(((COSStream) 
> value).toTextString()) + "\n");
> }
> }
> {code}
> and `getValue()` which transform COSString into String :
> {code:java}
>  public Object getValue() throws IOException
> {
> COSBase value = field.getDictionaryObject(COSName.V);
> if (value instanceof COSName)
> {
> return ((COSName) value).getName();
> }
> else if (value instanceof COSArray)
> {
> return COSArrayList.convertCOSStringCOSArrayToList((COSArray) 
> value);
> }
> else if (value instanceof COSString)
> {
> return ((COSString) value).getString();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-4125) FDFField.writeXML KO with String

2018-02-24 Thread Maruan Sahyoun (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375464#comment-16375464
 ] 

Maruan Sahyoun commented on PDFBOX-4125:


Would you mind adding a small test file and (failing) unit test so it's easier 
to resolve the issue?

> FDFField.writeXML KO with String
> 
>
> Key: PDFBOX-4125
> URL: https://issues.apache.org/jira/browse/PDFBOX-4125
> Project: PDFBox
>  Issue Type: Bug
>  Components: AcroForm
>Affects Versions: 2.0.8
>Reporter: Loic
>Priority: Major
>
> When saving an XFDF into file, all the `` are skiped in the output.
> This is due to an incoherence between `writeXML()` which use `value 
> instanceof COSString`
> {code:java}
>  public void writeXML(Writer output) throws IOException
> {
> output.write("\n");
> Object value = getValue();
> if (value != null)
> {
> if (value instanceof COSString)
> {
> output.write("" + escapeXML(((COSString) 
> value).getString()) + "\n");
> }
> else if (value instanceof COSStream)
> {
> output.write("" + escapeXML(((COSStream) 
> value).toTextString()) + "\n");
> }
> }
> {code}
> and `getValue()` which transform COSString into String :
> {code:java}
>  public Object getValue() throws IOException
> {
> COSBase value = field.getDictionaryObject(COSName.V);
> if (value instanceof COSName)
> {
> return ((COSName) value).getName();
> }
> else if (value instanceof COSArray)
> {
> return COSArrayList.convertCOSStringCOSArrayToList((COSArray) 
> value);
> }
> else if (value instanceof COSString)
> {
> return ((COSString) value).getString();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org