[jira] [Commented] (PDFBOX-4197) PDStructureElement.getAttributes() ignores reference objects
[ https://issues.apache.org/jira/browse/PDFBOX-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444613#comment-16444613 ] ASF subversion and git services commented on PDFBOX-4197: - Commit 1829602 from [~tilman] in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1829602 ] PDFBOX-4197: add test that object references in array attributes of a PDStructureElement are caught > PDStructureElement.getAttributes() ignores reference objects > > > Key: PDFBOX-4197 > URL: https://issues.apache.org/jira/browse/PDFBOX-4197 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 1.8.13, 2.0.9 > Environment: N/A >Reporter: Bill Janssen >Assignee: Tilman Hausherr >Priority: Major > Labels: StructureTree > Fix For: 1.8.15, 2.0.10, 3.0.0 PDFBox > > Attachments: sample.pdf > > Original Estimate: 4h > Remaining Estimate: 4h > > Attribute dictionaries attached to a structure element may be either direct > or references. getAttributes() handles the direct case but ignores object > references without error messages. This can also lead to invalid revision > numbers attached to the attribute dictionaries it does handle properly. > > The fix would be to add another branch to the iteration loop in > PDStructureElement.getAttributes(), to handle object references. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4197) PDStructureElement.getAttributes() ignores reference objects
[ https://issues.apache.org/jira/browse/PDFBOX-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444610#comment-16444610 ] ASF subversion and git services commented on PDFBOX-4197: - Commit 1829601 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1829601 ] PDFBOX-4197: add test that object references in array attributes of a PDStructureElement are caught > PDStructureElement.getAttributes() ignores reference objects > > > Key: PDFBOX-4197 > URL: https://issues.apache.org/jira/browse/PDFBOX-4197 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 1.8.13, 2.0.9 > Environment: N/A >Reporter: Bill Janssen >Assignee: Tilman Hausherr >Priority: Major > Labels: StructureTree > Fix For: 1.8.15, 2.0.10, 3.0.0 PDFBox > > Attachments: sample.pdf > > Original Estimate: 4h > Remaining Estimate: 4h > > Attribute dictionaries attached to a structure element may be either direct > or references. getAttributes() handles the direct case but ignores object > references without error messages. This can also lead to invalid revision > numbers attached to the attribute dictionaries it does handle properly. > > The fix would be to add another branch to the iteration loop in > PDStructureElement.getAttributes(), to handle object references. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4197) PDStructureElement.getAttributes() ignores reference objects
[ https://issues.apache.org/jira/browse/PDFBOX-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1656#comment-1656 ] ASF subversion and git services commented on PDFBOX-4197: - Commit 1829583 from [~tilman] in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1829583 ] PDFBOX-4197: load test file into repository > PDStructureElement.getAttributes() ignores reference objects > > > Key: PDFBOX-4197 > URL: https://issues.apache.org/jira/browse/PDFBOX-4197 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 1.8.13, 2.0.9 > Environment: N/A >Reporter: Bill Janssen >Assignee: Tilman Hausherr >Priority: Major > Labels: StructureTree > Fix For: 1.8.15, 2.0.10, 3.0.0 PDFBox > > Attachments: sample.pdf > > Original Estimate: 4h > Remaining Estimate: 4h > > Attribute dictionaries attached to a structure element may be either direct > or references. getAttributes() handles the direct case but ignores object > references without error messages. This can also lead to invalid revision > numbers attached to the attribute dictionaries it does handle properly. > > The fix would be to add another branch to the iteration loop in > PDStructureElement.getAttributes(), to handle object references. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4197) PDStructureElement.getAttributes() ignores reference objects
[ https://issues.apache.org/jira/browse/PDFBOX-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1657#comment-1657 ] ASF subversion and git services commented on PDFBOX-4197: - Commit 1829584 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1829584 ] PDFBOX-4197: load test file into repository > PDStructureElement.getAttributes() ignores reference objects > > > Key: PDFBOX-4197 > URL: https://issues.apache.org/jira/browse/PDFBOX-4197 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 1.8.13, 2.0.9 > Environment: N/A >Reporter: Bill Janssen >Assignee: Tilman Hausherr >Priority: Major > Labels: StructureTree > Fix For: 1.8.15, 2.0.10, 3.0.0 PDFBox > > Attachments: sample.pdf > > Original Estimate: 4h > Remaining Estimate: 4h > > Attribute dictionaries attached to a structure element may be either direct > or references. getAttributes() handles the direct case but ignores object > references without error messages. This can also lead to invalid revision > numbers attached to the attribute dictionaries it does handle properly. > > The fix would be to add another branch to the iteration loop in > PDStructureElement.getAttributes(), to handle object references. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4197) PDStructureElement.getAttributes() ignores reference objects
[
https://issues.apache.org/jira/browse/PDFBOX-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443540#comment-16443540
]
Tilman Hausherr commented on PDFBOX-4197:
-
thanks, I found at least two:
{noformat}
Root/StructTreeRoot/K/[0]/K/[11]/K/[0]/K/[0]/A
Root/StructTreeRoot/K/[0]/K/[11]/K/[0]/K/[1]/A
{noformat}
I'll create a test from there later.
> PDStructureElement.getAttributes() ignores reference objects
>
>
> Key: PDFBOX-4197
> URL: https://issues.apache.org/jira/browse/PDFBOX-4197
> Project: PDFBox
> Issue Type: Bug
> Components: PDModel
>Affects Versions: 1.8.13, 2.0.9
> Environment: N/A
>Reporter: Bill Janssen
>Assignee: Tilman Hausherr
>Priority: Major
> Labels: StructureTree
> Fix For: 1.8.15, 2.0.10, 3.0.0 PDFBox
>
> Attachments: sample.pdf
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Attribute dictionaries attached to a structure element may be either direct
> or references. getAttributes() handles the direct case but ignores object
> references without error messages. This can also lead to invalid revision
> numbers attached to the attribute dictionaries it does handle properly.
>
> The fix would be to add another branch to the iteration loop in
> PDStructureElement.getAttributes(), to handle object references.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4197) PDStructureElement.getAttributes() ignores reference objects
[ https://issues.apache.org/jira/browse/PDFBOX-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443400#comment-16443400 ] Bill Janssen commented on PDFBOX-4197: -- Attached sample file. This has a table with headers that have both Layout and Table attribute dictionaries. > PDStructureElement.getAttributes() ignores reference objects > > > Key: PDFBOX-4197 > URL: https://issues.apache.org/jira/browse/PDFBOX-4197 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 1.8.13, 2.0.9 > Environment: N/A >Reporter: Bill Janssen >Assignee: Tilman Hausherr >Priority: Major > Labels: StructureTree > Fix For: 1.8.15, 2.0.10, 3.0.0 PDFBox > > Attachments: sample.pdf > > Original Estimate: 4h > Remaining Estimate: 4h > > Attribute dictionaries attached to a structure element may be either direct > or references. getAttributes() handles the direct case but ignores object > references without error messages. This can also lead to invalid revision > numbers attached to the attribute dictionaries it does handle properly. > > The fix would be to add another branch to the iteration loop in > PDStructureElement.getAttributes(), to handle object references. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4197) PDStructureElement.getAttributes() ignores reference objects
[ https://issues.apache.org/jira/browse/PDFBOX-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443169#comment-16443169 ] Bill Janssen commented on PDFBOX-4197: -- I think any document with a table would work, but my example document had some table headers that spanned multiple columns, so there was an attribute dictionionary with "colspan=3" in it. > PDStructureElement.getAttributes() ignores reference objects > > > Key: PDFBOX-4197 > URL: https://issues.apache.org/jira/browse/PDFBOX-4197 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 1.8.13, 2.0.9 > Environment: N/A >Reporter: Bill Janssen >Assignee: Tilman Hausherr >Priority: Major > Labels: StructureTree > Fix For: 1.8.15, 2.0.10, 3.0.0 PDFBox > > Original Estimate: 4h > Remaining Estimate: 4h > > Attribute dictionaries attached to a structure element may be either direct > or references. getAttributes() handles the direct case but ignores object > references without error messages. This can also lead to invalid revision > numbers attached to the attribute dictionaries it does handle properly. > > The fix would be to add another branch to the iteration loop in > PDStructureElement.getAttributes(), to handle object references. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4197) PDStructureElement.getAttributes() ignores reference objects
[ https://issues.apache.org/jira/browse/PDFBOX-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442925#comment-16442925 ] Tilman Hausherr commented on PDFBOX-4197: - I found another occurence and I fixed it too. I agree that a test case would be nice but I don't have a test file. If possible, please attach it here. Alternatively I could write some code that goes through our test files hoping to hit such an example. > PDStructureElement.getAttributes() ignores reference objects > > > Key: PDFBOX-4197 > URL: https://issues.apache.org/jira/browse/PDFBOX-4197 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 1.8.13, 2.0.9 > Environment: N/A >Reporter: Bill Janssen >Priority: Major > Labels: StructureTree > Fix For: 1.8.15, 2.0.10, 3.0.0 PDFBox > > Original Estimate: 4h > Remaining Estimate: 4h > > Attribute dictionaries attached to a structure element may be either direct > or references. getAttributes() handles the direct case but ignores object > references without error messages. This can also lead to invalid revision > numbers attached to the attribute dictionaries it does handle properly. > > The fix would be to add another branch to the iteration loop in > PDStructureElement.getAttributes(), to handle object references. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4197) PDStructureElement.getAttributes() ignores reference objects
[ https://issues.apache.org/jira/browse/PDFBOX-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442913#comment-16442913 ] ASF subversion and git services commented on PDFBOX-4197: - Commit 1829464 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1829464 ] PDFBOX-4197: consider object references > PDStructureElement.getAttributes() ignores reference objects > > > Key: PDFBOX-4197 > URL: https://issues.apache.org/jira/browse/PDFBOX-4197 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 1.8.13, 2.0.9 > Environment: N/A >Reporter: Bill Janssen >Priority: Major > Labels: StructureTree > Fix For: 2.0.10, 3.0.0 PDFBox > > Original Estimate: 4h > Remaining Estimate: 4h > > Attribute dictionaries attached to a structure element may be either direct > or references. getAttributes() handles the direct case but ignores object > references without error messages. This can also lead to invalid revision > numbers attached to the attribute dictionaries it does handle properly. > > The fix would be to add another branch to the iteration loop in > PDStructureElement.getAttributes(), to handle object references. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4197) PDStructureElement.getAttributes() ignores reference objects
[ https://issues.apache.org/jira/browse/PDFBOX-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442911#comment-16442911 ] ASF subversion and git services commented on PDFBOX-4197: - Commit 1829462 from [~tilman] in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1829462 ] PDFBOX-4197: consider object references > PDStructureElement.getAttributes() ignores reference objects > > > Key: PDFBOX-4197 > URL: https://issues.apache.org/jira/browse/PDFBOX-4197 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 1.8.13, 2.0.9 > Environment: N/A >Reporter: Bill Janssen >Priority: Major > Labels: StructureTree > Fix For: 2.0.10, 3.0.0 PDFBox > > Original Estimate: 4h > Remaining Estimate: 4h > > Attribute dictionaries attached to a structure element may be either direct > or references. getAttributes() handles the direct case but ignores object > references without error messages. This can also lead to invalid revision > numbers attached to the attribute dictionaries it does handle properly. > > The fix would be to add another branch to the iteration loop in > PDStructureElement.getAttributes(), to handle object references. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4197) PDStructureElement.getAttributes() ignores reference objects
[ https://issues.apache.org/jira/browse/PDFBOX-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442912#comment-16442912 ] ASF subversion and git services commented on PDFBOX-4197: - Commit 1829463 from [~tilman] in branch 'pdfbox/branches/1.8' [ https://svn.apache.org/r1829463 ] PDFBOX-4197: consider object references > PDStructureElement.getAttributes() ignores reference objects > > > Key: PDFBOX-4197 > URL: https://issues.apache.org/jira/browse/PDFBOX-4197 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 1.8.13, 2.0.9 > Environment: N/A >Reporter: Bill Janssen >Priority: Major > Labels: StructureTree > Fix For: 2.0.10, 3.0.0 PDFBox > > Original Estimate: 4h > Remaining Estimate: 4h > > Attribute dictionaries attached to a structure element may be either direct > or references. getAttributes() handles the direct case but ignores object > references without error messages. This can also lead to invalid revision > numbers attached to the attribute dictionaries it does handle properly. > > The fix would be to add another branch to the iteration loop in > PDStructureElement.getAttributes(), to handle object references. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4197) PDStructureElement.getAttributes() ignores reference objects
[ https://issues.apache.org/jira/browse/PDFBOX-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442871#comment-16442871 ] Bill Janssen commented on PDFBOX-4197: -- Yes, that seems to work. Also need a test case. > PDStructureElement.getAttributes() ignores reference objects > > > Key: PDFBOX-4197 > URL: https://issues.apache.org/jira/browse/PDFBOX-4197 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 2.0.9 > Environment: N/A >Reporter: Bill Janssen >Priority: Major > Labels: StructureTree > Fix For: 2.0.10, 3.0.0 PDFBox > > Original Estimate: 4h > Remaining Estimate: 4h > > Attribute dictionaries attached to a structure element may be either direct > or references. getAttributes() handles the direct case but ignores object > references without error messages. This can also lead to invalid revision > numbers attached to the attribute dictionaries it does handle properly. > > The fix would be to add another branch to the iteration loop in > PDStructureElement.getAttributes(), to handle object references. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4197) PDStructureElement.getAttributes() ignores reference objects
[
https://issues.apache.org/jira/browse/PDFBOX-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442817#comment-16442817
]
Tilman Hausherr commented on PDFBOX-4197:
-
Do you mean this part?
{code}
COSBase item = it.next();
if (item instanceof COSDictionary)
{code}
I'd change it to
{code}
COSBase item = it.next();
if (item instanceof COSObject)
{
item = ((COSObject) item).getObject();
}
if (item instanceof COSDictionary)
{code}
> PDStructureElement.getAttributes() ignores reference objects
>
>
> Key: PDFBOX-4197
> URL: https://issues.apache.org/jira/browse/PDFBOX-4197
> Project: PDFBox
> Issue Type: Bug
> Components: PDModel
>Affects Versions: 2.0.9
> Environment: N/A
>Reporter: Bill Janssen
>Priority: Major
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Attribute dictionaries attached to a structure element may be either direct
> or references. getAttributes() handles the direct case but ignores object
> references without error messages. This can also lead to invalid revision
> numbers attached to the attribute dictionaries it does handle properly.
>
> The fix would be to add another branch to the iteration loop in
> PDStructureElement.getAttributes(), to handle object references.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
