[jira] [Commented] (PDFBOX-4303) Helv and ZaDb overridden
[ https://issues.apache.org/jira/browse/PDFBOX-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711390#comment-16711390 ] ASF subversion and git services commented on PDFBOX-4303: - Commit 1848299 from til...@apache.org in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1848299 ] PDFBOX-4303, PDFBOX-4393: add test > Helv and ZaDb overridden > > > Key: PDFBOX-4303 > URL: https://issues.apache.org/jira/browse/PDFBOX-4303 > Project: PDFBox > Issue Type: Bug > Components: AcroForm >Affects Versions: 2.0.11 >Reporter: simon steiner >Assignee: Maruan Sahyoun >Priority: Major > Labels: Appearance > Fix For: 2.0.14, 3.0.0 PDFBox > > Attachments: PDFBOX-4303-2.0.12.diff, ReaderModifiedForm.pdf > > > Due to change: > PDFBOX-3943: create /Helv and /ZaDb entries if they don't exist, regardless > if /DR existed or not > > was working ok in 2.0.7, in 2.0 branch > PDAcroForm > verifyOrCreateDefaults(): > is: > {color:#80}if > {color}(!defaultResources.getCOSObject().containsKey({color:#008000}"Helv"{color})) > should be checking key in the font dictionary before calling > defaultResources.put -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4303) Helv and ZaDb overridden
[ https://issues.apache.org/jira/browse/PDFBOX-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711392#comment-16711392 ] ASF subversion and git services commented on PDFBOX-4303: - Commit 1848300 from til...@apache.org in branch 'pdfbox/trunk' [ https://svn.apache.org/r1848300 ] PDFBOX-4303, PDFBOX-4393: add test > Helv and ZaDb overridden > > > Key: PDFBOX-4303 > URL: https://issues.apache.org/jira/browse/PDFBOX-4303 > Project: PDFBox > Issue Type: Bug > Components: AcroForm >Affects Versions: 2.0.11 >Reporter: simon steiner >Assignee: Maruan Sahyoun >Priority: Major > Labels: Appearance > Fix For: 2.0.14, 3.0.0 PDFBox > > Attachments: PDFBOX-4303-2.0.12.diff, ReaderModifiedForm.pdf > > > Due to change: > PDFBOX-3943: create /Helv and /ZaDb entries if they don't exist, regardless > if /DR existed or not > > was working ok in 2.0.7, in 2.0 branch > PDAcroForm > verifyOrCreateDefaults(): > is: > {color:#80}if > {color}(!defaultResources.getCOSObject().containsKey({color:#008000}"Helv"{color})) > should be checking key in the font dictionary before calling > defaultResources.put -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4303) Helv and ZaDb overridden
[ https://issues.apache.org/jira/browse/PDFBOX-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711296#comment-16711296 ] ASF subversion and git services commented on PDFBOX-4303: - Commit 1848285 from til...@apache.org in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1848285 ] PDFBOX-4303, PDFBOX-4393: add comments > Helv and ZaDb overridden > > > Key: PDFBOX-4303 > URL: https://issues.apache.org/jira/browse/PDFBOX-4303 > Project: PDFBox > Issue Type: Bug > Components: AcroForm >Affects Versions: 2.0.11 >Reporter: simon steiner >Assignee: Maruan Sahyoun >Priority: Major > Labels: Appearance > Fix For: 2.0.14, 3.0.0 PDFBox > > Attachments: PDFBOX-4303-2.0.12.diff, ReaderModifiedForm.pdf > > > Due to change: > PDFBOX-3943: create /Helv and /ZaDb entries if they don't exist, regardless > if /DR existed or not > > was working ok in 2.0.7, in 2.0 branch > PDAcroForm > verifyOrCreateDefaults(): > is: > {color:#80}if > {color}(!defaultResources.getCOSObject().containsKey({color:#008000}"Helv"{color})) > should be checking key in the font dictionary before calling > defaultResources.put -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4303) Helv and ZaDb overridden
[ https://issues.apache.org/jira/browse/PDFBOX-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711298#comment-16711298 ] ASF subversion and git services commented on PDFBOX-4303: - Commit 1848286 from til...@apache.org in branch 'pdfbox/trunk' [ https://svn.apache.org/r1848286 ] PDFBOX-4303, PDFBOX-4393: add comments > Helv and ZaDb overridden > > > Key: PDFBOX-4303 > URL: https://issues.apache.org/jira/browse/PDFBOX-4303 > Project: PDFBox > Issue Type: Bug > Components: AcroForm >Affects Versions: 2.0.11 >Reporter: simon steiner >Assignee: Maruan Sahyoun >Priority: Major > Labels: Appearance > Fix For: 2.0.14, 3.0.0 PDFBox > > Attachments: PDFBOX-4303-2.0.12.diff, ReaderModifiedForm.pdf > > > Due to change: > PDFBOX-3943: create /Helv and /ZaDb entries if they don't exist, regardless > if /DR existed or not > > was working ok in 2.0.7, in 2.0 branch > PDAcroForm > verifyOrCreateDefaults(): > is: > {color:#80}if > {color}(!defaultResources.getCOSObject().containsKey({color:#008000}"Helv"{color})) > should be checking key in the font dictionary before calling > defaultResources.put -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4303) Helv and ZaDb overridden
[ https://issues.apache.org/jira/browse/PDFBOX-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711295#comment-16711295 ] Tilman Hausherr commented on PDFBOX-4303: - Commit 1848212 from til...@apache.org in branch 'pdfbox/trunk' [ https://svn.apache.org/r1848212 ] PDFBOX-4303, PDFBOX-4393: mark updated when applicable; check whether font dictionary exists; avoid bug that wrong dictionary was checked for font Commit 1848213 from til...@apache.org in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1848213 ] PDFBOX-4303, PDFBOX-4393: mark updated when applicable; check whether font dictionary exists; avoid bug that wrong dictionary was checked for font > Helv and ZaDb overridden > > > Key: PDFBOX-4303 > URL: https://issues.apache.org/jira/browse/PDFBOX-4303 > Project: PDFBox > Issue Type: Bug > Components: AcroForm >Affects Versions: 2.0.11 >Reporter: simon steiner >Assignee: Maruan Sahyoun >Priority: Major > Labels: Appearance > Fix For: 2.0.14, 3.0.0 PDFBox > > Attachments: PDFBOX-4303-2.0.12.diff, ReaderModifiedForm.pdf > > > Due to change: > PDFBOX-3943: create /Helv and /ZaDb entries if they don't exist, regardless > if /DR existed or not > > was working ok in 2.0.7, in 2.0 branch > PDAcroForm > verifyOrCreateDefaults(): > is: > {color:#80}if > {color}(!defaultResources.getCOSObject().containsKey({color:#008000}"Helv"{color})) > should be checking key in the font dictionary before calling > defaultResources.put -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4303) Helv and ZaDb overridden
[ https://issues.apache.org/jira/browse/PDFBOX-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710078#comment-16710078 ] Tilman Hausherr commented on PDFBOX-4303: - Yes please, open a new issue and delete that part here (all after "{color:#33}I am unsure if my observed{color}"). And clarify why this bothers you. Because the now fixed version will still add Helv and ZaDb. > Helv and ZaDb overridden > > > Key: PDFBOX-4303 > URL: https://issues.apache.org/jira/browse/PDFBOX-4303 > Project: PDFBox > Issue Type: Bug > Components: AcroForm >Affects Versions: 2.0.11 >Reporter: simon steiner >Assignee: Maruan Sahyoun >Priority: Major > Labels: Appearance > Attachments: PDFBOX-4303-2.0.12.diff, ReaderModifiedForm.pdf > > > Due to change: > PDFBOX-3943: create /Helv and /ZaDb entries if they don't exist, regardless > if /DR existed or not > > was working ok in 2.0.7, in 2.0 branch > PDAcroForm > verifyOrCreateDefaults(): > is: > {color:#80}if > {color}(!defaultResources.getCOSObject().containsKey({color:#008000}"Helv"{color})) > should be checking key in the font dictionary before calling > defaultResources.put -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4303) Helv and ZaDb overridden
[ https://issues.apache.org/jira/browse/PDFBOX-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710069#comment-16710069 ] beat weisskopf commented on PDFBOX-4303: [~tilman] What about the other issue? Should I open a new issue? The call to getLastSignatureDictionary should not intitialize the AcroForm-DefaultResources imho. > Helv and ZaDb overridden > > > Key: PDFBOX-4303 > URL: https://issues.apache.org/jira/browse/PDFBOX-4303 > Project: PDFBox > Issue Type: Bug > Components: AcroForm >Affects Versions: 2.0.11 >Reporter: simon steiner >Assignee: Maruan Sahyoun >Priority: Major > Labels: Appearance > Attachments: PDFBOX-4303-2.0.12.diff, ReaderModifiedForm.pdf > > > Due to change: > PDFBOX-3943: create /Helv and /ZaDb entries if they don't exist, regardless > if /DR existed or not > > was working ok in 2.0.7, in 2.0 branch > PDAcroForm > verifyOrCreateDefaults(): > is: > {color:#80}if > {color}(!defaultResources.getCOSObject().containsKey({color:#008000}"Helv"{color})) > should be checking key in the font dictionary before calling > defaultResources.put -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4303) Helv and ZaDb overridden
[ https://issues.apache.org/jira/browse/PDFBOX-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710053#comment-16710053 ] Tilman Hausherr commented on PDFBOX-4303: - LOL I had to look several times before I saw the mistake. I'll fix this as part of the work in PDFBOX-4393. > Helv and ZaDb overridden > > > Key: PDFBOX-4303 > URL: https://issues.apache.org/jira/browse/PDFBOX-4303 > Project: PDFBox > Issue Type: Bug > Components: AcroForm >Affects Versions: 2.0.11 >Reporter: simon steiner >Assignee: Maruan Sahyoun >Priority: Major > Labels: Appearance > Attachments: PDFBOX-4303-2.0.12.diff, ReaderModifiedForm.pdf > > > Due to change: > PDFBOX-3943: create /Helv and /ZaDb entries if they don't exist, regardless > if /DR existed or not > > was working ok in 2.0.7, in 2.0 branch > PDAcroForm > verifyOrCreateDefaults(): > is: > {color:#80}if > {color}(!defaultResources.getCOSObject().containsKey({color:#008000}"Helv"{color})) > should be checking key in the font dictionary before calling > defaultResources.put -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4303) Helv and ZaDb overridden
[ https://issues.apache.org/jira/browse/PDFBOX-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707130#comment-16707130 ] beat weisskopf commented on PDFBOX-4303: We are hitting this issue too on upgrading from 2.0.5 to 2.0.12. To fix the issue one should get the "Font"-Dictionary and check the existence there: e.g. {code} COSDictionary fontDict = (COSDictionary) defaultResources.getCOSObject().getDictionaryObject(COSName.FONT); if (!fontDict.containsKey("Helv")) { defaultResources.put(COSName.getPDFName("Helv"), PDType1Font.HELVETICA); } {code} What is missing for this to be fixed? > Helv and ZaDb overridden > > > Key: PDFBOX-4303 > URL: https://issues.apache.org/jira/browse/PDFBOX-4303 > Project: PDFBox > Issue Type: Bug > Components: AcroForm >Affects Versions: 2.0.11 >Reporter: simon steiner >Assignee: Maruan Sahyoun >Priority: Major > Labels: Appearance > Attachments: ReaderModifiedForm.pdf > > > Due to change: > PDFBOX-3943: create /Helv and /ZaDb entries if they don't exist, regardless > if /DR existed or not > > was working ok in 2.0.7, in 2.0 branch > PDAcroForm > verifyOrCreateDefaults(): > is: > {color:#80}if > {color}(!defaultResources.getCOSObject().containsKey({color:#008000}"Helv"{color})) > should be checking key in the font dictionary before calling > defaultResources.put -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4303) Helv and ZaDb overridden
[ https://issues.apache.org/jira/browse/PDFBOX-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597478#comment-16597478 ] simon steiner commented on PDFBOX-4303: --- PDDocument sourceDoc = PDDocument.load({color:#80}new {color}File({color:#008000}"ReaderModifiedForm.pdf"{color})); PDDocumentCatalog srcCatalog = sourceDoc.getDocumentCatalog(); PDAcroForm srcAcroForm = srcCatalog.getAcroForm(); COSDictionary dr = (COSDictionary) srcAcroForm.getCOSObject().getDictionaryObject(COSName.{color:#660e7a}DR{color}); COSDictionary font = (COSDictionary) dr.getDictionaryObject(COSName.{color:#660e7a}FONT{color}); COSDictionary helv = (COSDictionary) font.getDictionaryObject(COSName.getPDFName({color:#008000}"Helv"{color})); Assert.assertNotNull(helv.getDictionaryObject(COSName.{color:#660e7a}NAME{color})); sourceDoc.close(); > Helv and ZaDb overridden > > > Key: PDFBOX-4303 > URL: https://issues.apache.org/jira/browse/PDFBOX-4303 > Project: PDFBox > Issue Type: Bug > Components: AcroForm >Affects Versions: 2.0.11 >Reporter: simon steiner >Assignee: Maruan Sahyoun >Priority: Major > Labels: Appearance > Attachments: ReaderModifiedForm.pdf > > > Due to change: > PDFBOX-3943: create /Helv and /ZaDb entries if they don't exist, regardless > if /DR existed or not > > was working ok in 2.0.7, in 2.0 branch > PDAcroForm > verifyOrCreateDefaults(): > is: > {color:#80}if > {color}(!defaultResources.getCOSObject().containsKey({color:#008000}"Helv"{color})) > should be checking key in the font dictionary before calling > defaultResources.put -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4303) Helv and ZaDb overridden
[ https://issues.apache.org/jira/browse/PDFBOX-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597459#comment-16597459 ] Maruan Sahyoun commented on PDFBOX-4303: [~ssteiner1] would it be possible for you to create a unit test where a) /Helv exists and b) /Helv doesn't exist and attach it to this issue? > Helv and ZaDb overridden > > > Key: PDFBOX-4303 > URL: https://issues.apache.org/jira/browse/PDFBOX-4303 > Project: PDFBox > Issue Type: Bug > Components: AcroForm >Affects Versions: 2.0.11 >Reporter: simon steiner >Assignee: Maruan Sahyoun >Priority: Major > Labels: Appearance > > Due to change: > PDFBOX-3943: create /Helv and /ZaDb entries if they don't exist, regardless > if /DR existed or not > > was working ok in 2.0.7, in 2.0 branch > PDAcroForm > verifyOrCreateDefaults(): > is: > {color:#80}if > {color}(!defaultResources.getCOSObject().containsKey({color:#008000}"Helv"{color})) > should be checking key in the font dictionary before calling > defaultResources.put -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org