Re: Removing methods deprectaed in 2.0.x in trunk

[Maruan Sahyoun]

> Am 04.02.2018 um 10:39 schrieb Tilman Hausherr :
> 
> Am 04.02.2018 um 10:31 schrieb Maruan Sahyoun:
>> - keep the "height" methods that are mentioned in the builds because 
>> these are still being used by ourselves (I think).
> that's getHeight in some of the font classes - correct?
 Yes
>> what about replacing the deprecated call with the new method?
>> 
> 
> I suspect that text extraction would no longer work.

From the comments in the source it shouldn't matter but I suspect that's not 
the case. And replacing with the height of the GeneralPath is IMHO a very 
costly although likely more accurate operation.

> 
> 
> Tilman
> 


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: Removing methods deprectaed in 2.0.x in trunk

[Tilman Hausherr]

Am 04.02.2018 um 10:31 schrieb Maruan Sahyoun:

- keep the "height" methods that are mentioned in the builds because these are 
still being used by ourselves (I think).

that's getHeight in some of the font classes - correct?

Yes

what about replacing the deprecated call with the new method?



I suspect that text extraction would no longer work.


Tilman

Re: Removing methods deprectaed in 2.0.x in trunk

[Maruan Sahyoun]

> Am 03.02.2018 um 20:54 schrieb Maruan Sahyoun :
> 
> 
>> Am 03.02.2018 um 20:52 schrieb Tilman Hausherr :
>> 
>> Am 03.02.2018 um 20:42 schrieb Maruan Sahyoun:
 Am 03.02.2018 um 20:28 schrieb Tilman Hausherr :
 
 Yes with some exceptions:
 - keep the "raw" methods from the contentstream classes because some 
 people may use them anyway
>>> I'd like to keep them too as it allows people who know what they do to use 
>>> them. Why not remove the deprecation notice in 2.0?
>> 
>> I'd prefer to keep the deprecation so that "new" people don't start using 
>> them. It's like smoking. It is warned against that it shouldn't be done, but 
>> people do it anyway, but at least they've been warned that they'll have a 
>> terrible death.
> 
> OK
> 
>> 
>> 
>>> 
 - keep the "height" methods that are mentioned in the builds because these 
 are still being used by ourselves (I think).
>>> that's getHeight in some of the font classes - correct?
>> 
>> Yes

what about replacing the deprecated call with the new method? 

>> 
>>> 
>>> Shall I add a ticket or do we handle that with PDFBOX-4071?
>> 
>> There's PDFBOX-3709 for that :-)
> 
> thanks - too many tickets :-)
> 
>> 
>> Tilman
>> 
>> 
>>> BR
>>> Maruan
>>> 
>>> 
 Tilman
 
 Am 03.02.2018 um 19:56 schrieb Maruan Sahyoun:
> Hi,
> 
> there are a number of deprecated constructors, methods and fields in 
> trunk which we deprecated in 2.0.x.
> 
> What about starting to remove these while we are working on some of the 
> affected classes?
> 
> BR
> Maruan
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
> For additional commands, e-mail: dev-h...@pdfbox.apache.org
> 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
 For additional commands, e-mail: dev-h...@pdfbox.apache.org
 
>>> 
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
>>> For additional commands, e-mail: dev-h...@pdfbox.apache.org
>>> 
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
>> For additional commands, e-mail: dev-h...@pdfbox.apache.org
>> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
> For additional commands, e-mail: dev-h...@pdfbox.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: Removing methods deprectaed in 2.0.x in trunk

[Maruan Sahyoun]

> Am 03.02.2018 um 20:52 schrieb Tilman Hausherr :
> 
> Am 03.02.2018 um 20:42 schrieb Maruan Sahyoun:
>>> Am 03.02.2018 um 20:28 schrieb Tilman Hausherr :
>>> 
>>> Yes with some exceptions:
>>> - keep the "raw" methods from the contentstream classes because some people 
>>> may use them anyway
>> I'd like to keep them too as it allows people who know what they do to use 
>> them. Why not remove the deprecation notice in 2.0?
> 
> I'd prefer to keep the deprecation so that "new" people don't start using 
> them. It's like smoking. It is warned against that it shouldn't be done, but 
> people do it anyway, but at least they've been warned that they'll have a 
> terrible death.

OK

> 
> 
>> 
>>> - keep the "height" methods that are mentioned in the builds because these 
>>> are still being used by ourselves (I think).
>> that's getHeight in some of the font classes - correct?
> 
> Yes
> 
>> 
>> Shall I add a ticket or do we handle that with PDFBOX-4071?
> 
> There's PDFBOX-3709 for that :-)

thanks - too many tickets :-)

> 
> Tilman
> 
> 
>> BR
>> Maruan
>> 
>> 
>>> Tilman
>>> 
>>> Am 03.02.2018 um 19:56 schrieb Maruan Sahyoun:
 Hi,
 
 there are a number of deprecated constructors, methods and fields in trunk 
 which we deprecated in 2.0.x.
 
 What about starting to remove these while we are working on some of the 
 affected classes?
 
 BR
 Maruan
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
 For additional commands, e-mail: dev-h...@pdfbox.apache.org
 
>>> 
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
>>> For additional commands, e-mail: dev-h...@pdfbox.apache.org
>>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
>> For additional commands, e-mail: dev-h...@pdfbox.apache.org
>> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
> For additional commands, e-mail: dev-h...@pdfbox.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: Removing methods deprectaed in 2.0.x in trunk

[Tilman Hausherr]

Am 03.02.2018 um 20:42 schrieb Maruan Sahyoun:

Am 03.02.2018 um 20:28 schrieb Tilman Hausherr :

Yes with some exceptions:
- keep the "raw" methods from the contentstream classes because some people may 
use them anyway

I'd like to keep them too as it allows people who know what they do to use 
them. Why not remove the deprecation notice in 2.0?


I'd prefer to keep the deprecation so that "new" people don't start 
using them. It's like smoking. It is warned against that it shouldn't be 
done, but people do it anyway, but at least they've been warned that 
they'll have a terrible death.






- keep the "height" methods that are mentioned in the builds because these are 
still being used by ourselves (I think).

that's getHeight in some of the font classes - correct?


Yes



Shall I add a ticket or do we handle that with PDFBOX-4071?


There's PDFBOX-3709 for that :-)

Tilman



BR
Maruan



Tilman

Am 03.02.2018 um 19:56 schrieb Maruan Sahyoun:

Hi,

there are a number of deprecated constructors, methods and fields in trunk 
which we deprecated in 2.0.x.

What about starting to remove these while we are working on some of the 
affected classes?

BR
Maruan


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: Removing methods deprectaed in 2.0.x in trunk

[Maruan Sahyoun]

> Am 03.02.2018 um 20:28 schrieb Tilman Hausherr :
> 
> Yes with some exceptions:
> - keep the "raw" methods from the contentstream classes because some people 
> may use them anyway

I'd like to keep them too as it allows people who know what they do to use 
them. Why not remove the deprecation notice in 2.0?

> - keep the "height" methods that are mentioned in the builds because these 
> are still being used by ourselves (I think).

that's getHeight in some of the font classes - correct? 

Shall I add a ticket or do we handle that with PDFBOX-4071?

BR
Maruan


> 
> Tilman
> 
> Am 03.02.2018 um 19:56 schrieb Maruan Sahyoun:
>> Hi,
>> 
>> there are a number of deprecated constructors, methods and fields in trunk 
>> which we deprecated in 2.0.x.
>> 
>> What about starting to remove these while we are working on some of the 
>> affected classes?
>> 
>> BR
>> Maruan
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
>> For additional commands, e-mail: dev-h...@pdfbox.apache.org
>> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
> For additional commands, e-mail: dev-h...@pdfbox.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: Removing methods deprectaed in 2.0.x in trunk

[Tilman Hausherr]

Yes with some exceptions:
- keep the "raw" methods from the contentstream classes because some 
people may use them anyway
- keep the "height" methods that are mentioned in the builds because 
these are still being used by ourselves (I think).


Tilman

Am 03.02.2018 um 19:56 schrieb Maruan Sahyoun:

Hi,

there are a number of deprecated constructors, methods and fields in trunk 
which we deprecated in 2.0.x.

What about starting to remove these while we are working on some of the 
affected classes?

BR
Maruan


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org