[jira] [Commented] (PDFBOX-4071) Improve code quality (3)
[ https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394863#comment-16394863 ] ASF subversion and git services commented on PDFBOX-4071: - Commit 1826501 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1826501 ] PDFBOX-4071: fix formatting > Improve code quality (3) > > > Key: PDFBOX-4071 > URL: https://issues.apache.org/jira/browse/PDFBOX-4071 > Project: PDFBox > Issue Type: Task >Affects Versions: 2.0.8 >Reporter: Tilman Hausherr >Priority: Major > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2852, which was getting too long. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4071) Improve code quality (3)
[ https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394844#comment-16394844 ] ASF subversion and git services commented on PDFBOX-4071: - Commit 1826500 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1826500 ] PDFBOX-4071: remove unused import > Improve code quality (3) > > > Key: PDFBOX-4071 > URL: https://issues.apache.org/jira/browse/PDFBOX-4071 > Project: PDFBox > Issue Type: Task >Affects Versions: 2.0.8 >Reporter: Tilman Hausherr >Priority: Major > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2852, which was getting too long. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4071) Improve code quality (3)
[ https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394842#comment-16394842 ] ASF subversion and git services commented on PDFBOX-4071: - Commit 1826499 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1826499 ] PDFBOX-4071: remove unused field; split large method > Improve code quality (3) > > > Key: PDFBOX-4071 > URL: https://issues.apache.org/jira/browse/PDFBOX-4071 > Project: PDFBox > Issue Type: Task >Affects Versions: 2.0.8 >Reporter: Tilman Hausherr >Priority: Major > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2852, which was getting too long. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4149) PDF consisting on one page with 5 MB renders until the end of time using renderImageWithDPI
[
https://issues.apache.org/jira/browse/PDFBOX-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394868#comment-16394868
]
ASF subversion and git services commented on PDFBOX-4149:
-
Commit 1826505 from [~tilman] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826505 ]
PDFBOX-4149: use cache when creating base colorspace in indexed colorspace
> PDF consisting on one page with 5 MB renders until the end of time using
> renderImageWithDPI
> ---
>
> Key: PDFBOX-4149
> URL: https://issues.apache.org/jira/browse/PDFBOX-4149
> Project: PDFBox
> Issue Type: Bug
> Components: Rendering
>Affects Versions: 2.0.8
>Reporter: Christian
>Priority: Major
> Attachments: SB_Flyer_SpargelPromo_03-062018.pdf
>
>
> I am using PDFBOX 2.0.8 on a Java VM 1.8.0_151
> The attached and valid pdf should be rendered by calling
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> But the rendering never ends - the only thing I see is this line repeating
> very often in the console:
> [Finalizer] DEBUG org.apache.pdfbox.io.ScratchFileBuffer - ScratchFileBuffer
> not closed!
> Here is the code that is used to open the document and then start the
> rendering:
> {code:java}
> PDDocument document = PDDocument.load(file,
> MemoryUsageSetting.setupTempFileOnly());
> try {
>PDFRenderer pdfRenderer = new PDFRenderer(document);
>int numberOfPages = document.getPages().getCount();
>for (int i = 0; i < numberOfPages; i++) {
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> [...]
> {code}
> The line
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> is never passed. I ran a test and have wait for 30 minutes to let it pass,
> but nothing happens.
> Please advise what to do and how to solve the issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4149) PDF consisting on one page with 5 MB renders until the end of time using renderImageWithDPI
[
https://issues.apache.org/jira/browse/PDFBOX-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394867#comment-16394867
]
ASF subversion and git services commented on PDFBOX-4149:
-
Commit 1826504 from [~tilman] in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1826504 ]
PDFBOX-4149: use cache when creating base colorspace in indexed colorspace
> PDF consisting on one page with 5 MB renders until the end of time using
> renderImageWithDPI
> ---
>
> Key: PDFBOX-4149
> URL: https://issues.apache.org/jira/browse/PDFBOX-4149
> Project: PDFBox
> Issue Type: Bug
> Components: Rendering
>Affects Versions: 2.0.8
>Reporter: Christian
>Priority: Major
> Attachments: SB_Flyer_SpargelPromo_03-062018.pdf
>
>
> I am using PDFBOX 2.0.8 on a Java VM 1.8.0_151
> The attached and valid pdf should be rendered by calling
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> But the rendering never ends - the only thing I see is this line repeating
> very often in the console:
> [Finalizer] DEBUG org.apache.pdfbox.io.ScratchFileBuffer - ScratchFileBuffer
> not closed!
> Here is the code that is used to open the document and then start the
> rendering:
> {code:java}
> PDDocument document = PDDocument.load(file,
> MemoryUsageSetting.setupTempFileOnly());
> try {
>PDFRenderer pdfRenderer = new PDFRenderer(document);
>int numberOfPages = document.getPages().getCount();
>for (int i = 0; i < numberOfPages; i++) {
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> [...]
> {code}
> The line
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> is never passed. I ran a test and have wait for 30 minutes to let it pass,
> but nothing happens.
> Please advise what to do and how to solve the issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4071) Improve code quality (3)
[ https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394883#comment-16394883 ] ASF subversion and git services commented on PDFBOX-4071: - Commit 1826511 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1826511 ] PDFBOX-4071: make public menu items final > Improve code quality (3) > > > Key: PDFBOX-4071 > URL: https://issues.apache.org/jira/browse/PDFBOX-4071 > Project: PDFBox > Issue Type: Task >Affects Versions: 2.0.8 >Reporter: Tilman Hausherr >Priority: Major > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2852, which was getting too long. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4071) Improve code quality (3)
[ https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395640#comment-16395640 ] Maruan Sahyoun commented on PDFBOX-4071: [~tilman] which platform are you on? On my OS X and Linux machine all menus items look the same. > Improve code quality (3) > > > Key: PDFBOX-4071 > URL: https://issues.apache.org/jira/browse/PDFBOX-4071 > Project: PDFBox > Issue Type: Task >Affects Versions: 2.0.8 >Reporter: Tilman Hausherr >Priority: Major > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2852, which was getting too long. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Updated] (PDFBOX-4071) Improve code quality (3)
[ https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tilman Hausherr updated PDFBOX-4071: Attachment: pdfbox-screenshot-bad.png pdfbox-screenshot-good.png > Improve code quality (3) > > > Key: PDFBOX-4071 > URL: https://issues.apache.org/jira/browse/PDFBOX-4071 > Project: PDFBox > Issue Type: Task >Affects Versions: 2.0.8 >Reporter: Tilman Hausherr >Priority: Major > Attachments: pdfbox-screenshot-bad.png, pdfbox-screenshot-good.png > > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2852, which was getting too long. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4071) Improve code quality (3)
[ https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395663#comment-16395663 ] Tilman Hausherr commented on PDFBOX-4071: - Windows. > Improve code quality (3) > > > Key: PDFBOX-4071 > URL: https://issues.apache.org/jira/browse/PDFBOX-4071 > Project: PDFBox > Issue Type: Task >Affects Versions: 2.0.8 >Reporter: Tilman Hausherr >Priority: Major > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2852, which was getting too long. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4071) Improve code quality (3)
[ https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395683#comment-16395683 ] Maruan Sahyoun commented on PDFBOX-4071: Would you mind adding a screenshot before/after the change - looking on my Windows 10 machine it looks fine to me. > Improve code quality (3) > > > Key: PDFBOX-4071 > URL: https://issues.apache.org/jira/browse/PDFBOX-4071 > Project: PDFBox > Issue Type: Task >Affects Versions: 2.0.8 >Reporter: Tilman Hausherr >Priority: Major > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2852, which was getting too long. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4146) Patch: Fix for appearance of visible signature
[ https://issues.apache.org/jira/browse/PDFBOX-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395706#comment-16395706 ] Martin Mancuska commented on PDFBOX-4146: - You're welcome [~tilman]. Thanks for link, but for signing we use DSS ([https://github.com/esig/dss)] and it uses PDFBox as backend. > Patch: Fix for appearance of visible signature > -- > > Key: PDFBOX-4146 > URL: https://issues.apache.org/jira/browse/PDFBOX-4146 > Project: PDFBox > Issue Type: Bug > Components: Signing >Affects Versions: 2.0.8 >Reporter: Martin Mancuska >Assignee: Tilman Hausherr >Priority: Minor > Labels: Signature, patch > Fix For: 2.0.9, 3.0.0 PDFBox > > Attachments: visible_signature.patch > > > We're using PDFBox (as backend used by Esig DSS) for digital signing of > documents. We've found out that visible signature has different look on Mac > Preview app than other PDF viewers. After some investigation we suspect that > BBox-es for appearance of signature is not filled correctly by PDFBox. The > values are hard coded as [0, 0, 100, 50]. Also transformation matrix for > translating from form XObject coordinate system into default one has value > (1, 0, 0, 1, 0, 0) -> no scaling between default user coordinate system and > form XObject coordinate system. > Therefore I think that the Mac Preview App draws signature with dimensions > 100x50 because no transformation were done. > I've attached patch which solves this issue for us. The signature is shown > correctly in all PDF viewers now. Maybe you can take a look on it and > integrate it into your code base, or propose better solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4071) Improve code quality (3)
[ https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395724#comment-16395724 ] Tilman Hausherr commented on PDFBOX-4071: - That's on Windows 10, for which I am using an UHD monitor. On Windows 7 the size difference doesn't occur, only the weird square icons. > Improve code quality (3) > > > Key: PDFBOX-4071 > URL: https://issues.apache.org/jira/browse/PDFBOX-4071 > Project: PDFBox > Issue Type: Task >Affects Versions: 2.0.8 >Reporter: Tilman Hausherr >Priority: Major > Attachments: pdfbox-screenshot-bad.png, pdfbox-screenshot-good.png > > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2852, which was getting too long. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4071) Improve code quality (3)
[ https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395553#comment-16395553 ] Tilman Hausherr commented on PDFBOX-4071: - [~msahyoun] your commit in PDFDebugger has a weird effect on the menu. It looks different. This could be because the items are now created before the look & feel has been set. > Improve code quality (3) > > > Key: PDFBOX-4071 > URL: https://issues.apache.org/jira/browse/PDFBOX-4071 > Project: PDFBox > Issue Type: Task >Affects Versions: 2.0.8 >Reporter: Tilman Hausherr >Priority: Major > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2852, which was getting too long. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
RE: PDFBox 2.0.9 release?
> ok => Tim, please start again Will start now.
[jira] [Commented] (PDFBOX-4149) PDF consisting on one page with 5 MB renders until the end of time using renderImageWithDPI
[
https://issues.apache.org/jira/browse/PDFBOX-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395494#comment-16395494
]
ASF subversion and git services commented on PDFBOX-4149:
-
Commit 1826574 from [~tilman] in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1826574 ]
PDFBOX-4149: forgot to use new constructor
> PDF consisting on one page with 5 MB renders until the end of time using
> renderImageWithDPI
> ---
>
> Key: PDFBOX-4149
> URL: https://issues.apache.org/jira/browse/PDFBOX-4149
> Project: PDFBox
> Issue Type: Bug
> Components: Rendering
>Affects Versions: 2.0.8
>Reporter: Christian
>Priority: Major
> Attachments: SB_Flyer_SpargelPromo_03-062018.pdf
>
>
> I am using PDFBOX 2.0.8 on a Java VM 1.8.0_151
> The attached and valid pdf should be rendered by calling
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> But the rendering never ends - the only thing I see is this line repeating
> very often in the console:
> [Finalizer] DEBUG org.apache.pdfbox.io.ScratchFileBuffer - ScratchFileBuffer
> not closed!
> Here is the code that is used to open the document and then start the
> rendering:
> {code:java}
> PDDocument document = PDDocument.load(file,
> MemoryUsageSetting.setupTempFileOnly());
> try {
>PDFRenderer pdfRenderer = new PDFRenderer(document);
>int numberOfPages = document.getPages().getCount();
>for (int i = 0; i < numberOfPages; i++) {
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> [...]
> {code}
> The line
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> is never passed. I ran a test and have wait for 30 minutes to let it pass,
> but nothing happens.
> Please advise what to do and how to solve the issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4146) Patch: Fix for appearance of visible signature
[ https://issues.apache.org/jira/browse/PDFBOX-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395503#comment-16395503 ] ASF subversion and git services commented on PDFBOX-4146: - Commit 1826576 from [~tilman] in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1826576 ] PDFBOX-4146: use same bbox size as image size instead of hard coded values to avoid confusing Mac Preview app, as suggested by Martin Mancuska > Patch: Fix for appearance of visible signature > -- > > Key: PDFBOX-4146 > URL: https://issues.apache.org/jira/browse/PDFBOX-4146 > Project: PDFBox > Issue Type: Bug > Components: Signing >Affects Versions: 2.0.8 >Reporter: Martin Mancuska >Priority: Minor > Labels: Signature, patch > Fix For: 2.0.9 > > Attachments: visible_signature.patch > > > We're using PDFBox (as backend used by Esig DSS) for digital signing of > documents. We've found out that visible signature has different look on Mac > Preview app than other PDF viewers. After some investigation we suspect that > BBox-es for appearance of signature is not filled correctly by PDFBox. The > values are hard coded as [0, 0, 100, 50]. Also transformation matrix for > translating from form XObject coordinate system into default one has value > (1, 0, 0, 1, 0, 0) -> no scaling between default user coordinate system and > form XObject coordinate system. > Therefore I think that the Mac Preview App draws signature with dimensions > 100x50 because no transformation were done. > I've attached patch which solves this issue for us. The signature is shown > correctly in all PDF viewers now. Maybe you can take a look on it and > integrate it into your code base, or propose better solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4146) Patch: Fix for appearance of visible signature
[ https://issues.apache.org/jira/browse/PDFBOX-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395502#comment-16395502 ] ASF subversion and git services commented on PDFBOX-4146: - Commit 1826575 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1826575 ] PDFBOX-4146: use same bbox size as image size instead of hard coded values to avoid confusing Mac Preview app, as suggested by Martin Mancuska > Patch: Fix for appearance of visible signature > -- > > Key: PDFBOX-4146 > URL: https://issues.apache.org/jira/browse/PDFBOX-4146 > Project: PDFBox > Issue Type: Bug > Components: Signing >Affects Versions: 2.0.8 >Reporter: Martin Mancuska >Priority: Minor > Labels: Signature, patch > Fix For: 2.0.9 > > Attachments: visible_signature.patch > > > We're using PDFBox (as backend used by Esig DSS) for digital signing of > documents. We've found out that visible signature has different look on Mac > Preview app than other PDF viewers. After some investigation we suspect that > BBox-es for appearance of signature is not filled correctly by PDFBox. The > values are hard coded as [0, 0, 100, 50]. Also transformation matrix for > translating from form XObject coordinate system into default one has value > (1, 0, 0, 1, 0, 0) -> no scaling between default user coordinate system and > form XObject coordinate system. > Therefore I think that the Mac Preview App draws signature with dimensions > 100x50 because no transformation were done. > I've attached patch which solves this issue for us. The signature is shown > correctly in all PDF viewers now. Maybe you can take a look on it and > integrate it into your code base, or propose better solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Resolved] (PDFBOX-4146) Patch: Fix for appearance of visible signature
[ https://issues.apache.org/jira/browse/PDFBOX-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tilman Hausherr resolved PDFBOX-4146. - Resolution: Fixed Assignee: Tilman Hausherr Fix Version/s: 3.0.0 PDFBox Thank you [~mato7d5]! Btw there is an alternative example for visual signing available in the repository and in the next source download, see also https://stackoverflow.com/questions/44311502/in-java-using-pdfbox-how-to-create-visible-digital-signature-with-text > Patch: Fix for appearance of visible signature > -- > > Key: PDFBOX-4146 > URL: https://issues.apache.org/jira/browse/PDFBOX-4146 > Project: PDFBox > Issue Type: Bug > Components: Signing >Affects Versions: 2.0.8 >Reporter: Martin Mancuska >Assignee: Tilman Hausherr >Priority: Minor > Labels: Signature, patch > Fix For: 2.0.9, 3.0.0 PDFBox > > Attachments: visible_signature.patch > > > We're using PDFBox (as backend used by Esig DSS) for digital signing of > documents. We've found out that visible signature has different look on Mac > Preview app than other PDF viewers. After some investigation we suspect that > BBox-es for appearance of signature is not filled correctly by PDFBox. The > values are hard coded as [0, 0, 100, 50]. Also transformation matrix for > translating from form XObject coordinate system into default one has value > (1, 0, 0, 1, 0, 0) -> no scaling between default user coordinate system and > form XObject coordinate system. > Therefore I think that the Mac Preview App draws signature with dimensions > 100x50 because no transformation were done. > I've attached patch which solves this issue for us. The signature is shown > correctly in all PDF viewers now. Maybe you can take a look on it and > integrate it into your code base, or propose better solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Created] (PDFBOX-4150) Optimize clipping text rendering modes
Tilman Hausherr created PDFBOX-4150:
---
Summary: Optimize clipping text rendering modes
Key: PDFBOX-4150
URL: https://issues.apache.org/jira/browse/PDFBOX-4150
Project: PDFBox
Issue Type: Improvement
Components: Rendering
Affects Versions: 2.0.8
Reporter: Tilman Hausherr
Assignee: Tilman Hausherr
I noticed that the file from PDFBOX-2035 needs 210 seconds on my new PC. The
profiler shows that much time is lost in {{pruneEdges}}. A google search hit
the linked SO issue. So I changed PageDrawer. Times on new PC with energy
setting to maximum:
- PDFBOX-1350: 53 secs before, 12 secs after
- PDFBOX-2035: 210 secs before, 9 secs after
- all tests: 424 secs before, 247 secs after (the difference is mostly because
of PDFBOX-2035 which prevents termnination of the test)
- all tests except the two: 246 secs before, 230 secs after
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4150) Optimize clipping text rendering modes
[
https://issues.apache.org/jira/browse/PDFBOX-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395535#comment-16395535
]
ASF subversion and git services commented on PDFBOX-4150:
-
Commit 1826578 from [~tilman] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826578 ]
PDFBOX-4150: speed up by appending to a path instead of adding to a shape, as
suggested by fonkap on stackoverflow
> Optimize clipping text rendering modes
> --
>
> Key: PDFBOX-4150
> URL: https://issues.apache.org/jira/browse/PDFBOX-4150
> Project: PDFBox
> Issue Type: Improvement
> Components: Rendering
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Labels: optimization
>
> I noticed that the file from PDFBOX-2035 needs 210 seconds on my new PC. The
> profiler shows that much time is lost in {{java.awt.geom.AreaOp.pruneEdges}}.
> A google search hit the linked SO issue. So I changed PageDrawer. Times on
> new PC with energy setting to maximum:
> - PDFBOX-1350: 53 secs before, 12 secs after
> - PDFBOX-2035: 210 secs before, 9 secs after
> - all tests: 424 secs before, 247 secs after (the difference is mostly
> because of PDFBOX-2035 which prevents termnination of the test)
> - all tests except the two: 246 secs before, 230 secs after
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Updated] (PDFBOX-4150) Optimize clipping text rendering modes
[
https://issues.apache.org/jira/browse/PDFBOX-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tilman Hausherr updated PDFBOX-4150:
Description:
I noticed that the file from PDFBOX-2035 needs 210 seconds on my new PC. The
profiler shows that much time is lost in {{java.awt.geom.AreaOp.pruneEdges}}. A
google search hit the linked SO issue. So I changed PageDrawer. Times on new PC
with energy setting to maximum:
- PDFBOX-1350: 53 secs before, 12 secs after
- PDFBOX-2035: 210 secs before, 9 secs after
- all tests: 424 secs before, 247 secs after (the difference is mostly because
of PDFBOX-2035 which prevents termnination of the test)
- all tests except the two: 246 secs before, 230 secs after
was:
I noticed that the file from PDFBOX-2035 needs 210 seconds on my new PC. The
profiler shows that much time is lost in {{pruneEdges}}. A google search hit
the linked SO issue. So I changed PageDrawer. Times on new PC with energy
setting to maximum:
- PDFBOX-1350: 53 secs before, 12 secs after
- PDFBOX-2035: 210 secs before, 9 secs after
- all tests: 424 secs before, 247 secs after (the difference is mostly because
of PDFBOX-2035 which prevents termnination of the test)
- all tests except the two: 246 secs before, 230 secs after
> Optimize clipping text rendering modes
> --
>
> Key: PDFBOX-4150
> URL: https://issues.apache.org/jira/browse/PDFBOX-4150
> Project: PDFBox
> Issue Type: Improvement
> Components: Rendering
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Labels: optimization
>
> I noticed that the file from PDFBOX-2035 needs 210 seconds on my new PC. The
> profiler shows that much time is lost in {{java.awt.geom.AreaOp.pruneEdges}}.
> A google search hit the linked SO issue. So I changed PageDrawer. Times on
> new PC with energy setting to maximum:
> - PDFBOX-1350: 53 secs before, 12 secs after
> - PDFBOX-2035: 210 secs before, 9 secs after
> - all tests: 424 secs before, 247 secs after (the difference is mostly
> because of PDFBOX-2035 which prevents termnination of the test)
> - all tests except the two: 246 secs before, 230 secs after
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4150) Optimize clipping text rendering modes
[
https://issues.apache.org/jira/browse/PDFBOX-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395536#comment-16395536
]
ASF subversion and git services commented on PDFBOX-4150:
-
Commit 1826579 from [~tilman] in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1826579 ]
PDFBOX-4150: speed up by appending to a path instead of adding to a shape, as
suggested by fonkap on stackoverflow
> Optimize clipping text rendering modes
> --
>
> Key: PDFBOX-4150
> URL: https://issues.apache.org/jira/browse/PDFBOX-4150
> Project: PDFBox
> Issue Type: Improvement
> Components: Rendering
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Labels: optimization
> Fix For: 2.0.9, 3.0.0 PDFBox
>
>
> I noticed that the file from PDFBOX-2035 needs 210 seconds on my new PC. The
> profiler shows that much time is lost in {{java.awt.geom.AreaOp.pruneEdges}}.
> A google search hit the linked SO issue. So I changed PageDrawer. Times on
> new PC with energy setting to maximum:
> - PDFBOX-1350: 53 secs before, 12 secs after
> - PDFBOX-2035: 210 secs before, 9 secs after
> - all tests: 424 secs before, 247 secs after (the difference is mostly
> because of PDFBOX-2035 which prevents termnination of the test)
> - all tests except the two: 246 secs before, 230 secs after
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Resolved] (PDFBOX-4150) Optimize clipping text rendering modes
[
https://issues.apache.org/jira/browse/PDFBOX-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tilman Hausherr resolved PDFBOX-4150.
-
Resolution: Fixed
Fix Version/s: 3.0.0 PDFBox
2.0.9
> Optimize clipping text rendering modes
> --
>
> Key: PDFBOX-4150
> URL: https://issues.apache.org/jira/browse/PDFBOX-4150
> Project: PDFBox
> Issue Type: Improvement
> Components: Rendering
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Labels: optimization
> Fix For: 2.0.9, 3.0.0 PDFBox
>
>
> I noticed that the file from PDFBOX-2035 needs 210 seconds on my new PC. The
> profiler shows that much time is lost in {{java.awt.geom.AreaOp.pruneEdges}}.
> A google search hit the linked SO issue. So I changed PageDrawer. Times on
> new PC with energy setting to maximum:
> - PDFBOX-1350: 53 secs before, 12 secs after
> - PDFBOX-2035: 210 secs before, 9 secs after
> - all tests: 424 secs before, 247 secs after (the difference is mostly
> because of PDFBOX-2035 which prevents termnination of the test)
> - all tests except the two: 246 secs before, 230 secs after
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4071) Improve code quality (3)
[ https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396201#comment-16396201 ] Maruan Sahyoun commented on PDFBOX-4071: I've tried Windows 10 4K resolution and different scalings but couldn't reproduce the issue you are experiencing. Anyway, I'll revert the change tomorrow. IMHO the square icons are OK as can be seen from other Windows applications such as Windows Explorer which has empty check boxes in front of "checkable" menu items to give a visual hint about that. > Improve code quality (3) > > > Key: PDFBOX-4071 > URL: https://issues.apache.org/jira/browse/PDFBOX-4071 > Project: PDFBox > Issue Type: Task >Affects Versions: 2.0.8 >Reporter: Tilman Hausherr >Priority: Major > Attachments: pdfbox-screenshot-bad.png, pdfbox-screenshot-good.png > > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2852, which was getting too long. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
RE: PDFBox 2.0.9 release?
Reports are available here: http://162.242.228.174/reports/pdfbox-2.0.9-pre-rc1_reports_2.tar.bz2
[jira] [Commented] (PDFBOX-4149) PDF consisting on one page with 5 MB renders until the end of time using renderImageWithDPI
[
https://issues.apache.org/jira/browse/PDFBOX-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395873#comment-16395873
]
ASF subversion and git services commented on PDFBOX-4149:
-
Commit 1826590 from [~tilman] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826590 ]
PDFBOX-4149: fix typo
> PDF consisting on one page with 5 MB renders until the end of time using
> renderImageWithDPI
> ---
>
> Key: PDFBOX-4149
> URL: https://issues.apache.org/jira/browse/PDFBOX-4149
> Project: PDFBox
> Issue Type: Bug
> Components: Rendering
>Affects Versions: 2.0.8
>Reporter: Christian
>Priority: Major
> Attachments: SB_Flyer_SpargelPromo_03-062018.pdf
>
>
> I am using PDFBOX 2.0.8 on a Java VM 1.8.0_151
> The attached and valid pdf should be rendered by calling
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> But the rendering never ends - the only thing I see is this line repeating
> very often in the console:
> [Finalizer] DEBUG org.apache.pdfbox.io.ScratchFileBuffer - ScratchFileBuffer
> not closed!
> Here is the code that is used to open the document and then start the
> rendering:
> {code:java}
> PDDocument document = PDDocument.load(file,
> MemoryUsageSetting.setupTempFileOnly());
> try {
>PDFRenderer pdfRenderer = new PDFRenderer(document);
>int numberOfPages = document.getPages().getCount();
>for (int i = 0; i < numberOfPages; i++) {
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> [...]
> {code}
> The line
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> is never passed. I ran a test and have wait for 30 minutes to let it pass,
> but nothing happens.
> Please advise what to do and how to solve the issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4149) PDF consisting on one page with 5 MB renders until the end of time using renderImageWithDPI
[
https://issues.apache.org/jira/browse/PDFBOX-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395874#comment-16395874
]
ASF subversion and git services commented on PDFBOX-4149:
-
Commit 1826591 from [~tilman] in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1826591 ]
PDFBOX-4149: fix typo
> PDF consisting on one page with 5 MB renders until the end of time using
> renderImageWithDPI
> ---
>
> Key: PDFBOX-4149
> URL: https://issues.apache.org/jira/browse/PDFBOX-4149
> Project: PDFBox
> Issue Type: Bug
> Components: Rendering
>Affects Versions: 2.0.8
>Reporter: Christian
>Priority: Major
> Attachments: SB_Flyer_SpargelPromo_03-062018.pdf
>
>
> I am using PDFBOX 2.0.8 on a Java VM 1.8.0_151
> The attached and valid pdf should be rendered by calling
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> But the rendering never ends - the only thing I see is this line repeating
> very often in the console:
> [Finalizer] DEBUG org.apache.pdfbox.io.ScratchFileBuffer - ScratchFileBuffer
> not closed!
> Here is the code that is used to open the document and then start the
> rendering:
> {code:java}
> PDDocument document = PDDocument.load(file,
> MemoryUsageSetting.setupTempFileOnly());
> try {
>PDFRenderer pdfRenderer = new PDFRenderer(document);
>int numberOfPages = document.getPages().getCount();
>for (int i = 0; i < numberOfPages; i++) {
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> [...]
> {code}
> The line
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> is never passed. I ran a test and have wait for 30 minutes to let it pass,
> but nothing happens.
> Please advise what to do and how to solve the issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-2092) Very slow rendering of scanned document
[
https://issues.apache.org/jira/browse/PDFBOX-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395876#comment-16395876
]
Tilman Hausherr commented on PDFBOX-2092:
-
{quote}with a call to PDResources.getXObjects taking roughly half of that and
PageDrawer.drawImage taking the other half.
{quote}
That's the double decoding, which has been fixed in PDFBOX-3340.
Re the code by Petr: I believe something like this has been done in
PDFBOX-3791, see "compromise between memory and time usage" code comment.
Re the patch by Petr: I haven't tested it due to the problems I mentioned, and
because there is a new reason for not using it: we avoid the creation of custom
formats, see PDFBOX-3854.
What remains in the profiler is related to the fact that this image is huge.
Subsampling (PDFBOX-4137) can be one solution.
Another mystery is that rendering time for this file in PDFDebugger went up
between 2.0.6 (2017-06-26) and 2.0.7 (2017-10-04). The cause is... PDFBOX-3854
:(
> Very slow rendering of scanned document
> ---
>
> Key: PDFBOX-2092
> URL: https://issues.apache.org/jira/browse/PDFBOX-2092
> Project: PDFBox
> Issue Type: Improvement
> Components: Rendering
>Affects Versions: 2.0.0
> Environment: Win7 x64 EN
> JDK6,JDK7,JDK8
>Reporter: Juraj Lonc
>Priority: Major
> Attachments: PDFBOX-2092.patch, SCAN_20140522_160457490_page2.pdf
>
>
> It takes extremely long to render this file to image.
> Depends on computer but it can take 15s+ to render 1 page.
> When I skip drawing of inserted image /Im0, then rendering is fast. So there
> is something wrong with drawing that image in
> {code}
> PageDrawer.drawImage(Image awtImage, AffineTransform at)
> {code}
> when I comment out line
> {code}
> graphics.drawImage(awtImage, imageTransform, null);
> {code}
> then rendering process takes 6s
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-2092) Very slow rendering of scanned document
[
https://issues.apache.org/jira/browse/PDFBOX-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395880#comment-16395880
]
patrick achat commented on PDFBOX-2092:
---
To authenticate your email, go to
http://asp33.mailinblack.com/captchaCom/captcha.jsp?id=NDAyODE2ZGM1Njk4NTVlZTAxNTcyODE2ZmRiMzU4YjA7amlyYUBhcGFjaGUub3JnO0VOOzRXMU82dEJXRHhuYlZNTHpUT0gvbzVERGd3TT0==en
More information in HTML part
> Very slow rendering of scanned document
> ---
>
> Key: PDFBOX-2092
> URL: https://issues.apache.org/jira/browse/PDFBOX-2092
> Project: PDFBox
> Issue Type: Improvement
> Components: Rendering
>Affects Versions: 2.0.0
> Environment: Win7 x64 EN
> JDK6,JDK7,JDK8
>Reporter: Juraj Lonc
>Priority: Major
> Attachments: PDFBOX-2092.patch, SCAN_20140522_160457490_page2.pdf
>
>
> It takes extremely long to render this file to image.
> Depends on computer but it can take 15s+ to render 1 page.
> When I skip drawing of inserted image /Im0, then rendering is fast. So there
> is something wrong with drawing that image in
> {code}
> PageDrawer.drawImage(Image awtImage, AffineTransform at)
> {code}
> when I comment out line
> {code}
> graphics.drawImage(awtImage, imageTransform, null);
> {code}
> then rendering process takes 6s
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
Re: PDFBox 2.0.9 release?
Am 11.03.2018 um 14:26 schrieb Andreas Lehmkuehler: On 03/11/2018 12:31 PM, Tilman Hausherr wrote: Am 04.03.2018 um 12:50 schrieb Andreas Lehmkuehler: now that we got the JBIG2 ImageIO out of the door it's time to release a new 2.0.x version of PDFBox. Hello Andreas, Could you please configure a 2.0.10 target? We might need it. Done, and btw I made you admin so that I'm no longer the bottle neck Thanks for both. The second one was very useful 1 minute ago :-) Tilman Andreas Tilman - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Issue Comment Deleted] (PDFBOX-2092) Very slow rendering of scanned document
[
https://issues.apache.org/jira/browse/PDFBOX-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tilman Hausherr updated PDFBOX-2092:
Comment: was deleted
(was: To authenticate your email, go to
http://asp33.mailinblack.com/captchaCom/captcha.jsp?id=NDAyODE2ZGM1Njk4NTVlZTAxNTcyODE2ZmRiMzU4YjA7amlyYUBhcGFjaGUub3JnO0VOOzRXMU82dEJXRHhuYlZNTHpUT0gvbzVERGd3TT0==en
More information in HTML part
)
> Very slow rendering of scanned document
> ---
>
> Key: PDFBOX-2092
> URL: https://issues.apache.org/jira/browse/PDFBOX-2092
> Project: PDFBox
> Issue Type: Improvement
> Components: Rendering
>Affects Versions: 2.0.0
> Environment: Win7 x64 EN
> JDK6,JDK7,JDK8
>Reporter: Juraj Lonc
>Priority: Major
> Attachments: PDFBOX-2092.patch, SCAN_20140522_160457490_page2.pdf
>
>
> It takes extremely long to render this file to image.
> Depends on computer but it can take 15s+ to render 1 page.
> When I skip drawing of inserted image /Im0, then rendering is fast. So there
> is something wrong with drawing that image in
> {code}
> PageDrawer.drawImage(Image awtImage, AffineTransform at)
> {code}
> when I comment out line
> {code}
> graphics.drawImage(awtImage, imageTransform, null);
> {code}
> then rendering process takes 6s
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
