[jira] [Commented] (PDFBOX-5138) Embedded files not extracted from PDF files with multilevel EmbeddedFiles tree
[ https://issues.apache.org/jira/browse/PDFBOX-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307612#comment-17307612 ] ASF subversion and git services commented on PDFBOX-5138: - Commit 1887990 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1887990 ] PDFBOX-5138: SonarQube fix > Embedded files not extracted from PDF files with multilevel EmbeddedFiles tree > -- > > Key: PDFBOX-5138 > URL: https://issues.apache.org/jira/browse/PDFBOX-5138 > Project: PDFBox > Issue Type: Bug > Components: Utilities >Affects Versions: 2.0.23 >Reporter: Tilman Hausherr >Assignee: Tilman Hausherr >Priority: Major > Fix For: 2.0.24, 3.0.0 PDFBox > > Attachments: pdfcpu-201-0.zip-0.pdf > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307620#comment-17307620 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1887992 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1887992 ] PDFBOX-4892: avoid possible later UnsupportedOperationException in readRaster() due to non null loop ending without raster capability > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307619#comment-17307619 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1887991 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1887991 ] PDFBOX-4892: avoid possible later UnsupportedOperationException in readRaster() due to non null loop ending without raster capability > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements
valerybokov commented on pull request #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-805890260 In https://issues.apache.org/jira/browse/PDFBOX-2941?filter=allopenissues is written "show page labels additional to page number (see file from TIKA-2121 as example)". The PagePane.initUI has label initialsation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Updated] (PDFBOX-5139) Signing PDF with empty fields multiple times breaks signature
[ https://issues.apache.org/jira/browse/PDFBOX-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabricio updated PDFBOX-5139: - Description: Hi! I apologize if there is already a similar report. We have a PDF document with multiple empty signature fields. We are currently preparing the document and adding the fields with the javascript library PSPDFKit. Our signature implementation with PDFBOX is based on [https://apache.googlesource.com/pdfbox/+/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature2.java] When signing the document more than one time, the first signature is invalidated for some PDF Spec versions. We tried adding the new signatures in the existing fields, and in new ones, but the results is the same. The multiple signature works well with PDF versions 1.4 and 1.6. It does not work with versions 1.5 and 1.7. The first signature is invalidated by the second one. Initially, I had the doubt if this problem was related to PSDPFKit or PDF-Box. While investigating, we tried to sign the 1.5 spec version document multiple times using iText and it worked ok. I'm attaching 10 pdfs: * For each spec version, one PDF with the empty signature fields, and another one with 2 signatures made by Apache PDF-Box. * Specs 1.5 and 1.7 signed 2 times by itext. Thank you for your help. Fabricio Edit 1: We are not using the certify functionality (SigUtils.setMDPPermission). was: Hi! I apologize if there is already a similar report. We have a PDF document with multiple empty signature fields. We are currently preparing the document and adding the fields with the javascript library PSPDFKit. Our signature implementation with PDFBOX is based on [https://apache.googlesource.com/pdfbox/+/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature2.java] When signing the document more than one time, the first signature is invalidated for some PDF Spec versions. We tried adding the new signatures in the existing fields, and in new ones, but the results is the same. The multiple signature works well with PDF versions 1.4 and 1.6. It does not work with versions 1.5 and 1.7. The first signature is invalidated by the second one. Initially, I had the doubt if this problem was related to PSDPFKit or PDF-Box. While investigating, we tried to sign the 1.5 spec version document multiple times using iText and it worked ok. I'm attaching 10 pdfs: * For each spec version, one PDF with the empty signature fields, and another one with 2 signatures made by Apache PDF-Box. * Specs 1.5 and 1.7 signed 2 times by itext. Thank you for your help. Fabricio > Signing PDF with empty fields multiple times breaks signature > - > > Key: PDFBOX-5139 > URL: https://issues.apache.org/jira/browse/PDFBOX-5139 > Project: PDFBox > Issue Type: Bug >Affects Versions: 2.0.23 >Reporter: Fabricio >Priority: Major > Attachments: 1.4.pdf, 1.4.signed.signed.pdf, > 1.5.itext.signed.signed.pdf, 1.5.pdf, 1.5.signed.signed.pdf, 1.6.pdf, > 1.6.signed.signed.pdf, 1.7.itext.signed.signed.pdf, 1.7.pdf, > 1.7.signed.signed.pdf > > > Hi! > I apologize if there is already a similar report. > We have a PDF document with multiple empty signature fields. We are currently > preparing the document and adding the fields with the javascript library > PSPDFKit. > Our signature implementation with PDFBOX is based on > [https://apache.googlesource.com/pdfbox/+/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature2.java] > When signing the document more than one time, the first signature is > invalidated for some PDF Spec versions. We tried adding the new signatures in > the existing fields, and in new ones, but the results is the same. > The multiple signature works well with PDF versions 1.4 and 1.6. It does not > work with versions 1.5 and 1.7. The first signature is invalidated by the > second one. > Initially, I had the doubt if this problem was related to PSDPFKit or > PDF-Box. While investigating, we tried to sign the 1.5 spec version document > multiple times using iText and it worked ok. > I'm attaching 10 pdfs: > * For each spec version, one PDF with the empty signature fields, and > another one with 2 signatures made by Apache PDF-Box. > * Specs 1.5 and 1.7 signed 2 times by itext. > Thank you for your help. > Fabricio > Edit 1: We are not using the certify functionality > (SigUtils.setMDPPermission). > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements
valerybokov commented on pull request #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-805885019 when I uncommented COSArrayListTest.addToList and launched it, it was green -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
Re: Redaction Annotation
Yes... depending on the size / complexity a signed ICLA might be needed. Is this just the PD class or also appearances? Please upload your attachments on a sharehoster, all attachments here were deleted. Tilman Am 23.03.2021 um 21:00 schrieb Kett, Bernward: Hi all, I successfully implemented a redaction annotation class and wanted to contact you if you are interested in merging it? All three highlights are redactions. Redaction of “External” has been created with Acrobat afterwards. Reader and viewer is missing yet. Best regards, Bernward EntServ Deutschland GmbH: Schickardstraße 32, 71034 Böblingen, Germany - Board of Directors: Joachim Löffler (Chairman), Karl Anzboeck - Registered in Stuttgart: HRB 757510. DXC Technology Company -- This message is transmitted to you by or on behalf of DXC Technology Company or one of its affiliates. It is intended exclusively for the addressee. The substance of this message, along with any attachments, may contain proprietary, confidential or privileged information or information that is otherwise legally exempt from disclosure. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient of this message, you are not authorized to read, print, retain, copy or disseminate any part of this message. If you have received this message in error, please destroy and delete all copies and notify the sender by return e-mail. Regardless of content, this e-mail shall not operate to bind DXC Technology Company or any of its affiliates to any order or other contract unless pursuant to explicit written agreement or government initiative expressly permitting the use of e-mail for such purpose. --. - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Updated] (PDFBOX-2941) Improve PDFDebugger (2)
[
https://issues.apache.org/jira/browse/PDFBOX-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tilman Hausherr updated PDFBOX-2941:
Description:
This is a follow-up issue to PDFBOX-2530 to implement extra ideas that came up
in GSoC2015, ideas that were not implemented due to lack of time, and new ideas.
*Viewing*
- refactor PDFDebugger.java
- ✓ render glyphs of fonts
- ✓ refactor StreamPane to share stream filtering among Text view and hex view
- ✓ password dialog when hitting protected PDF
- show "pretty" XML
- display filtered streams even if the unfiltered stream is corrupt
(PDFBOX-2976)
- ✓ display the "caused by" part exception stack trace (nested exceptions)
- ✓ keep zoom
- ✓ integrate DrawPrintTextLocations into rendering
- integrate area text extraction with a mouse-created rectangle that shows the
coordinates in a status line
- ✓ show permission flags of {{Encrypt/P}} entry
- ✓ show signature flags of {{Root/AcroForm/SigFlags}} entry, see Table 219 in
PDF spec
- ✓ show page labels additional to page number (see file from TIKA-2121 as
example)
- ✓ "reopen" menu item (useful when editing an existing PDF to create a
reduced PDF)
- choose zoom automatically so that PDF page can be seen in full
*Editing*
- save modified PDFs
- editing in hex viewer
- remove nodes (e.g. elements from a COSDictionary)
- delete array or dictionary elements
- load content streams
- edit & keep content streams
was:
This is a follow-up issue to PDFBOX-2530 to implement extra ideas that came up
in GSoC2015, ideas that were not implemented due to lack of time, and new ideas.
*Viewing*
- refactor PDFDebugger.java
- render glyphs of fonts
- ✓ refactor StreamPane to share stream filtering among Text view and hex view
- ✓ password dialog when hitting protected PDF
- show "pretty" XML
- display filtered streams even if the unfiltered stream is corrupt
(PDFBOX-2976)
- ✓ display the "caused by" part exception stack trace (nested exceptions)
- ✓ keep zoom
- ✓ integrate DrawPrintTextLocations into rendering
- integrate area text extraction with a mouse-created rectangle that shows the
coordinates in a status line
- ✓ show permission flags of {{Encrypt/P}} entry
- ✓ show signature flags of {{Root/AcroForm/SigFlags}} entry, see Table 219 in
PDF spec
- ✓ show page labels additional to page number (see file from TIKA-2121 as
example)
- ✓ "reopen" menu item (useful when editing an existing PDF to create a
reduced PDF)
- choose zoom automatically so that PDF page can be seen in full
*Editing*
- save modified PDFs
- editing in hex viewer
- remove nodes (e.g. elements from a COSDictionary)
- delete array or dictionary elements
- load content streams
- edit & keep content streams
> Improve PDFDebugger (2)
> ---
>
> Key: PDFBOX-2941
> URL: https://issues.apache.org/jira/browse/PDFBOX-2941
> Project: PDFBox
> Issue Type: Improvement
> Components: Utilities
>Affects Versions: 2.0.0
>Reporter: Tilman Hausherr
>Priority: Major
> Attachments: gs-bugzilla694570.pdf, keep_zoom.diff, osx-tabs.png,
> pdfdebugger-screenshot-reverted.png, pdfdebugger-screenshot-trunc.png,
> screenshot_debugger_new.png, screenshot_debugger_not_aligned.png,
> screenshot_debugger_old.png, screenshot_w7_fontsize.png,
> separate_filter_choice_from_text_hex_views.diff, sonar_qube_resolve.diff,
> sonar_qube_resolve_25_08.diff
>
>
> This is a follow-up issue to PDFBOX-2530 to implement extra ideas that came
> up in GSoC2015, ideas that were not implemented due to lack of time, and new
> ideas.
> *Viewing*
> - refactor PDFDebugger.java
> - ✓ render glyphs of fonts
> - ✓ refactor StreamPane to share stream filtering among Text view and hex
> view
> - ✓ password dialog when hitting protected PDF
> - show "pretty" XML
> - display filtered streams even if the unfiltered stream is corrupt
> (PDFBOX-2976)
> - ✓ display the "caused by" part exception stack trace (nested exceptions)
> - ✓ keep zoom
> - ✓ integrate DrawPrintTextLocations into rendering
> - integrate area text extraction with a mouse-created rectangle that shows
> the coordinates in a status line
> - ✓ show permission flags of {{Encrypt/P}} entry
> - ✓ show signature flags of {{Root/AcroForm/SigFlags}} entry, see Table 219
> in PDF spec
> - ✓ show page labels additional to page number (see file from TIKA-2121 as
> example)
> - ✓ "reopen" menu item (useful when editing an existing PDF to create a
> reduced PDF)
> - choose zoom automatically so that PDF page can be seen in full
> *Editing*
> - save modified PDFs
> - editing in hex viewer
> - remove nodes (e.g. elements from a COSDictionary)
> - delete array or dictionary elements
> - load content streams
> - edit & keep content streams
--
This message was sent by Atlassian Jira
[GitHub] [pdfbox] THausherr commented on pull request #107: potential memory leaks and small performance improvements
THausherr commented on pull request #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-806055173 labels.length is always > 0 because there's always at least 1 page in a document. If not, there's something rotten anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5139) Signing PDF with empty fields multiple times breaks signature
[
https://issues.apache.org/jira/browse/PDFBOX-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307997#comment-17307997
]
Tilman Hausherr commented on PDFBOX-5139:
-
I tried only 1.5 and signed with CreateSignature which is kindof minimal. First
signature brings problem when using SigUtils.setMDPPermission() ?! When not
using it, it worked. But then second signature brings the problem. I looked
into the result file and have no clue what Adobe considers "changed". I even
tried a modified PDFBox version that doesn't update the catalog and had the
same result.
But what is this in the trailer?
{code:java}
<>/Info 11 0 R /Root 4 0 R
/Type/XRef/Size 24
{code}
/XRef is for crossreference streams but that isn't one. You have a
"Cross-Reference Table".
I "whitened" that part to
{noformat}
<< /Info 11 0 R /Root 4 0 R
{noformat}
but it still didn't work. But who knows what else is wrong?
> Signing PDF with empty fields multiple times breaks signature
> -
>
> Key: PDFBOX-5139
> URL: https://issues.apache.org/jira/browse/PDFBOX-5139
> Project: PDFBox
> Issue Type: Bug
>Affects Versions: 2.0.23
>Reporter: Fabricio
>Priority: Major
> Attachments: 1.4.pdf, 1.4.signed.signed.pdf,
> 1.5.itext.signed.signed.pdf, 1.5.pdf, 1.5.signed.signed.pdf, 1.6.pdf,
> 1.6.signed.signed.pdf, 1.7.itext.signed.signed.pdf, 1.7.pdf,
> 1.7.signed.signed.pdf
>
>
> Hi!
> I apologize if there is already a similar report.
> We have a PDF document with multiple empty signature fields. We are currently
> preparing the document and adding the fields with the javascript library
> PSPDFKit.
> Our signature implementation with PDFBOX is based on
> [https://apache.googlesource.com/pdfbox/+/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature2.java]
> When signing the document more than one time, the first signature is
> invalidated for some PDF Spec versions. We tried adding the new signatures in
> the existing fields, and in new ones, but the results is the same.
> The multiple signature works well with PDF versions 1.4 and 1.6. It does not
> work with versions 1.5 and 1.7. The first signature is invalidated by the
> second one.
> Initially, I had the doubt if this problem was related to PSDPFKit or
> PDF-Box. While investigating, we tried to sign the 1.5 spec version document
> multiple times using iText and it worked ok.
> I'm attaching 10 pdfs:
> * For each spec version, one PDF with the empty signature fields, and
> another one with 2 signatures made by Apache PDF-Box.
> * Specs 1.5 and 1.7 signed 2 times by itext.
> Thank you for your help.
> Fabricio
> Edit 1: We are not using the certify functionality
> (SigUtils.setMDPPermission).
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4669) Ensure proper functionality of COSArrayList
[
https://issues.apache.org/jira/browse/PDFBOX-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308086#comment-17308086
]
Tilman Hausherr commented on PDFBOX-4669:
-
[valerybokov|https://github.com/apache/pdfbox/pull/107#issuecomment-805885019]
noticed that {{addToList()}} is green when enabled
> Ensure proper functionality of COSArrayList
> ---
>
> Key: PDFBOX-4669
> URL: https://issues.apache.org/jira/browse/PDFBOX-4669
> Project: PDFBox
> Issue Type: Sub-task
> Components: PDModel
>Affects Versions: 2.0.17, 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
>
> The current COSArrayList implementation has some glitches as pointed out at
> https://stackoverflow.com/questions/45812696/
> In addition when working with {{AnnotationFilter}} as the
> adding/update/removal is index based the wron index of the underlying
> {{COSArray}} is affected.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308109#comment-17308109 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888027 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1888027 ] PDFBOX-4892: improve speed, as suggested by valerybokov; use try-with-resources > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[GitHub] [pdfbox] THausherr commented on pull request #107: potential memory leaks and small performance improvements
THausherr commented on pull request #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-806051549 Thanks, I've forwarded the test thing and changed the JIRA issue. Re PDFDebugger, I'll do just a few of the changes. (I'm hopelessly behind) I'll do the "static" thing assuming this is a hint in some IDEs (not mine). Performance improvements for PDFDebugger aren't really important (unless they're noticeable by humans). This is a GUI tool that is used mostly by PDFBox developers who don't have access to Adobe tools. Optimizations are more relevant for text extraction and rendering. There I'd say every millisecond counts, because these add up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308096#comment-17308096 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888022 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1888022 ] PDFBOX-4892: set inner class static + improve javadoc, as suggested by valerybokov > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308097#comment-17308097 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888023 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1888023 ] PDFBOX-4892: set inner class static + improve javadoc, as suggested by valerybokov > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308098#comment-17308098 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888024 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1888024 ] PDFBOX-4892: refactor, as suggested by valerybokov > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308108#comment-17308108 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888026 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1888026 ] PDFBOX-4892: improve speed, as suggested by valerybokov > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Updated] (PDFBOX-2941) Improve PDFDebugger (2)
[
https://issues.apache.org/jira/browse/PDFBOX-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tilman Hausherr updated PDFBOX-2941:
Description:
This is a follow-up issue to PDFBOX-2530 to implement extra ideas that came up
in GSoC2015, ideas that were not implemented due to lack of time, and new ideas.
*Viewing*
- refactor PDFDebugger.java
- render glyphs of fonts
- ✓ refactor StreamPane to share stream filtering among Text view and hex view
- ✓ password dialog when hitting protected PDF
- show "pretty" XML
- display filtered streams even if the unfiltered stream is corrupt
(PDFBOX-2976)
- ✓ display the "caused by" part exception stack trace (nested exceptions)
- ✓ keep zoom
- ✓ integrate DrawPrintTextLocations into rendering
- integrate area text extraction with a mouse-created rectangle that shows the
coordinates in a status line
- ✓ show permission flags of {{Encrypt/P}} entry
- ✓ show signature flags of {{Root/AcroForm/SigFlags}} entry, see Table 219 in
PDF spec
- ✓ show page labels additional to page number (see file from TIKA-2121 as
example)
- ✓ "reopen" menu item (useful when editing an existing PDF to create a
reduced PDF)
- choose zoom automatically so that PDF page can be seen in full
*Editing*
- save modified PDFs
- editing in hex viewer
- remove nodes (e.g. elements from a COSDictionary)
- delete array or dictionary elements
- load content streams
- edit & keep content streams
was:
This is a follow-up issue to PDFBOX-2530 to implement extra ideas that came up
in GSoC2015, ideas that were not implemented due to lack of time, and new ideas.
*Viewing*
- refactor PDFDebugger.java
- render glyphs of fonts
- ✓ refactor StreamPane to share stream filtering among Text view and hex view
- ✓ password dialog when hitting protected PDF
- show "pretty" XML
- display filtered streams even if the unfiltered stream is corrupt
(PDFBOX-2976)
- ✓ display the "caused by" part exception stack trace (nested exceptions)
- ✓ keep zoom
- ✓ integrate DrawPrintTextLocations into rendering
- integrate area text extraction with a mouse-created rectangle that shows the
coordinates in a status line
- ✓ show permission flags of {{Encrypt/P}} entry
- ✓ show signature flags of {{Root/AcroForm/SigFlags}} entry, see Table 219 in
PDF spec
- show page labels additional to page number (see file from TIKA-2121 as
example)
- ✓ "reopen" menu item (useful when editing an existing PDF to create a reduced
PDF)
- choose zoom automatically so that PDF page can be seen in full
*Editing*
- save modified PDFs
- editing in hex viewer
- remove nodes (e.g. elements from a COSDictionary)
- delete array or dictionary elements
- load content streams
- edit & keep content streams
> Improve PDFDebugger (2)
> ---
>
> Key: PDFBOX-2941
> URL: https://issues.apache.org/jira/browse/PDFBOX-2941
> Project: PDFBox
> Issue Type: Improvement
> Components: Utilities
>Affects Versions: 2.0.0
>Reporter: Tilman Hausherr
>Priority: Major
> Attachments: gs-bugzilla694570.pdf, keep_zoom.diff, osx-tabs.png,
> pdfdebugger-screenshot-reverted.png, pdfdebugger-screenshot-trunc.png,
> screenshot_debugger_new.png, screenshot_debugger_not_aligned.png,
> screenshot_debugger_old.png, screenshot_w7_fontsize.png,
> separate_filter_choice_from_text_hex_views.diff, sonar_qube_resolve.diff,
> sonar_qube_resolve_25_08.diff
>
>
> This is a follow-up issue to PDFBOX-2530 to implement extra ideas that came
> up in GSoC2015, ideas that were not implemented due to lack of time, and new
> ideas.
> *Viewing*
> - refactor PDFDebugger.java
> - render glyphs of fonts
> - ✓ refactor StreamPane to share stream filtering among Text view and hex
> view
> - ✓ password dialog when hitting protected PDF
> - show "pretty" XML
> - display filtered streams even if the unfiltered stream is corrupt
> (PDFBOX-2976)
> - ✓ display the "caused by" part exception stack trace (nested exceptions)
> - ✓ keep zoom
> - ✓ integrate DrawPrintTextLocations into rendering
> - integrate area text extraction with a mouse-created rectangle that shows
> the coordinates in a status line
> - ✓ show permission flags of {{Encrypt/P}} entry
> - ✓ show signature flags of {{Root/AcroForm/SigFlags}} entry, see Table 219
> in PDF spec
> - ✓ show page labels additional to page number (see file from TIKA-2121 as
> example)
> - ✓ "reopen" menu item (useful when editing an existing PDF to create a
> reduced PDF)
> - choose zoom automatically so that PDF page can be seen in full
> *Editing*
> - save modified PDFs
> - editing in hex viewer
> - remove nodes (e.g. elements from a COSDictionary)
> - delete array or dictionary elements
> - load content streams
> - edit & keep content streams
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308099#comment-17308099 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888025 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1888025 ] PDFBOX-4892: refactor, as suggested by valerybokov > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308112#comment-17308112 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888028 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1888028 ] PDFBOX-4892: improve speed, as suggested by valerybokov > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308113#comment-17308113 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888029 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1888029 ] PDFBOX-4892: improve speed, as suggested by valerybokov > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308121#comment-17308121 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888033 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1888033 ] PDFBOX-4892: performance optimization, as suggested by valerybokov > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308120#comment-17308120 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888032 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1888032 ] PDFBOX-4892: performance optimization, as suggested by valerybokov > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308117#comment-17308117 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888030 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1888030 ] PDFBOX-4892: remove null check (would mean a completely broken download anyway), as suggested by valerybokov > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308118#comment-17308118 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888031 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1888031 ] PDFBOX-4892: remove null check (would mean a completely broken download anyway), as suggested by valerybokov > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements
valerybokov commented on pull request #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-806093557 > labels.length is always > 0 because there's always at least 1 page in a document. If not, there's something rotten anyway. I got a little carried away by the debugger. I used a check for an empty document, because the library allows you to create blank documents -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
RE: Redaction Annotation
Hi Tilmann, it's the base class, appearances some other adjustments in lower classes (especially for data streams). I also created a sample main class for demo (reused your appearance example). I also detected that it's preferable to create the Normal appearance after the Rollover appearance. I will have to check with the lawyers for proper ICLA. I'm sure it's possible, since we would prefer not to merge every change in pdfbox. Sorry I have no public sharehoster at hand, any suggestions from your side? I attached the PDF created from my example program (and added one redaction with Acrobat) Best regards, Bernward -Original Message- From: Tilman Hausherr Sent: Mittwoch, 24. März 2021 17:53 To: dev@pdfbox.apache.org Subject: Re: Redaction Annotation Yes... depending on the size / complexity a signed ICLA might be needed. Is this just the PD class or also appearances? Please upload your attachments on a sharehoster, all attachments here were deleted. Tilman Am 23.03.2021 um 21:00 schrieb Kett, Bernward: > > Hi all, > > I successfully implemented a redaction annotation class and wanted to > contact you if you are interested in merging it? > > All three highlights are redactions. Redaction of "External" has been > created with Acrobat afterwards. > > Reader and viewer is missing yet. > > Best regards, > > Bernward > > > EntServ Deutschland GmbH: Schickardstraße 32, 71034 Böblingen, Germany > - Board of Directors: Joachim Löffler (Chairman), Karl Anzboeck - > Registered in Stuttgart: HRB 757510. > DXC Technology Company -- This message is transmitted to you by or on > behalf of DXC Technology Company or one of its affiliates. It is > intended exclusively for the addressee. The substance of this message, > along with any attachments, may contain proprietary, confidential or > privileged information or information that is otherwise legally exempt > from disclosure. Any unauthorized review, use, disclosure or > distribution is prohibited. If you are not the intended recipient of > this message, you are not authorized to read, print, retain, copy or > disseminate any part of this message. If you have received this > message in error, please destroy and delete all copies and notify the > sender by return e-mail. Regardless of content, this e-mail shall not > operate to bind DXC Technology Company or any of its affiliates to any > order or other contract unless pursuant to explicit written agreement > or government initiative expressly permitting the use of e-mail for > such purpose. --. > > - > To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For > additional commands, e-mail: dev-h...@pdfbox.apache.org EntServ Deutschland GmbH: Schickardstraße 32, 71034 Böblingen, Germany - Board of Directors: Joachim Löffler (Chairman), Karl Anzboeck - Registered in Stuttgart: HRB 757510. DXC Technology Company -- This message is transmitted to you by or on behalf of DXC Technology Company or one of its affiliates. It is intended exclusively for the addressee. The substance of this message, along with any attachments, may contain proprietary, confidential or privileged information or information that is otherwise legally exempt from disclosure. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient of this message, you are not authorized to read, print, retain, copy or disseminate any part of this message. If you have received this message in error, please destroy and delete all copies and notify the sender by return e-mail. Regardless of content, this e-mail shall not operate to bind DXC Technology Company or any of its affiliates to any order or other contract unless pursuant to explicit written agreement or government initiative expressly permitting the use of e-mail for such purpose. --. - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308337#comment-17308337 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888047 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1888047 ] PDFBOX-4892: performance optimization, as suggested by valerybokov > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-2602) Enhance command line tools
[ https://issues.apache.org/jira/browse/PDFBOX-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308350#comment-17308350 ] ASF subversion and git services commented on PDFBOX-2602: - Commit 1888050 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1888050 ] PDFBOX-2602: set dpi only if not set through cli > Enhance command line tools > -- > > Key: PDFBOX-2602 > URL: https://issues.apache.org/jira/browse/PDFBOX-2602 > Project: PDFBox > Issue Type: Bug > Components: Utilities >Affects Versions: 1.8.8, 2.0.0 >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Minor > Fix For: 3.0.0 PDFBox > > > The command line tools shall be enhanced to have the same behavior across all > tools. > From the discussion on the dev mailing list > - add an -h option to print the usage > - print the usage to System.err and use an exit code of 1 if there was an > invalid command line parameter > - print messages on exceptions to System.err > - rethrow the exception so java can handle it if it will terminate afterwards > anyway > - use an exit code of 1if rethrowing doesn't make sense > Additional input: > https://clig.dev/ -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308380#comment-17308380 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888052 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1888052 ] PDFBOX-4892: avoid ClassCastException > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308379#comment-17308379 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888051 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1888051 ] PDFBOX-4892: avoid ClassCastException > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
Re: Redaction Annotation
Am 24.03.2021 um 20:22 schrieb Kett, Bernward: Hi Tilmann, it's the base class, appearances some other adjustments in lower classes (especially for data streams). I also created a sample main class for demo (reused your appearance example). I also detected that it's preferable to create the Normal appearance after the Rollover appearance. I will have to check with the lawyers for proper ICLA. I'm sure it's possible, since we would prefer not to merge every change in pdfbox. Sorry I have no public sharehoster at hand, any suggestions from your side? filedropper.com Tilman I attached the PDF created from my example program (and added one redaction with Acrobat) Best regards, Bernward -Original Message- From: Tilman Hausherr Sent: Mittwoch, 24. März 2021 17:53 To: dev@pdfbox.apache.org Subject: Re: Redaction Annotation Yes... depending on the size / complexity a signed ICLA might be needed. Is this just the PD class or also appearances? Please upload your attachments on a sharehoster, all attachments here were deleted. Tilman Am 23.03.2021 um 21:00 schrieb Kett, Bernward: Hi all, I successfully implemented a redaction annotation class and wanted to contact you if you are interested in merging it? All three highlights are redactions. Redaction of "External" has been created with Acrobat afterwards. Reader and viewer is missing yet. Best regards, Bernward EntServ Deutschland GmbH: Schickardstraße 32, 71034 Böblingen, Germany - Board of Directors: Joachim Löffler (Chairman), Karl Anzboeck - Registered in Stuttgart: HRB 757510. DXC Technology Company -- This message is transmitted to you by or on behalf of DXC Technology Company or one of its affiliates. It is intended exclusively for the addressee. The substance of this message, along with any attachments, may contain proprietary, confidential or privileged information or information that is otherwise legally exempt from disclosure. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient of this message, you are not authorized to read, print, retain, copy or disseminate any part of this message. If you have received this message in error, please destroy and delete all copies and notify the sender by return e-mail. Regardless of content, this e-mail shall not operate to bind DXC Technology Company or any of its affiliates to any order or other contract unless pursuant to explicit written agreement or government initiative expressly permitting the use of e-mail for such purpose. --. - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org EntServ Deutschland GmbH: Schickardstraße 32, 71034 Böblingen, Germany - Board of Directors: Joachim Löffler (Chairman), Karl Anzboeck - Registered in Stuttgart: HRB 757510. DXC Technology Company -- This message is transmitted to you by or on behalf of DXC Technology Company or one of its affiliates. It is intended exclusively for the addressee. The substance of this message, along with any attachments, may contain proprietary, confidential or privileged information or information that is otherwise legally exempt from disclosure. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient of this message, you are not authorized to read, print, retain, copy or disseminate any part of this message. If you have received this message in error, please destroy and delete all copies and notify the sender by return e-mail. Regardless of content, this e-mail shall not operate to bind DXC Technology Company or any of its affiliates to any order or other contract unless pursuant to explicit written agreement or government initiative expressly permitting the use of e-mail for such purpose. --. - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308336#comment-17308336 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888046 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1888046 ] PDFBOX-4892: performance optimization, as suggested by valerybokov > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308335#comment-17308335 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888045 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1888045 ] PDFBOX-4892: remove unused import > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
