[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253288#comment-14253288 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646672 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646672 ] PDFBOX-2576: avoid using implementation types, use the interface instead Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253300#comment-14253300 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646677 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646677 ] PDFBOX-2576: add @override where needed Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253310#comment-14253310 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646680 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646680 ] PDFBOX-2576: remove unneded init Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253313#comment-14253313 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646682 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646682 ] PDFBOX-2576: remove unneded null checks Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253329#comment-14253329 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646690 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646690 ] PDFBOX-2576: combine nested if statements Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1425#comment-1425 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646691 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646691 ] PDFBOX-2576: controlPoints can be private Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253346#comment-14253346 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646692 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646692 ] PDFBOX-2576: ContentStreamException is an IOException Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253350#comment-14253350 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646693 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646693 ] PDFBOX-2576: instanceof is never null Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253359#comment-14253359 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646695 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646695 ] PDFBOX-2576: removed code that does nothing; close stream Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2571) IllegalStateException: Not a CIDFont
[
https://issues.apache.org/jira/browse/PDFBOX-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253363#comment-14253363
]
ASF subversion and git services commented on PDFBOX-2571:
-
Commit 1646697 from [~jahewson] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1646697 ]
PDFBOX-2571: Use identity charset for CFF fonts with missing charset
IllegalStateException: Not a CIDFont
Key: PDFBOX-2571
URL: https://issues.apache.org/jira/browse/PDFBOX-2571
Project: PDFBox
Issue Type: Bug
Components: FontBox
Affects Versions: 2.0.0
Reporter: Tilman Hausherr
Assignee: John Hewson
Fix For: 2.0.0
Attachments: 518330.pdf, GWG090_Font-Support_x3.pdf,
bugzilla867751.pdf
{code}
Exception in thread main java.lang.IllegalStateException: Not a CIDFont
at org.apache.fontbox.cff.CFFCharset.getGIDForCID(CFFCharset.java:134)
at
org.apache.fontbox.cff.CFFCIDFont.getType2CharString(CFFCIDFont.java:227)
at
org.apache.pdfbox.pdmodel.font.PDCIDFontType0.getType2CharString(PDCIDFontType0.java:224)
at
org.apache.pdfbox.rendering.font.CIDType0Glyph2D.getPathForCharacterCode(CIDType0Glyph2D.java:63)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253379#comment-14253379 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646704 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646704 ] PDFBOX-2576: remove nested if statements Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253383#comment-14253383 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646708 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646708 ] PDFBOX-2576: avoid using implementation types, use the interface instead Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253387#comment-14253387 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646711 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646711 ] PDFBOX-2576: avoid using implementation types, use the interface instead Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2516) Further align AcroForms and Fields PDModel with PDF specification
[ https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253727#comment-14253727 ] ASF subversion and git services commented on PDFBOX-2516: - Commit 1646812 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646812 ] PDFBOX-2516 return Java types instead of COS model types Further align AcroForms and Fields PDModel with PDF specification - Key: PDFBOX-2516 URL: https://issues.apache.org/jira/browse/PDFBOX-2516 Project: PDFBox Issue Type: Bug Components: AcroForm Affects Versions: 2.0.0 Reporter: Maruan Sahyoun Assignee: Maruan Sahyoun The PDModel for AcroForms and the fields being part of it (o.a.p.pdmodel.interactive.form) needs to be enhanced. Sample issues: - RadioButton and Checkbox don’t support DV entries although they should - inheritable attributes only support inheritance either form their parent or the root of the AcroForms model which is not inline with the specification -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2516) Further align AcroForms and Fields PDModel with PDF specification
[ https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253759#comment-14253759 ] ASF subversion and git services commented on PDFBOX-2516: - Commit 1646814 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646814 ] PDFBOX-2516 return Java types instead of COS model types Further align AcroForms and Fields PDModel with PDF specification - Key: PDFBOX-2516 URL: https://issues.apache.org/jira/browse/PDFBOX-2516 Project: PDFBox Issue Type: Bug Components: AcroForm Affects Versions: 2.0.0 Reporter: Maruan Sahyoun Assignee: Maruan Sahyoun The PDModel for AcroForms and the fields being part of it (o.a.p.pdmodel.interactive.form) needs to be enhanced. Sample issues: - RadioButton and Checkbox don’t support DV entries although they should - inheritable attributes only support inheritance either form their parent or the root of the AcroForms model which is not inline with the specification -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2573) IllegalStateException: PDFBox bug: encoding should not be null!
[
https://issues.apache.org/jira/browse/PDFBOX-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253812#comment-14253812
]
ASF subversion and git services commented on PDFBOX-2573:
-
Commit 1646827 from [~jahewson] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1646827 ]
PDFBOX-2573: Avoid recursive definition of isSymbolic
IllegalStateException: PDFBox bug: encoding should not be null!
---
Key: PDFBOX-2573
URL: https://issues.apache.org/jira/browse/PDFBOX-2573
Project: PDFBox
Issue Type: Bug
Components: FontBox
Affects Versions: 2.0.0
Reporter: Tilman Hausherr
Assignee: John Hewson
Attachments: PDFBOX-2573-865252-p4.pdf, preflight.png
This seems to be a follow-up of PDFBOX-2489 (some of the files that had the
old bug are now ok, but not this one):
{code}
Exception in thread main java.lang.IllegalStateException: PDFBox bug:
encoding should not be null!
at
org.apache.pdfbox.pdmodel.font.PDSimpleFont.isFontSymbolic(PDSimpleFont.java:205)
at org.apache.pdfbox.pdmodel.font.PDFont.isSymbolic(PDFont.java:440)
at
org.apache.pdfbox.pdmodel.font.PDSimpleFont.readEncoding(PDSimpleFont.java:111)
at
org.apache.pdfbox.pdmodel.font.PDType1Font.init(PDType1Font.java:228)
at
org.apache.pdfbox.pdmodel.font.PDFontFactory.createFont(PDFontFactory.java:65)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253827#comment-14253827 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646832 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646832 ] PDFBOX-2576 don't throw raw exception type Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2516) Further align AcroForms and Fields PDModel with PDF specification
[ https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14253913#comment-14253913 ] ASF subversion and git services commented on PDFBOX-2516: - Commit 1646851 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646851 ] PDFBOX-2516 add field with text stream to AcroForm testfile Further align AcroForms and Fields PDModel with PDF specification - Key: PDFBOX-2516 URL: https://issues.apache.org/jira/browse/PDFBOX-2516 Project: PDFBox Issue Type: Bug Components: AcroForm Affects Versions: 2.0.0 Reporter: Maruan Sahyoun Assignee: Maruan Sahyoun The PDModel for AcroForms and the fields being part of it (o.a.p.pdmodel.interactive.form) needs to be enhanced. Sample issues: - RadioButton and Checkbox don’t support DV entries although they should - inheritable attributes only support inheritance either form their parent or the root of the AcroForms model which is not inline with the specification -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254000#comment-14254000 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646859 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646859 ] PDFBOX-2576: keep double method skipToNextObj() in base class only Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2516) Further align AcroForms and Fields PDModel with PDF specification
[ https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254015#comment-14254015 ] ASF subversion and git services commented on PDFBOX-2516: - Commit 1646865 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646865 ] PDFBOX-2516 handle text streams for field value Further align AcroForms and Fields PDModel with PDF specification - Key: PDFBOX-2516 URL: https://issues.apache.org/jira/browse/PDFBOX-2516 Project: PDFBox Issue Type: Bug Components: AcroForm Affects Versions: 2.0.0 Reporter: Maruan Sahyoun Assignee: Maruan Sahyoun The PDModel for AcroForms and the fields being part of it (o.a.p.pdmodel.interactive.form) needs to be enhanced. Sample issues: - RadioButton and Checkbox don’t support DV entries although they should - inheritable attributes only support inheritance either form their parent or the root of the AcroForms model which is not inline with the specification -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254034#comment-14254034 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646875 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646875 ] PDFBOX-2576: DRY refactoring of securityHandler construction Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2516) Further align AcroForms and Fields PDModel with PDF specification
[ https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254033#comment-14254033 ] ASF subversion and git services commented on PDFBOX-2516: - Commit 1646874 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646874 ] PDFBOX-2516 fix typo; javadoc cleanups Further align AcroForms and Fields PDModel with PDF specification - Key: PDFBOX-2516 URL: https://issues.apache.org/jira/browse/PDFBOX-2516 Project: PDFBox Issue Type: Bug Components: AcroForm Affects Versions: 2.0.0 Reporter: Maruan Sahyoun Assignee: Maruan Sahyoun The PDModel for AcroForms and the fields being part of it (o.a.p.pdmodel.interactive.form) needs to be enhanced. Sample issues: - RadioButton and Checkbox don’t support DV entries although they should - inheritable attributes only support inheritance either form their parent or the root of the AcroForms model which is not inline with the specification -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254066#comment-14254066 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646884 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646884 ] PDFBOX-2576: DRY refactoring of double code in triangle building Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254559#comment-14254559 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646922 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646922 ] PDFBOX-2576: DRY refactoring of double code Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254693#comment-14254693 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646960 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646960 ] PDFBOX-2576: fix imports Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254697#comment-14254697 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646963 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646963 ] PDFBOX-2576: fix imports Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254714#comment-14254714 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1646972 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646972 ] PDFBOX-2576: DRY refactoring of double code, move more stuff near or to base classes Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2516) Further align AcroForms and Fields PDModel with PDF specification
[ https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254784#comment-14254784 ] ASF subversion and git services commented on PDFBOX-2516: - Commit 1647000 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647000 ] PDFBOX-2516 use Java types instead of COS model types Further align AcroForms and Fields PDModel with PDF specification - Key: PDFBOX-2516 URL: https://issues.apache.org/jira/browse/PDFBOX-2516 Project: PDFBox Issue Type: Bug Components: AcroForm Affects Versions: 2.0.0 Reporter: Maruan Sahyoun Assignee: Maruan Sahyoun The PDModel for AcroForms and the fields being part of it (o.a.p.pdmodel.interactive.form) needs to be enhanced. Sample issues: - RadioButton and Checkbox don’t support DV entries although they should - inheritable attributes only support inheritance either form their parent or the root of the AcroForms model which is not inline with the specification -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2516) Further align AcroForms and Fields PDModel with PDF specification
[ https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254783#comment-14254783 ] ASF subversion and git services commented on PDFBOX-2516: - Commit 1646999 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1646999 ] PDFBOX-2516 use Java types instead of COS model types Further align AcroForms and Fields PDModel with PDF specification - Key: PDFBOX-2516 URL: https://issues.apache.org/jira/browse/PDFBOX-2516 Project: PDFBox Issue Type: Bug Components: AcroForm Affects Versions: 2.0.0 Reporter: Maruan Sahyoun Assignee: Maruan Sahyoun The PDModel for AcroForms and the fields being part of it (o.a.p.pdmodel.interactive.form) needs to be enhanced. Sample issues: - RadioButton and Checkbox don’t support DV entries although they should - inheritable attributes only support inheritance either form their parent or the root of the AcroForms model which is not inline with the specification -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254932#comment-14254932 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647039 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647039 ] PDFBOX-2576, PDFBOX-1242: simplify write ASCII string; code cleanup Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-1242) Handle non ISO-8859-1 chars with drawString
[ https://issues.apache.org/jira/browse/PDFBOX-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254933#comment-14254933 ] ASF subversion and git services commented on PDFBOX-1242: - Commit 1647039 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647039 ] PDFBOX-2576, PDFBOX-1242: simplify write ASCII string; code cleanup Handle non ISO-8859-1 chars with drawString --- Key: PDFBOX-1242 URL: https://issues.apache.org/jira/browse/PDFBOX-1242 Project: PDFBox Issue Type: Bug Components: Writing Affects Versions: 1.5.0, 1.6.0 Reporter: Peter Andersen Assignee: John Hewson Fix For: 2.0.0 The PDPageContentStream.drawString take a String as argument, it construct a COSString of the input. If the input contain chars above 255, the COSString is prefixed 0xFe, 0xff and the bytes are taken from the input as UTF-16BE encoded. Back in the drawString method this unicode16 encoded COSString is appended as a ISO-8859-1 appendRawCommands( new String( buffer.toByteArray(), ISO-8859-1)); The result of this is that a line with UTF-16 chars is shown prefix with þÿ, and with double space between the other chars. The chars above 255 are shown as the two corresponding ISO-8859-1 characters. As a side question to this observation, is there an alternative way to use Pdfbox, to support UTF16? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254950#comment-14254950 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647048 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647048 ] PDFBOX-2576: DRY refactoring of xref table writing Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254961#comment-14254961 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647053 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647053 ] PDFBOX-2576: fix javadoc Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254987#comment-14254987 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647063 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647063 ] PDFBOX-2576: partial reformat for code analysis tool Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254988#comment-14254988 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647064 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647064 ] PDFBOX-2576: DRY refactoring of double code Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254989#comment-14254989 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647065 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647065 ] PDFBOX-2576: avoid overridable method call in constructor warning Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254994#comment-14254994 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647070 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647070 ] PDFBOX-2576: refactor double code and move to base class, including Andersens_Fairy_Tales workaround Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255047#comment-14255047 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647083 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647083 ] PDFBOX-2576: split up long method into smaller ones Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255048#comment-14255048 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647084 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647084 ] PDFBOX-2576: simplify flow Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255056#comment-14255056 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647090 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647090 ] PDFBOX-2576: slight reformat Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255057#comment-14255057 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647091 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647091 ] PDFBOX-2576: remove assignment that has no effect Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255059#comment-14255059 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647093 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647093 ] PDFBOX-2576: set methods with private parameter type to private Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255064#comment-14255064 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647097 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647097 ] PDFBOX-2576: avoid inner assignment Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255069#comment-14255069 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647098 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647098 ] PDFBOX-2576: remove statement that has no effect Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255070#comment-14255070 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647099 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647099 ] PDFBOX-2576: remove field that already exists in base class Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2516) Further align AcroForms and Fields PDModel with PDF specification
[ https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255101#comment-14255101 ] ASF subversion and git services commented on PDFBOX-2516: - Commit 1647113 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647113 ] PDFBOX-2516 don't cache field value locally Further align AcroForms and Fields PDModel with PDF specification - Key: PDFBOX-2516 URL: https://issues.apache.org/jira/browse/PDFBOX-2516 Project: PDFBox Issue Type: Bug Components: AcroForm Affects Versions: 2.0.0 Reporter: Maruan Sahyoun Assignee: Maruan Sahyoun The PDModel for AcroForms and the fields being part of it (o.a.p.pdmodel.interactive.form) needs to be enhanced. Sample issues: - RadioButton and Checkbox don’t support DV entries although they should - inheritable attributes only support inheritance either form their parent or the root of the AcroForms model which is not inline with the specification -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255108#comment-14255108 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647116 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647116 ] PDFBOX-2576: combine and simplify nested if statement Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255110#comment-14255110 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647117 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647117 ] PDFBOX-2576: split up long method into smaller ones Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255113#comment-14255113 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647118 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647118 ] PDFBOX-2576: use IOUtils.closeQuietly where possible Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255128#comment-14255128 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647122 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647122 ] PDFBOX-2576: move matrix code to abstract class Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255181#comment-14255181 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647151 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647151 ] PDFBOX-2576: split up long method into smaller ones Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255183#comment-14255183 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647152 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647152 ] PDFBOX-2576: split up long method into smaller ones Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-1874) PDFTextStripper.isParagraphSeparation(...)
[
https://issues.apache.org/jira/browse/PDFBOX-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255190#comment-14255190
]
ASF subversion and git services commented on PDFBOX-1874:
-
Commit 1647158 from [~lehmi] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1647158 ]
PDFBOX-1874: adjust precision to avoid false results when comparing floats as
proposed by Yuri Burrows
PDFTextStripper.isParagraphSeparation(...)
--
Key: PDFBOX-1874
URL: https://issues.apache.org/jira/browse/PDFBOX-1874
Project: PDFBox
Issue Type: Bug
Components: Text extraction
Affects Versions: 1.8.3
Environment: Eclipse
Reporter: Yuri Burrows
Assignee: Andreas Lehmkühler
Priority: Minor
Labels: patch
PDFTextStripper.isParagraphSeparation(...) seems to have an issue with how it
finds Y text indentation.
PROBLEM:
I believe the issue is due to precision in the the following logic:
{code}
float yGap = Math.abs(position.getTextPosition().getYDirAdj()-
lastPosition.getTextPosition().getYDirAdj());
float xGap = (position.getTextPosition().getXDirAdj()-
lastLineStartPosition.getTextPosition().getXDirAdj());
if(yGap (getDropThreshold()*maxHeightForLine))
{
result = true;
{code}
yGap has a precision to 1000th+, while (getDropThreshold()*maxHeightForLine)
has a precision to 100,000th. Resulting in the following comparison (example):
16.018 16.018005
which evaluates to True. However 16.018 16.018 would evaluate to False.
EFFECT OF THE PROBLEM:
every line in the output is marked as isParagraphStart = true and
writeParagraphEnd() ... = true.
I.E.
|||NEW_LINE|||
|||PARAGRAPH_START|||PDFBox has been designed to represent PDF documents
using familiar object-oriented paradigms. The data|||NEW_LINE|||
contained in a PDF document is a collection of basic object types: arrays,
booleans, dictionaries, numbers,|||NEW_LINE|||
|||PARAGRAPH_END||NEW_LINE|||
|||PARAGRAPH_START|||strings and binary streams. PDFBox captures these basic
object types in the org.pdfbox.cos package (the|||NEW_LINE|||
COS Model). While it's possible to create any desired interactions with a PDF
document using only these|||NEW_LINE|||
|||PARAGRAPH_END||NEW_LINE|||
In the source PDF these lines appear as such:
PDFBox has been designed to represent PDF documents using familiar
object-oriented paradigms. The data
contained in a PDF document is a collection of basic object types: arrays,
booleans, dictionaries, numbers,
strings and binary streams. PDFBox captures these basic object types in the
org.pdfbox.cos package (the
COS Model). While it's possible to create any desired interactions with a PDF
document using only these
MY WORKAROUND:
NOTE: there is a small performance hit with this workaround.
{code}
float yGap = Math.abs(position.getTextPosition().getYDirAdj()
- lastPosition.getTextPosition().getYDirAdj());
DecimalFormat df = new DecimalFormat(#.00);
float yGapTruncated = Float.valueOf(df.format(yGap));
float newYVal = Float.valueOf(df.format(getDropThreshold()
* maxHeightForLine));
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255193#comment-14255193 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647160 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647160 ] PDFBOX-2576: split up long method into smaller ones; remove variable (alreadyPresent) that is always false Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-1874) PDFTextStripper.isParagraphSeparation(...)
[
https://issues.apache.org/jira/browse/PDFBOX-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255194#comment-14255194
]
ASF subversion and git services commented on PDFBOX-1874:
-
Commit 1647161 from [~lehmi] in branch 'pdfbox/branches/1.8'
[ https://svn.apache.org/r1647161 ]
PDFBOX-1874: adjust precision to avoid false results when comparing floats as
proposed by Yuri Burrows
PDFTextStripper.isParagraphSeparation(...)
--
Key: PDFBOX-1874
URL: https://issues.apache.org/jira/browse/PDFBOX-1874
Project: PDFBox
Issue Type: Bug
Components: Text extraction
Affects Versions: 1.8.8, 2.0.0
Environment: Eclipse
Reporter: Yuri Burrows
Assignee: Andreas Lehmkühler
Priority: Minor
Labels: patch
PDFTextStripper.isParagraphSeparation(...) seems to have an issue with how it
finds Y text indentation.
PROBLEM:
I believe the issue is due to precision in the the following logic:
{code}
float yGap = Math.abs(position.getTextPosition().getYDirAdj()-
lastPosition.getTextPosition().getYDirAdj());
float xGap = (position.getTextPosition().getXDirAdj()-
lastLineStartPosition.getTextPosition().getXDirAdj());
if(yGap (getDropThreshold()*maxHeightForLine))
{
result = true;
{code}
yGap has a precision to 1000th+, while (getDropThreshold()*maxHeightForLine)
has a precision to 100,000th. Resulting in the following comparison (example):
16.018 16.018005
which evaluates to True. However 16.018 16.018 would evaluate to False.
EFFECT OF THE PROBLEM:
every line in the output is marked as isParagraphStart = true and
writeParagraphEnd() ... = true.
I.E.
|||NEW_LINE|||
|||PARAGRAPH_START|||PDFBox has been designed to represent PDF documents
using familiar object-oriented paradigms. The data|||NEW_LINE|||
contained in a PDF document is a collection of basic object types: arrays,
booleans, dictionaries, numbers,|||NEW_LINE|||
|||PARAGRAPH_END||NEW_LINE|||
|||PARAGRAPH_START|||strings and binary streams. PDFBox captures these basic
object types in the org.pdfbox.cos package (the|||NEW_LINE|||
COS Model). While it's possible to create any desired interactions with a PDF
document using only these|||NEW_LINE|||
|||PARAGRAPH_END||NEW_LINE|||
In the source PDF these lines appear as such:
PDFBox has been designed to represent PDF documents using familiar
object-oriented paradigms. The data
contained in a PDF document is a collection of basic object types: arrays,
booleans, dictionaries, numbers,
strings and binary streams. PDFBox captures these basic object types in the
org.pdfbox.cos package (the
COS Model). While it's possible to create any desired interactions with a PDF
document using only these
MY WORKAROUND:
NOTE: there is a small performance hit with this workaround.
{code}
float yGap = Math.abs(position.getTextPosition().getYDirAdj()
- lastPosition.getTextPosition().getYDirAdj());
DecimalFormat df = new DecimalFormat(#.00);
float yGapTruncated = Float.valueOf(df.format(yGap));
float newYVal = Float.valueOf(df.format(getDropThreshold()
* maxHeightForLine));
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255196#comment-14255196 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647162 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647162 ] PDFBOX-2576: split up long method into smaller ones Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-785) Spliting a PDF creates unnecessarily large files
[ https://issues.apache.org/jira/browse/PDFBOX-785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255205#comment-14255205 ] ASF subversion and git services commented on PDFBOX-785: Commit 1647167 from [~lehmi] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647167 ] PDFBOX-785: add compression to stream when importing an existing page as proposed by Thomas Sörensen Spliting a PDF creates unnecessarily large files Key: PDFBOX-785 URL: https://issues.apache.org/jira/browse/PDFBOX-785 Project: PDFBox Issue Type: Bug Components: Utilities Affects Versions: 0.8.0-incubator, 1.1.0, 1.2.1 Environment: Windows XP, openOffice3.0.0, pdfsam Reporter: mathieu radiguet Assignee: Andreas Lehmkühler Fix For: 2.0.0 Attachments: fileSizeIssue.zip Using PDFBox 0.8.0 (also tried on 1.1.0 and 1.2.1) to split files result in bigger parts than the original. Concerned files were made from openOffice .odt documents in version 3.0.0 using openOffice pdf Export and then merging several copies with pdfsam (http://www.pdfsam.org/) In joined eclipse project the test file size is 10 712 749 bytes for 2812 pages and the result file sizes after splitting in two at page 2300 are : 8 812 515 bytes and 10 701 142 bytes. Using pdfSplit in command line as result we have all single result files bigger than the original. An example is also attached. An error tells the original file is corrupted, but we tried it on a file (using pdfsam and without using it) with no error and with similar result, so I think it's not related. This issue seems similar to PDFBOX-28. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255206#comment-14255206 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647168 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647168 ] PDFBOX-2576: No need to check for null before an instanceof Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-785) Spliting a PDF creates unnecessarily large files
[ https://issues.apache.org/jira/browse/PDFBOX-785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255207#comment-14255207 ] ASF subversion and git services commented on PDFBOX-785: Commit 1647169 from [~lehmi] in branch 'pdfbox/branches/1.8' [ https://svn.apache.org/r1647169 ] PDFBOX-785: add compression to stream when importing an existing page as proposed by Thomas Sörensen Spliting a PDF creates unnecessarily large files Key: PDFBOX-785 URL: https://issues.apache.org/jira/browse/PDFBOX-785 Project: PDFBox Issue Type: Bug Components: Utilities Affects Versions: 0.8.0-incubator, 1.1.0, 1.2.1 Environment: Windows XP, openOffice3.0.0, pdfsam Reporter: mathieu radiguet Assignee: Andreas Lehmkühler Fix For: 2.0.0 Attachments: fileSizeIssue.zip Using PDFBox 0.8.0 (also tried on 1.1.0 and 1.2.1) to split files result in bigger parts than the original. Concerned files were made from openOffice .odt documents in version 3.0.0 using openOffice pdf Export and then merging several copies with pdfsam (http://www.pdfsam.org/) In joined eclipse project the test file size is 10 712 749 bytes for 2812 pages and the result file sizes after splitting in two at page 2300 are : 8 812 515 bytes and 10 701 142 bytes. Using pdfSplit in command line as result we have all single result files bigger than the original. An example is also attached. An error tells the original file is corrupted, but we tried it on a file (using pdfsam and without using it) with no error and with similar result, so I think it's not related. This issue seems similar to PDFBOX-28. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255213#comment-14255213 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647174 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647174 ] PDFBOX-2576: nested if statements can be combined Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255217#comment-14255217 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647175 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647175 ] PDFBOX-2576: split up long method into smaller ones Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255224#comment-14255224 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647177 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647177 ] PDFBOX-2576: No need to check for null before an instanceof Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255231#comment-14255231 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647184 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647184 ] PDFBOX-2576: nested if statements can be combined Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255245#comment-14255245 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647193 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647193 ] PDFBOX-2576: remove method introduced in rev 1604572 that isn't used anymore and did nothing due to error in last line Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255248#comment-14255248 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647195 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647195 ] PDFBOX-2576: merge identical code from two branches Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255249#comment-14255249 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647197 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647197 ] PDFBOX-2576: merge identical code from two branches Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255262#comment-14255262 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647203 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647203 ] PDFBOX-2576: getMatrix is never null, fix javadoc Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2516) Further align AcroForms and Fields PDModel with PDF specification
[ https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255265#comment-14255265 ] ASF subversion and git services commented on PDFBOX-2516: - Commit 1647205 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647205 ] PDFBOX-2516 reduce PDVariableText properties to PDF standard documented ones Further align AcroForms and Fields PDModel with PDF specification - Key: PDFBOX-2516 URL: https://issues.apache.org/jira/browse/PDFBOX-2516 Project: PDFBox Issue Type: Bug Components: AcroForm Affects Versions: 2.0.0 Reporter: Maruan Sahyoun Assignee: Maruan Sahyoun The PDModel for AcroForms and the fields being part of it (o.a.p.pdmodel.interactive.form) needs to be enhanced. Sample issues: - RadioButton and Checkbox don’t support DV entries although they should - inheritable attributes only support inheritance either form their parent or the root of the AcroForms model which is not inline with the specification -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255264#comment-14255264 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647204 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647204 ] PDFBOX-2576: lastSectiion is never null Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2516) Further align AcroForms and Fields PDModel with PDF specification
[ https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255268#comment-14255268 ] ASF subversion and git services commented on PDFBOX-2516: - Commit 1647207 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647207 ] PDFBOX-2516 don't cache default appearance string Further align AcroForms and Fields PDModel with PDF specification - Key: PDFBOX-2516 URL: https://issues.apache.org/jira/browse/PDFBOX-2516 Project: PDFBox Issue Type: Bug Components: AcroForm Affects Versions: 2.0.0 Reporter: Maruan Sahyoun Assignee: Maruan Sahyoun The PDModel for AcroForms and the fields being part of it (o.a.p.pdmodel.interactive.form) needs to be enhanced. Sample issues: - RadioButton and Checkbox don’t support DV entries although they should - inheritable attributes only support inheritance either form their parent or the root of the AcroForms model which is not inline with the specification -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2516) Further align AcroForms and Fields PDModel with PDF specification
[ https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255278#comment-14255278 ] ASF subversion and git services commented on PDFBOX-2516: - Commit 1647218 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647218 ] PDFBOX-2516 use Java types instead of COS model types Further align AcroForms and Fields PDModel with PDF specification - Key: PDFBOX-2516 URL: https://issues.apache.org/jira/browse/PDFBOX-2516 Project: PDFBox Issue Type: Bug Components: AcroForm Affects Versions: 2.0.0 Reporter: Maruan Sahyoun Assignee: Maruan Sahyoun The PDModel for AcroForms and the fields being part of it (o.a.p.pdmodel.interactive.form) needs to be enhanced. Sample issues: - RadioButton and Checkbox don’t support DV entries although they should - inheritable attributes only support inheritance either form their parent or the root of the AcroForms model which is not inline with the specification -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2516) Further align AcroForms and Fields PDModel with PDF specification
[ https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255285#comment-14255285 ] ASF subversion and git services commented on PDFBOX-2516: - Commit 1647219 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647219 ] PDFBOX-2516 remove duplicate code Further align AcroForms and Fields PDModel with PDF specification - Key: PDFBOX-2516 URL: https://issues.apache.org/jira/browse/PDFBOX-2516 Project: PDFBox Issue Type: Bug Components: AcroForm Affects Versions: 2.0.0 Reporter: Maruan Sahyoun Assignee: Maruan Sahyoun The PDModel for AcroForms and the fields being part of it (o.a.p.pdmodel.interactive.form) needs to be enhanced. Sample issues: - RadioButton and Checkbox don’t support DV entries although they should - inheritable attributes only support inheritance either form their parent or the root of the AcroForms model which is not inline with the specification -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2516) Further align AcroForms and Fields PDModel with PDF specification
[ https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255293#comment-14255293 ] ASF subversion and git services commented on PDFBOX-2516: - Commit 1647222 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647222 ] PDFBOX-2516 don't cache default appearance string Further align AcroForms and Fields PDModel with PDF specification - Key: PDFBOX-2516 URL: https://issues.apache.org/jira/browse/PDFBOX-2516 Project: PDFBox Issue Type: Bug Components: AcroForm Affects Versions: 2.0.0 Reporter: Maruan Sahyoun Assignee: Maruan Sahyoun The PDModel for AcroForms and the fields being part of it (o.a.p.pdmodel.interactive.form) needs to be enhanced. Sample issues: - RadioButton and Checkbox don’t support DV entries although they should - inheritable attributes only support inheritance either form their parent or the root of the AcroForms model which is not inline with the specification -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255381#comment-14255381 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647237 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647237 ] PDFBOX-2576: delete methods with one or zero LoC, that were sometimes used and sometimes not Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1420#comment-1420 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647257 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647257 ] PDFBOX-2576: delete methods with one or zero LoC, that were sometimes used and sometimes not Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255586#comment-14255586 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647272 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647272 ] PDFBOX-2576: remove unused imports Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255587#comment-14255587 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647273 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647273 ] PDFBOX-2576: remove unused imports Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-785) Spliting a PDF creates unnecessarily large files
[ https://issues.apache.org/jira/browse/PDFBOX-785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255612#comment-14255612 ] ASF subversion and git services commented on PDFBOX-785: Commit 1647281 from [~lehmi] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647281 ] PDFBOX-785: remove all pages within annotations to avoid the import of unneeded resources Spliting a PDF creates unnecessarily large files Key: PDFBOX-785 URL: https://issues.apache.org/jira/browse/PDFBOX-785 Project: PDFBox Issue Type: Bug Components: Utilities Affects Versions: 1.8.8, 2.0.0 Environment: Windows XP, openOffice3.0.0, pdfsam Reporter: mathieu radiguet Assignee: Andreas Lehmkühler Fix For: 1.8.9, 2.0.0 Attachments: fileSizeIssue.zip Using PDFBox 0.8.0 (also tried on 1.1.0 and 1.2.1) to split files result in bigger parts than the original. Concerned files were made from openOffice .odt documents in version 3.0.0 using openOffice pdf Export and then merging several copies with pdfsam (http://www.pdfsam.org/) In joined eclipse project the test file size is 10 712 749 bytes for 2812 pages and the result file sizes after splitting in two at page 2300 are : 8 812 515 bytes and 10 701 142 bytes. Using pdfSplit in command line as result we have all single result files bigger than the original. An example is also attached. An error tells the original file is corrupted, but we tried it on a file (using pdfsam and without using it) with no error and with similar result, so I think it's not related. This issue seems similar to PDFBOX-28. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255616#comment-14255616 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647284 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647284 ] PDFBOX-2576: remove double code Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255695#comment-14255695 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647300 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647300 ] PDFBOX-2576 reduce empty if statement Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255699#comment-14255699 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647301 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647301 ] PDFBOX-2576 resolve TODO in code Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255729#comment-14255729 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647313 from [~lehmi] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647313 ] PDFBOX-2576: make immutable static values final, reformatted Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-1618) Split PDF file to single page files, some files are inflated in size
[ https://issues.apache.org/jira/browse/PDFBOX-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255827#comment-14255827 ] ASF subversion and git services commented on PDFBOX-1618: - Commit 1647330 from [~lehmi] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647330 ] PDFBOX-1618: take GoTo actions into account when removing page links Split PDF file to single page files, some files are inflated in size Key: PDFBOX-1618 URL: https://issues.apache.org/jira/browse/PDFBOX-1618 Project: PDFBox Issue Type: Bug Components: Utilities Affects Versions: 1.8.1 Environment: Windows 7, JVM 1.6.0_29 Reporter: Tom Taylor Assignee: Andreas Lehmkühler Fix For: 2.0.0 Attachments: 112080-TECHNICAL MANUAL FOR GENERATOR NIR 7194 A-10LW OF 4038 KVA.pdf, Test_PDFs.zip, internalstructure.png A PDF file is split into single pages for inclusion within another document (pdfbox.utils.Splitter within our code but same phenomenon observed when splitting using command line PDFSplit tool). Som of the pages are almost as large as the original file which causes performance problems for our customers. Again, I have a sample pdf to attach. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-1618) Split PDF file to single page files, some files are inflated in size
[ https://issues.apache.org/jira/browse/PDFBOX-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255829#comment-14255829 ] ASF subversion and git services commented on PDFBOX-1618: - Commit 1647331 from [~lehmi] in branch 'pdfbox/branches/1.8' [ https://svn.apache.org/r1647331 ] PDFBOX-1618: take GoTo actions into account when removing page links Split PDF file to single page files, some files are inflated in size Key: PDFBOX-1618 URL: https://issues.apache.org/jira/browse/PDFBOX-1618 Project: PDFBox Issue Type: Bug Components: Utilities Affects Versions: 1.8.1 Environment: Windows 7, JVM 1.6.0_29 Reporter: Tom Taylor Assignee: Andreas Lehmkühler Fix For: 2.0.0 Attachments: 112080-TECHNICAL MANUAL FOR GENERATOR NIR 7194 A-10LW OF 4038 KVA.pdf, Test_PDFs.zip, internalstructure.png A PDF file is split into single pages for inclusion within another document (pdfbox.utils.Splitter within our code but same phenomenon observed when splitting using command line PDFSplit tool). Som of the pages are almost as large as the original file which causes performance problems for our customers. Again, I have a sample pdf to attach. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255904#comment-14255904 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647349 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647349 ] PDFBOX-2576: remove COSStream branch that is identical to COSDictionary branch, because COSStream is derived from COSDictionary Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2579) Exception in thread main java.io.IOException: Error: Expected a long type at offset 1029, instead got '12688(Deleted'
[
https://issues.apache.org/jira/browse/PDFBOX-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256071#comment-14256071
]
ASF subversion and git services commented on PDFBOX-2579:
-
Commit 1647382 from [~tilman] in branch 'pdfbox/branches/1.8'
[ https://svn.apache.org/r1647382 ]
PDFBOX-2579: add '(' as extra delimiter for BaseParser.readStringNumber()
Exception in thread main java.io.IOException: Error: Expected a long type
at offset 1029, instead got '12688(Deleted'
---
Key: PDFBOX-2579
URL: https://issues.apache.org/jira/browse/PDFBOX-2579
Project: PDFBox
Issue Type: Bug
Components: Parsing
Affects Versions: 1.8.8, 2.0.0
Reporter: Tilman Hausherr
A (semi-confidential) file sent to me has an object stream with this content:
{code}
12076 132 12125 133 12616 1 12636 135 12688(Deleted
Obj)/A/O/Layout/Placement...
{code}
So I guess that there's a problem with recognizing the 12688 as a number.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PDFBOX-2579) Exception in thread main java.io.IOException: Error: Expected a long type at offset 1029, instead got '12688(Deleted'
[
https://issues.apache.org/jira/browse/PDFBOX-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256073#comment-14256073
]
ASF subversion and git services commented on PDFBOX-2579:
-
Commit 1647383 from [~tilman] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1647383 ]
PDFBOX-2579: add '(' as extra delimiter for BaseParser.readStringNumber()
Exception in thread main java.io.IOException: Error: Expected a long type
at offset 1029, instead got '12688(Deleted'
---
Key: PDFBOX-2579
URL: https://issues.apache.org/jira/browse/PDFBOX-2579
Project: PDFBox
Issue Type: Bug
Components: Parsing
Affects Versions: 1.8.8, 2.0.0
Reporter: Tilman Hausherr
A (semi-confidential) file sent to me has an object stream with this content:
{code}
12076 132 12125 133 12616 1 12636 135 12688(Deleted
Obj)/A/O/Layout/Placement...
{code}
So I guess that there's a problem with recognizing the 12688 as a number.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256230#comment-14256230 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647420 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647420 ] PDFBOX-2576 provide cause of exception; StringBuilder for concatenation Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256271#comment-14256271 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647425 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647425 ] PDFBOX-2576: remove unused imports, unused variable Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256273#comment-14256273 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647427 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647427 ] PDFBOX-2576 remove duplicate code Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256272#comment-14256272 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647426 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647426 ] PDFBOX-2576: field can be final Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256274#comment-14256274 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647428 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647428 ] PDFBOX-2576: remove unused imports, sort imports Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256279#comment-14256279 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647434 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647434 ] PDFBOX-2576: remove inaccurate comment Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256281#comment-14256281 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647435 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647435 ] PDFBOX-2576: remove unused imports Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256282#comment-14256282 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647436 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647436 ] PDFBOX-2576: remove unused imports Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2580) Decouple forms filling from interactive.form PD Model
[ https://issues.apache.org/jira/browse/PDFBOX-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256297#comment-14256297 ] ASF subversion and git services commented on PDFBOX-2580: - Commit 1647440 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647440 ] PDFBOX-2580 package creation and initial file movement Decouple forms filling from interactive.form PD Model - Key: PDFBOX-2580 URL: https://issues.apache.org/jira/browse/PDFBOX-2580 Project: PDFBox Issue Type: Bug Components: AcroForm Reporter: Maruan Sahyoun Assignee: Maruan Sahyoun The interactive.form PD model currently holds classes reflecting the various fields intermixed with appearance generation and layout handling. In order to separate the PD model from the service of forms filling and appearance generation this functionality shall be moved into a new package. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2580) Decouple forms filling from interactive.form PD Model
[ https://issues.apache.org/jira/browse/PDFBOX-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256303#comment-14256303 ] ASF subversion and git services commented on PDFBOX-2580: - Commit 1647441 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647441 ] PDFBOX-2580 move appearance generation Decouple forms filling from interactive.form PD Model - Key: PDFBOX-2580 URL: https://issues.apache.org/jira/browse/PDFBOX-2580 Project: PDFBox Issue Type: Bug Components: AcroForm Reporter: Maruan Sahyoun Assignee: Maruan Sahyoun The interactive.form PD model currently holds classes reflecting the various fields intermixed with appearance generation and layout handling. In order to separate the PD model from the service of forms filling and appearance generation this functionality shall be moved into a new package. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256318#comment-14256318 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647446 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647446 ] PDFBOX-2576 fix variable hides a field warning Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256808#comment-14256808 ] ASF subversion and git services commented on PDFBOX-2576: - Commit 1647525 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647525 ] PDFBOX-2576 mark class as final Improve code quality Key: PDFBOX-2576 URL: https://issues.apache.org/jira/browse/PDFBOX-2576 Project: PDFBox Issue Type: Task Affects Versions: 2.0.0 Reporter: Tilman Hausherr This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PDFBOX-2440) xref stream is saved as table
[ https://issues.apache.org/jira/browse/PDFBOX-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257076#comment-14257076 ] ASF subversion and git services commented on PDFBOX-2440: - Commit 1647593 from [~lehmi] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1647593 ] PDFBOX-2440: improved XRef type handling xref stream is saved as table - Key: PDFBOX-2440 URL: https://issues.apache.org/jira/browse/PDFBOX-2440 Project: PDFBox Issue Type: Bug Components: Writing Affects Versions: 1.8.7 Reporter: WB Assignee: Andreas Lehmkühler Fix For: 2.0.0 Attachments: COSWriter.diff, lipsum.pdf When saving a PDDocument, PdfBox seems to always write an xref table, even when the original file contains an xref stream. To reproduce, load a PDF file (like the one attached) with PDDocument#load (or PDDocument#loadNonSeq, same result) and then save it with PDDocument#save to another file. It seems to me that the problem is in COSWriter#doWriteXRef. When COSDocument#isXRefStream is true, the xref entries should be wrapped in a stream, but they're written to output one by one. I think that part should look more like its counterpart in COSWriter#doWriteXRefInc. I made some changes to doWriteXRef accordingly and it seems to work for PDFs that have never been incrementally updated but leads to corrupt files when the PDF has been incrementally updated before :( -- This message was sent by Atlassian JIRA (v6.3.4#6332)
