RE : RE : RE : RE : RE : bug : make test fails
Hi Stas,
Here is what I get. Maybe the problem comes from my user in httpd.conf
not being "nobody" ? (but I doubt it could be so).
su-2.05b# killall httpd
su-2.05b# t/TEST -start
*** root mode: changing the files ownership to 'nobody' (65534:65534)
*** /usr/bin/perl -e ' require POSIX; POSIX::setuid(65534);
POSIX::s
etgid(65534); print -r q{/usr/data/src/apache2/mod_perl-1.99_11/t}
&& -w _
&& -x _ ? q{OK} : q{NOK}; '
*** result: OK
/usr/local/apache2/bin/httpd -d /usr/data/src/apache2/mod_perl-1.99_11/t
-f /usr
/data/src/apache2/mod_perl-1.99_11/t/conf/httpd.conf -DAPACHE2
using Apache/2.0.48 (prefork MPM)
waiting 60 seconds for server to start: .[Tue Dec 02 10:23:03 2003]
[info] 23 Ap
ache:: modules loaded
[Tue Dec 02 10:23:03 2003] [info] 5 APR:: modules loaded
[Tue Dec 02 10:23:03 2003] [info] base server + 11 vhosts ready to run
tests
..
waiting 60 seconds for server to start: ok (waited 2 secs)
server localhost:8529 started
server localhost:8530 listening (TestProtocol::echo_filter)
server localhost:8531 listening (TestProtocol::echo)
server localhost:8532 listening (TestPreConnection::note)
server localhost:8533 listening (TestHooks::stacked_handlers2)
server localhost:8534 listening (TestFilter::in_bbs_inject_header)
server localhost:8535 listening (TestFilter::in_str_msg)
server localhost:8536 listening (TestFilter::both_str_con_add)
server localhost:8537 listening (TestFilter::in_bbs_msg)
server localhost:8538 listening (TestDirective::perlmodule)
server localhost:8539 listening (TestDirective::perlrequire)
server localhost:8540 listening (TestPerl::ithreads)
server localhost:8541 listening (TestDirective::perlloadmodule4)
server localhost:8542 listening (TestDirective::perlloadmodule5)
server localhost:8543 listening (TestDirective::perlloadmodule3)
server localhost:8544 listening (TestDirective::perlloadmodule6)
still waiting for server to warm up:
...
the server is down, giving up after 61 secs
!!! failed to start server! (please examine t/logs/error_log)
su-2.05b# cat t/logs/error_log
[Tue Dec 02 10:23:03 2003] [info] mod_unique_id: using ip addr
192.168.1.5
[Tue Dec 02 10:23:04 2003] [info] Init: Initializing OpenSSL library
[Tue Dec 02 10:23:04 2003] [info] Init: Seeding PRNG with 0 bytes of
entropy
[Tue Dec 02 10:23:04 2003] [info] Init: Generating temporary RSA private
keys (5
12/1024 bits)
[Tue Dec 02 10:23:04 2003] [info] Init: Generating temporary DH
parameters (512/
1024 bits)
[Tue Dec 02 10:23:04 2003] [warn] Init: Session Cache is not configured
[hint: S
SLSessionCache]
[Tue Dec 02 10:23:04 2003] [info] Init: Initializing (virtual) servers
for SSL
[Tue Dec 02 10:23:04 2003] [info] Server: Apache/2.0.48, Interface:
mod_ssl/2.0.
48, Library: OpenSSL/0.9.7a
END in modperl_extra.pl, pid=98478
[Tue Dec 02 10:23:04 2003] [info] mod_unique_id: using ip addr
192.168.1.5
[Tue Dec 02 10:23:05 2003] [info] Init: Initializing OpenSSL library
[Tue Dec 02 10:23:05 2003] [info] Init: Seeding PRNG with 0 bytes of
entropy
[Tue Dec 02 10:23:05 2003] [info] Init: Generating temporary RSA private
keys (5
12/1024 bits)
[Tue Dec 02 10:23:05 2003] [info] Init: Generating temporary DH
parameters (512/
1024 bits)
[Tue Dec 02 10:23:05 2003] [info] Init: Initializing (virtual) servers
for SSL
[Tue Dec 02 10:23:05 2003] [info] Server: Apache/2.0.48, Interface:
mod_ssl/2.0.
48, Library: OpenSSL/0.9.7a
[Tue Dec 02 10:23:05 2003] [notice] Apache/2.0.48 (Unix)
mod_perl/1.99_11 Perl/v
5.8.0 mod_ssl/2.0.48 OpenSSL/0.9.7a configured -- resuming normal
operations
[Tue Dec 02 10:23:05 2003] [info] Server built: Dec 1 2003 12:22:41
[Tue Dec 02 10:23:05 2003] [debug] prefork.c(1037): AcceptMutex: flock
(default:
flock)
[Tue Dec 02 10:23:07 2003] [error] server reached MaxClients setting,
consider r
aising the MaxClients setting
Barbara Post
-Message d'origine-
De : Stas Bekman [mailto:[EMAIL PROTECTED]
Envoyé : lundi 1 décembre 2003 19:59
À : barbara post
Cc : [EMAIL PROTECTED]
Objet : Re: RE : RE : RE : RE : bug : make test fails
Barbara Post wrote:
> Thanks Stas, it works, I first didn't properly killed every httpd
> process... but I still have a _slight_ bug, MaxNumberClients is too
low
> in (apache's ?) default configuration. This is unimportant except for
> "make test" proofreading (my installation of apache works, at least
> loads errorless).
Nuh,
[Mon Dec 01 19:53:50 2003] [error] server reached MaxClients setting,
consider raising the MaxClients setting
is not a problem in this situation. It's only an issue in production
when all
servers are busy and new requests will be put on hold and served
immediately.
But this is strange:
> # make test
>
> waiting 60 seconds for server to start: .[Mon Dec 01 19:53:45 2003]
> [info] 23 Apache:: modules loaded
> [Mon Dec 01 19:53:45 2003] [info] 5 APR:: modules loaded
> [Mon Dec 01 19:53:45 2003] [info] base server + 11 vhosts ready to run
> tests
> ...
> waiting 60 seconds for se
Re: bug : make test fails
Barbara, you have a strange mail client, it keeps on adding RE: to the subject, and breaking the thread. Hmm, I guess that explains it: X-Mailer: Microsoft Outlook, Build 10.0.2627 Here is what I get. Maybe the problem comes from my user in httpd.conf not being "nobody" ? (but I doubt it could be so). Ahm, can you please run what I've asked in the previous email and post the output of the second one? i.e.: t/TEST -start t/TEST -run t/apache/read.t Notice that there are two commands. Disregard the failure of the first one. Thanks. Next please try to unpack mod_perl under your normal user's home, when you aren't root and try to build again as you did before, plus 'make test'. It's possible that the problem is because you are running as root. Thanks. __ Stas BekmanJAm_pH --> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: BUG REPORT: modperl(dev) make fails at "`APR_SO_TIMEOUT' undeclared"
>>> 2.1 has dropped quite a few deprecated features. If we can do that >>> without any special #ifdef (i.e. 2.0.46 and higher support this API), >>> then I see no harm in adjusting it. Patches are very welcome. >> >> >> I'll look into this and fix it if possible. hopefully there's no reason >> that we can't keep mod_perl 2.0 at least compiling with 2.1 current mod_perl 2.0 cvs now works with 2.1 (at least for the moment). back tested to 2.0.46 as well. --Geoff - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: BUG REPORT: modperl(dev) make fails at "`APR_SO_TIMEOUT' undeclared"
hi geoff, i can verify that mod_perl compiles (thanks!) and runs w/ Apache2.10 (dev) on MacOSX 10.2.8 & 10.3.1: Apache/2.1.0-dev (Unix) mod_perl/1.99_12-dev Perl/v5.8.2 DAV/2 PHP/4.3.4 great! thanks again! as fyi -- "make test" gives: Failed Test Stat Wstat Total Fail Failed List of Failed --- apr/finfo.t 172 11.76% 7-8 9 tests skipped. *** server localhost:8529 shutdown !!! error running tests (please examine t/logs/error_log) ++ | Please file a bug report: http://perl.apache.org/bugs/ | ++ make: *** [run_tests] Error 1 and, for completeness, the contents of "t/logs/error_log" are included here at the bottom ... cheers, richard -- On Tuesday, December 2, 2003 10:53 AM -0500 Geoffrey Young <[EMAIL PROTECTED]> wrote: 2.1 has dropped quite a few deprecated features. If we can do that without any special #ifdef (i.e. 2.0.46 and higher support this API), then I see no harm in adjusting it. Patches are very welcome. I'll look into this and fix it if possible. hopefully there's no reason that we can't keep mod_perl 2.0 at least compiling with 2.1 current mod_perl 2.0 cvs now works with 2.1 (at least for the moment). back tested to 2.0.46 as well. --Geoff - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] % cat t/logs/error_log [Tue Dec 02 08:58:41 2003] [info] mod_unique_id: using ip addr 10.0.0.6 [Tue Dec 02 08:58:42 2003] [info] Init: Seeding PRNG with 0 bytes of entropy [Tue Dec 02 08:58:42 2003] [info] Init: Generating temporary RSA private keys (512/1024 bits) [Tue Dec 02 08:58:42 2003] [info] Init: Generating temporary DH parameters (512/1024 bits) [Tue Dec 02 08:58:42 2003] [warn] Init: Session Cache is not configured [hint: SSLSessionCache] [Tue Dec 02 08:58:42 2003] [info] Init: Initializing (virtual) servers for SSL [Tue Dec 02 08:58:42 2003] [info] Server: Apache/2.1.0-dev, Interface: mod_ssl/2.1.0-dev, Library: OpenSSL/0.9.7c END in modperl_extra.pl, pid=12826 END in modperl_extra.pl, pid=12826 END in modperl_extra.pl, pid=12826 END in modperl_extra.pl, pid=12826 [Tue Dec 02 08:59:12 2003] [info] mod_unique_id: using ip addr 10.0.0.6 [Tue Dec 02 08:59:13 2003] [notice] Digest: generating secret for digest authentication ... [Tue Dec 02 08:59:13 2003] [notice] Digest: done [Tue Dec 02 08:59:13 2003] [info] Init: Seeding PRNG with 0 bytes of entropy [Tue Dec 02 08:59:13 2003] [info] Init: Generating temporary RSA private keys (512/1024 bits) [Tue Dec 02 08:59:14 2003] [info] Init: Generating temporary DH parameters (512/1024 bits) [Tue Dec 02 08:59:14 2003] [info] Init: Initializing (virtual) servers for SSL [Tue Dec 02 08:59:14 2003] [info] Server: Apache/2.1.0-dev, Interface: mod_ssl/2.1.0-dev, Library: OpenSSL/0.9.7c [Tue Dec 02 08:59:15 2003] [notice] Apache/2.1.0-dev (Unix) mod_perl/1.99_12-dev Perl/v5.8.2 DAV/2 PHP/4.3.4 mod_ssl/2.1.0-dev OpenSSL/0.9.7c configured -- resuming normal operations [Tue Dec 02 08:59:15 2003] [info] Server built: Nov 26 2003 14:58:49 [Tue Dec 02 08:59:15 2003] [debug] worker.c(1691): AcceptMutex: posixsem (default: posixsem) [Tue Dec 02 08:59:21 2003] [error] server reached MaxClients setting, consider raising the MaxClients setting [Tue Dec 02 08:59:45 2003] [info] [client 127.0.0.1] TestAPI::aplog test in progress This log message comes with no header *** The following warn entry is expected and it is harmless *** [Tue Dec 02 08:59:45 2003] [debug] /Volumes/develop/ports/modperl-2.0/t/response/TestAPI/aplog.pm(48): log_serror test ok *** The following warn entry is expected and it is harmless *** [Tue Dec 02 08:59:45 2003] [debug] /Volumes/develop/ports/modperl-2.0/t/response/TestAPI/aplog.pm(52): (20014)Error string not specified yet: log_serror test 2 ok *** The following error entry is expected and it is harmless *** [Tue Dec 02 08:59:45 2003] [crit] [client 127.0.0.1] (20007)No time was provided and one was required.: log_rerror test ok *** The following error entry is expected and it is harmless *** [Tue Dec 02 08:59:45 2003] [error] $r->log_error test ok *** The following error entry is expected and it is harmless *** [Tue Dec 02 08:59:45 2003] [error] $s->log_error test ok [Tue Dec 02 08:59:45 2003] [debug] /Volumes/develop/ports/modperl-2.0/t/response/TestAPI/aplog.pm(73): TestAPI::aplog test done [Tue Dec 02 08:59:45 2003] [warn] ApacheApache->warn test ok [Tue Dec 02 08:59:45 2003] [warn] $s->warn test ok trying now*** at /Volumes/develop/ports/modperl-2.0/t/response/TestAPI/show.pm line 19. Subroutine APR::URI::parse redefined at /System/Library/Perl/5.8.2/darwin-thread-multi/XSLoader.pm line 29. Subroutine APR::URI::port_of_scheme redefined at /System/Library/Perl/5.8.2/darwin-thread-multi/XSLoade
Re: BUG REPORT: modperl(dev) make fails at "`APR_SO_TIMEOUT' undeclared"
OpenMacNews wrote: > hi geoff, > > i can verify that mod_perl compiles (thanks!) and runs w/ Apache2.10 > (dev) on MacOSX 10.2.8 & 10.3.1: > >Apache/2.1.0-dev (Unix) mod_perl/1.99_12-dev Perl/v5.8.2 DAV/2 > PHP/4.3.4 > > great! thanks again! > > as fyi -- "make test" gives: > > Failed Test Stat Wstat Total Fail Failed List of Failed > --- > > apr/finfo.t 172 11.76% 7-8 > 9 tests skipped. can you please run $ t/TEST t/apr/finfo.t -v and report it's output. thanks. --Geoff - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: modperl-2.0/xs/tables/current/Apache ConstantsTable.pm FunctionTable.pm
[EMAIL PROTECTED] wrote:
geoff 2003/12/02 07:49:22
Modified:t/filter/TestFilter both_str_req_proxy.pm
t/response/TestAPI rutil.pm
xs/maps apr_functions.map
xs/tables/current/Apache ConstantsTable.pm FunctionTable.pm
Log:
remove deprecated APR features: apr_uri_default_port_for_scheme(),
apr_socket_opt_get(), apr_socket_opt_set(), and APR_NO_TIMEOUT.
geoff++
Revision ChangesPath
1.3 +20 -1 modperl-2.0/t/filter/TestFilter/both_str_req_proxy.pm
Index: both_str_req_proxy.pm
===
RCS file: /home/cvs/modperl-2.0/t/filter/TestFilter/both_str_req_proxy.pm,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- both_str_req_proxy.pm 25 Nov 2003 00:11:52 - 1.2
+++ both_str_req_proxy.pm 2 Dec 2003 15:49:22 - 1.3
@@ -58,6 +58,8 @@
__DATA__
+
+# 2.0
http://@servername@:@port@/*>
Order Deny,Allow
@@ -71,7 +73,24 @@
http://@servername@:@port@/TestFilter__both_str_req_proxy_content/
ProxyPassReverse /TestFilter__both_str_req_proxy/ \
http://@servername@:@port@/TestFilter__both_str_req_proxy_content/
-
+
+
+# 2.1
+
+http://@servername@:@port@/*>
+Order Deny,Allow
+Deny from all
+Allow from @servername@
+
+ProxyRequests Off
+RewriteEngine On
+
+ProxyPass/TestFilter__both_str_req_proxy/ \
+http://@servername@:@port@/TestFilter__both_str_req_proxy_content/
+ProxyPassReverse /TestFilter__both_str_req_proxy/ \
+http://@servername@:@port@/TestFilter__both_str_req_proxy_content/
+
+
PerlModule TestFilter::both_str_req_proxy
It'd be better to commit this separately, as it has nothing to do with the
rest of the commit.
I don't like the duplication that this auth thing creates. May be we should
consider adding some magic to Apache-Test to use the right IfModule depending
on the used httpd version used.
1.61 +1 -3 modperl-2.0/xs/maps/apr_functions.map
Index: apr_functions.map
===
RCS file: /home/cvs/modperl-2.0/xs/maps/apr_functions.map,v
retrieving revision 1.60
retrieving revision 1.61
diff -u -r1.60 -r1.61
--- apr_functions.map 17 Nov 2003 23:27:11 - 1.60
+++ apr_functions.map 2 Dec 2003 15:49:22 - 1.61
@@ -58,8 +58,6 @@
!apr_socket_addr_get
!apr_socket_data_get
!apr_socket_data_set
- apr_socket_opt_get
- apr_socket_opt_set
apr_socket_timeout_get | mpxs_ | ...
apr_socket_timeout_set
-apr_socket_sendfile
@@ -569,7 +567,7 @@
uptr, flags=APR_URI_UNP_OMITPASSWORD | unparse
#special case to set both uri->port and uri->port_str
mpxs_APR__URI_port | | uri, portsv=Nullsv
- apr_uri_default_port_for_scheme
+ apr_uri_port_of_scheme
You replaced apr_uri_default_port_for_scheme with apr_uri_port_of_scheme, but
logged only that the former was deleted.
Also most users have no idea what APR_NO_TIMEOUT is (Changes is a user log,
right?) so I think it's better to s/APR_NO_TIMEOUT/APR::NO_TIMEOUT/
1.49 +0 -10 modperl-2.0/xs/tables/current/Apache/FunctionTable.pm
Index: FunctionTable.pm
===
RCS file: /home/cvs/modperl-2.0/xs/tables/current/Apache/FunctionTable.pm,v
retrieving revision 1.48
retrieving revision 1.49
diff -u -r1.48 -r1.49
--- FunctionTable.pm 1 Dec 2003 17:14:16 - 1.48
+++ FunctionTable.pm 2 Dec 2003 15:49:22 - 1.49
@@ -12903,16 +12903,6 @@
]
},
{
-'return_type' => 'apr_port_t',
-'name' => 'apr_uri_default_port_for_scheme',
-'args' => [
- {
-'type' => 'const char *',
-'name' => 'scheme_str'
- }
-]
- },
- {
What about these two:
xs/tables/current/Apache/FunctionTable.pm:'name' => 'apr_socket_opt_get',
xs/tables/current/Apache/FunctionTable.pm:'name' => 'apr_socket_opt_set',
shouldn't these be removed as well?
__
Stas BekmanJAm_pH --> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: BUG REPORT: modperl(dev) make fails at "`APR_SO_TIMEOUT' undeclared"
OpenMacNews wrote: hi geoff, i can verify that mod_perl compiles (thanks!) and runs w/ Apache2.10 (dev) on MacOSX 10.2.8 & 10.3.1: Apache/2.1.0-dev (Unix) mod_perl/1.99_12-dev Perl/v5.8.2 DAV/2 PHP/4.3.4 great! thanks again! as fyi -- "make test" gives: Failed Test Stat Wstat Total Fail Failed List of Failed --- apr/finfo.t 172 11.76% 7-8 9 tests skipped. can you please run $ t/TEST t/apr/finfo.t -v and report it's output. thanks. --Geoff certainly! :-) Richard % t/TEST t/apr/finfo.t -v *** setting ulimit to allow core files ulimit -c unlimited; t/TEST 't/apr/finfo.t' -v /usr/sbin/httpd -d /Volumes/develop/ports/modperl-2.0/t -f /Volumes/develop/ports/modperl-2.0/t/conf/httpd.conf -DAPACHE2 -DPERL_USEITHREADS using Apache/2.1.0-dev (worker MPM) waiting 60 seconds for server to start: ..[Tue Dec 02 10:05:17 2003] [info] 22 Apache:: modules loaded [Tue Dec 02 10:05:17 2003] [info] 5 APR:: modules loaded [Tue Dec 02 10:05:17 2003] [info] base server + 12 vhosts ready to run tests ..(48)Address already in use: make_sock: could not bind to address [::]:8529 (48)Address already in use: make_sock: could not bind to address [::]:8530 (48)Address already in use: make_sock: could not bind to address [::]:8531 (48)Address already in use: make_sock: could not bind to address [::]:8532 (48)Address already in use: make_sock: could not bind to address [::]:8533 (48)Address already in use: make_sock: could not bind to address [::]:8534 (48)Address already in use: make_sock: could not bind to address [::]:8535 (48)Address already in use: make_sock: could not bind to address [::]:8536 (48)Address already in use: make_sock: could not bind to address [::]:8537 (48)Address already in use: make_sock: could not bind to address [::]:8538 (48)Address already in use: make_sock: could not bind to address [::]:8539 (48)Address already in use: make_sock: could not bind to address [::]:8540 (48)Address already in use: make_sock: could not bind to address [::]:8541 (48)Address already in use: make_sock: could not bind to address [::]:8542 (48)Address already in use: make_sock: could not bind to address [::]:8543 (48)Address already in use: make_sock: could not bind to address [::]:8544 (48)Address already in use: make_sock: could not bind to address [::]:8545 ... waiting 60 seconds for server to start: ok (waited 42 secs) server localhost:8529 started server localhost:8530 listening (TestProtocol::echo) server localhost:8531 listening (TestProtocol::echo_filter) server localhost:8532 listening (TestProtocol::eliza) server localhost:8533 listening (TestPreConnection::note) server localhost:8534 listening (TestHooks::stacked_handlers2) server localhost:8535 listening (TestFilter::both_str_con_add) server localhost:8536 listening (TestFilter::in_bbs_inject_header) server localhost:8537 listening (TestFilter::in_bbs_msg) server localhost:8538 listening (TestFilter::in_str_msg) server localhost:8539 listening (TestDirective::perlmodule) server localhost:8540 listening (TestDirective::perlrequire) server localhost:8541 listening (TestPerl::ithreads) server localhost:8542 listening (TestDirective::perlloadmodule3) server localhost:8543 listening (TestDirective::perlloadmodule4) server localhost:8544 listening (TestDirective::perlloadmodule5) server localhost:8545 listening (TestDirective::perlloadmodule6) apr/finfo1..17 # Running under perl version 5.008002 for darwin # Current time local: Tue Dec 2 10:05:47 2003 # Current time GMT: Tue Dec 2 18:05:47 2003 # Using Test.pm version 1.24 # $r->finfo APR::Finfo=SCALAR(0x196b320) ok 1 # $r->finfo->pool APR::Pool=SCALAR(0x1246b68) ok 2 # testing : stat /Volumes/develop/ports/modperl-2.0/t/htdocs/index.html # expected: 0 # received: 0 ok 3 # testing : $r->finfo->device() # expected: 234881045 # received: 234881045 ok 4 # testing : $r->finfo->inode() # expected: 3376188 # received: 3376188 ok 5 # testing : $r->finfo->nlink() # expected: 1 # received: 1 ok 6 # testing : $r->finfo->user() # expected: 4294967294 # received: -2 not ok 7 # testing : $r->finfo->group() # expected: 4294967294 # received: -2 not ok 8 # testing : $r->finfo->size() # expected: 632 # received: 632 ok 9 # testing : $r->finfo->atime() # expected: 1070388357 # received: 1070388357 ok 10
Re: cvs commit: modperl-2.0/xs/tables/current/Apache ConstantsTable.pm FunctionTable.pm
>> + >> + >> +# 2.1 >> + >> +http://@servername@:@port@/*> >> +Order Deny,Allow >> +Deny from all >> +Allow from @servername@ >> + >> +ProxyRequests Off >> +RewriteEngine On >> + >> +ProxyPass/TestFilter__both_str_req_proxy/ \ >> + >> http://@servername@:@port@/TestFilter__both_str_req_proxy_content/ >> +ProxyPassReverse /TestFilter__both_str_req_proxy/ \ >> + >> http://@servername@:@port@/TestFilter__both_str_req_proxy_content/ >> + >> + >> >> PerlModule TestFilter::both_str_req_proxy > > > It'd be better to commit this separately, as it has nothing to do with > the rest of the commit. well, the goal for me was to get things working with 2.1. before commit was not working, after commit was. but yeah, I suppose some of it could have been separated out. > > I don't like the duplication that this auth thing creates. May be we > should consider adding some magic to Apache-Test to use the right > IfModule depending on the used httpd version used. I guess. magic makes things wierd, though - magically turning mod_access.c to mod_authz_host might just be confusing. >> - apr_uri_default_port_for_scheme >> + apr_uri_port_of_scheme > > > You replaced apr_uri_default_port_for_scheme with > apr_uri_port_of_scheme, but logged only that the former was deleted. actually, I'm not sure exactly what the above bit of magic does. when I inadvertnetly added apr_uri_port_of_scheme to the function table it was generated twice (because it was in the function table twice). so it may have always been there. I didn't check. > > Also most users have no idea what APR_NO_TIMEOUT is (Changes is a user > log, right?) so I think it's better to s/APR_NO_TIMEOUT/APR::NO_TIMEOUT/ ok > > > What about these two: > > xs/tables/current/Apache/FunctionTable.pm:'name' => > 'apr_socket_opt_get', > xs/tables/current/Apache/FunctionTable.pm:'name' => > 'apr_socket_opt_set', > > shouldn't these be removed as well? yes, good catch. --Geoff - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: BUG REPORT: modperl(dev) make fails at "`APR_SO_TIMEOUT' undeclared"
># testing : $r->finfo->user() ># expected: 4294967294 ># received: -2 >not ok 7 ># testing : $r->finfo->group() ># expected: 4294967294 ># received: -2 >not ok 8 ack! this is apache 2.1, right? if you're interested in helping OSX along, I'd be interested in seeing the results from these two tests against apache 2.0.48, just to see if APR 1.0 introduced some changes. other than that, I have no idea. ack. --Geoff - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: modperl-2.0/xs/tables/current/Apache ConstantsTable.pm FunctionTable.pm
Geoffrey Young wrote: It'd be better to commit this separately, as it has nothing to do with the rest of the commit. well, the goal for me was to get things working with 2.1. before commit was not working, after commit was. it's ok if it was committed by mistake, but if you simply don't care to keep commits clean than :( I don't like the duplication that this auth thing creates. May be we should consider adding some magic to Apache-Test to use the right IfModule depending on the used httpd version used. I guess. magic makes things wierd, though - magically turning mod_access.c to mod_authz_host might just be confusing. But it avoids an error-prone duplications. - apr_uri_default_port_for_scheme + apr_uri_port_of_scheme You replaced apr_uri_default_port_for_scheme with apr_uri_port_of_scheme, but logged only that the former was deleted. actually, I'm not sure exactly what the above bit of magic does. when I inadvertnetly added apr_uri_port_of_scheme to the function table it was generated twice (because it was in the function table twice). so it may have always been there. I didn't check. it was in the table, but wasn't in the map. It wasn't enabled until now. __ Stas BekmanJAm_pH --> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: BUG REPORT: modperl(dev) make fails at "`APR_SO_TIMEOUT' undeclared"
;-)
i'll report back with results ...
geoff,
ok, here we go ... (i've included all the following info for completeness/posterity's
sake ...)
bottom line: the results of " t/TEST t/apr/finfo.t -v" for
(a) httpd-2.0.48+modperl
(b) httpd-2.1.0 (dev) +modperl
are, in fact, different.
ack!
richard
===
httpd-2.0.48
% cd /usr/ports/
% wget ftp://apache.secsup.org/pub/apache/dist/httpd/httpd-2.0.48.tar.gz
% gnutar zxf httpd-2.0.48.tar.gz
% cd /usr/ports/httpd-2.0.48
unsetenv CFLAGS CPPFLAGS CXX CXXFLAGS LDFLAGS LDDLFLAGS LD_PREBIND LC_ALL LANG LINGUAS
# this enables linking against libdl (dlcompat) ...
% vi /usr/ports/httpd-2.0.48/srclib/apr/configure
=
--- enable_dlopen=no
+++ enable_dlopen=yes
enable_win32_dll=no
=
% ./configure \
--prefix=/usr/local/httpd2048 \
--with-mpm=worker \
--enable-layout=Darwin --with-port=80 \
--enable-mods-shared=all --enable-so \
--sysconfdir=/etc/apache2 \
--enable-dav --enable-dav-fs \
--enable-ssl --with-ssl \
--disable-suexec \
--with-z \
--enable-cgi \
--enable-proxy \
--enable-proxy-connect \
--enable-proxy-ftp \
--enable-proxy-http \
--enable-logio \
--enable-authn-dbm --enable-authz-dbm
% vi /usr/ports/httpd-2.0.48/build/config_vars.mk
=
--- EXTRA_LIBS = -lssl -lcrypto
+++ EXTRA_LIBS = -lssl -lcrypto -ldl -lz
=
% make
% make install
[root]/usr/local/httpd2048/sbin> ./httpd -V
Server version: Apache/2.0.48
Server built: Dec 2 2003 11:14:52
Server's Module Magic Number: 20020903:4
Architecture: 32-bit
Server compiled with
-D APACHE_MPM_DIR="server/mpm/worker"
-D APR_HAS_MMAP
-D APR_HAVE_IPV6 (IPv4-mapped addresses enabled)
-D APR_USE_POSIXSEM_SERIALIZE
-D APR_USE_PTHREAD_SERIALIZE
-D SINGLE_LISTEN_UNSERIALIZED_ACCEPT
-D APR_HAS_OTHER_CHILD
-D AP_HAVE_RELIABLE_PIPED_LOGS
-D HTTPD_ROOT="/usr/local/httpd2048"
-D SUEXEC_BIN="/usr/local/httpd2048/bin/suexec"
-D DEFAULT_SCOREBOARD="logs/apache_runtime_status"
-D DEFAULT_ERRORLOG="logs/error_log"
-D AP_TYPES_CONFIG_FILE="/etc/apache2/mime.types"
-D SERVER_CONFIG_FILE="/etc/apache2/httpd.conf"
[root]/usr/local/httpd2048/sbin> ./httpd -l
Compiled in modules:
core.c
worker.c
http_core.c
mod_so.c
mod_perl-2.0
% cd /usr/ports
# 12/02/03 11:51:10
% cvs -d :pserver:[EMAIL PROTECTED]:/home/cvspublic login
% cvs -d :pserver:[EMAIL PROTECTED]:/home/cvspublic co -d modperl2048 modperl-2.0
% unsetenv CFLAGS CPPFLAGS CXX CXXFLAGS LDFLAGS LDDLFLAGS LD_PREBIND;\
setenv LDFLAGS "-L/usr/include/apache2 -ldl"
% cd /usr/ports/modperl2048
% perl Makefile.PL MP_APXS=/usr/local/httpd2048/sbin/apxs MP_INST_APACHE2=1
Reading Makefile.PL args from @ARGV
MP_APXS = /usr/local/httpd2048/sbin/apxs
MP_INST_APACHE2 = 1
Configuring Apache/2.0.48 mod_perl/1.99_12-dev Perl/v5.8.2
generating script t/TEST
Checking if your kit is complete...
Warning: the following files are missing in your kit:
META.yml
Please inform the author.
% chown -R www:wheel /usr/ports/modperl2048/
% chmod -R g+w /usr/ports/modperl2048/
% make
% make install
% chmod o+x /usr/local/httpd2048/libexec/apache2/mod_perl.so
% vi /etc/apache2/httpd.conf
# ( ... temporary change ...)
=
--- ServerRoot "/usr"
+++ ServerRoot "/usr/local/httpd2048"
+++ LoadModule perl_module libexec/apache2/mod_perl.so
(deprecate the neceesary mod_auth & mod_access entries for 2.0.48 compat)
=
RESULTS ###
###
## APACHE 2.0.48
###
% cd /usr/local/httpd2048/sbin
% ./apachectl start
Server Version: Apache/2.0.48 (Unix) mod_perl/1.99_12-dev Perl/v5.8.2 DAV/2
Server Built: Dec 2 2003 11:14:52
API Version: 20020903:4
% ./apachectl stop
% cd /usr/ports/modperl2048
% t/TEST t/apr/finfo.t -v
% t/TEST t/apr/finfo.t -v
*** setting ulimit to allow core files
ulimit -c unlimited; t/TEST 't/apr/finfo.t' -v
*** root mode: changing the files ownership to 'nobody' (4294967294:4294967294)
*** /usr/bin/perl -e ' require POSIX; POSIX::setuid(4294967294); POSIX::setgid(4294967294); print -r
q{/Volumes/develop/ports/modperl2048/t} && -w _ && -x _ ? q{OK} : q{NOK}; '
*** result: OK
/usr/local/httpd2048/sbin/httpd -d /Volumes/develop/ports/modperl2048/t -f
/Volumes/develop/ports/modperl2048/t/conf/httpd.conf -DAPACHE2 -DPERL_USEITHREADS
using Apach
Re: BUG REPORT: modperl(dev) make fails at "`APR_SO_TIMEOUT' undeclared"
geoff, after staring at the results i'd just sent you, i wanted to take a look into the httpd.conf's that each test used ... specifically, in the case of: (a) httpd-2.0.48 /usr/local/httpd2048/sbin/httpd -d /Volumes/develop/ports/modperl2048/t -f /Volumes/develop/ports/modperl2048/t/conf/httpd.conf -DAPACHE2 -DPERL_USEITHREADS (b) httpd-2.1.0(dev) /usr/sbin/httpd -d /Volumes/develop/ports/modperl-2.0/t -f /Volumes/develop/ports/modperl-2.0/t/conf/httpd.conf -DAPACHE2 -DPERL_USEITHREADS however, i find the conf files missing! [root]/> ls -al /Volumes/develop/ports/modperl2048/t/conf/httpd.conf /Volumes/develop/ports/modperl-2.0/t/conf/httpd.conf /bin/ls: /Volumes/develop/ports/modperl2048/t/conf/httpd.conf: No such file or directory /bin/ls: /Volumes/develop/ports/modperl-2.0/t/conf/httpd.conf: No such file or directory am i missing something here, or is the lack of these files a problem? richard - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: BUG REPORT: modperl(dev) make fails at "`APR_SO_TIMEOUT' undeclared"
> % t/TEST t/apr/finfo.t -v > *** setting ulimit to allow core files > ulimit -c unlimited; t/TEST 't/apr/finfo.t' -v > *** root mode: changing the files ownership to 'nobody' > (4294967294:4294967294) are you doing all this as root? that could be part of the problem. please 't/TEST t/apr/finfo.t -v' as a non-root user and see if that changes things. you might need to change ownership of the files before things will work at all (or just scratch it all and start fresh, building and making as a non-root user). --Geoff - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: BUG REPORT: modperl(dev) make fails at "`APR_SO_TIMEOUT' undeclared"
% t/TEST t/apr/finfo.t -v *** setting ulimit to allow core files ulimit -c unlimited; t/TEST 't/apr/finfo.t' -v *** root mode: changing the files ownership to 'nobody' (4294967294:4294967294) are you doing all this as root? that could be part of the problem. please 't/TEST t/apr/finfo.t -v' as a non-root user and see if that changes things. you might need to change ownership of the files before things will work at all (or just scratch it all and start fresh, building and making as a non-root user). --Geoff geoff, fair enuf! (yeah, yeah -- RTFM ;-), altho for the life of me i can't find where it says run "make test" as non-root ...) bottom line: http-2.0.48: All tests successful. Files=1, Tests=17, 2 wallclock secs ( 1.32 cusr + 0.35 csys = 1.67 CPU) http-2.1.0(dev): All tests successful. Files=1, Tests=17, 2 wallclock secs ( 1.27 cusr + 0.41 csys = 1.68 CPU) i suppose this is good news? richard and awy we go again ... [root]/usr/ports> chown -R www:wheel modperl2048/ modperl-2.0/ [root]/usr/ports> login www ... [www]/usr/ports> ps -ax | grep http 13640 std S+ 0:00.00 grep http unsetenv CFLAGS CPPFLAGS CXX CXXFLAGS LDFLAGS LDDLFLAGS LD_PREBIND setenv LDFLAGS "-L/usr/include/apache2 -ldl" cd /usr/ports/modperl2048 perl Makefile.PL MP_APXS=/usr/local/httpd2048/sbin/apxs MP_INST_APACHE2=1 Reading Makefile.PL args from @ARGV MP_APXS = /usr/local/httpd2048/sbin/apxs MP_INST_APACHE2 = 1 Configuring Apache/2.0.48 mod_perl/1.99_12-dev Perl/v5.8.2 make sudo make install cd /usr/ports/modperl-2.0 perl Makefile.PL MP_APXS=/usr/sbin/apxs MP_INST_APACHE2=1 Reading Makefile.PL args from @ARGV MP_APXS = /usr/sbin/apxs MP_INST_APACHE2 = 1 Configuring Apache/2.1.0-dev mod_perl/1.99_12-dev Perl/v5.8.2 make sudo make install cd /usr/ports/modperl2048 && t/TEST t/apr/finfo.t -v *** setting ulimit to allow core files ulimit -c unlimited; t/TEST 't/apr/finfo.t' -v /usr/local/httpd2048/sbin/httpd -d /Volumes/develop/ports/modperl2048/t -f /Volumes/develop/ports/modperl2048/t/conf/httpd.conf -DAPACHE2 -DPERL_USEITHREADS using Apache/2.0.48 (worker MPM) waiting 60 seconds for server to start: [Tue Dec 02 14:19:58 2003] [info] 22 Apache:: modules loaded [Tue Dec 02 14:19:58 2003] [info] 5 APR:: modules loaded [Tue Dec 02 14:19:58 2003] [info] base server + 12 vhosts ready to run tests ... waiting 60 seconds for server to start: ok (waited 46 secs) server localhost:8529 started server localhost:8530 listening (TestProtocol::echo) server localhost:8531 listening (TestProtocol::echo_filter) server localhost:8532 listening (TestProtocol::eliza) server localhost:8533 listening (TestPreConnection::note) server localhost:8534 listening (TestHooks::stacked_handlers2) server localhost:8535 listening (TestFilter::both_str_con_add) server localhost:8536 listening (TestFilter::in_bbs_inject_header) server localhost:8537 listening (TestFilter::in_bbs_msg) server localhost:8538 listening (TestFilter::in_str_msg) server localhost:8539 listening (TestDirective::perlmodule) server localhost:8540 listening (TestDirective::perlrequire) server localhost:8541 listening (TestPerl::ithreads) server localhost:8542 listening (TestDirective::perlloadmodule3) server localhost:8543 listening (TestDirective::perlloadmodule4) server localhost:8544 listening (TestDirective::perlloadmodule5) server localhost:8545 listening (TestDirective::perlloadmodule6) apr/finfo1..17 # Running under perl version 5.008002 for darwin # Current time local: Tue Dec 2 14:20:35 2003 # Current time GMT: Tue Dec 2 22:20:35 2003 # Using Test.pm version 1.24 # $r->finfo APR::Finfo=SCALAR(0x1d45a50) ok 1 # $r->finfo->pool APR::Pool=SCALAR(0x2386bf8) ok 2 # testing : stat /Volumes/develop/ports/modperl2048/t/htdocs/index.html # expected: 0 # received: 0 ok 3 # testing : $r->finfo->device() # expected: 234881045 # received: 234881045 ok 4 # testing : $r->finfo->inode() # expected: 3384022 # received: 3384022 ok 5 # testing : $r->finfo->nlink() # expected: 1 # received: 1 ok 6 # testing : $r->finfo->user() # expected: 501 # received: 501 ok 7 # testing : $r->finfo->group() # expected: 0 # received: 0 ok 8 # testing : $r->finfo->size() # expected: 632 # received: 632 ok 9 # testing : $r->finfo->atime() # expected: 1070403645 # received: 1070403645 ok 10 # testing : $r->finfo->mtime() # expected: 1070396908 # received: 1070396908 ok 11 # testing : $r->finfo->ctime() # expected: 1070401439 # received: 1070401439 ok 12 # testing : $r->finfo->protection() & APR::WREAD # expected: 4 # received: 4 ok 13 # testing : $r->finfo->protection() & APR::WWRITE # expected: 0 # received: 0 ok 14 # testing : $r->finfo->protection() & APR::WEXECUTE # expected: 0 # received
Re: BUG REPORT: modperl(dev) make fails at "`APR_SO_TIMEOUT' undeclared"
> geoff, > > fair enuf! > (yeah, yeah -- RTFM ;-), altho for the life of me i can't find where it > says run "make test" as non-root ...) it might not in the docs. doing only install as root is considered by many to be a best practice. I'll try to remember to add something in the appropriate place tomorrow (and, as always, patches welcome :) > > bottom line: > > http-2.0.48: > All tests successful. > Files=1, Tests=17, 2 wallclock secs ( 1.32 cusr + 0.35 csys = > 1.67 CPU) > > http-2.1.0(dev): > All tests successful. > Files=1, Tests=17, 2 wallclock secs ( 1.27 cusr + 0.41 csys = > 1.68 CPU) yea! > > i suppose this is good news? indeed :) --Geoff - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: BUG REPORT: modperl(dev) make fails at "`APR_SO_TIMEOUT' undeclared"
Geoffrey Young wrote: geoff, fair enuf! (yeah, yeah -- RTFM ;-), altho for the life of me i can't find where it says run "make test" as non-root ...) it might not in the docs. doing only install as root is considered by many to be a best practice. I'll try to remember to add something in the appropriate place tomorrow (and, as always, patches welcome :) Please don't. The test should work just fine under 'root'. It's not a documentation issue. __ Stas BekmanJAm_pH --> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: BUG REPORT: modperl(dev) make fails at "`APR_SO_TIMEOUT' undeclared"
Stas Bekman wrote: Geoffrey Young wrote: geoff, fair enuf! (yeah, yeah -- RTFM ;-), altho for the life of me i can't find where it says run "make test" as non-root ...) it might not in the docs. doing only install as root is considered by many to be a best practice. I'll try to remember to add something in the appropriate place tomorrow (and, as always, patches welcome :) Please don't. The test should work just fine under 'root'. It's not a documentation issue. I just tested and it seems to work fine for me under 'root'. Notice that all files under t are chowned to the user/group the server is running under (not-root) before the tests are run. I think I remember about a similar problem discussed on p5p # testing : $r->finfo->user() # expected: 4294967294 # received: -2 not ok 7 # testing : $r->finfo->group() # expected: 4294967294 # received: -2 Notice that the expected values are not very good. Here it is: http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2002-01/msg01530.html perl's t/op/stat failing on MacOSX. Arthur resolves to: http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2002-01/msg01555.html Seems like some bug in the UFS filesystem? and more: http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2002-01/msg01578.html So p5p decided to skip these sub-tests if $Is_Darwin && $Is_UFS; from t/op/stat.t: $Is_Darwin = $^O eq 'darwin'; $Is_UFS = $Is_Darwin && (() = `df -t ufs .`) == 2; and we also need to document that that finfo doesn't give a valid user/group under Darwin/UFS. Geoff, you are taking care of this? __ Stas BekmanJAm_pH --> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: BUG REPORT: modperl(dev) make fails at "`APR_SO_TIMEOUT' undeclared"
> I just tested and it seems to work fine for me under 'root'. Notice that > all files under t are chowned to the user/group the server is running > under (not-root) before the tests are run. yes, for me too, but on linux. did you test any OSX variant, though? richard, are you on darwin or panther? I have access to darwin but not panther, so my debugging is limited. > > I think I remember about a similar problem discussed on p5p > > # testing : $r->finfo->user() > # expected: 4294967294 > # received: -2 > not ok 7 > # testing : $r->finfo->group() > # expected: 4294967294 > # received: -2 > > Notice that the expected values are not very good. but they match what Apache-Test is doing. from richard's output ** root mode: changing the files ownership to 'nobody' (4294967294:4294967294) so perl is being consistent with itself, at least. apr merely reports back the result from an fstat call, so the issue really does seem to be with the underlying OS. > Here it is: > http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2002-01/msg01530.html those are good links. however, according to nick in the first thread, they all seem to be talking about c/mtime, not uid/gid. > > and we also need to document that that finfo doesn't give a valid > user/group under Darwin/UFS. I think that's premature at this point. we can just keep skipping failing platforms, I suppose, but I'd rather find someone who really understands this OSX biz before we simply proclaim that the results are meaningless on that platform. that it works fine as non-root (with sensical 501:0 values) leads me to believe that something else is going on. > > Geoff, you are taking care of this? haven't I been? I'll piddle around on moof a bit, but underlying POSIX stuff (or whatever it is) really isn't my strong point. --Geoff - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: BUG REPORT: modperl(dev) make fails at "`APR_SO_TIMEOUT' undeclared"
Geoffrey Young wrote: I just tested and it seems to work fine for me under 'root'. Notice that all files under t are chowned to the user/group the server is running under (not-root) before the tests are run. yes, for me too, but on linux. did you test any OSX variant, though? richard, are you on darwin or panther? I have access to darwin but not panther, so my debugging is limited. Richard is on darwin, please see the original report: http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=106989642826330&w=2 I think I remember about a similar problem discussed on p5p # testing : $r->finfo->user() # expected: 4294967294 # received: -2 not ok 7 # testing : $r->finfo->group() # expected: 4294967294 # received: -2 Notice that the expected values are not very good. but they match what Apache-Test is doing. from richard's output ** root mode: changing the files ownership to 'nobody' (4294967294:4294967294) so perl is being consistent with itself, at least. apr merely reports back the result from an fstat call, so the issue really does seem to be with the underlying OS. Cool, I've missed that. It just looked weird. I guess they use 2*32-1 for nobody, so they can accomodate 2*32-2 users ;) Here it is: http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2002-01/msg01530.html those are good links. however, according to nick in the first thread, they all seem to be talking about c/mtime, not uid/gid. if you look at that perl test, they don't test uid/gid at all. So I won't be surprised if that's the same case. BTW, why Finfo doesn't use uid/gid but user/group? because of the C data struct names? It's probably more intuitive to rename them to be uid/gid, since they return the ids and not names. and we also need to document that that finfo doesn't give a valid user/group under Darwin/UFS. I think that's premature at this point. we can just keep skipping failing platforms, I suppose, but I'd rather find someone who really understands this OSX biz before we simply proclaim that the results are meaningless on that platform. that it works fine as non-root (with sensical 501:0 values) leads me to believe that something else is going on. sure, I suggested to do that if that's indeed the problem. Geoff, you are taking care of this? haven't I been? I thought you bailed out, saying that we should document that the tests are not to be run as root. Hence I was asking, so I won't step on your toes. I'll piddle around on moof a bit, but underlying POSIX stuff (or whatever it is) really isn't my strong point. How does perl handles that on darwin/UFS? We should just do the same. __ Stas BekmanJAm_pH --> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: BUG REPORT: modperl(dev) make fails at "`APR_SO_TIMEOUT' undeclared"
Stas Bekman wrote: [...] Cool, I've missed that. It just looked weird. I guess they use 2*32-1 for nobody, so they can accomodate 2*32-2 users ;) s/2\*32/2**32/ of course __ Stas BekmanJAm_pH --> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: BUG REPORT: modperl(dev) make fails at "`APR_SO_TIMEOUT' undeclared"
> > BTW, why Finfo doesn't use uid/gid but user/group? because of the C data > struct names? It's probably more intuitive to rename them to be uid/gid, > since they return the ids and not names. > I don't think we have typically been renaming struct slots but rather carrying them directly over for accessors/mutators. at least I can't think of an example where we have renamed stuff. personally, I prefer it the way it is - it keeps the C and the Perl API consistent. --Geoff - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [mp2] ModPerl-Registry redirect test
On Mon, 1 Dec 2003, Stas Bekman wrote:
> [...]
>
> I'm still unhappy about whatever_url() working with fs
> paths. I guess I'm taking my words on using Unix-> back.
> At least we know that we work with paths and not urls. How
> about this:
>
> # concat a dir/file using unix path separators
> # no platform specific path cleanups are run unless the filepath is absolute
> sub t_catfile_unix {
> my $f = canonpath join "/", @_;
> return $f unless File::Spec->file_name_is_absolute($f);
> return Apache::TestConfig::WIN32 ?
> Win32::GetLongPathName($f) : $f;
> }
>
> # concat a dir/file ala catfile
> # and run platform specific path cleanups if the filepath is absolute
> sub t_catfile {
> my $f = File::Spec->catfile(@_);
> return $f unless File::Spec->file_name_is_absolute($f);
> return Apache::TestConfig::WIN32 ?
> Win32::GetLongPathName($f) : $f;
> }
>
> or may be even better:
> s/t_catfile_unix/t_catfile_apache/
> ? to denote that we catfile the apache way?
>
> I won't try to use File::Spec::Unix instead of join '/',
> because one day it may stop loading on non-Unix...
That's a good point ... However, using
sub t_catfile_apache {
my $f = canonpath join "/", @_;
return $f unless File::Spec->file_name_is_absolute($f);
return Apache::TestConfig::WIN32 ?
Win32::GetLongPathName($f) : $f;
}
doesn't quite work on Win32 :( (and probably not on Macs,
either), as canonpath flips the '/' back to the native
directory separator ('\' on Win32). What one could do is
then s{[\\:]}{/}g afterwards, but on Win32 one has to take
care of the case that the drive is specified, as
D:/whatever, and not change the ':'. The following is OK:
=
Index: Apache-Test/lib/Apache/TestUtil.pm
===
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestUtil.pm,v
retrieving revision 1.31
diff -u -r1.31 TestUtil.pm
--- Apache-Test/lib/Apache/TestUtil.pm 29 Apr 2003 08:04:04 - 1.31
+++ Apache-Test/lib/Apache/TestUtil.pm 3 Dec 2003 05:10:59 -
@@ -9,7 +9,7 @@
use Carp ();
use Config;
use File::Basename qw(dirname);
-use File::Spec::Functions qw(catfile);
+use File::Spec::Functions qw(catfile canonpath file_name_is_absolute);
use Symbol ();
use Apache::Test ();
@@ -26,7 +26,8 @@
t_client_log_error_is_expected t_client_log_warn_is_expected
);
[EMAIL PROTECTED] = qw(t_write_perl_script t_write_shell_script t_chown);
[EMAIL PROTECTED] = qw(t_write_perl_script t_write_shell_script t_chown
+ t_catfile_apache t_catfile);
%CLEAN = ();
@@ -302,6 +303,21 @@
t_debug("removing dir tree: $_");
t_rmtree($_);
}
+}
+
+sub t_catfile {
+my $f = catfile(@_);
+return $f unless file_name_is_absolute($f);
+return Apache::TestConfig::WIN32 ?
+Win32::GetLongPathName($f) : $f;
+}
+
+sub t_catfile_apache {
+my $f = canonpath join '/', @_;
+$f =~ s{[\\:](?!\\)}{/}g;
+return $f unless file_name_is_absolute($f);
+return Apache::TestConfig::WIN32 ?
+Win32::GetLongPathName($f) : $f;
}
1;
Index: ModPerl-Registry/t/basic.t
===
RCS file: /home/cvs/modperl-2.0/ModPerl-Registry/t/basic.t,v
retrieving revision 1.15
diff -u -r1.15 basic.t
--- ModPerl-Registry/t/basic.t 23 Nov 2003 21:01:50 - 1.15
+++ ModPerl-Registry/t/basic.t 3 Dec 2003 05:10:59 -
@@ -6,7 +6,7 @@
use Apache::TestRequest qw(GET GET_BODY HEAD);
use Apache::TestConfig ();
-use File::Spec::Functions qw(catfile);
+use Apache::TestUtil qw(t_catfile_apache);
my %modules = (
registry=> 'ModPerl::Registry',
@@ -19,7 +19,7 @@
plan tests => @aliases * 4 + 3;
my $vars = Apache::Test::config()->{vars};
-my $script_file = catfile $vars->{serverroot}, 'cgi-bin', 'basic.pl';
+my $script_file = t_catfile_apache($vars->{serverroot}, 'cgi-bin', 'basic.pl');
# very basic compilation/response test
for my $alias (@aliases) {
Index: ModPerl-Registry/t/redirect.t
===
RCS file: /home/cvs/modperl-2.0/ModPerl-Registry/t/redirect.t,v
retrieving revision 1.6
diff -u -r1.6 redirect.t
--- ModPerl-Registry/t/redirect.t 23 Nov 2003 21:01:50 - 1.6
+++ ModPerl-Registry/t/redirect.t 3 Dec 2003 05:10:59 -
@@ -5,7 +5,7 @@
use Apache::TestUtil;
use Apache::TestRequest qw(GET_BODY HEAD);
-use File::Spec::Functions qw(catfile);
+use Apache::TestUtil qw(t_catfile_apache);
plan tests => 4, have_lwp;
@@ -16,7 +16,7 @@
my $redirect_path = "/registry/basic.pl";
my $url = "$base_url?$redirect_path";
my $vars = Apache::Test::config()->{vars};
-my $script_file = catfile $vars->{serverroot}, 'cgi-bin', 'basic.pl';
+my $script_file = t_catfile_apache($vars->{serverroot}, 'cgi-bin', 'basic.pl');
ok t_cmp(
"ok $scri
