[jira] [Resolved] (PHOENIX-4790) Simplify check for client side delete
[ https://issues.apache.org/jira/browse/PHOENIX-4790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor resolved PHOENIX-4790. --- Resolution: Won't Fix Turns out the check can't be simplified, so I've reverted the related commits. Sorry for the noise, [~tdsilva]. > Simplify check for client side delete > - > > Key: PHOENIX-4790 > URL: https://issues.apache.org/jira/browse/PHOENIX-4790 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor >Priority: Minor > Fix For: 4.15.0, 5.1.0 > > Attachments: PHOENIX-4790.patch, PHOENIX-4790_addendum1.patch > > > We don't need to check every query plan for the existence of a where clause > to determine if we can do a client-side delete. Instead, we can simply check > if any non PK columns are projected. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (PHOENIX-4790) Simplify check for client side delete
[ https://issues.apache.org/jira/browse/PHOENIX-4790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor reopened PHOENIX-4790: --- > Simplify check for client side delete > - > > Key: PHOENIX-4790 > URL: https://issues.apache.org/jira/browse/PHOENIX-4790 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor >Priority: Minor > Fix For: 4.15.0, 5.1.0 > > Attachments: PHOENIX-4790.patch, PHOENIX-4790_addendum1.patch > > > We don't need to check every query plan for the existence of a where clause > to determine if we can do a client-side delete. Instead, we can simply check > if any non PK columns are projected. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4811) Phoenix Secondary Index isn't be used
[
https://issues.apache.org/jira/browse/PHOENIX-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542415#comment-16542415
]
张延召 commented on PHOENIX-4811:
--
I tried this,and it did,but I have a question,why can I not create this index
with (name, age) in mysql database,What is the mechanism that led me to do
this in phoenix?
> Phoenix Secondary Index isn't be used
> -
>
> Key: PHOENIX-4811
> URL: https://issues.apache.org/jira/browse/PHOENIX-4811
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.13.1
> Environment: Operating System : centos6.9 ;
> Phoenix version : 4.13.1;
> HBase version : 1.3.1;
>Reporter: 张延召
>Priority: Major
> Labels: SecondaryIndex
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> I created two indexes (not Covered Indexes):
> ^create table test(id varchar not null primary key,name varchar,age varchar
> ,sex varchar);^
> ^create local index if not exists val_test_name on test(name);^
> ^create local index if not exists val_test_age on test(age);^
> ^upsert into test(id,name,age,sex)values('myid','name','age','sex');^
> It is work to use one index:
> ^explain select name from test where name = 'name';^
> But why can't hit index when using multiple indexes？
> ^explain select name,age from test where name = 'name' and age = 'age';^
>
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4688) Add kerberos authentication to python-phoenixdb
[ https://issues.apache.org/jira/browse/PHOENIX-4688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542214#comment-16542214 ] ASF GitHub Bot commented on PHOENIX-4688: - Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/307 Ugh, I'm getting frustrated: I have MIT kerberos on my Mac, so I unblocked myself first by just forcing the minikdc config file to be made instead of the if-branch you added, Lev. The next thing, I get a failure trying to launch python from the virtualenv: ``` /Users/jelser/projects/phoenix.git/phoenix-queryserver/./src/it/bin/test_phoenixdb.sh: line 59: 66933 Illegal instruction: 4 python $PYTHON_SCRIPT $PQS_PORT ``` This was reproducible doing it by hand, so I thought maybe it was related to me using python-2.7.14 (old). So, I switched over to Python-3.6.4, reinstalled everything, and I got this. ``` Traceback (most recent call last): File "/private/var/folders/4q/q02ykc2j5l1fg8nbs_sczskhgp/T/tmp.iUMwkyIZ/lib/python3.6/site-packages/requests_kerberos/kerberos_.py", line 2, in import kerberos ImportError: dlopen(/private/var/folders/4q/q02ykc2j5l1fg8nbs_sczskhgp/T/tmp.iUMwkyIZ/lib/python3.6/site-packages/kerberos.cpython-36m-darwin.so, 2): Symbol not found: _mempcpy Referenced from: /private/var/folders/4q/q02ykc2j5l1fg8nbs_sczskhgp/T/tmp.iUMwkyIZ/lib/python3.6/site-packages/kerberos.cpython-36m-darwin.so Expected in: flat namespace in /private/var/folders/4q/q02ykc2j5l1fg8nbs_sczskhgp/T/tmp.iUMwkyIZ/lib/python3.6/site-packages/kerberos.cpython-36m-darwin.so ``` I ran into another GH issue saying that pykerberos==1.1.14 fixed it for them, but I'm not seeing a difference locally. How do you feel about requiring Docker, @pu239ppy? ;) > Add kerberos authentication to python-phoenixdb > --- > > Key: PHOENIX-4688 > URL: https://issues.apache.org/jira/browse/PHOENIX-4688 > Project: Phoenix > Issue Type: Improvement >Reporter: Lev Bronshtein >Priority: Minor > > In its current state python-phoenixdv does not support support kerberos > authentication. Using a modern python http library such as requests or > urllib it would be simple (if not trivial) to add this support. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] phoenix issue #307: PHOENIX-4688 Kerberize python phoenixdb
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/307 Ugh, I'm getting frustrated: I have MIT kerberos on my Mac, so I unblocked myself first by just forcing the minikdc config file to be made instead of the if-branch you added, Lev. The next thing, I get a failure trying to launch python from the virtualenv: ``` /Users/jelser/projects/phoenix.git/phoenix-queryserver/./src/it/bin/test_phoenixdb.sh: line 59: 66933 Illegal instruction: 4 python $PYTHON_SCRIPT $PQS_PORT ``` This was reproducible doing it by hand, so I thought maybe it was related to me using python-2.7.14 (old). So, I switched over to Python-3.6.4, reinstalled everything, and I got this. ``` Traceback (most recent call last): File "/private/var/folders/4q/q02ykc2j5l1fg8nbs_sczskhgp/T/tmp.iUMwkyIZ/lib/python3.6/site-packages/requests_kerberos/kerberos_.py", line 2, in import kerberos ImportError: dlopen(/private/var/folders/4q/q02ykc2j5l1fg8nbs_sczskhgp/T/tmp.iUMwkyIZ/lib/python3.6/site-packages/kerberos.cpython-36m-darwin.so, 2): Symbol not found: _mempcpy Referenced from: /private/var/folders/4q/q02ykc2j5l1fg8nbs_sczskhgp/T/tmp.iUMwkyIZ/lib/python3.6/site-packages/kerberos.cpython-36m-darwin.so Expected in: flat namespace in /private/var/folders/4q/q02ykc2j5l1fg8nbs_sczskhgp/T/tmp.iUMwkyIZ/lib/python3.6/site-packages/kerberos.cpython-36m-darwin.so ``` I ran into another GH issue saying that pykerberos==1.1.14 fixed it for them, but I'm not seeing a difference locally. How do you feel about requiring Docker, @pu239ppy? ;) ---
Re: [DISCUSS] reduce notifications to phoenix-dev list
I think INFRA keeps these locked down. Just requires an INFRA JIRA issue, I'd guess asking them to change it. On 7/12/18 1:53 PM, Thomas D'Silva wrote: Josh, Do you know how to edit the notification scheme here https://issues.apache.org/jira/plugins/servlet/project-config/PHOENIX/notifications ? I don't see an edit button. Thanks, Thomas On Thu, Jul 12, 2018 at 7:09 AM, James Taylor wrote: +1 On Thu, Jul 12, 2018 at 5:51 AM Josh Elser wrote: Fine by me. On 7/11/18 9:50 PM, Thomas D'Silva wrote: I think we should reduce the number of notifications that are sent to the phoenix-dev list. The notification scheme we use is located here : https://issues.apache.org/ jira/plugins/servlet/project-config/PHOENIX/notifications Maybe we don't need to notify the dev list when an issue is updated, or a comment is created/edited/deleted. People watching a particular issue would still see all the changes. This would be similar to how other projects like HBase and Calcite operate. Thanks, Thomas
Re: [DISCUSS] 4.15 or move to 5.0?
With my work hat on I would request the 4.x line continue for as long as HBase 1.x does. Probably it would be best if eventually there is only one active 4.x branch that follows the HBase 1.x minor release progression. So it would target 1.4 today, then 1.5, then 1.6 (and I'm not sure there will be more 1.x after that but who can say, releasing is an emergent community process) On Thu, Jul 12, 2018 at 7:44 AM Josh Elser wrote: > I remember a passing comment, but I forget the decision: what's up for > the 4.x release line post 4.14 and 5.0? > > Was 5.x going to move to master and then make 4.x branches for any more > 4.x releases? > > Related question I think I know the answer to: how much longer are we > going to continue work on the 4.x line? (as long as there are related > HBase releases, I imagine) > > - Josh > -- Best regards, Andrew Words like orphans lost among the crosstalk, meaning torn from truth's decrepit hands - A23, Crosstalk
[jira] [Commented] (PHOENIX-4750) Resolve server customizers and provide them to Avatica
[
https://issues.apache.org/jira/browse/PHOENIX-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542076#comment-16542076
]
Josh Elser commented on PHOENIX-4750:
-
{code:java}
+ public static final String QUERY_SERVER_CUSTOMIZERS_ENABLED =
"phoenix.queryserver.customizers.enabled";{code}
Let's get a companion to this over in QueryServicesOptions.java (the default
value)
Looks straightforward otherwise (nice and simple due to your nice work in
Avatica!). Could you write an IT with a contrived ServerCustomizer that you
could verify? Maybe enable HTTP Basic auth, only for a given user? All of the
options defined over at
[https://calcite.apache.org/avatica/docs/client_reference.html] should work
directly with the PQS client URL (e.g.
{{jdbc:phoenix:thin:url=http://localhost:8765;authentication=BASIC;avatica_user=foo;avatica_password=bar}})
> Resolve server customizers and provide them to Avatica
> --
>
> Key: PHOENIX-4750
> URL: https://issues.apache.org/jira/browse/PHOENIX-4750
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Alex Araujo
>Assignee: Alex Araujo
>Priority: Major
> Fix For: 4.15.0
>
> Attachments: PHOENIX-4750.patch
>
>
> CALCITE-2284 allows finer grained customization of the underlying Avatica
> HttpServer.
> Resolve server customizers on the PQS classpath and provide them to the
> HttpServer builder.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4750) Resolve server customizers and provide them to Avatica
[ https://issues.apache.org/jira/browse/PHOENIX-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542069#comment-16542069 ] Alex Araujo commented on PHOENIX-4750: -- It needs a review. [~elserj] have any spare cycles? > Resolve server customizers and provide them to Avatica > -- > > Key: PHOENIX-4750 > URL: https://issues.apache.org/jira/browse/PHOENIX-4750 > Project: Phoenix > Issue Type: Improvement >Reporter: Alex Araujo >Assignee: Alex Araujo >Priority: Major > Fix For: 4.15.0 > > Attachments: PHOENIX-4750.patch > > > CALCITE-2284 allows finer grained customization of the underlying Avatica > HttpServer. > Resolve server customizers on the PQS classpath and provide them to the > HttpServer builder. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4750) Resolve server customizers and provide them to Avatica
[ https://issues.apache.org/jira/browse/PHOENIX-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542055#comment-16542055 ] Karan Mehta commented on PHOENIX-4750: -- [~elserj] and [~alexaraujo] Given that PHOENIX-4805 is done yet and [~mujtabachohan] helped me bump up the Phoenix Precommit build JDK version to 1.8 (instead of 1.7), shall we check this patch in? Is this final patch or do we have any other changes? > Resolve server customizers and provide them to Avatica > -- > > Key: PHOENIX-4750 > URL: https://issues.apache.org/jira/browse/PHOENIX-4750 > Project: Phoenix > Issue Type: Improvement >Reporter: Alex Araujo >Assignee: Alex Araujo >Priority: Major > Fix For: 4.15.0 > > Attachments: PHOENIX-4750.patch > > > CALCITE-2284 allows finer grained customization of the underlying Avatica > HttpServer. > Resolve server customizers on the PQS classpath and provide them to the > HttpServer builder. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4790) Simplify check for client side delete
[ https://issues.apache.org/jira/browse/PHOENIX-4790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542035#comment-16542035 ] Thomas D'Silva commented on PHOENIX-4790: - James, These three tests are still failing (https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/161/) Test Result (3 failures / +3) org.apache.phoenix.end2end.DeleteIT.testDeleteByRowAndFilterAutoCommit org.apache.phoenix.end2end.DeleteIT.testDeleteByRowAndFilterNoAutoCommit org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testBytesRowsForPointDelete > Simplify check for client side delete > - > > Key: PHOENIX-4790 > URL: https://issues.apache.org/jira/browse/PHOENIX-4790 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor >Priority: Minor > Fix For: 4.15.0, 5.1.0 > > Attachments: PHOENIX-4790.patch, PHOENIX-4790_addendum1.patch > > > We don't need to check every query plan for the existence of a where clause > to determine if we can do a client-side delete. Instead, we can simply check > if any non PK columns are projected. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (PHOENIX-4812) Issue while deploying on JBOSS
[
https://issues.apache.org/jira/browse/PHOENIX-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Geoffrey Jacoby resolved PHOENIX-4812.
--
Resolution: Invalid
> Issue while deploying on JBOSS
> --
>
> Key: PHOENIX-4812
> URL: https://issues.apache.org/jira/browse/PHOENIX-4812
> Project: Phoenix
> Issue Type: Bug
>Reporter: Arjun
>Priority: Critical
>
> We are{color:#33} using the class:
> *org.apache.phoenix.jdbc.PhoenixDriver* to *connect to Phoenix* and currently
> using the jar (*phoenix-4.7.0-HBase-1.0-client.jar*) & while using this jar
> in our final artifact and deploying on JBOSS, seeing the following
> exception:{color}
> {color:#33}aga@{color}{color:#33}$ cat
> vzw-hbase-djr-client-1.0-SNAPSHOT.war.failed
> *"{*
> *\"JBAS014671: Failed services\" =>
> {\"jboss.deployment.unit.\\\"vzw-hbase-djr-client-1.0-SNAPSHOT.war\\\".POST_MODULE\"
> => \"org.jboss.msc.service.StartException in service
> jboss.deployment.unit.\\\"vzw-hbase-djr-client-1.0-SNAPSHOT.war\\\".POST_MODULE:
> JBAS018733: Failed to process phase POST_MODULE of deployment*
> {color}[\\\"vzw-hbase-djr-client-1.0-SNAPSHOT.war\\\|file:///%22vzw-hbase-djr-client-1.0-SNAPSHOT.war/]*{color:#33}"{color}*{color:#33}
> *Caused by:
> org.jboss.as.server.deployment.DeploymentUnitProcessingException: JBAS011232:
> Only one JAX-RS Application Class allowed.
> com.sun.jersey.server.impl.application.DeferredResourceConfig
> com.sun.jersey.api.core.WebAppResourceConfig
> com.sun.jersey.api.core.DefaultResourceConfig
> com.sun.jersey.api.core.ApplicationAdapter
> com.sun.jersey.api.core.PackagesResourceConfig
> com.sun.jersey.api.core.ClasspathResourceConfig
> com.sun.jersey.api.core.ClassNamesResourceConfig
> com.sun.jersey.api.core.ScanningResourceConfig
> com.sun.jersey.api.core.ResourceConfig\"},*
> *\"JBAS014771: Services with missing/unavailable dependencies\" =>
> [\"jboss.naming.context.java.jboss.udm-plugin-meta.\\\"vzw-hbase-djr-client-1.0-SNAPSHOT.war\\\"
> is missing*
> *[jboss.deployment.unit.\\\"vzw-hbase-djr-client-1.0-SNAPSHOT.war\\\".beanmanager]**\"]*{color}
> {color:#33}W/o this jar{color}{color:#33} in the{color}
> {color:#33}war{color}{color:#33} file we get ClassNotFoundException
> for org.apache.phoenix.jdbc.PhoenixDriver.{color}
> *Any inputs on this will help. It is ok if we deploy this jar outside of WAR
> file.*
> *Also, ok to consume a lighter jar which can be used to connect to Phoenix
> from Java.*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-3534) Support multi region SYSTEM.CATALOG table
[ https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542032#comment-16542032 ] ASF GitHub Bot commented on PHOENIX-3534: - Github user twdsilva commented on the issue: https://github.com/apache/phoenix/pull/303 @JamesRTaylor Thanks for the feedback, I have updated the PR. I will get this committed shortly. > Support multi region SYSTEM.CATALOG table > - > > Key: PHOENIX-3534 > URL: https://issues.apache.org/jira/browse/PHOENIX-3534 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Assignee: Thomas D'Silva >Priority: Major > Fix For: 5.0.0, 4.15.0 > > Attachments: PHOENIX-3534-v2.patch, PHOENIX-3534-v3.patch, > PHOENIX-3534.patch > > > Currently Phoenix requires that the SYSTEM.CATALOG table is single region > based on the server-side row locks being held for operations that impact a > table and all of it's views. For example, adding/removing a column from a > base table pushes this change to all views. > As an alternative to making the SYSTEM.CATALOG transactional (PHOENIX-2431), > when a new table is created we can do a lazy cleanup of any rows that may be > left over from a failed DDL call (kudos to [~lhofhansl] for coming up with > this idea). To implement this efficiently, we'd need to also do PHOENIX-2051 > so that we can efficiently find derived views. > The implementation would rely on an optimistic concurrency model based on > checking our sequence numbers for each table/view before/after updating. Each > table/view row would be individually locked for their change (metadata for a > view or table cannot span regions due to our split policy), with the sequence > number being incremented under lock and then returned to the client. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] phoenix issue #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG table
Github user twdsilva commented on the issue: https://github.com/apache/phoenix/pull/303 @JamesRTaylor Thanks for the feedback, I have updated the PR. I will get this committed shortly. ---
Re: [DISCUSS] reduce notifications to phoenix-dev list
Josh, Do you know how to edit the notification scheme here https://issues.apache.org/jira/plugins/servlet/project-config/PHOENIX/notifications ? I don't see an edit button. Thanks, Thomas On Thu, Jul 12, 2018 at 7:09 AM, James Taylor wrote: > +1 > > On Thu, Jul 12, 2018 at 5:51 AM Josh Elser wrote: > > > Fine by me. > > > > On 7/11/18 9:50 PM, Thomas D'Silva wrote: > > > I think we should reduce the number of notifications that are sent to > the > > > phoenix-dev list. > > > The notification scheme we use is located here : > > https://issues.apache.org/ > > > jira/plugins/servlet/project-config/PHOENIX/notifications > > > > > > Maybe we don't need to notify the dev list when an issue is updated, > or a > > > comment is created/edited/deleted. People watching a particular issue > > would > > > still see all the changes. > > > This would be similar to how other projects like HBase and Calcite > > operate. > > > > > > Thanks, > > > Thomas > > > > > >
Re: pre-commit Jenkins build isn't running - is this related to mast moved to HBase 1.4?
Awesome, Thomas! Thanks for following up on this.
On Thu, Jul 12, 2018 at 10:01 AM Thomas D'Silva
wrote:
> I found a similar issue posted here
> https://issues.apache.org/jira/browse/INFRA-16349.
> I was able to get the Precommit build to post to jira by changing the
> jiracli cmd location to /home/jenkins/tools/jiracli/latest/jira.sh
> If you submit a patch the Precommit build should post the results to the
> JIRA now.
>
>
> On Thu, Mar 8, 2018 at 4:09 PM, Thomas D'Silva
> wrote:
>
> > I think the exception is because we are using JDK7 according to this
> issue
> > https://issues.apache.org/jira/browse/HIVE-18461.
> > I tried switching the precommit build to use JDK8 but it then fails on a
> > different error:
> >
> > This message is automatically generated.' --issue PHOENIX-4576
> > Unable to log in to server:
> https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user:
> hadoopqa.
> > Cause: (404)404
> > + /home/jenkins/tools/jiracli/latest/jira -s
> https://issues.apache.org/jira -a logout -u hadoopqa -p 4hadoopqa
> > Unable to log in to server:
> https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user:
> hadoopqa.
> > Cause: (404)404
> > + cleanupAndExit 130
> >
> >
> >
> > On Fri, Mar 2, 2018 at 12:37 PM, Thomas D'Silva
> > wrote:
> >
> >> The precommit build is running but not posting the results to the jira.
> >> It looks like hadoopqa is unable to login.
> >> Does anyone know how to fix this?
> >>
> >> export USER=hudson
> >>
> >> + USER=hudson
> >>
> >> + /home/jenkins/tools/jiracli/latest/jira -s
> >> https://issues.apache.org/jira -a addcomment -u hadoopqa -p 4hadoopqa
> >> --comment '{color:red}-1 overall{color}. Here are the results of
> testing
> >> the latest attachment
> >>
> >> http://issues.apache.org/jira/secure/attachment/12912665/PHO
> >> ENIX-4633-v2.patch
> >>
> >> against master branch at commit 1a226ed3e6ac4a56658acbac4da0d5
> >> 18af343ee2.
> >>
> >> ATTACHMENT ID: 12912665
> >>
> >>
> >>
> >> This message is automatically generated.' --issue PHOENIX-4633
> >>
> >> Unable to log in to server: https://issues.apache.org/jira
> >> /rpc/soap/jirasoapservice-v2 with user: hadoopqa.
> >>
> >> Cause: ; nested exception is:
> >>
> >> javax.net.ssl.SSLException: Received fatal alert: protocol_version
> >>
> >> + /home/jenkins/tools/jiracli/latest/jira -s
> >> https://issues.apache.org/jira -a logout -u hadoopqa -p 4hadoopqa
> >>
> >> Unable to log in to server: https://issues.apache.org/jira
> >> /rpc/soap/jirasoapservice-v2 with user: hadoopqa.
> >>
> >> Cause: ; nested exception is:
> >>
> >> javax.net.ssl.SSLException: Received fatal alert: protocol_version
> >>
> >> + cleanupAndExit 129
> >>
> >> + local result=129
> >>
> >> + [[ true == \t\r\u\e ]]
> >>
> >> + '[' -e
> /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/patchprocess
> >> ']'
> >>
> >> + mv
> /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/patchprocess
> >> /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build
> >>
> >> mv:
> '/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/patchprocess'
> >> and
> '/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/patchprocess'
> >> are the same file
> >>
> >> + echo ''
> >>
> >>
> >> On Thu, Jan 18, 2018 at 4:16 PM, James Taylor
> >> wrote:
> >>
> >>> The pre-commit Jenkins job doesn't appear to be running. Do you think
> >>> this
> >>> might be related to moving master to HBase 1.4? Another potential
> culprit
> >>> might be PHOENIX-4538.
> >>>
> >>> WDYT, Lars?
> >>>
> >>> Thanks,
> >>> James
> >>>
> >>
> >>
> >
>
[GitHub] phoenix pull request #308: Client-side hash aggregation
Github user geraldss commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/308#discussion_r202112790
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java
---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.iterate;
+
+import static org.apache.phoenix.query.QueryConstants.AGG_TIMESTAMP;
+import static org.apache.phoenix.query.QueryConstants.SINGLE_COLUMN;
+import static org.apache.phoenix.query.QueryConstants.SINGLE_COLUMN_FAMILY;
+
+import java.io.IOException;
+import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Map;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.KeyValue;
+import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
+import org.apache.phoenix.expression.Expression;
+import org.apache.phoenix.expression.aggregator.Aggregator;
+import org.apache.phoenix.expression.aggregator.Aggregators;
+import org.apache.phoenix.schema.tuple.MultiKeyValueTuple;
+import org.apache.phoenix.schema.tuple.Tuple;
+import org.apache.phoenix.util.KeyValueUtil;
+import org.apache.phoenix.util.TupleUtil;
+
+/**
+ *
+ * This class implements client-side hash aggregation in memory.
+ * Issue https://issues.apache.org/jira/browse/PHOENIX-4751.
+ *
+ */
+public class ClientHashAggregatingResultIterator
+implements AggregatingResultIterator {
+
+private static final int HASH_AGG_INIT_SIZE = 64*1024;
+private static final byte[] UNITIALIZED_KEY_BUFFER = new byte[0];
+private final ResultIterator resultIterator;
+private final Aggregators aggregators;
+private final List groupByExpressions;
+private HashMap hash;
+private List keyList;
+private Iterator keyIterator;
+
+public ClientHashAggregatingResultIterator(ResultIterator
resultIterator, Aggregators aggregators, List groupByExpressions) {
+if (resultIterator == null) throw new NullPointerException();
+if (aggregators == null) throw new NullPointerException();
+if (groupByExpressions == null) throw new NullPointerException();
+this.resultIterator = resultIterator;
+this.aggregators = aggregators;
+this.groupByExpressions = groupByExpressions;
+}
+
+@Override
+public Tuple next() throws SQLException {
+if (keyIterator == null) {
+populateHash();
+sortKeys();
+keyIterator = keyList.iterator();
+}
+
+if (!keyIterator.hasNext()) {
+return null;
+}
+
+ImmutableBytesWritable key = keyIterator.next();
+Aggregator[] rowAggregators = hash.get(key);
+byte[] value = aggregators.toBytes(rowAggregators);
+Tuple tuple = wrapKeyValueAsResult(KeyValueUtil.newKeyValue(key,
SINGLE_COLUMN_FAMILY, SINGLE_COLUMN, AGG_TIMESTAMP, value, 0, value.length));
+return tuple;
+}
+
+@Override
+public void close() throws SQLException {
+keyIterator = null;
+keyList = null;
+hash = null;
+resultIterator.close();
+}
+
+@Override
+public Aggregator[] aggregate(Tuple result) {
+Aggregator[] rowAggregators = aggregators.getAggregators();
+aggregators.reset(rowAggregators);
+aggregators.aggregate(rowAggregators, result);
+return rowAggregators;
+}
+
+@Override
+public void explain(List planSteps) {
+resultIterator.explain(planSteps);
+}
+
+@Override
+public String toString() {
+return "ClientHashAggregatingResultIterator [resultIterator="
++
[GitHub] phoenix issue #307: PHOENIX-4688 Kerberize python phoenixdb
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/307 > If you are still unable to get .deactivate to work, remove it from the shell script for now and we can revisit it. Again I am being overly pedantic here, but a the shell exits, we really do not need to clean up any environment. Ok. I'm looking at this again today. Thanks for the feedback so far. The test/code looks good to me. I think we just need to update documentation to explain what we're doing (maybe a README.md in `python/`?) ---
Re: pre-commit Jenkins build isn't running - is this related to mast moved to HBase 1.4?
I found a similar issue posted here
https://issues.apache.org/jira/browse/INFRA-16349.
I was able to get the Precommit build to post to jira by changing the
jiracli cmd location to /home/jenkins/tools/jiracli/latest/jira.sh
If you submit a patch the Precommit build should post the results to the
JIRA now.
On Thu, Mar 8, 2018 at 4:09 PM, Thomas D'Silva
wrote:
> I think the exception is because we are using JDK7 according to this issue
> https://issues.apache.org/jira/browse/HIVE-18461.
> I tried switching the precommit build to use JDK8 but it then fails on a
> different error:
>
> This message is automatically generated.' --issue PHOENIX-4576
> Unable to log in to server:
> https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user:
> hadoopqa.
> Cause: (404)404
> + /home/jenkins/tools/jiracli/latest/jira -s https://issues.apache.org/jira
> -a logout -u hadoopqa -p 4hadoopqa
> Unable to log in to server:
> https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user:
> hadoopqa.
> Cause: (404)404
> + cleanupAndExit 130
>
>
>
> On Fri, Mar 2, 2018 at 12:37 PM, Thomas D'Silva
> wrote:
>
>> The precommit build is running but not posting the results to the jira.
>> It looks like hadoopqa is unable to login.
>> Does anyone know how to fix this?
>>
>> export USER=hudson
>>
>> + USER=hudson
>>
>> + /home/jenkins/tools/jiracli/latest/jira -s
>> https://issues.apache.org/jira -a addcomment -u hadoopqa -p 4hadoopqa
>> --comment '{color:red}-1 overall{color}. Here are the results of testing
>> the latest attachment
>>
>> http://issues.apache.org/jira/secure/attachment/12912665/PHO
>> ENIX-4633-v2.patch
>>
>> against master branch at commit 1a226ed3e6ac4a56658acbac4da0d5
>> 18af343ee2.
>>
>> ATTACHMENT ID: 12912665
>>
>>
>>
>> This message is automatically generated.' --issue PHOENIX-4633
>>
>> Unable to log in to server: https://issues.apache.org/jira
>> /rpc/soap/jirasoapservice-v2 with user: hadoopqa.
>>
>> Cause: ; nested exception is:
>>
>> javax.net.ssl.SSLException: Received fatal alert: protocol_version
>>
>> + /home/jenkins/tools/jiracli/latest/jira -s
>> https://issues.apache.org/jira -a logout -u hadoopqa -p 4hadoopqa
>>
>> Unable to log in to server: https://issues.apache.org/jira
>> /rpc/soap/jirasoapservice-v2 with user: hadoopqa.
>>
>> Cause: ; nested exception is:
>>
>> javax.net.ssl.SSLException: Received fatal alert: protocol_version
>>
>> + cleanupAndExit 129
>>
>> + local result=129
>>
>> + [[ true == \t\r\u\e ]]
>>
>> + '[' -e
>> /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/patchprocess
>> ']'
>>
>> + mv
>> /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/patchprocess
>> /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build
>>
>> mv:
>> '/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/patchprocess'
>> and
>> '/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/patchprocess'
>> are the same file
>>
>> + echo ''
>>
>>
>> On Thu, Jan 18, 2018 at 4:16 PM, James Taylor
>> wrote:
>>
>>> The pre-commit Jenkins job doesn't appear to be running. Do you think
>>> this
>>> might be related to moving master to HBase 1.4? Another potential culprit
>>> might be PHOENIX-4538.
>>>
>>> WDYT, Lars?
>>>
>>> Thanks,
>>> James
>>>
>>
>>
>
[jira] [Commented] (PHOENIX-4688) Add kerberos authentication to python-phoenixdb
[
https://issues.apache.org/jira/browse/PHOENIX-4688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541951#comment-16541951
]
ASF GitHub Bot commented on PHOENIX-4688:
-
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/307#discussion_r202108057
--- Diff: phoenix-queryserver/src/it/bin/test_phoenixdb.sh ---
@@ -0,0 +1,59 @@
+#/usr/bin/env bash
+
+set -u
+set -x
+set -e
+
+function cleanup {
+set +e
+set +u
+kdestroy
+pushd ${PY_ENV_PATH}/bin
+. deactivate ""
+popd
+rm -rf $PY_ENV_PATH
+}
+
+trap cleanup EXIT
+
+echo "LAUNCHING SCRIPT"
+
+LOCAL_PY=$1
+PRINC=$2
+KEYTAB_LOC=$3
+KRB5_CFG_FILE=$4
+PQS_PORT=$5
+PYTHON_SCRIPT=$6
+
+PY_ENV_PATH=$( mktemp -d )
+
+conda create -y -p $PY_ENV_PATH || virtualenv $PY_ENV_PATH
+
+pushd ${PY_ENV_PATH}/bin
+
+# conda activate does stuff with unbound variables :(
+set +u
+. activate ""
+
+popd
+
+set -u
+echo "INSTALLING COMPONENTS"
+pip install -e file:///${LOCAL_PY}/requests-kerberos
+pip install -e file:///${LOCAL_PY}/phoenixdb-module
+
+export KRB5_CONFIG=$KRB5_CFG_FILE
+cat $KRB5_CONFIG
+export KRB5_TRACE=/dev/stdout
+
+#echo "RUNNING KINIT"
+kinit -kt $KEYTAB_LOC $PRINC
--- End diff --
> I just tried on the command line and MAC OS (Heimdal) kinit does not
require a directory
Yeah, convention is to use `${tmpdir}/krb5cc_$(current-user uid)`.
> pass the when executing python or just continue running in the same
shell, which is why I stopped attempts to make ny further reductions to the
shell script
Oh right, I forgot they would bash the environment. Let's just let this be
for now. Will be easier to come back to it later.
> Add kerberos authentication to python-phoenixdb
> ---
>
> Key: PHOENIX-4688
> URL: https://issues.apache.org/jira/browse/PHOENIX-4688
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Lev Bronshtein
>Priority: Minor
>
> In its current state python-phoenixdv does not support support kerberos
> authentication. Using a modern python http library such as requests or
> urllib it would be simple (if not trivial) to add this support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4688) Add kerberos authentication to python-phoenixdb
[
https://issues.apache.org/jira/browse/PHOENIX-4688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541939#comment-16541939
]
ASF GitHub Bot commented on PHOENIX-4688:
-
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/307#discussion_r202106445
--- Diff: phoenix-queryserver/src/it/bin/test_phoenixdb.sh ---
@@ -0,0 +1,59 @@
+#/usr/bin/env bash
+
+set -u
+set -x
+set -e
+
+function cleanup {
+set +e
+set +u
+kdestroy
--- End diff --
Ok, cool. I didn't think kdestroy was doing more than just cleaning up
those token :)
> Add kerberos authentication to python-phoenixdb
> ---
>
> Key: PHOENIX-4688
> URL: https://issues.apache.org/jira/browse/PHOENIX-4688
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Lev Bronshtein
>Priority: Minor
>
> In its current state python-phoenixdv does not support support kerberos
> authentication. Using a modern python http library such as requests or
> urllib it would be simple (if not trivial) to add this support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] phoenix pull request #307: PHOENIX-4688 Kerberize python phoenixdb
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/307#discussion_r202106445
--- Diff: phoenix-queryserver/src/it/bin/test_phoenixdb.sh ---
@@ -0,0 +1,59 @@
+#/usr/bin/env bash
+
+set -u
+set -x
+set -e
+
+function cleanup {
+set +e
+set +u
+kdestroy
--- End diff --
Ok, cool. I didn't think kdestroy was doing more than just cleaning up
those token :)
---
[jira] [Commented] (PHOENIX-4805) Move Avatica version to 1.12 for PQS
[ https://issues.apache.org/jira/browse/PHOENIX-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541925#comment-16541925 ] ASF GitHub Bot commented on PHOENIX-4805: - Github user asfgit closed the pull request at: https://github.com/apache/phoenix/pull/310 > Move Avatica version to 1.12 for PQS > > > Key: PHOENIX-4805 > URL: https://issues.apache.org/jira/browse/PHOENIX-4805 > Project: Phoenix > Issue Type: Improvement >Reporter: Karan Mehta >Assignee: Karan Mehta >Priority: Major > Attachments: PHOENIX-4805.001.patch > > > CALCITE-2330 is now resolved. We can use the new version for supporting new > features such as MTLS authentication and server customization in PQS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] phoenix pull request #310: PHOENIX-4805 Move Avatica version to 1.12 for PQS
Github user asfgit closed the pull request at: https://github.com/apache/phoenix/pull/310 ---
[jira] [Commented] (PHOENIX-4805) Move Avatica version to 1.12 for PQS
[ https://issues.apache.org/jira/browse/PHOENIX-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541897#comment-16541897 ] ASF GitHub Bot commented on PHOENIX-4805: - GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/310 PHOENIX-4805 Move Avatica version to 1.12 for PQS You can merge this pull request into a Git repository by running: $ git pull https://github.com/karanmehta93/phoenix master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/phoenix/pull/310.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #310 commit da2743027582de3f4b6001be8ac1eadf4f008174 Author: Karan Mehta Date: 2018-07-06T20:35:52Z PHOENIX-4805 Move Avatica version to 1.12 for PQS > Move Avatica version to 1.12 for PQS > > > Key: PHOENIX-4805 > URL: https://issues.apache.org/jira/browse/PHOENIX-4805 > Project: Phoenix > Issue Type: Improvement >Reporter: Karan Mehta >Assignee: Karan Mehta >Priority: Major > Attachments: PHOENIX-4805.001.patch > > > CALCITE-2330 is now resolved. We can use the new version for supporting new > features such as MTLS authentication and server customization in PQS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] phoenix pull request #310: PHOENIX-4805 Move Avatica version to 1.12 for PQS
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/310 PHOENIX-4805 Move Avatica version to 1.12 for PQS You can merge this pull request into a Git repository by running: $ git pull https://github.com/karanmehta93/phoenix master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/phoenix/pull/310.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #310 commit da2743027582de3f4b6001be8ac1eadf4f008174 Author: Karan Mehta Date: 2018-07-06T20:35:52Z PHOENIX-4805 Move Avatica version to 1.12 for PQS ---
[jira] [Commented] (PHOENIX-4790) Simplify check for client side delete
[ https://issues.apache.org/jira/browse/PHOENIX-4790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541821#comment-16541821 ] Thomas D'Silva commented on PHOENIX-4790: - +1 > Simplify check for client side delete > - > > Key: PHOENIX-4790 > URL: https://issues.apache.org/jira/browse/PHOENIX-4790 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor >Priority: Minor > Fix For: 4.15.0, 5.1.0 > > Attachments: PHOENIX-4790.patch, PHOENIX-4790_addendum1.patch > > > We don't need to check every query plan for the existence of a where clause > to determine if we can do a client-side delete. Instead, we can simply check > if any non PK columns are projected. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[DISCUSS] 4.15 or move to 5.0?
I remember a passing comment, but I forget the decision: what's up for the 4.x release line post 4.14 and 5.0? Was 5.x going to move to master and then make 4.x branches for any more 4.x releases? Related question I think I know the answer to: how much longer are we going to continue work on the 4.x line? (as long as there are related HBase releases, I imagine) - Josh
[jira] [Commented] (PHOENIX-4805) Move Avatica version to 1.12 for PQS
[
https://issues.apache.org/jira/browse/PHOENIX-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541747#comment-16541747
]
Josh Elser commented on PHOENIX-4805:
-
{quote}any thing else over here?
{quote}
Nope. Looks good! Ship it :)
> Move Avatica version to 1.12 for PQS
>
>
> Key: PHOENIX-4805
> URL: https://issues.apache.org/jira/browse/PHOENIX-4805
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Karan Mehta
>Assignee: Karan Mehta
>Priority: Major
> Attachments: PHOENIX-4805.001.patch
>
>
> CALCITE-2330 is now resolved. We can use the new version for supporting new
> features such as MTLS authentication and server customization in PQS.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [DISCUSS] reduce notifications to phoenix-dev list
+1 On Thu, Jul 12, 2018 at 5:51 AM Josh Elser wrote: > Fine by me. > > On 7/11/18 9:50 PM, Thomas D'Silva wrote: > > I think we should reduce the number of notifications that are sent to the > > phoenix-dev list. > > The notification scheme we use is located here : > https://issues.apache.org/ > > jira/plugins/servlet/project-config/PHOENIX/notifications > > > > Maybe we don't need to notify the dev list when an issue is updated, or a > > comment is created/edited/deleted. People watching a particular issue > would > > still see all the changes. > > This would be similar to how other projects like HBase and Calcite > operate. > > > > Thanks, > > Thomas > > >
[GitHub] phoenix pull request #308: Client-side hash aggregation
Github user solzy commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/308#discussion_r202024941
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java
---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.iterate;
+
+import static org.apache.phoenix.query.QueryConstants.AGG_TIMESTAMP;
+import static org.apache.phoenix.query.QueryConstants.SINGLE_COLUMN;
+import static org.apache.phoenix.query.QueryConstants.SINGLE_COLUMN_FAMILY;
+
+import java.io.IOException;
+import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Map;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.KeyValue;
+import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
+import org.apache.phoenix.expression.Expression;
+import org.apache.phoenix.expression.aggregator.Aggregator;
+import org.apache.phoenix.expression.aggregator.Aggregators;
+import org.apache.phoenix.schema.tuple.MultiKeyValueTuple;
+import org.apache.phoenix.schema.tuple.Tuple;
+import org.apache.phoenix.util.KeyValueUtil;
+import org.apache.phoenix.util.TupleUtil;
+
+/**
+ *
+ * This class implements client-side hash aggregation in memory.
+ * Issue https://issues.apache.org/jira/browse/PHOENIX-4751.
+ *
+ */
+public class ClientHashAggregatingResultIterator
+implements AggregatingResultIterator {
+
+private static final int HASH_AGG_INIT_SIZE = 64*1024;
+private static final byte[] UNITIALIZED_KEY_BUFFER = new byte[0];
+private final ResultIterator resultIterator;
+private final Aggregators aggregators;
+private final List groupByExpressions;
+private HashMap hash;
+private List keyList;
+private Iterator keyIterator;
+
+public ClientHashAggregatingResultIterator(ResultIterator
resultIterator, Aggregators aggregators, List groupByExpressions) {
+if (resultIterator == null) throw new NullPointerException();
+if (aggregators == null) throw new NullPointerException();
+if (groupByExpressions == null) throw new NullPointerException();
+this.resultIterator = resultIterator;
+this.aggregators = aggregators;
+this.groupByExpressions = groupByExpressions;
+}
+
+@Override
+public Tuple next() throws SQLException {
+if (keyIterator == null) {
+populateHash();
+sortKeys();
+keyIterator = keyList.iterator();
+}
+
+if (!keyIterator.hasNext()) {
+return null;
+}
+
+ImmutableBytesWritable key = keyIterator.next();
+Aggregator[] rowAggregators = hash.get(key);
+byte[] value = aggregators.toBytes(rowAggregators);
+Tuple tuple = wrapKeyValueAsResult(KeyValueUtil.newKeyValue(key,
SINGLE_COLUMN_FAMILY, SINGLE_COLUMN, AGG_TIMESTAMP, value, 0, value.length));
+return tuple;
+}
+
+@Override
+public void close() throws SQLException {
+keyIterator = null;
+keyList = null;
+hash = null;
+resultIterator.close();
+}
+
+@Override
+public Aggregator[] aggregate(Tuple result) {
+Aggregator[] rowAggregators = aggregators.getAggregators();
+aggregators.reset(rowAggregators);
+aggregators.aggregate(rowAggregators, result);
+return rowAggregators;
+}
+
+@Override
+public void explain(List planSteps) {
+resultIterator.explain(planSteps);
+}
+
+@Override
+public String toString() {
+return "ClientHashAggregatingResultIterator [resultIterator="
++
Re: [DISCUSS] reduce notifications to phoenix-dev list
Fine by me. On 7/11/18 9:50 PM, Thomas D'Silva wrote: I think we should reduce the number of notifications that are sent to the phoenix-dev list. The notification scheme we use is located here : https://issues.apache.org/ jira/plugins/servlet/project-config/PHOENIX/notifications Maybe we don't need to notify the dev list when an issue is updated, or a comment is created/edited/deleted. People watching a particular issue would still see all the changes. This would be similar to how other projects like HBase and Calcite operate. Thanks, Thomas
FW: Issue while deploying on JBOSS
Hello,
We are using the class: org.apache.phoenix.jdbc.PhoenixDriver to connect to
Phoenix and currently using the jar (phoenix-4.7.0-HBase-1.0-client.jar) &
while using this jar in our final artifact and deploying on JBOSS, seeing the
following exception:
aga@$ cat vzw-hbase-djr-client-1.0-SNAPSHOT.war.failed
"{
\"JBAS014671: Failed services\" =>
{\"jboss.deployment.unit.\\\"vzw-hbase-djr-client-1.0-SNAPSHOT.war\\\".POST_MODULE\"
=> \"org.jboss.msc.service.StartException in service
jboss.deployment.unit.\\\"vzw-hbase-djr-client-1.0-SNAPSHOT.war\\\".POST_MODULE:
JBAS018733: Failed to process phase POST_MODULE of deployment
\\\"vzw-hbase-djr-client-1.0-SNAPSHOT.war\\\"
Caused by:
org.jboss.as.server.deployment.DeploymentUnitProcessingException: JBAS011232:
Only one JAX-RS Application Class allowed.
com.sun.jersey.server.impl.application.DeferredResourceConfig
com.sun.jersey.api.core.WebAppResourceConfig
com.sun.jersey.api.core.DefaultResourceConfig
com.sun.jersey.api.core.ApplicationAdapter
com.sun.jersey.api.core.PackagesResourceConfig
com.sun.jersey.api.core.ClasspathResourceConfig
com.sun.jersey.api.core.ClassNamesResourceConfig
com.sun.jersey.api.core.ScanningResourceConfig
com.sun.jersey.api.core.ResourceConfig\"},
\"JBAS014771: Services with missing/unavailable dependencies\" =>
[\"jboss.naming.context.java.jboss.udm-plugin-meta.\\\"vzw-hbase-djr-client-1.0-SNAPSHOT.war\\\"
is missing
[jboss.deployment.unit.\\\"vzw-hbase-djr-client-1.0-SNAPSHOT.war\\\".beanmanager]\"]
W/o this jar in the war file we get ClassNotFoundException for
org.apache.phoenix.jdbc.PhoenixDriver.
Any inputs on this will help. It is ok if we deploy this jar outside of WAR
file.
Regards,
Arjun G V
[jira] [Commented] (PHOENIX-4793) Backport PHOENIX-4303, PHOENIX-4305, PHOENIX-4321 to 4.x branches.
[ https://issues.apache.org/jira/browse/PHOENIX-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541518#comment-16541518 ] Rajeshbabu Chintaguntla commented on PHOENIX-4793: -- sure [~jamestaylor]. > Backport PHOENIX-4303, PHOENIX-4305, PHOENIX-4321 to 4.x branches. > -- > > Key: PHOENIX-4793 > URL: https://issues.apache.org/jira/browse/PHOENIX-4793 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 4.15.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (PHOENIX-4812) Issue while deploying on JBOSS
Arjun created PHOENIX-4812:
--
Summary: Issue while deploying on JBOSS
Key: PHOENIX-4812
URL: https://issues.apache.org/jira/browse/PHOENIX-4812
Project: Phoenix
Issue Type: Bug
Reporter: Arjun
We are{color:#33} using the class: *org.apache.phoenix.jdbc.PhoenixDriver*
to *connect to Phoenix* and currently using the jar
(*phoenix-4.7.0-HBase-1.0-client.jar*) & while using this jar in our final
artifact and deploying on JBOSS, seeing the following exception:{color}
{color:#33}aga@{color}{color:#33}$ cat
vzw-hbase-djr-client-1.0-SNAPSHOT.war.failed
*"{*
*\"JBAS014671: Failed services\" =>
{\"jboss.deployment.unit.\\\"vzw-hbase-djr-client-1.0-SNAPSHOT.war\\\".POST_MODULE\"
=> \"org.jboss.msc.service.StartException in service
jboss.deployment.unit.\\\"vzw-hbase-djr-client-1.0-SNAPSHOT.war\\\".POST_MODULE:
JBAS018733: Failed to process phase POST_MODULE of deployment*
{color}[\\\"vzw-hbase-djr-client-1.0-SNAPSHOT.war\\\|file:///%22vzw-hbase-djr-client-1.0-SNAPSHOT.war/]*{color:#33}"{color}*{color:#33}
*Caused by:
org.jboss.as.server.deployment.DeploymentUnitProcessingException: JBAS011232:
Only one JAX-RS Application Class allowed.
com.sun.jersey.server.impl.application.DeferredResourceConfig
com.sun.jersey.api.core.WebAppResourceConfig
com.sun.jersey.api.core.DefaultResourceConfig
com.sun.jersey.api.core.ApplicationAdapter
com.sun.jersey.api.core.PackagesResourceConfig
com.sun.jersey.api.core.ClasspathResourceConfig
com.sun.jersey.api.core.ClassNamesResourceConfig
com.sun.jersey.api.core.ScanningResourceConfig
com.sun.jersey.api.core.ResourceConfig\"},*
*\"JBAS014771: Services with missing/unavailable dependencies\" =>
[\"jboss.naming.context.java.jboss.udm-plugin-meta.\\\"vzw-hbase-djr-client-1.0-SNAPSHOT.war\\\"
is missing*
*[jboss.deployment.unit.\\\"vzw-hbase-djr-client-1.0-SNAPSHOT.war\\\".beanmanager]**\"]*{color}
{color:#33}W/o this jar{color}{color:#33} in the{color}
{color:#33}war{color}{color:#33} file we get ClassNotFoundException for
org.apache.phoenix.jdbc.PhoenixDriver.{color}
*Any inputs on this will help. It is ok if we deploy this jar outside of WAR
file.*
*Also, ok to consume a lighter jar which can be used to connect to Phoenix from
Java.*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
