[jira] [Resolved] (PHOENIX-1567) Publish Phoenix-Client & Phoenix-Server jars into Maven Repo
[
https://issues.apache.org/jira/browse/PHOENIX-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vincent Poon resolved PHOENIX-1567.
---
Resolution: Fixed
Fix Version/s: 4.14.1
After applying PHOENIX-4781, I was able to publish the client and server jars
for 4.14.1 here:
https://repository.apache.org/content/repositories/releases/org/apache/phoenix/phoenix-client/
Marking this resolved.
> Publish Phoenix-Client & Phoenix-Server jars into Maven Repo
>
>
> Key: PHOENIX-1567
> URL: https://issues.apache.org/jira/browse/PHOENIX-1567
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.2.0
>Reporter: Jeffrey Zhong
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 4.14.1
>
> Attachments: PHOENIX-1567.patch
>
>
> Phoenix doesn't publish Phoenix Client & Server jars into Maven repository.
> This make things quite hard for down steam projects/applications to use maven
> to resolve dependencies.
> I tried to modify the pom.xml under phoenix-assembly while it shows the
> following.
> {noformat}
> [INFO] Installing
> /Users/jzhong/work/phoenix_apache/checkins/phoenix/phoenix-assembly/target/phoenix-4.3.0-SNAPSHOT-client.jar
>
> to
> /Users/jzhong/.m2/repository/org/apache/phoenix/phoenix-assembly/4.3.0-SNAPSHOT/phoenix-assembly-4.3.0-SNAPSHOT-client.jar
> {noformat}
> Basically the jar published to maven repo will become
> phoenix-assembly-4.3.0-SNAPSHOT-client.jar or
> phoenix-assembly-4.3.0-SNAPSHOT-server.jar
> The artifact id "phoenix-assembly" has to be the prefix of the names of jars.
> Therefore, the possible solutions are:
> 1) rename current client & server jar to phoenix-assembly-clinet/server.jar
> to match the jars published to maven repo.
> 2) rename phoenix-assembly to something more meaningful and rename our client
> & server jars accordingly
> 3) split phoenix-assembly and move the corresponding artifacts into
> phoenix-client & phoenix-server folders. Phoenix-assembly will only create
> tar ball files.
> [~giacomotaylor], [~apurtell] or other maven experts: Any suggestion on this?
> Thanks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [DISCUSS] Drop support for java 1.7 on the 1.2, 1.3 and 1.4 branches
I'd vote for keep using java7 on 4.x branches. if upgrades to java8, it will impact users who want to upgrade the latest 4.x branches. they must consider using java8 in their running environments, maybe their libraries do not support java8, then they have to give up to upgrade. So I think that drops support java7 is not friendly for some users. Jaanai Zhang Best regards! Pedro Boado 于2018年11月30日周五 上午6:13写道： > I'd vote for keep compiling 4.x branches in java7. It makes sense as it's > just a new minor release. > > It's pretty easy reverting back to spark 1.6 and also avatica dependency > could be reverted to the previous version. > > On 29 Nov 2018 21:41, "Thomas D'Silva" wrote: > > We have traditionally followed HBase's java support (see > https://hbase.apache.org/book.html#basic.prerequisites). The > phoenix-queryserver module has a dependency on Avatica which does not > support Java 1.7. The phoenix-spark module depends on spark 2.3.2 which > also does not support Java 1.7. Do folks feel we should continue to provide > support Java 1.7 on the 1.x branches? >
[jira] [Updated] (PHOENIX-4781) Phoenix client project's jar naming convention causes maven-deploy-plugin to fail
[
https://issues.apache.org/jira/browse/PHOENIX-4781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vincent Poon updated PHOENIX-4781:
--
Attachment: PHOENIX-4781.4.x-HBase-1.4.v3.patch
> Phoenix client project's jar naming convention causes maven-deploy-plugin to
> fail
> -
>
> Key: PHOENIX-4781
> URL: https://issues.apache.org/jira/browse/PHOENIX-4781
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 5.0.0, 4.14.1
>Reporter: Karan Mehta
>Assignee: Karan Mehta
>Priority: Major
> Attachments: PHOENIX-4781.001.patch, PHOENIX-4781.002.patch,
> PHOENIX-4781.4.x-HBase-1.4.v3.patch
>
>
> `maven-deploy-plugin` is used for deploying built artifacts to repository
> provided by `distributionManagement` tag. The name of files that need to be
> uploaded are either derived from pom file of the project or it generates an
> temporary one on its own.
> For `phoenix-client` project, we essentially create a shaded uber jar that
> contains all dependencies and provide the project pom file for the plugin to
> work. `maven-jar-plugin` is disabled for the project, hence the shade plugin
> essentially packages the jar. The final name of the shaded jar is defined as
> `phoenix-${project.version}\-client`, which is different from how the
> standard maven convention based on pom file (artifact and group id) is
> `phoenix-client-${project.version}`
> This causes `maven-deploy-plugin` to fail since it is unable to find any
> artifacts to be published.
> `maven-install-plugin` works correctly and hence it installs correct jar in
> local repo.
> The same is effective for `phoenix-pig` project as well. However we require
> the require jar for that project in the repo. I am not even sure why we
> create shaded jar for that project.
> I will put up a 3 liner patch for the same.
> Any thoughts? [~sergey.soldatov] [~elserj]
> Files before change (first col is size):
> {code:java}
> 103487701 Jun 13 22:47
> phoenix-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSHOT-client.jar{code}
> Files after change (first col is size):
> {code:java}
> 3640 Jun 13 21:23
> original-phoenix-client-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSHOT.jar
> 103487702 Jun 13 21:24
> phoenix-client-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSHOT.jar{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (PHOENIX-4781) Phoenix client project's jar naming convention causes maven-deploy-plugin to fail
[
https://issues.apache.org/jira/browse/PHOENIX-4781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vincent Poon updated PHOENIX-4781:
--
Attachment: (was: PHOENIX-4781.4.x-HBase-1.4.v3.patch)
> Phoenix client project's jar naming convention causes maven-deploy-plugin to
> fail
> -
>
> Key: PHOENIX-4781
> URL: https://issues.apache.org/jira/browse/PHOENIX-4781
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 5.0.0, 4.14.1
>Reporter: Karan Mehta
>Assignee: Karan Mehta
>Priority: Major
> Attachments: PHOENIX-4781.001.patch, PHOENIX-4781.002.patch,
> PHOENIX-4781.4.x-HBase-1.4.v3.patch
>
>
> `maven-deploy-plugin` is used for deploying built artifacts to repository
> provided by `distributionManagement` tag. The name of files that need to be
> uploaded are either derived from pom file of the project or it generates an
> temporary one on its own.
> For `phoenix-client` project, we essentially create a shaded uber jar that
> contains all dependencies and provide the project pom file for the plugin to
> work. `maven-jar-plugin` is disabled for the project, hence the shade plugin
> essentially packages the jar. The final name of the shaded jar is defined as
> `phoenix-${project.version}\-client`, which is different from how the
> standard maven convention based on pom file (artifact and group id) is
> `phoenix-client-${project.version}`
> This causes `maven-deploy-plugin` to fail since it is unable to find any
> artifacts to be published.
> `maven-install-plugin` works correctly and hence it installs correct jar in
> local repo.
> The same is effective for `phoenix-pig` project as well. However we require
> the require jar for that project in the repo. I am not even sure why we
> create shaded jar for that project.
> I will put up a 3 liner patch for the same.
> Any thoughts? [~sergey.soldatov] [~elserj]
> Files before change (first col is size):
> {code:java}
> 103487701 Jun 13 22:47
> phoenix-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSHOT-client.jar{code}
> Files after change (first col is size):
> {code:java}
> 3640 Jun 13 21:23
> original-phoenix-client-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSHOT.jar
> 103487702 Jun 13 21:24
> phoenix-client-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSHOT.jar{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (PHOENIX-4781) Phoenix client project's jar naming convention causes maven-deploy-plugin to fail
[
https://issues.apache.org/jira/browse/PHOENIX-4781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vincent Poon updated PHOENIX-4781:
--
Attachment: PHOENIX-4781.4.x-HBase-1.4.v3.patch
> Phoenix client project's jar naming convention causes maven-deploy-plugin to
> fail
> -
>
> Key: PHOENIX-4781
> URL: https://issues.apache.org/jira/browse/PHOENIX-4781
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Karan Mehta
>Assignee: Karan Mehta
>Priority: Major
> Attachments: PHOENIX-4781.001.patch, PHOENIX-4781.002.patch,
> PHOENIX-4781.4.x-HBase-1.4.v3.patch
>
>
> `maven-deploy-plugin` is used for deploying built artifacts to repository
> provided by `distributionManagement` tag. The name of files that need to be
> uploaded are either derived from pom file of the project or it generates an
> temporary one on its own.
> For `phoenix-client` project, we essentially create a shaded uber jar that
> contains all dependencies and provide the project pom file for the plugin to
> work. `maven-jar-plugin` is disabled for the project, hence the shade plugin
> essentially packages the jar. The final name of the shaded jar is defined as
> `phoenix-${project.version}\-client`, which is different from how the
> standard maven convention based on pom file (artifact and group id) is
> `phoenix-client-${project.version}`
> This causes `maven-deploy-plugin` to fail since it is unable to find any
> artifacts to be published.
> `maven-install-plugin` works correctly and hence it installs correct jar in
> local repo.
> The same is effective for `phoenix-pig` project as well. However we require
> the require jar for that project in the repo. I am not even sure why we
> create shaded jar for that project.
> I will put up a 3 liner patch for the same.
> Any thoughts? [~sergey.soldatov] [~elserj]
> Files before change (first col is size):
> {code:java}
> 103487701 Jun 13 22:47
> phoenix-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSHOT-client.jar{code}
> Files after change (first col is size):
> {code:java}
> 3640 Jun 13 21:23
> original-phoenix-client-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSHOT.jar
> 103487702 Jun 13 21:24
> phoenix-client-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSHOT.jar{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (PHOENIX-5050) Maven install of phoenix-client overwrites phoenix-core jar
[ https://issues.apache.org/jira/browse/PHOENIX-5050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Poon resolved PHOENIX-5050. --- Resolution: Not A Problem Was on an older branch, looks like this is fixed in PHOENIX-1567 , which is still unresolved. Will see if I can finish any remaining work there. > Maven install of phoenix-client overwrites phoenix-core jar > --- > > Key: PHOENIX-5050 > URL: https://issues.apache.org/jira/browse/PHOENIX-5050 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.0.0, 4.14.1 >Reporter: Vincent Poon >Priority: Major > > If I run `mvn install -pl phoenix-client`, I get: > I > [INFO] --- maven-install-plugin:2.5.2:install-file (default-install) @ > phoenix-client --- > [INFO] Installing > /Users/vincent.poon/git_public/apache_git_phoenix/phoenix-client/target/phoenix-4.13.1-HBase-1.3-client.jar > to > /Users/vincent.poon/.m2/repository/org/apache/phoenix/phoenix-core/4.13.1-HBase-1.3/phoenix-core-4.13.1-HBase-1.3.jar -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (PHOENIX-5050) Maven install of phoenix-client overwrites phoenix-core jar
Vincent Poon created PHOENIX-5050: - Summary: Maven install of phoenix-client overwrites phoenix-core jar Key: PHOENIX-5050 URL: https://issues.apache.org/jira/browse/PHOENIX-5050 Project: Phoenix Issue Type: Bug Affects Versions: 4.14.1, 5.0.0 Reporter: Vincent Poon If I run `mvn install -pl phoenix-client`, I get: I [INFO] --- maven-install-plugin:2.5.2:install-file (default-install) @ phoenix-client --- [INFO] Installing /Users/vincent.poon/git_public/apache_git_phoenix/phoenix-client/target/phoenix-4.13.1-HBase-1.3-client.jar to /Users/vincent.poon/.m2/repository/org/apache/phoenix/phoenix-core/4.13.1-HBase-1.3/phoenix-core-4.13.1-HBase-1.3.jar -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [DISCUSS] Drop support for java 1.7 on the 1.2, 1.3 and 1.4 branches
I'd vote for keep compiling 4.x branches in java7. It makes sense as it's just a new minor release. It's pretty easy reverting back to spark 1.6 and also avatica dependency could be reverted to the previous version. On 29 Nov 2018 21:41, "Thomas D'Silva" wrote: We have traditionally followed HBase's java support (see https://hbase.apache.org/book.html#basic.prerequisites). The phoenix-queryserver module has a dependency on Avatica which does not support Java 1.7. The phoenix-spark module depends on spark 2.3.2 which also does not support Java 1.7. Do folks feel we should continue to provide support Java 1.7 on the 1.x branches?
Re: System.Catalog Table
We've also run into this problem in Phoenix 4.13
Here are steps to reproduce:
1) create original table in phoenix
CREATE TABLE IF NOT EXISTS "test"."TRACKING_VALUES" (
"cstId" BIGINT NOT NULL,
"cltId" BIGINT NOT NULL,
"trkblTp" VARCHAR NOT NULL,
"trkblId" BIGINT NOT NULL,
"id" BIGINT NOT NULL,
"vl" VARCHAR,
"dstTp" VARCHAR,
"crdAt" TIMESTAMP,
"crdBy" BIGINT,
"updAt" TIMESTAMP,
"updBy" BIGINT,
"stts"VARCHAR,
"lgcyId" VARCHAR,
CONSTRAINT "tracking_values_pk" PRIMARY KEY ("cstId", "cltId",
"trkblTp", "trkblId", "id")
)SALT_BUCKETS=10, DEFAULT_COLUMN_FAMILY='TV';
# Respective system.catalog table
0: jdbc:phoenix:labs-kumki-namenode-lv-101,la> select TENANT_ID,
TABLE_SCHEM, TABLE_NAME, COLUMN_NAME, COLUMN_FAMILY from
SYSTEM.CATALOG where table_schem = 'test' and table_name =
'TRACKING_VALUES';
++--+--+--++
| TENANT_ID | TABLE_SCHEM |TABLE_NAME| COLUMN_NAME | COLUMN_FAMILY |
++--+--+--++
|| test | TRACKING_VALUES | ||
|| test | TRACKING_VALUES | | TV |
|| test | TRACKING_VALUES | cltId||
|| test | TRACKING_VALUES | crdAt| TV |
|| test | TRACKING_VALUES | crdBy| TV |
|| test | TRACKING_VALUES | cstId||
|| test | TRACKING_VALUES | dstTp| TV |
|| test | TRACKING_VALUES | id ||
|| test | TRACKING_VALUES | lgcyId | TV |
|| test | TRACKING_VALUES | stts | TV |
|| test | TRACKING_VALUES | trkblId ||
|| test | TRACKING_VALUES | trkblTp ||
|| test | TRACKING_VALUES | updAt| TV |
|| test | TRACKING_VALUES | updBy| TV |
|| test | TRACKING_VALUES | vl | TV |
++--+--+--++
15 rows selected (0.079 seconds)
2) Populate data into the table
0: jdbc:phoenix:labs-kumki-namenode-lv-101,la> select * from
"test".TRACKING_VALUES;
++--++-++--+--+--++--++--+--+
| cstId | cltId | trkblTp | trkblId |
id | vl |dstTp | crdAt |
crdBy | updAt | updBy | stts |lgcyId
|
++--++-++--+--+--++--++--+--+
| -42| 4291717 | KeywordInstance| 9224773823 |
81606793 | tlm0YryK | SEARCH | 2014-04-22 15:24:21.000 |
null | 2014-04-22 15:24:21.000 | null | |
38783873798 |
| -42| 4291717 | PublisherCreative | 1971851927 |
81450003 | sRE2Ds8hZ| SEARCH | 2014-04-10 20:12:21.000 |
null | 2014-04-10 20:12:21.000 | null | |
38615971930 |
| 100| 100 | randomValue| 100 |
157124916 | randomValue | randomValue | 2018-08-16 05:34:42.000 |
100| 2018-08-16 05:34:42.000 | 100| randomValue |
randomValue |
| 7242 | 62235| KEYWORD| 74564665|
105322310 | Qwerty123| | 2017-08-10 18:35:48.000 |
34447 | | null | ACTIVE |
|
| 7242 | 64555| CREATIVE | 144115188096252274 |
157126212 | 20180903 | | 2018-09-04 06:36:16.000 |
34447 | | null | ACTIVE |
|
++--++-++--+--+--++--++--+--+
5 rows selected (0.26 seconds)
3) Hbase snapshot
hbase(main):001:0> snapshot 'test.TRACKING_VALUES', 'test-TRACKING_VALUES-SNAP'
0 row(s) in 0.7690 seconds
4) cloned Hbase snapshot
hbase(main):002:0> clone_snapshot 'test-TRACKING_VALUES-SNAP',
'testNew.TRACKING_VALUES'
0 row(s) in 0.6080 seconds
5) Created table in phoenix
0: jdbc:phoenix:labs-kumki-namenode-lv-101,la> CREATE TABLE IF NOT
EXISTS "testNew"."TRACKING_VAL
[DISCUSS] Drop support for java 1.7 on the 1.2, 1.3 and 1.4 branches
We have traditionally followed HBase's java support (see https://hbase.apache.org/book.html#basic.prerequisites). The phoenix-queryserver module has a dependency on Avatica which does not support Java 1.7. The phoenix-spark module depends on spark 2.3.2 which also does not support Java 1.7. Do folks feel we should continue to provide support Java 1.7 on the 1.x branches?
