[jira] [Updated] (PHOENIX-5931) PhoenixIndexFailurePolicy throws NPE if cause of IOE is null

2020-06-01 Thread Abhishek Singh Chouhan (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-5931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Singh Chouhan updated PHOENIX-5931:

Attachment: PHOENIX-5931-4.x.001.patch

> PhoenixIndexFailurePolicy throws NPE if cause of IOE is null
> 
>
> Key: PHOENIX-5931
> URL: https://issues.apache.org/jira/browse/PHOENIX-5931
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.16.0
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
>Priority: Minor
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5931-4.x.001.patch, PHOENIX-5931-4.x.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-5932) View Index rebuild results in surplus rows from other view indexes

2020-06-01 Thread Abhishek Singh Chouhan (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Singh Chouhan updated PHOENIX-5932:

Attachment: PHOENIX-5932-wip-master.patch

> View Index rebuild results in surplus rows from other view indexes
> --
>
> Key: PHOENIX-5932
> URL: https://issues.apache.org/jira/browse/PHOENIX-5932
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.16.0
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-5932-wip-4.x.patch, PHOENIX-5932-wip-master.patch
>
>
> Steps to reproduce
>  # Create a table with PK as COL1, COL2
>  # Create 2 views with different view constants on COL2. Also add other 
> columns
>  # Upsert rows into the views
>  # Create indexes on the views. Rebuild will result in each view index having 
> rows from other view also
> This is because we set the filter on scan to null during rebuild 
> [here|[https://github.com/apache/phoenix/blob/4.x/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java#L1084]]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-5932) View Index rebuild results in surplus rows from other view indexes

2020-06-01 Thread Abhishek Singh Chouhan (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Singh Chouhan updated PHOENIX-5932:

Issue Type: Bug  (was: Improvement)

> View Index rebuild results in surplus rows from other view indexes
> --
>
> Key: PHOENIX-5932
> URL: https://issues.apache.org/jira/browse/PHOENIX-5932
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.16.0
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-5932-wip-4.x.patch
>
>
> Steps to reproduce
>  # Create a table with PK as COL1, COL2
>  # Create 2 views with different view constants on COL2. Also add other 
> columns
>  # Upsert rows into the views
>  # Create indexes on the views. Rebuild will result in each view index having 
> rows from other view also
> This is because we set the filter on scan to null during rebuild 
> [here|[https://github.com/apache/phoenix/blob/4.x/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java#L1084]]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-5932) View Index rebuild results in surplus rows from other view indexes

2020-06-01 Thread Abhishek Singh Chouhan (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Singh Chouhan updated PHOENIX-5932:

Attachment: PHOENIX-5932-wip-4.x.patch

> View Index rebuild results in surplus rows from other view indexes
> --
>
> Key: PHOENIX-5932
> URL: https://issues.apache.org/jira/browse/PHOENIX-5932
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.16.0
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Attachments: PHOENIX-5932-wip-4.x.patch
>
>
> Steps to reproduce
>  # Create a table with PK as COL1, COL2
>  # Create 2 views with different view constants on COL2. Also add other 
> columns
>  # Upsert rows into the views
>  # Create indexes on the views. Rebuild will result in each view index having 
> rows from other view also
> This is because we set the filter on scan to null during rebuild 
> [here|[https://github.com/apache/phoenix/blob/4.x/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java#L1084]]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-5932) View Index rebuild results in surplus rows from other view indexes

2020-06-01 Thread Abhishek Singh Chouhan (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Singh Chouhan updated PHOENIX-5932:

Description: 
Steps to reproduce
 # Create a table with PK as COL1, COL2
 # Create 2 views with different view constants on COL2. Also add other columns
 # Upsert rows into the views
 # Create indexes on the views. Rebuild will result in each view index having 
rows from other view also

This is because we set the filter on scan to null during rebuild 
[here|[https://github.com/apache/phoenix/blob/4.x/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java#L1084]]

  was:
Steps to reproduce
 # Create a table with PK as COL1, COL2
 # Create 2 views with different view constants on COL2. Also add other columns
 # Upsert rows into the views
 # Create indexes on the views. Rebuild will result in each view index having 
rows from other view also

This is because we set the filter on scan to null during rebuild 
[here|[https://github.com/apache/phoenix/blob/4.x/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java#L1084]


> View Index rebuild results in surplus rows from other view indexes
> --
>
> Key: PHOENIX-5932
> URL: https://issues.apache.org/jira/browse/PHOENIX-5932
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.16.0
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
>Priority: Major
>
> Steps to reproduce
>  # Create a table with PK as COL1, COL2
>  # Create 2 views with different view constants on COL2. Also add other 
> columns
>  # Upsert rows into the views
>  # Create indexes on the views. Rebuild will result in each view index having 
> rows from other view also
> This is because we set the filter on scan to null during rebuild 
> [here|[https://github.com/apache/phoenix/blob/4.x/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java#L1084]]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (PHOENIX-5932) View Index rebuild results in surplus rows from other view indexes

2020-06-01 Thread Abhishek Singh Chouhan (Jira)
Abhishek Singh Chouhan created PHOENIX-5932:
---

 Summary: View Index rebuild results in surplus rows from other 
view indexes
 Key: PHOENIX-5932
 URL: https://issues.apache.org/jira/browse/PHOENIX-5932
 Project: Phoenix
  Issue Type: Improvement
Affects Versions: 4.16.0
Reporter: Abhishek Singh Chouhan
Assignee: Abhishek Singh Chouhan


Steps to reproduce
 # Create a table with PK as COL1, COL2
 # Create 2 views with different view constants on COL2. Also add other columns
 # Upsert rows into the views
 # Create indexes on the views. Rebuild will result in each view index having 
rows from other view also

This is because we set the filter on scan to null during rebuild 
[here|[https://github.com/apache/phoenix/blob/4.x/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java#L1084]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-5931) PhoenixIndexFailurePolicy throws NPE if cause of IOE is null

2020-06-01 Thread Abhishek Singh Chouhan (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-5931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Singh Chouhan updated PHOENIX-5931:

Attachment: PHOENIX-5931-4.x.patch

> PhoenixIndexFailurePolicy throws NPE if cause of IOE is null
> 
>
> Key: PHOENIX-5931
> URL: https://issues.apache.org/jira/browse/PHOENIX-5931
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.16.0
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
>Priority: Minor
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5931-4.x.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (PHOENIX-5931) PhoenixIndexFailurePolicy throws NPE if cause of IOE is null

2020-06-01 Thread Abhishek Singh Chouhan (Jira)
Abhishek Singh Chouhan created PHOENIX-5931:
---

 Summary: PhoenixIndexFailurePolicy throws NPE if cause of IOE is 
null
 Key: PHOENIX-5931
 URL: https://issues.apache.org/jira/browse/PHOENIX-5931
 Project: Phoenix
  Issue Type: Improvement
Affects Versions: 4.16.0
Reporter: Abhishek Singh Chouhan
Assignee: Abhishek Singh Chouhan
 Fix For: 5.1.0, 4.16.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (PHOENIX-5930) Index Verification Output should include result error code

2020-06-01 Thread Geoffrey Jacoby (Jira)
Geoffrey Jacoby created PHOENIX-5930:


 Summary: Index Verification Output should include result error code
 Key: PHOENIX-5930
 URL: https://issues.apache.org/jira/browse/PHOENIX-5930
 Project: Phoenix
  Issue Type: Improvement
Reporter: Geoffrey Jacoby
Assignee: Geoffrey Jacoby


When an index rebuild / verification logs a failed row to the 
PHOENIX_INDEX_TOOL table, it should include a machine-readable column 
corresponding to the counter in PHOENIX_INDEX_TOOL_RESULT that gets 
incremented. (Invalid, Missing, Beyond max lookback, etc). An enum seems 
appropriate. 

Lacking this, any automated tool analyzing the PIT table has to do string 
matching on the error message, which is brittle. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-5928) Index rebuilds without replaying data table mutations

2020-06-01 Thread Kadir OZDEMIR (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-5928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kadir OZDEMIR updated PHOENIX-5928:
---
Attachment: PHOENIX-5928.4.x.003.patch

> Index rebuilds without replaying data table mutations
> -
>
> Key: PHOENIX-5928
> URL: https://issues.apache.org/jira/browse/PHOENIX-5928
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 5.0.0, 4.14.3
>Reporter: Kadir OZDEMIR
>Assignee: Kadir OZDEMIR
>Priority: Major
> Attachments: PHOENIX-5928.4.x.001.patch, PHOENIX-5928.4.x.002.patch, 
> PHOENIX-5928.4.x.003.patch
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Index rebuilds are done currently by reading data table mutations (in 
> UngroupedAggregateRegionObserver) and then replaying them on the data table 
> (in IndexRegionObser) -- without actually applying mutations on the data 
> table -- in order to generate the corresponding index mutations and apply 
> them on index tables. IndexRegionObserver sets the operation status for these 
> data table mutations to NOWRITE so that they are ignored by HBase after 
> generating index table mutations from these data table mutations. Since we do 
> not apply these mutations on the data table, there is no need to send these 
> mutations to the data table regions if index mutations are generated and sent 
> to index tables by UngroupedAggregateRegionObserver. By doing so, we 
> eliminate going through data table update path and its overhead (its 
> interaction with flushes, row locking etc). 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-5928) Index rebuilds without replaying data table mutations

2020-06-01 Thread Kadir OZDEMIR (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-5928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kadir OZDEMIR updated PHOENIX-5928:
---
Attachment: PHOENIX-5928.4.x.002.patch

> Index rebuilds without replaying data table mutations
> -
>
> Key: PHOENIX-5928
> URL: https://issues.apache.org/jira/browse/PHOENIX-5928
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 5.0.0, 4.14.3
>Reporter: Kadir OZDEMIR
>Assignee: Kadir OZDEMIR
>Priority: Major
> Attachments: PHOENIX-5928.4.x.001.patch, PHOENIX-5928.4.x.002.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Index rebuilds are done currently by reading data table mutations (in 
> UngroupedAggregateRegionObserver) and then replaying them on the data table 
> (in IndexRegionObser) -- without actually applying mutations on the data 
> table -- in order to generate the corresponding index mutations and apply 
> them on index tables. IndexRegionObserver sets the operation status for these 
> data table mutations to NOWRITE so that they are ignored by HBase after 
> generating index table mutations from these data table mutations. Since we do 
> not apply these mutations on the data table, there is no need to send these 
> mutations to the data table regions if index mutations are generated and sent 
> to index tables by UngroupedAggregateRegionObserver. By doing so, we 
> eliminate going through data table update path and its overhead (its 
> interaction with flushes, row locking etc). 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-5927) IndexScrutinyTool in schema table is error

2020-06-01 Thread Chao Wang (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-5927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chao Wang updated PHOENIX-5927:
---
Attachment: PHOENIX-5927.patch

> IndexScrutinyTool  in schema table is error  
> -
>
> Key: PHOENIX-5927
> URL: https://issues.apache.org/jira/browse/PHOENIX-5927
> Project: Phoenix
>  Issue Type: Bug
>  Components: core
>Affects Versions: 4.14.1, 4.14.2, 4.14.3
>Reporter: Chao Wang
>Priority: Major
> Attachments: PHOENIX-5927.patch
>
>
> Currently, if you use  IndexScrutinyTool  like this:
> 1. CREATE TABLE if not exists my_schema.TEST4 (id SMALLINT not null primary 
> key, name VARCHAR(10));
> 2. create index my_idx4 on my_schema.TEST4(name);
> 3.hbase org.apache.phoenix.mapreduce.index.IndexScrutinyTool -dt 
> MY_SCHEMA.TEST4 -it MY_SCHEMA.MY_IDX4;
> this will throw exception, As shown below.
> !https://dts.huawei.com/net/dts/fckeditor/download.ashx?Path=LEJcxkX%2fS4Mb3WaclkNh5LxQyU4OEwKVxGzMlk6Rrc%2biiopqBY902rxuef1%2b3cv7sSFVccO9iD3h4rOVuZar6A%3d%3d!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)