[jira] [Updated] (PHOENIX-5695) Phoenix website build.sh should return when child script has errors
[ https://issues.apache.org/jira/browse/PHOENIX-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari updated PHOENIX-5695: --- Fix Version/s: 4.15.1 5.1.0 > Phoenix website build.sh should return when child script has errors > --- > > Key: PHOENIX-5695 > URL: https://issues.apache.org/jira/browse/PHOENIX-5695 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.15.0, 5.1.0 >Reporter: Nitesh Maheshwari >Assignee: Nitesh Maheshwari >Priority: Major > Fix For: 5.1.0, 4.15.1 > > > There is a bug in build.sh while building phoenix website, when JAVA_HOME is > not set. The script prints the error, but thereafter continues and eventually > succeeds rather than exiting at the point with error. > In the following case, it ended up removing the contents of datatypes.html, > functions.html and index.html: > {code:sh} > :~/oss/phoenix_website/phoenix$ echo $JAVA_HOME > :~/oss/phoenix_website/phoenix$ ./build.sh > Generate Phoenix Website > BUILDING LANGUAGE REFERENCE > === > Error: JAVA_HOME is not defined. > ./build.sh: line 12: /bin/javac: No such file or directory > ./build.sh: line 13: /bin/java: No such file or directory > BUILDING SITE > === > [INFO] Scanning for projects... > [WARNING] > [WARNING] Some problems were encountered while building the effective model > for org.apache.phoenix:phoenix-site:jar:4.3.1 > [WARNING] Reporting configuration should be done in section, not > in maven-site-plugin as reportPlugins parameter. @ line 52, > column 23 > [WARNING] > [WARNING] It is highly recommended to fix these problems because they > threaten the stability of your build. > [WARNING] > [WARNING] For this reason, future Maven versions might no longer support > building such malformed projects. > [WARNING] > [INFO] > [INFO] --< org.apache.phoenix:phoenix-site > >--- > [INFO] Building Phoenix 4.3.1 > [INFO] [ jar > ]- > [INFO] > [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ phoenix-site --- > [INFO] > [INFO] --- maven-site-plugin:3.3:site (default-site) @ phoenix-site --- > [INFO] configuring report plugin org.codehaus.mojo:findbugs-maven-plugin:2.5.2 > [INFO] Parent project loaded from repository: > org.apache.phoenix:phoenix:pom:4.3.1 > [INFO] Parent project loaded from repository: org.apache:apache:pom:14 > [INFO] Relativizing decoration links with respect to project URL: > http://phoenix.apache.org/ > [INFO] Rendering site with lt.velykis.maven.skins:reflow-maven-skin:jar:1.1.0 > skin. > [INFO] > [INFO] --- exec-maven-plugin:1.2.1:exec (Merge Language Reference) @ > phoenix-site --- > Exception in thread "main" java.io.FileNotFoundException: > ../../../../../phoenix-docs/docs/html/index.html (No such file or directory) > at java.io.FileInputStream.open0(Native Method) > at java.io.FileInputStream.open(FileInputStream.java:195) > at java.io.FileInputStream.(FileInputStream.java:138) > at mergehtml.getFileAsString(mergehtml.java:33) > at mergehtml.main(mergehtml.java:15) > Exception in thread "main" java.io.FileNotFoundException: > ../../../../../phoenix-docs/docs/html/functions.html (No such file or > directory) > at java.io.FileInputStream.open0(Native Method) > at java.io.FileInputStream.open(FileInputStream.java:195) > at java.io.FileInputStream.(FileInputStream.java:138) > at mergehtml.getFileAsString(mergehtml.java:33) > at mergehtml.main(mergehtml.java:15) > Exception in thread "main" java.io.FileNotFoundException: > ../../../../../phoenix-docs/docs/html/datatypes.html (No such file or > directory) > at java.io.FileInputStream.open0(Native Method) > at java.io.FileInputStream.open(FileInputStream.java:195) > at java.io.FileInputStream.(FileInputStream.java:138) > at mergehtml.getFileAsString(mergehtml.java:33) > at mergehtml.main(mergehtml.java:15) > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 2.754 s > [INFO] Finished at: 2020-01-22T13:36:47-08:00 > [INFO] > > Removing temp directories > === > :~/oss/phoenix_website/phoenix$ svn st > M site/publish/language/datatypes.html > M site/publish/language/functions.html > M site/publish/language/index.html > {code} > The fix is to check for errors from the child script phoenix-docs/build.sh > before continuing. -- This message was sent by
[jira] [Updated] (PHOENIX-5695) Phoenix website build.sh should return when child script has errors
[ https://issues.apache.org/jira/browse/PHOENIX-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari updated PHOENIX-5695: --- Affects Version/s: 5.1.0 4.15.0 > Phoenix website build.sh should return when child script has errors > --- > > Key: PHOENIX-5695 > URL: https://issues.apache.org/jira/browse/PHOENIX-5695 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.15.0, 5.1.0 >Reporter: Nitesh Maheshwari >Assignee: Nitesh Maheshwari >Priority: Major > > There is a bug in build.sh while building phoenix website, when JAVA_HOME is > not set. The script prints the error, but thereafter continues and eventually > succeeds rather than exiting at the point with error. > In the following case, it ended up removing the contents of datatypes.html, > functions.html and index.html: > {code:sh} > :~/oss/phoenix_website/phoenix$ echo $JAVA_HOME > :~/oss/phoenix_website/phoenix$ ./build.sh > Generate Phoenix Website > BUILDING LANGUAGE REFERENCE > === > Error: JAVA_HOME is not defined. > ./build.sh: line 12: /bin/javac: No such file or directory > ./build.sh: line 13: /bin/java: No such file or directory > BUILDING SITE > === > [INFO] Scanning for projects... > [WARNING] > [WARNING] Some problems were encountered while building the effective model > for org.apache.phoenix:phoenix-site:jar:4.3.1 > [WARNING] Reporting configuration should be done in section, not > in maven-site-plugin as reportPlugins parameter. @ line 52, > column 23 > [WARNING] > [WARNING] It is highly recommended to fix these problems because they > threaten the stability of your build. > [WARNING] > [WARNING] For this reason, future Maven versions might no longer support > building such malformed projects. > [WARNING] > [INFO] > [INFO] --< org.apache.phoenix:phoenix-site > >--- > [INFO] Building Phoenix 4.3.1 > [INFO] [ jar > ]- > [INFO] > [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ phoenix-site --- > [INFO] > [INFO] --- maven-site-plugin:3.3:site (default-site) @ phoenix-site --- > [INFO] configuring report plugin org.codehaus.mojo:findbugs-maven-plugin:2.5.2 > [INFO] Parent project loaded from repository: > org.apache.phoenix:phoenix:pom:4.3.1 > [INFO] Parent project loaded from repository: org.apache:apache:pom:14 > [INFO] Relativizing decoration links with respect to project URL: > http://phoenix.apache.org/ > [INFO] Rendering site with lt.velykis.maven.skins:reflow-maven-skin:jar:1.1.0 > skin. > [INFO] > [INFO] --- exec-maven-plugin:1.2.1:exec (Merge Language Reference) @ > phoenix-site --- > Exception in thread "main" java.io.FileNotFoundException: > ../../../../../phoenix-docs/docs/html/index.html (No such file or directory) > at java.io.FileInputStream.open0(Native Method) > at java.io.FileInputStream.open(FileInputStream.java:195) > at java.io.FileInputStream.(FileInputStream.java:138) > at mergehtml.getFileAsString(mergehtml.java:33) > at mergehtml.main(mergehtml.java:15) > Exception in thread "main" java.io.FileNotFoundException: > ../../../../../phoenix-docs/docs/html/functions.html (No such file or > directory) > at java.io.FileInputStream.open0(Native Method) > at java.io.FileInputStream.open(FileInputStream.java:195) > at java.io.FileInputStream.(FileInputStream.java:138) > at mergehtml.getFileAsString(mergehtml.java:33) > at mergehtml.main(mergehtml.java:15) > Exception in thread "main" java.io.FileNotFoundException: > ../../../../../phoenix-docs/docs/html/datatypes.html (No such file or > directory) > at java.io.FileInputStream.open0(Native Method) > at java.io.FileInputStream.open(FileInputStream.java:195) > at java.io.FileInputStream.(FileInputStream.java:138) > at mergehtml.getFileAsString(mergehtml.java:33) > at mergehtml.main(mergehtml.java:15) > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 2.754 s > [INFO] Finished at: 2020-01-22T13:36:47-08:00 > [INFO] > > Removing temp directories > === > :~/oss/phoenix_website/phoenix$ svn st > M site/publish/language/datatypes.html > M site/publish/language/functions.html > M site/publish/language/index.html > {code} > The fix is to check for errors from the child script phoenix-docs/build.sh > before continuing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (PHOENIX-5695) Phoenix website build.sh should return when child script has errors
Nitesh Maheshwari created PHOENIX-5695: -- Summary: Phoenix website build.sh should return when child script has errors Key: PHOENIX-5695 URL: https://issues.apache.org/jira/browse/PHOENIX-5695 Project: Phoenix Issue Type: Bug Reporter: Nitesh Maheshwari Assignee: Nitesh Maheshwari There is a bug in build.sh while building phoenix website, when JAVA_HOME is not set. The script prints the error, but thereafter continues and eventually succeeds rather than exiting at the point with error. In the following case, it ended up removing the contents of datatypes.html, functions.html and index.html: {code:sh} :~/oss/phoenix_website/phoenix$ echo $JAVA_HOME :~/oss/phoenix_website/phoenix$ ./build.sh Generate Phoenix Website BUILDING LANGUAGE REFERENCE === Error: JAVA_HOME is not defined. ./build.sh: line 12: /bin/javac: No such file or directory ./build.sh: line 13: /bin/java: No such file or directory BUILDING SITE === [INFO] Scanning for projects... [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.phoenix:phoenix-site:jar:4.3.1 [WARNING] Reporting configuration should be done in section, not in maven-site-plugin as reportPlugins parameter. @ line 52, column 23 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [WARNING] [INFO] [INFO] --< org.apache.phoenix:phoenix-site >--- [INFO] Building Phoenix 4.3.1 [INFO] [ jar ]- [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ phoenix-site --- [INFO] [INFO] --- maven-site-plugin:3.3:site (default-site) @ phoenix-site --- [INFO] configuring report plugin org.codehaus.mojo:findbugs-maven-plugin:2.5.2 [INFO] Parent project loaded from repository: org.apache.phoenix:phoenix:pom:4.3.1 [INFO] Parent project loaded from repository: org.apache:apache:pom:14 [INFO] Relativizing decoration links with respect to project URL: http://phoenix.apache.org/ [INFO] Rendering site with lt.velykis.maven.skins:reflow-maven-skin:jar:1.1.0 skin. [INFO] [INFO] --- exec-maven-plugin:1.2.1:exec (Merge Language Reference) @ phoenix-site --- Exception in thread "main" java.io.FileNotFoundException: ../../../../../phoenix-docs/docs/html/index.html (No such file or directory) at java.io.FileInputStream.open0(Native Method) at java.io.FileInputStream.open(FileInputStream.java:195) at java.io.FileInputStream.(FileInputStream.java:138) at mergehtml.getFileAsString(mergehtml.java:33) at mergehtml.main(mergehtml.java:15) Exception in thread "main" java.io.FileNotFoundException: ../../../../../phoenix-docs/docs/html/functions.html (No such file or directory) at java.io.FileInputStream.open0(Native Method) at java.io.FileInputStream.open(FileInputStream.java:195) at java.io.FileInputStream.(FileInputStream.java:138) at mergehtml.getFileAsString(mergehtml.java:33) at mergehtml.main(mergehtml.java:15) Exception in thread "main" java.io.FileNotFoundException: ../../../../../phoenix-docs/docs/html/datatypes.html (No such file or directory) at java.io.FileInputStream.open0(Native Method) at java.io.FileInputStream.open(FileInputStream.java:195) at java.io.FileInputStream.(FileInputStream.java:138) at mergehtml.getFileAsString(mergehtml.java:33) at mergehtml.main(mergehtml.java:15) [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 2.754 s [INFO] Finished at: 2020-01-22T13:36:47-08:00 [INFO] Removing temp directories === :~/oss/phoenix_website/phoenix$ svn st M site/publish/language/datatypes.html M site/publish/language/functions.html M site/publish/language/index.html {code} The fix is to check for errors from the child script phoenix-docs/build.sh before continuing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-5634) Use 'phoenix.default.update.cache.frequency' from connection properties at query time
[ https://issues.apache.org/jira/browse/PHOENIX-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari updated PHOENIX-5634: --- Attachment: (was: PHOENIX-5634.master.v3.patch) > Use 'phoenix.default.update.cache.frequency' from connection properties at > query time > - > > Key: PHOENIX-5634 > URL: https://issues.apache.org/jira/browse/PHOENIX-5634 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.15.0, 5.1.0 >Reporter: Nitesh Maheshwari >Assignee: Nitesh Maheshwari >Priority: Minor > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5634.4.x-HBase-1.3.v3.patch, > PHOENIX-5634.master.v6.patch > > Time Spent: 4h 10m > Remaining Estimate: 0h > > We have the config 'phoenix.default.update.cache.frequency' which specifies > the time a client should wait before it refreshes its metadata cache entry > for a table by fetching the latest metadata from system catalog. This value > could be set for a table in the following ways (in the following preference > order): > # Specifying UPDATE_CACHE_FREQUENCY in table creation DDL > # Specifying the connection property 'phoenix.default.update.cache.frequency' > # Using the default 'phoenix.default.update.cache.frequency' > At query time, we look at whether UPDATE_CACHE_FREQUENCY was specified for > the table and decide based on that value if the latest metadata for a table > should be fetched from system catalog to update the cache. However, when the > table doesn't have UPDATE_CACHE_FREQUENCY specified we should look at the > connection property 'phoenix.default.update.cache.frequency' (or the default > 'phoenix.default.update.cache.frequency' when the connection level property > is not set) to make that decision. The support for latter is missing - this > Jira is intended to add that. > This will aid exiting installations where the tables were created without a > specified UPDATE_CACHE_FREQUENCY, and thus always hit the system catalog to > get the latest metadata when referenced. With this support, we will be able > to reduce the load on system catalog by specifying a connection level > property for all tables referenced from the connection (as against UPSERTing > each table entry in system catalog to set an UPDATE_CACHE_FREQUENCY value). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-5634) Use 'phoenix.default.update.cache.frequency' from connection properties at query time
[ https://issues.apache.org/jira/browse/PHOENIX-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari updated PHOENIX-5634: --- Attachment: (was: PHOENIX-5634.master.v4.patch) > Use 'phoenix.default.update.cache.frequency' from connection properties at > query time > - > > Key: PHOENIX-5634 > URL: https://issues.apache.org/jira/browse/PHOENIX-5634 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.15.0, 5.1.0 >Reporter: Nitesh Maheshwari >Assignee: Nitesh Maheshwari >Priority: Minor > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5634.4.x-HBase-1.3.v3.patch, > PHOENIX-5634.master.v6.patch > > Time Spent: 4h 10m > Remaining Estimate: 0h > > We have the config 'phoenix.default.update.cache.frequency' which specifies > the time a client should wait before it refreshes its metadata cache entry > for a table by fetching the latest metadata from system catalog. This value > could be set for a table in the following ways (in the following preference > order): > # Specifying UPDATE_CACHE_FREQUENCY in table creation DDL > # Specifying the connection property 'phoenix.default.update.cache.frequency' > # Using the default 'phoenix.default.update.cache.frequency' > At query time, we look at whether UPDATE_CACHE_FREQUENCY was specified for > the table and decide based on that value if the latest metadata for a table > should be fetched from system catalog to update the cache. However, when the > table doesn't have UPDATE_CACHE_FREQUENCY specified we should look at the > connection property 'phoenix.default.update.cache.frequency' (or the default > 'phoenix.default.update.cache.frequency' when the connection level property > is not set) to make that decision. The support for latter is missing - this > Jira is intended to add that. > This will aid exiting installations where the tables were created without a > specified UPDATE_CACHE_FREQUENCY, and thus always hit the system catalog to > get the latest metadata when referenced. With this support, we will be able > to reduce the load on system catalog by specifying a connection level > property for all tables referenced from the connection (as against UPSERTing > each table entry in system catalog to set an UPDATE_CACHE_FREQUENCY value). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-5634) Use 'phoenix.default.update.cache.frequency' from connection properties at query time
[ https://issues.apache.org/jira/browse/PHOENIX-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari updated PHOENIX-5634: --- Attachment: (was: PHOENIX-5634.master.v5.patch) > Use 'phoenix.default.update.cache.frequency' from connection properties at > query time > - > > Key: PHOENIX-5634 > URL: https://issues.apache.org/jira/browse/PHOENIX-5634 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.15.0, 5.1.0 >Reporter: Nitesh Maheshwari >Assignee: Nitesh Maheshwari >Priority: Minor > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5634.4.x-HBase-1.3.v3.patch, > PHOENIX-5634.master.v6.patch > > Time Spent: 4h 10m > Remaining Estimate: 0h > > We have the config 'phoenix.default.update.cache.frequency' which specifies > the time a client should wait before it refreshes its metadata cache entry > for a table by fetching the latest metadata from system catalog. This value > could be set for a table in the following ways (in the following preference > order): > # Specifying UPDATE_CACHE_FREQUENCY in table creation DDL > # Specifying the connection property 'phoenix.default.update.cache.frequency' > # Using the default 'phoenix.default.update.cache.frequency' > At query time, we look at whether UPDATE_CACHE_FREQUENCY was specified for > the table and decide based on that value if the latest metadata for a table > should be fetched from system catalog to update the cache. However, when the > table doesn't have UPDATE_CACHE_FREQUENCY specified we should look at the > connection property 'phoenix.default.update.cache.frequency' (or the default > 'phoenix.default.update.cache.frequency' when the connection level property > is not set) to make that decision. The support for latter is missing - this > Jira is intended to add that. > This will aid exiting installations where the tables were created without a > specified UPDATE_CACHE_FREQUENCY, and thus always hit the system catalog to > get the latest metadata when referenced. With this support, we will be able > to reduce the load on system catalog by specifying a connection level > property for all tables referenced from the connection (as against UPSERTing > each table entry in system catalog to set an UPDATE_CACHE_FREQUENCY value). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-5634) Use 'phoenix.default.update.cache.frequency' from connection properties at query time
[ https://issues.apache.org/jira/browse/PHOENIX-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari updated PHOENIX-5634: --- Attachment: (was: PHOENIX-5634.master.v2.patch) > Use 'phoenix.default.update.cache.frequency' from connection properties at > query time > - > > Key: PHOENIX-5634 > URL: https://issues.apache.org/jira/browse/PHOENIX-5634 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.15.0, 5.1.0 >Reporter: Nitesh Maheshwari >Assignee: Nitesh Maheshwari >Priority: Minor > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5634.4.x-HBase-1.3.v3.patch, > PHOENIX-5634.master.v3.patch > > Time Spent: 4h > Remaining Estimate: 0h > > We have the config 'phoenix.default.update.cache.frequency' which specifies > the time a client should wait before it refreshes its metadata cache entry > for a table by fetching the latest metadata from system catalog. This value > could be set for a table in the following ways (in the following preference > order): > # Specifying UPDATE_CACHE_FREQUENCY in table creation DDL > # Specifying the connection property 'phoenix.default.update.cache.frequency' > # Using the default 'phoenix.default.update.cache.frequency' > At query time, we look at whether UPDATE_CACHE_FREQUENCY was specified for > the table and decide based on that value if the latest metadata for a table > should be fetched from system catalog to update the cache. However, when the > table doesn't have UPDATE_CACHE_FREQUENCY specified we should look at the > connection property 'phoenix.default.update.cache.frequency' (or the default > 'phoenix.default.update.cache.frequency' when the connection level property > is not set) to make that decision. The support for latter is missing - this > Jira is intended to add that. > This will aid exiting installations where the tables were created without a > specified UPDATE_CACHE_FREQUENCY, and thus always hit the system catalog to > get the latest metadata when referenced. With this support, we will be able > to reduce the load on system catalog by specifying a connection level > property for all tables referenced from the connection (as against UPSERTing > each table entry in system catalog to set an UPDATE_CACHE_FREQUENCY value). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-5634) Use 'phoenix.default.update.cache.frequency' from connection properties at query time
[ https://issues.apache.org/jira/browse/PHOENIX-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari updated PHOENIX-5634: --- Attachment: (was: PHOENIX-5634.master.v1.patch) > Use 'phoenix.default.update.cache.frequency' from connection properties at > query time > - > > Key: PHOENIX-5634 > URL: https://issues.apache.org/jira/browse/PHOENIX-5634 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.15.0, 5.1.0 >Reporter: Nitesh Maheshwari >Assignee: Nitesh Maheshwari >Priority: Minor > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5634.4.x-HBase-1.3.v3.patch, > PHOENIX-5634.master.v2.patch > > Time Spent: 4h > Remaining Estimate: 0h > > We have the config 'phoenix.default.update.cache.frequency' which specifies > the time a client should wait before it refreshes its metadata cache entry > for a table by fetching the latest metadata from system catalog. This value > could be set for a table in the following ways (in the following preference > order): > # Specifying UPDATE_CACHE_FREQUENCY in table creation DDL > # Specifying the connection property 'phoenix.default.update.cache.frequency' > # Using the default 'phoenix.default.update.cache.frequency' > At query time, we look at whether UPDATE_CACHE_FREQUENCY was specified for > the table and decide based on that value if the latest metadata for a table > should be fetched from system catalog to update the cache. However, when the > table doesn't have UPDATE_CACHE_FREQUENCY specified we should look at the > connection property 'phoenix.default.update.cache.frequency' (or the default > 'phoenix.default.update.cache.frequency' when the connection level property > is not set) to make that decision. The support for latter is missing - this > Jira is intended to add that. > This will aid exiting installations where the tables were created without a > specified UPDATE_CACHE_FREQUENCY, and thus always hit the system catalog to > get the latest metadata when referenced. With this support, we will be able > to reduce the load on system catalog by specifying a connection level > property for all tables referenced from the connection (as against UPSERTing > each table entry in system catalog to set an UPDATE_CACHE_FREQUENCY value). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-5634) Use 'phoenix.default.update.cache.frequency' from connection properties at query time
[ https://issues.apache.org/jira/browse/PHOENIX-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari updated PHOENIX-5634: --- Attachment: (was: PHOENIX-5634.4.x-HBase-1.3.v2.patch) > Use 'phoenix.default.update.cache.frequency' from connection properties at > query time > - > > Key: PHOENIX-5634 > URL: https://issues.apache.org/jira/browse/PHOENIX-5634 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.15.0, 5.1.0 >Reporter: Nitesh Maheshwari >Assignee: Nitesh Maheshwari >Priority: Minor > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5634.4.x-HBase-1.3.v3.patch, > PHOENIX-5634.master.v2.patch > > Time Spent: 4h > Remaining Estimate: 0h > > We have the config 'phoenix.default.update.cache.frequency' which specifies > the time a client should wait before it refreshes its metadata cache entry > for a table by fetching the latest metadata from system catalog. This value > could be set for a table in the following ways (in the following preference > order): > # Specifying UPDATE_CACHE_FREQUENCY in table creation DDL > # Specifying the connection property 'phoenix.default.update.cache.frequency' > # Using the default 'phoenix.default.update.cache.frequency' > At query time, we look at whether UPDATE_CACHE_FREQUENCY was specified for > the table and decide based on that value if the latest metadata for a table > should be fetched from system catalog to update the cache. However, when the > table doesn't have UPDATE_CACHE_FREQUENCY specified we should look at the > connection property 'phoenix.default.update.cache.frequency' (or the default > 'phoenix.default.update.cache.frequency' when the connection level property > is not set) to make that decision. The support for latter is missing - this > Jira is intended to add that. > This will aid exiting installations where the tables were created without a > specified UPDATE_CACHE_FREQUENCY, and thus always hit the system catalog to > get the latest metadata when referenced. With this support, we will be able > to reduce the load on system catalog by specifying a connection level > property for all tables referenced from the connection (as against UPSERTing > each table entry in system catalog to set an UPDATE_CACHE_FREQUENCY value). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-5634) Use 'phoenix.default.update.cache.frequency' from connection properties at query time
[ https://issues.apache.org/jira/browse/PHOENIX-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari updated PHOENIX-5634: --- Attachment: (was: PHOENIX-5634.4.x-HBase-1.3.v1.patch) > Use 'phoenix.default.update.cache.frequency' from connection properties at > query time > - > > Key: PHOENIX-5634 > URL: https://issues.apache.org/jira/browse/PHOENIX-5634 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.15.0, 5.1.0 >Reporter: Nitesh Maheshwari >Assignee: Nitesh Maheshwari >Priority: Minor > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5634.4.x-HBase-1.3.v3.patch, > PHOENIX-5634.master.v2.patch > > Time Spent: 4h > Remaining Estimate: 0h > > We have the config 'phoenix.default.update.cache.frequency' which specifies > the time a client should wait before it refreshes its metadata cache entry > for a table by fetching the latest metadata from system catalog. This value > could be set for a table in the following ways (in the following preference > order): > # Specifying UPDATE_CACHE_FREQUENCY in table creation DDL > # Specifying the connection property 'phoenix.default.update.cache.frequency' > # Using the default 'phoenix.default.update.cache.frequency' > At query time, we look at whether UPDATE_CACHE_FREQUENCY was specified for > the table and decide based on that value if the latest metadata for a table > should be fetched from system catalog to update the cache. However, when the > table doesn't have UPDATE_CACHE_FREQUENCY specified we should look at the > connection property 'phoenix.default.update.cache.frequency' (or the default > 'phoenix.default.update.cache.frequency' when the connection level property > is not set) to make that decision. The support for latter is missing - this > Jira is intended to add that. > This will aid exiting installations where the tables were created without a > specified UPDATE_CACHE_FREQUENCY, and thus always hit the system catalog to > get the latest metadata when referenced. With this support, we will be able > to reduce the load on system catalog by specifying a connection level > property for all tables referenced from the connection (as against UPSERTing > each table entry in system catalog to set an UPDATE_CACHE_FREQUENCY value). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-5634) Use 'phoenix.default.update.cache.frequency' from connection properties at query time
[ https://issues.apache.org/jira/browse/PHOENIX-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari updated PHOENIX-5634: --- Affects Version/s: 5.1.0 > Use 'phoenix.default.update.cache.frequency' from connection properties at > query time > - > > Key: PHOENIX-5634 > URL: https://issues.apache.org/jira/browse/PHOENIX-5634 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.15.0, 5.1.0 >Reporter: Nitesh Maheshwari >Assignee: Nitesh Maheshwari >Priority: Minor > Fix For: 4.15.1 > > Attachments: PHOENIX-5634.master.v1.patch > > Time Spent: 3h 50m > Remaining Estimate: 0h > > We have the config 'phoenix.default.update.cache.frequency' which specifies > the time a client should wait before it refreshes its metadata cache entry > for a table by fetching the latest metadata from system catalog. This value > could be set for a table in the following ways (in the following preference > order): > # Specifying UPDATE_CACHE_FREQUENCY in table creation DDL > # Specifying the connection property 'phoenix.default.update.cache.frequency' > # Using the default 'phoenix.default.update.cache.frequency' > At query time, we look at whether UPDATE_CACHE_FREQUENCY was specified for > the table and decide based on that value if the latest metadata for a table > should be fetched from system catalog to update the cache. However, when the > table doesn't have UPDATE_CACHE_FREQUENCY specified we should look at the > connection property 'phoenix.default.update.cache.frequency' (or the default > 'phoenix.default.update.cache.frequency' when the connection level property > is not set) to make that decision. The support for latter is missing - this > Jira is intended to add that. > This will aid exiting installations where the tables were created without a > specified UPDATE_CACHE_FREQUENCY, and thus always hit the system catalog to > get the latest metadata when referenced. With this support, we will be able > to reduce the load on system catalog by specifying a connection level > property for all tables referenced from the connection (as against UPSERTing > each table entry in system catalog to set an UPDATE_CACHE_FREQUENCY value). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-5634) Use 'phoenix.default.update.cache.frequency' from connection properties at query time
[ https://issues.apache.org/jira/browse/PHOENIX-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari updated PHOENIX-5634: --- Fix Version/s: 5.1.0 > Use 'phoenix.default.update.cache.frequency' from connection properties at > query time > - > > Key: PHOENIX-5634 > URL: https://issues.apache.org/jira/browse/PHOENIX-5634 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.15.0, 5.1.0 >Reporter: Nitesh Maheshwari >Assignee: Nitesh Maheshwari >Priority: Minor > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5634.master.v1.patch > > Time Spent: 3h 50m > Remaining Estimate: 0h > > We have the config 'phoenix.default.update.cache.frequency' which specifies > the time a client should wait before it refreshes its metadata cache entry > for a table by fetching the latest metadata from system catalog. This value > could be set for a table in the following ways (in the following preference > order): > # Specifying UPDATE_CACHE_FREQUENCY in table creation DDL > # Specifying the connection property 'phoenix.default.update.cache.frequency' > # Using the default 'phoenix.default.update.cache.frequency' > At query time, we look at whether UPDATE_CACHE_FREQUENCY was specified for > the table and decide based on that value if the latest metadata for a table > should be fetched from system catalog to update the cache. However, when the > table doesn't have UPDATE_CACHE_FREQUENCY specified we should look at the > connection property 'phoenix.default.update.cache.frequency' (or the default > 'phoenix.default.update.cache.frequency' when the connection level property > is not set) to make that decision. The support for latter is missing - this > Jira is intended to add that. > This will aid exiting installations where the tables were created without a > specified UPDATE_CACHE_FREQUENCY, and thus always hit the system catalog to > get the latest metadata when referenced. With this support, we will be able > to reduce the load on system catalog by specifying a connection level > property for all tables referenced from the connection (as against UPSERTing > each table entry in system catalog to set an UPDATE_CACHE_FREQUENCY value). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-5654) String values (ALWAYS and NEVER) don't work for connection level config phoenix.default.update.cache.frequency
[ https://issues.apache.org/jira/browse/PHOENIX-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari updated PHOENIX-5654: --- Attachment: (was: PHOENIX-5654.master.v1.patch) > String values (ALWAYS and NEVER) don't work for connection level config > phoenix.default.update.cache.frequency > -- > > Key: PHOENIX-5654 > URL: https://issues.apache.org/jira/browse/PHOENIX-5654 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.15.0, 5.1.0 >Reporter: Nitesh Maheshwari >Assignee: Nitesh Maheshwari >Priority: Major > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5654.master.v1.patch > > Time Spent: 2h 10m > Remaining Estimate: 0h > > While working on PHOENIX-5634, I noticed that the connection level property > 'phoenix.default.update.cache.frequency' is being read in > 'MetadataClient::createTable()' and 'Metadata::createTableInternal()' as > follows: > {code:java} > long updateCacheFrequency = connection.getQueryServices().getProps().getLong( > QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB, > QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY); > {code} > However, looking at the documentation for option 'UPDATE_CACHE_FREQUENCY' at > [https://phoenix.apache.org/language/index.html], the value for this config > could also be set to strings 'ALWAYS' and 'NEVER'. The use of getLong() above > will always return 'QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY' when > the config is set to 'ALWAYS'/'NEVER'. Reading the connection-level property > should also follow the way the table-level property is read in > 'TableProperty.UPDATE_CACHE_FREQUENCY'. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-5654) String values (ALWAYS and NEVER) don't work for connection level config phoenix.default.update.cache.frequency
[ https://issues.apache.org/jira/browse/PHOENIX-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari updated PHOENIX-5654: --- Attachment: PHOENIX-5654.master.v1.patch > String values (ALWAYS and NEVER) don't work for connection level config > phoenix.default.update.cache.frequency > -- > > Key: PHOENIX-5654 > URL: https://issues.apache.org/jira/browse/PHOENIX-5654 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.15.0, 5.1.0 >Reporter: Nitesh Maheshwari >Assignee: Nitesh Maheshwari >Priority: Major > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5654.master.v1.patch > > Time Spent: 2h 10m > Remaining Estimate: 0h > > While working on PHOENIX-5634, I noticed that the connection level property > 'phoenix.default.update.cache.frequency' is being read in > 'MetadataClient::createTable()' and 'Metadata::createTableInternal()' as > follows: > {code:java} > long updateCacheFrequency = connection.getQueryServices().getProps().getLong( > QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB, > QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY); > {code} > However, looking at the documentation for option 'UPDATE_CACHE_FREQUENCY' at > [https://phoenix.apache.org/language/index.html], the value for this config > could also be set to strings 'ALWAYS' and 'NEVER'. The use of getLong() above > will always return 'QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY' when > the config is set to 'ALWAYS'/'NEVER'. Reading the connection-level property > should also follow the way the table-level property is read in > 'TableProperty.UPDATE_CACHE_FREQUENCY'. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-5654) String values (ALWAYS and NEVER) don't work for connection level config phoenix.default.update.cache.frequency
[ https://issues.apache.org/jira/browse/PHOENIX-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari updated PHOENIX-5654: --- Description: While working on PHOENIX-5634, I noticed that the connection level property 'phoenix.default.update.cache.frequency' is being read in 'MetadataClient::createTable()' and 'Metadata::createTableInternal()' as follows: {code:java} long updateCacheFrequency = connection.getQueryServices().getProps().getLong( QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB, QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY); {code} However, looking at the documentation for option 'UPDATE_CACHE_FREQUENCY' at [https://phoenix.apache.org/language/index.html], the value for this config could also be set to strings 'ALWAYS' and 'NEVER'. The use of getLong() above will always return 'QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY' when the config is set to 'ALWAYS'/'NEVER'. Reading the connection-level property should also follow the way the table-level property is read in 'TableProperty.UPDATE_CACHE_FREQUENCY'. was: While working on PHOENIX-5634, I noticed that the connection level property `phoenix.default.update.cache.frequency` is being read in `MetadataClient::createTable()` and `Metadata::createTableInternal()` as follows: {code:java} long updateCacheFrequency = connection.getQueryServices().getProps().getLong( QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB, QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY); {code} However, looking at the documentation for option `UPDATE_CACHE_FREQUENCY` at [https://phoenix.apache.org/language/index.html], the value for this config could also be set to strings `ALWAYS` and `NEVER`. The use of getLong() above will always return `QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY` when the config is set to `ALWAYS`/`NEVER`. Reading the connection-level property should also follow the way the table-level property is read in `TableProperty.UPDATE_CACHE_FREQUENCY`. > String values (ALWAYS and NEVER) don't work for connection level config > phoenix.default.update.cache.frequency > -- > > Key: PHOENIX-5654 > URL: https://issues.apache.org/jira/browse/PHOENIX-5654 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.15.0 >Reporter: Nitesh Maheshwari >Assignee: Nitesh Maheshwari >Priority: Major > Fix For: 4.15.1 > > > While working on PHOENIX-5634, I noticed that the connection level property > 'phoenix.default.update.cache.frequency' is being read in > 'MetadataClient::createTable()' and 'Metadata::createTableInternal()' as > follows: > {code:java} > long updateCacheFrequency = connection.getQueryServices().getProps().getLong( > QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB, > QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY); > {code} > However, looking at the documentation for option 'UPDATE_CACHE_FREQUENCY' at > [https://phoenix.apache.org/language/index.html], the value for this config > could also be set to strings 'ALWAYS' and 'NEVER'. The use of getLong() above > will always return 'QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY' when > the config is set to 'ALWAYS'/'NEVER'. Reading the connection-level property > should also follow the way the table-level property is read in > 'TableProperty.UPDATE_CACHE_FREQUENCY'. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (PHOENIX-5654) String values (ALWAYS and NEVER) don't work for connection level config phoenix.default.update.cache.frequency
Nitesh Maheshwari created PHOENIX-5654: -- Summary: String values (ALWAYS and NEVER) don't work for connection level config phoenix.default.update.cache.frequency Key: PHOENIX-5654 URL: https://issues.apache.org/jira/browse/PHOENIX-5654 Project: Phoenix Issue Type: Bug Affects Versions: 4.15.0 Reporter: Nitesh Maheshwari Assignee: Nitesh Maheshwari Fix For: 4.15.1 While working on PHOENIX-5634, I noticed that the connection level property `phoenix.default.update.cache.frequency` is being read in `MetadataClient::createTable()` and `Metadata::createTableInternal()` as follows: {code:java} long updateCacheFrequency = connection.getQueryServices().getProps().getLong( QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB, QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY); {code} However, looking at the documentation for option `UPDATE_CACHE_FREQUENCY` at [https://phoenix.apache.org/language/index.html], the value for this config could also be set to strings `ALWAYS` and `NEVER`. The use of getLong() above will always return `QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY` when the config is set to `ALWAYS`/`NEVER`. Reading the connection-level property should also follow the way the table-level property is read in `TableProperty.UPDATE_CACHE_FREQUENCY`. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (PHOENIX-5653) Documentation updates for Update Cache Frequency
Nitesh Maheshwari created PHOENIX-5653: -- Summary: Documentation updates for Update Cache Frequency Key: PHOENIX-5653 URL: https://issues.apache.org/jira/browse/PHOENIX-5653 Project: Phoenix Issue Type: Improvement Affects Versions: 4.15.0 Reporter: Nitesh Maheshwari Assignee: Nitesh Maheshwari Fix For: 4.15.1 The documentation for the config parameter phoenix.default.update.cache.frequency is not available on the Configuration page on the website. Also, the existing documentation for 'Update Cache Frequency' should be updated on the Grammar page on the website. Specifically the precedence order that it follows should be mentioned i.e. Table-level property > Connection-level property > Default value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (PHOENIX-5634) Use 'phoenix.default.update.cache.frequency' from connection properties at query time
[ https://issues.apache.org/jira/browse/PHOENIX-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari reassigned PHOENIX-5634: -- Assignee: Nitesh Maheshwari > Use 'phoenix.default.update.cache.frequency' from connection properties at > query time > - > > Key: PHOENIX-5634 > URL: https://issues.apache.org/jira/browse/PHOENIX-5634 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.15.0 >Reporter: Nitesh Maheshwari >Assignee: Nitesh Maheshwari >Priority: Minor > Fix For: 4.15.1 > > > We have the config 'phoenix.default.update.cache.frequency' which specifies > the time a client should wait before it refreshes its metadata cache entry > for a table by fetching the latest metadata from system catalog. This value > could be set for a table in the following ways (in the following preference > order): > # Specifying UPDATE_CACHE_FREQUENCY in table creation DDL > # Specifying the connection property 'phoenix.default.update.cache.frequency' > # Using the default 'phoenix.default.update.cache.frequency' > At query time, we look at whether UPDATE_CACHE_FREQUENCY was specified for > the table and decide based on that value if the latest metadata for a table > should be fetched from system catalog to update the cache. However, when the > table doesn't have UPDATE_CACHE_FREQUENCY specified we should look at the > connection property 'phoenix.default.update.cache.frequency' (or the default > 'phoenix.default.update.cache.frequency' when the connection level property > is not set) to make that decision. The support for latter is missing - this > Jira is intended to add that. > This will aid exiting installations where the tables were created without a > specified UPDATE_CACHE_FREQUENCY, and thus always hit the system catalog to > get the latest metadata when referenced. With this support, we will be able > to reduce the load on system catalog by specifying a connection level > property for all tables referenced from the connection (as against UPSERTing > each table entry in system catalog to set an UPDATE_CACHE_FREQUENCY value). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (PHOENIX-5634) Use 'phoenix.default.update.cache.frequency' from connection properties at query time
Nitesh Maheshwari created PHOENIX-5634: -- Summary: Use 'phoenix.default.update.cache.frequency' from connection properties at query time Key: PHOENIX-5634 URL: https://issues.apache.org/jira/browse/PHOENIX-5634 Project: Phoenix Issue Type: Improvement Affects Versions: 4.15.0 Reporter: Nitesh Maheshwari Fix For: 4.15.1 We have the config 'phoenix.default.update.cache.frequency' which specifies the time a client should wait before it refreshes its metadata cache entry for a table by fetching the latest metadata from system catalog. This value could be set for a table in the following ways (in the following preference order): # Specifying UPDATE_CACHE_FREQUENCY in table creation DDL # Specifying the connection property 'phoenix.default.update.cache.frequency' # Using the default 'phoenix.default.update.cache.frequency' At query time, we look at whether UPDATE_CACHE_FREQUENCY was specified for the table and decide based on that value if the latest metadata for a table should be fetched from system catalog to update the cache. However, when the table doesn't have UPDATE_CACHE_FREQUENCY specified we should look at the connection property 'phoenix.default.update.cache.frequency' (or the default 'phoenix.default.update.cache.frequency' when the connection level property is not set) to make that decision. The support for latter is missing - this Jira is intended to add that. This will aid exiting installations where the tables were created without a specified UPDATE_CACHE_FREQUENCY, and thus always hit the system catalog to get the latest metadata when referenced. With this support, we will be able to reduce the load on system catalog by specifying a connection level property for all tables referenced from the connection (as against UPSERTing each table entry in system catalog to set an UPDATE_CACHE_FREQUENCY value). -- This message was sent by Atlassian Jira (v8.3.4#803005)